From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0E99A0547; Mon, 21 Jun 2021 09:14:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 649E640040; Mon, 21 Jun 2021 09:14:08 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 998FB4003F for ; Mon, 21 Jun 2021 09:14:06 +0200 (CEST) IronPort-SDR: af1OexosMiehDIthcQpT2aY/M0i8gdLTY6BYbNjEadHJ/vaA4Fj39X+FQGRAZ6dgOuG+29PScF 3lPsrIglUWxQ== X-IronPort-AV: E=McAfee;i="6200,9189,10021"; a="203772332" X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="203772332" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2021 00:14:02 -0700 IronPort-SDR: 9OWJKgTVbL/tHY2apQNMxgxvf6si5dFMtDYpG5h5uXzDh1p8QuL/dE1PJC0k46mLYLPVmDjfFA F+HqaqlFz7rQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,289,1616482800"; d="scan'208";a="489783401" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 21 Jun 2021 00:14:02 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 00:14:02 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 00:14:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 21 Jun 2021 00:14:01 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 21 Jun 2021 00:14:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JZKQN2iJSZGKOYlwpIvUWw6Pj6mugdILI34a48ec9SWo/F8A6Rn1n0aiRc5NhZTAYb4nsynsV6DJgTzWkD/nzqxDwNe1pJczfCVjfzg2kimUoXEtR5kgz9kORbjBq1RXzaYmrhMZAeNzBVjpyE/+OZNbgzA/79ewaOlKrGKMJCU5Q1Yw/GQaQscij0dzsqYDaUYMAQEvNdoOSa0eEzwDAqfA5B/NX7XypoQepRAp0S96U8ggJsxms2LxXJ4/k+9GCsuy0FSsqrrPj9h+gDfpbTZ4NV1MG+TOeSrI/D1eGRtoG7PgDKVYejjqOP/AAAvarhgmMQJYnjYxGXosPcXMXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QvmrrVMCTUp7q6oyV8dDwqRqxoAn8ZhUV4gbcJNsoC4=; b=fISsopH1/AZ2jbWqe8keUOyd5DVfSj9bFXjpmFciPCCtsRVdFPnpFPkOyLTqC1pY/iJRWXVvUBJeA7es3NqspTW4jBT2KkpQQ3BwG5n4Xv0eA6jKs6+mfOw7Ayi9a1RLMN0wgjzRJ5nHtsMPkJJkK+RsNP8btqj4ZAgTbw5MT2w7iV5oGgytlaAdccAcwpycIzDNldOCBpRV1smwtlTECDxpNQho7Eifv0LEFvYscp7cP7A+Nj8ZFcMh/jcZctJCju+D384Syvy8SrvJaw7kOKS0H51L6loP+PQcXyT0YRS7IzfhC6ZdYyy1o0de8pn8KulQ8N0IS4/p+c8seU1G0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QvmrrVMCTUp7q6oyV8dDwqRqxoAn8ZhUV4gbcJNsoC4=; b=A6Mpf55Pw8uEAP+Lp1NTkeF2qWmgGXkxsw30dk68pn94rTNMywC7N88lZjXU2B98badyCMDGuEV2usQH218wUQVPOENZQh+f1tLQYiM1w2R6HJuktVDMsGth0jF2PHhSNpk5ZPvoFwSrLxzTPlCUaL+oU7CttweZ+4dpDTCI4yE= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB3919.namprd11.prod.outlook.com (2603:10b6:208:13b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21; Mon, 21 Jun 2021 07:14:00 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52%5]) with mapi id 15.20.4242.023; Mon, 21 Jun 2021 07:14:00 +0000 From: "Xing, Beilei" To: "Yang, SteveX" , "dev@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: fix set rss hash function invalid Thread-Index: AQHXXo7xY4/CqZ3CU0+4zUj9UmOCeKseGIOQ Date: Mon, 21 Jun 2021 07:14:00 +0000 Message-ID: References: <20210611013511.977843-1-stevex.yang@intel.com> <20210611065457.988344-1-stevex.yang@intel.com> In-Reply-To: <20210611065457.988344-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8a7a32b4-79e5-4581-8354-08d93484249f x-ms-traffictypediagnostic: MN2PR11MB3919: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1079; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rnoF65QFT8wV5AcBeHjXLJhSKpTJhTJMdpfKaiDJH+cgPVIqpZEekaimM1cPh0qFUo9MKO2JhYRIzPwk9/gxAGwENpq9pkNh/f1iilVrcivDetQmP0aQFM/+/1E/qDbKrsDxy/CzZvc9I8y+CDkDq530gZi21dXyJAKWRrkxi5+bYrwhao/wQqYr53sPoKYnPNgIJ5+dT10t/QnSFncZl4ckB3n1ZDnGi0+7rXWJvMdr/PgozgIts/iblkYDPZQK7nGtvrDtw01tRD3ForLc7WRDhCZMNoH57yOLuz2BY8REg24I8+CXGKpMofAhEOBnwWyQ7yCzijexMRAOGbe0UOcHB6dN4xDkYaFNFpGks+0WwYjcJWwm0DLB5i7tptTIuCvl1tOxmR4xoVUTzMjV0LHd4VSda4t5IkDSKGdv4OtQn3WJWw3Mql82SbEkBkbN1EMHATGYLMIsnaNQf7cQLToTKM3CT4Z6UuKywnNJmbVcw92IR2DuefCaumgF9DGQbIp9AaX+qpEXUdWEHWNrlsOQLn0aazzt4ZBBBtSD6SCSaeLqerdsXUCSye8oXXIfY9oMP0GeyccA/bHN2yFrcNEqogKMqL+rsanCxImhWOo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(39860400002)(366004)(396003)(136003)(376002)(9686003)(66446008)(55016002)(110136005)(83380400001)(316002)(2906002)(86362001)(52536014)(478600001)(71200400001)(186003)(38100700002)(26005)(122000001)(7696005)(53546011)(5660300002)(6506007)(64756008)(66556008)(66476007)(76116006)(8936002)(8676002)(33656002)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MgEgT6AN/3ss7BeNNOVPM52BvRlbCzm4Ecj5AGqjnkodLsEizRLNeIZRcHda?= =?us-ascii?Q?NmYn/BZPbSJR8H9ccf+ETShcQOcoERzNRhIOSiBxaBwWhhTttrPPz87fSYdF?= =?us-ascii?Q?sTdEA6pZwnirF4KUuQH6IdloyFrucNZ6VDJUXTGS+GfavzqSlMCPaqYVa7ba?= =?us-ascii?Q?0bVW/U6Rgjk9jz3O7mtz9PzFdPn4Qf6eGkXYu3axssPh5KfUQ3nMjhL1SAUg?= =?us-ascii?Q?5Mu+ZkcT2HKqaP/a7UkV1OeNChvTJus8mtOOY+wbWDscq9KyE1k+1fcGuh3L?= =?us-ascii?Q?X7atTUdUquEe5WenCMvCdR4omfe2Q6QqhAeukZemiyX6EcFyOipxinr7LChJ?= =?us-ascii?Q?6bUP8CxAuJLcwaHLpezVQtSZghREagXGtYO+rcWnYoAJ9XScdM3cn80bCOD8?= =?us-ascii?Q?k4W+hM00xrbUC1g//n1ldP9dVSUqBv1bFA/FaYwSfY4PwH3vobruMlT9KqyA?= =?us-ascii?Q?YwZsALfzWjoZ6QYIxRupxSJVaMhrzWPPwhjAPK741EqhSPGU1MTp2bIUgeGN?= =?us-ascii?Q?JgfQ1idX9wNzGnpx5ORZarX1vUSbXuo60O0cUwJTMmcD03ZkPZQdrKRWtlLz?= =?us-ascii?Q?R3BFK+Whp88ScQa+gwFojcNE1ss9XrNXLahB97Nva834Ioac/1PqxErzGMTa?= =?us-ascii?Q?DyHcAnZZhQWTQkLAqGLZy4C/Lwxjbm7xfo+wUGPAUno1RgijVLt1WePtDc/Q?= =?us-ascii?Q?mS+DKpwGebRzdTyWRV4xt9FilvzJNNwBflu73qPlEHl4DtNo8Sva/VmIs+l5?= =?us-ascii?Q?vKHG0ItL3DTI2CTIESNN/qwpGAGuxCBmHWVNZyO61FYzyqGefGoy67GYC3vU?= =?us-ascii?Q?3/7L5+aBgNFKWkWZ6mZl9C2PXODaMPL9ur731WmMQiLEoXMxtMxrKOr1auLt?= =?us-ascii?Q?GJVCU3wG5wGD5STAKNS2GVDtU8dSQtPBgnQ+DEYFIjq4TJKgncV3M361rjpL?= =?us-ascii?Q?Y+KgHcyZP2xwXLY63Nwzxovjrcw+Qiql0X4brAwpEBcciMA/YyR7zXLYdM9W?= =?us-ascii?Q?szT+bwsEGEltDIomD7WWs90HOQlLQgHiCad42+XmmOAAmYWOBclzyCr9V0qG?= =?us-ascii?Q?bDgkNNUSLoZI4fbzF1GY9d+/FACZWBDtsY85eDaoW4k4NtSL67ONSLpQtpoE?= =?us-ascii?Q?FkhSXzSKgbLfN4Kp+dciY2XjL0x7IztowRDZNU45ydCbYv7nBQBZ/ucByQZz?= =?us-ascii?Q?HQ2vZCX5Xu62h61SZ7Zkk2374QKIuoFdGEjW2YAsMrhiQUwYo9UkoZ3/IcVO?= =?us-ascii?Q?SwoWME1qd5PPzUNxkHr11YI2aDDQx5CdeVwlQHrsULq12xl3vKyYl3X5+G8x?= =?us-ascii?Q?Y1A=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a7a32b4-79e5-4581-8354-08d93484249f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2021 07:14:00.3447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 32BOXQa4t004mogT77MItM90AEgO2ScNgq8pLUezacutXo7hdiEdRmCNOl4Jhy7AzpZavz/QUYu8Jx0tb8xEyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3919 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix set rss hash function invalid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, SteveX > Sent: Friday, June 11, 2021 2:55 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Yang, SteveX > > Subject: [PATCH v2] net/i40e: fix set rss hash function invalid >=20 > i40e can support following rss hash function types: default/toeplitz, > symmetric toeplitz, and simple_xor. However, when filter engine parses > pattern action, it only supports symmetric toeplitz & default. >=20 > Add simple_xor and toeplitz hash functions support when parsing pattern > action. >=20 > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") Why didn't CC stable? >=20 > Signed-off-by: Steve Yang > --- > v2: > - add the fix line. > - support simple_xor and toeplitz hash functions explicitly. >=20 > drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c > index b1cb24f437..0cef21c88f 100644 > --- a/drivers/net/i40e/i40e_hash.c > +++ b/drivers/net/i40e/i40e_hash.c > @@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct > rte_eth_dev *dev, > NULL, > "RSS Queues not supported when > pattern specified"); >=20 > - if (rss_act->func =3D=3D > RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) > + switch (rss_act->func) { > + case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ: > rss_conf->symmetric_enable =3D true; > - else if (rss_act->func !=3D RTE_ETH_HASH_FUNCTION_DEFAULT) > - return rte_flow_error_set(error, -EINVAL, > - > RTE_FLOW_ERROR_TYPE_ACTION_CONF, > - NULL, > - "Only symmetric TOEPLITZ > supported when pattern specified"); > + break; > + case RTE_ETH_HASH_FUNCTION_DEFAULT: > + case RTE_ETH_HASH_FUNCTION_TOEPLITZ: > + case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR: > + break; > + default: > + return rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION_CONF, > + NULL, > + "RSS hash function not supported " > + "when pattern specified"); > + } >=20 > if (!i40e_hash_validate_rss_types(rss_act->types)) > return rte_flow_error_set(error, EINVAL, > -- > 2.27.0