From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B37FBA0547; Mon, 19 Apr 2021 10:17:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DA5240683; Mon, 19 Apr 2021 10:17:07 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 4282440040 for ; Mon, 19 Apr 2021 10:17:05 +0200 (CEST) IronPort-SDR: A3vdyR4U695+O0Zx4ZDkA/LeBq9bIh3UT0PSYuIFpdTcsTuX7t4bRVZQMxeeY4mz/1YasTMgfq TggRJQZ6ux7Q== X-IronPort-AV: E=McAfee;i="6200,9189,9958"; a="256599463" X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="256599463" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 01:17:03 -0700 IronPort-SDR: kb9KReYUdscCYAb7ps51KUx56ScCqbZdQEeh7z6pFl+rhC65WynCNi16+Hc9yJom6YOS0NBcpY 1HjlsKzZ5djA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="523355821" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 19 Apr 2021 01:17:03 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 19 Apr 2021 01:17:03 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 19 Apr 2021 01:17:03 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 19 Apr 2021 01:17:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g9m6DUis8gL8b5n3M6ZfOD4UTXRqWiE3crnfpD2ASV6Y4XPMM2aUQtUHjXWeiOgl3+7GaNK9sbKK2oHllPGGe9Ez/iiLYewcN/y2QBpu9ZuDbWNzkNNOvnhoLzXss7jHdf11DzNfP73ZDeqQrhRd8sSGVWZhBbsVdGvCw/6SVP+lo67uCgiNDJgu9QYDx7xn17Qb6Vy28OJV3HR32t4ekOgSIuC2UyAzBverytZ7tyi7+I46V+dFxfdC+rx0u0hZQMGbt8Nw2x5BjmpqNslZPixWopkuV/PKwBKglKryRXru+J9Shxs/A+r8DxAx6fEIuRyasiKQWmpvLS4TOA3+pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A4NcHId0tZRPnoevakmNtCPcluCqyQZnpJqnEuV4czQ=; b=V5s2/tLWzKq6+FHZpZ5YoSqC5cfAgh2x5XHwLyCI6ubjFuoZqcU6n6VmbSL0npq9HUDwYbf27zIl9xMNykmlgDFJ3TT+H3dpHJw5KhBy1ipQdscM343Dkl0txfae/a7eoaE8+qc3puP/yrGOLEGwvYhWFIbsy7d51p1LF2gsEvU5Ha/HcJuQ3/bO3ppsJUo1TSdcnPYhftNrg3g96c59qnFg4rJKnqGxjZ4Pl2V3t/gazZDMOd2ECghTILq4q1YDcehskU1hgrCMGlSnj9tUlHqEOlPBhPlO5U3lajhfvFsG5JN5YzE/vh53abQFKUBNK+5sUdsSlY+zM72S1gKllA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A4NcHId0tZRPnoevakmNtCPcluCqyQZnpJqnEuV4czQ=; b=beUem7IgQXyMH9+3IEUXa7uTmquAiurxx81DDe5dbqpyIdKMHxQPhaozo13IWHywjoKnjiN2V6KfdicfvGpo19bsuzkvhgcPtkrcZCpVc+bmAQq3j8hK9V8s+jhhO3MLuKdPcSPvzPePsd3GDLaaIup6TqFueAdkjJ2R6yLLKhw= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by MN2PR11MB4158.namprd11.prod.outlook.com (2603:10b6:208:155::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.23; Mon, 19 Apr 2021 08:16:56 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::e554:7a73:44fd:37b7]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::e554:7a73:44fd:37b7%6]) with mapi id 15.20.4042.024; Mon, 19 Apr 2021 08:16:56 +0000 From: "Xing, Beilei" To: "Yang, MurphyX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Guo, Jia" , "Yang, SteveX" , "Zhang, RobinX" Thread-Topic: [PATCH] net/i40e: fix flow does not effect on uncustomed pctype Thread-Index: AQHXMmhFu7rij7ymhkWr2iRC6C8rRKq7gwjA Date: Mon, 19 Apr 2021 08:16:56 +0000 Message-ID: References: <20210416021955.9790-1-murphyx.yang@intel.com> In-Reply-To: <20210416021955.9790-1-murphyx.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a8fbca00-2259-4f0c-08ca-08d9030b7f19 x-ms-traffictypediagnostic: MN2PR11MB4158: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2150; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wsXLLMlYEMpzHNxACjZgABY5F3OFyq3a5pzFtXUoHFvqf653GgfMAu8U14bq0QoIpq9qBWG+21Q2dQOFb3zAeNHWFhMUtrq74Bc+20Y2IRCIuXfMcEyWPemKPT53LcwdUaYufhETT8zBAEYx4a8094zoOJ4fMEo388EQZfawpXZ7v1eUhhKYJjs/ev8J/BJkbKTAaYdgEHH+ba8/RfjdRgjU6fBjm/wGjtqJS+eDQ87B7UNFbaQlaC0KG8NiC0etBPoTs8kwah0H7fCu2KzWaIeJlzCIlYz9MpsKnFtm1xUTK3libBg4HBKnSVnfqXPgZIoALCeMlwo8Z1UnjDt18BG8wJuZ8bxEFOVwJDwSVybJuWvgvjoOPckdeTBFda6yJXejDD0ktkt2ox5pOoTqEV/f2EQhGJv8KC9XIEARvCFoGr55yvLo8yY+hFYJZovZzyUKhXq2P2B1KDc13Jju8PBVd6DTlz5+6+ARY56uUYqyUfgFeSBiPJzYQvGZn12++ioeI0baj6OctSZBA1cTsncbUUsytQdjkgLbeqpvArvuvFgPTRQ0tXvBgqrV3l6Kov1bQc4RePzG1alsP6NYIZUrmnRCSd1LDb7irsbr4xU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(346002)(39860400002)(376002)(366004)(136003)(7696005)(5660300002)(86362001)(38100700002)(122000001)(4326008)(83380400001)(316002)(26005)(107886003)(8936002)(6506007)(8676002)(53546011)(186003)(9686003)(2906002)(66556008)(478600001)(64756008)(33656002)(66476007)(66946007)(110136005)(76116006)(66446008)(71200400001)(52536014)(55016002)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?FcY6OcJRhgOZF56JB1N4u4Ui3VuljS+5r6hBGD3WUXAcYJOWw7HZAaBXWcYA?= =?us-ascii?Q?/C88nHL14yCZP/lrBXW1cOg1nefNPexJgshKX/u2oMKy/OMl6l7Ibn5SAQdk?= =?us-ascii?Q?JU6aiHXLkrcicVi/aQsh2h5tIHSAdzScZzVqlQUf7ogiIMhhx3T6QYtYAGPG?= =?us-ascii?Q?lI89T7ZuHWHKu+Sqbcz4otuoAI2zU4U+TvN5/nD9NpcTQpLA21EormaKNFNR?= =?us-ascii?Q?Ga0kT3u460YFe3g5YjaVOupiOG5DlDfjONp83vAlXOtnDsNho8iRto3HngYz?= =?us-ascii?Q?L3hoLJlU6/ghHm3buuh/5GsR7GcXDrPSAFfpwYKGMgi90niUJFQ6YKGHVOz1?= =?us-ascii?Q?kTpWnHmNS6GLqdw8trsnfAHEdoEKGBj4pj0M7/N26KZ2UkD+969zaMq0hFv6?= =?us-ascii?Q?6LZypYdNL9i2xqY6hiMSklMlXoj9J0hl5INc4RzwlaATgKzeZn3VYrmlLi63?= =?us-ascii?Q?onS+w8y7CbZ5UbtuUJDQZJSmb3h47FM7M9Tj88F39LgDyGr6IKeoUBSNW490?= =?us-ascii?Q?Ou5tZXR8slp0QG3ryIi9pzUTZ0bRqmuWIEwA5gBIjV/50GkZoYQ+uFEsOg4J?= =?us-ascii?Q?QB5BTXqy+boH8QrlWmQe7NpDbA4npW+wbK8w3YabmVT1BT4FCL1IU5CbWN1L?= =?us-ascii?Q?cZ85zZWCfAZ2age6BIo+m0AV0lYAq2abbq2yT6p5rW+k4BY7t7VEX69JEKmY?= =?us-ascii?Q?0LuC9JKbG4K6WHDtV6KExYZEPq1nwHQkEmvaOS+qSs45350WMw0w05b/gf4d?= =?us-ascii?Q?yKiVbO3qmwVKGDOFCwONZtShnUP7GW4dDDgKIkZKL8sE/aZvVXbNoD3lWPu3?= =?us-ascii?Q?U6yFIPdsWXU0F6ugdk15VlDg1Tl2BThJSn+JfsvC32KTxdl1v0sUH8Lawlar?= =?us-ascii?Q?fwJchGWPha+kQmvgHHQgSmTzpryqbvyDAfwW+YisgyI3suWMJhL7UpMPlp46?= =?us-ascii?Q?47BRD+g+58BxtAUDY4uez+ojuhCe9LbPo2YGkQBZxAwdIrlYmQLKKwNzBpEW?= =?us-ascii?Q?o9vgC/sN8RcTWNRDVjqbdBlg4KJ6X3dNxmJFjthwIn4UJXRptHda2heJxif0?= =?us-ascii?Q?EE8wrAEg0H62MOeJq/y+xPLg33eWUD1wDyQYiSfOUPiO/jPHee6pnwKs549d?= =?us-ascii?Q?/U1RqqVdJSTtCnlrELxZCXRLDyUwRnx0stt1YGtsZpCNBFzPGdtKpXNFkT9Z?= =?us-ascii?Q?sqnWvc36rkC2cWkjOaDhViljJlXXS1qlLRLAbS5iDr069OLxCT3KrK7/ybFH?= =?us-ascii?Q?3Z6kX3nmt4LwQ2W+B39kfzYQ/kPR64tWtQ79x3YYMTv4lqhROiQEG2ff5AMV?= =?us-ascii?Q?LZA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8fbca00-2259-4f0c-08ca-08d9030b7f19 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2021 08:16:56.0457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hvyTPvto/74gmDdT82wgSf9i8DPjFQoEBob3kQwGXprKuJXllZSbqnSCzgX7h9c0jqKr0gtglmZ8UxSzJJK54Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4158 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow does not effect on uncustomed pctype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Yang, MurphyX > Sent: Friday, April 16, 2021 10:20 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Xing, Beilei ; Yang, SteveX ; > Zhang, RobinX ; Yang, MurphyX > > Subject: [PATCH] net/i40e: fix flow does not effect on uncustomed pctype >=20 > Uncustomed flow rule does not effect, the root cause is not write the con= figure > in register. Could you please detail the issue case? Is it related to DDP package? >=20 > Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow valid= ate") > Signed-off-by: Murphy Yang > --- > drivers/net/i40e/i40e_fdir.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c = index > da089baa4d..77375b059a 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -1607,8 +1607,10 @@ i40e_flow_set_fdir_inset(struct i40e_pf *pf, >=20 > /* Check if the configuration is conflicted */ > if (pf->fdir.inset_flag[pctype] && > - memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > - return -1; > + memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > { > + PMD_DRV_LOG(ERR, "Conflict with the first rule's input set."); > + return -EINVAL; > + } >=20 > if (pf->fdir.inset_flag[pctype] && > !memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > @@ -1762,18 +1764,14 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev > *dev, > i40e_fdir_filter_convert(filter, &check_filter); >=20 > if (add) { > - if (filter->input.flow_ext.is_flex_flow) { > + if (!filter->input.flow_ext.customized_pctype) { > ret =3D i40e_flow_set_fdir_inset(pf, pctype, > filter->input.flow_ext.input_set); > - if (ret =3D=3D -1) { > - PMD_DRV_LOG(ERR, "Conflict with the" > - " first rule's input set."); > - return -EINVAL; > - } else if (ret =3D=3D -EINVAL) { > - PMD_DRV_LOG(ERR, "Invalid pattern mask."); > - return -EINVAL; > - } > + if (ret) > + return ret; > + } >=20 > + if (filter->input.flow_ext.is_flex_flow) { > for (i =3D 0; i < filter->input.flow_ext.raw_id; i++) { > layer_idx =3D filter->input.flow_ext.layer_idx; > field_idx =3D layer_idx * I40E_MAX_FLXPLD_FIED > + i; > -- > 2.17.1