From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE5D5A0524; Fri, 4 Jun 2021 03:58:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C35F4068F; Fri, 4 Jun 2021 03:58:16 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 03E904003C for ; Fri, 4 Jun 2021 03:58:14 +0200 (CEST) IronPort-SDR: 3ttBndlywQ7mYfms1RAlAS/cMbrGKnjGffg/pj6Bq9tHFH1v7RXtYvdUXx4DwW+AnJQPCGvsdd ho/eIENkFgwQ== X-IronPort-AV: E=McAfee;i="6200,9189,10004"; a="183885812" X-IronPort-AV: E=Sophos;i="5.83,246,1616482800"; d="scan'208";a="183885812" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2021 18:58:07 -0700 IronPort-SDR: 8asHcYSQjhF2+4/39dFeUVfY5OSCO5o28ryBWBFk8BBYVf/wlGM5MQppvVJrNBNGq308908BBP jCSAG70Mf31w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,246,1616482800"; d="scan'208";a="468178124" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 03 Jun 2021 18:58:06 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 3 Jun 2021 18:58:05 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 3 Jun 2021 18:58:05 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 3 Jun 2021 18:58:05 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 3 Jun 2021 18:58:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G6fXeg3HIFkEz2Ddf2R/wIRjEjBnze18BfsIZL8m9ZUaUA+1Dq4bY6amQvYY3JZx2uPSp+PWeC+0tLHxOudPu5+o1BEHaGNdVvlVSXZ51bGVhb2UVo9QRorCuXB/LDJ6cMVB9k2JucPaTFMPj+hWKwdu14tZrUBTgg40/q3vteQwcEPUF9uS42ISONO5uK2380a2JIGEAcXSULp2M9hJdA8XOhA79uQeFusIKrxMPCaiIvZHbTvXZYVSHlsnf4LwnABbGv3D/kMJMGn/OyaoQ9HG6TZnVQjHm6FRlAqSQPbNSvaOtGjOvHtzSSGVwPWEdu7MB+2QdJquWi+QMbUfbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y+0cumPLhAZiMtAROzjMTcVL+7yFTWez6TBz3detgKU=; b=mOdVCg7CZlMLtkJwNY3uoA/XCrqzpd9VzVXGLNBAv7x19Jg2QY2xES1g82cUK3806ZL6Ew6IX/on6tadYk8bdcAh7s5sOylUN94uj5gx8CnqTsB9exhYkgKsmNlM2MBaA3+WonA+TDMpNa1ItX9+VG51xLwFMQPf1Lh3088FcUHfJVggg+nGldbro19M+NA/pfF5H2/U8r1uxpOi0ar0kEN+Grp6LP+TukgrLISOpeWcQ75UG7zvHbqNdn0Kk9bA23bjHKcK4VAIhJytqbIsvCAyhIj0u37P5G9o6OoOdjsPLjm1eK8UJIGUDU80hup/QN9+/eRz8dFWEvjswQGpYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y+0cumPLhAZiMtAROzjMTcVL+7yFTWez6TBz3detgKU=; b=EwZ+7wQJofPqXl8dwJmyU69709IUSqgSdMdUBpE2mjmBi6vKoA/IaSoCwHmRk7xjDo2JKv86vN1d59X3+zD5safvd/gi15rCrJNujSc4RyUViovU87j49T0iOTYXv+g7K/Wf5r2V8rG9UNstO3TdZ+viCyMZ8aEB24wdOBFhr30= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by BL1PR11MB5349.namprd11.prod.outlook.com (2603:10b6:208:308::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.23; Fri, 4 Jun 2021 01:58:02 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::55a3:215a:f054:6b52%5]) with mapi id 15.20.4173.030; Fri, 4 Jun 2021 01:58:02 +0000 From: "Xing, Beilei" To: "Wang, Haiyue" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Wang, Liang-min" , "david.marchand@redhat.com" Thread-Topic: [PATCH v7 3/3] net/i40e: enable PCI bus master after reset Thread-Index: AQHXUD5iRIb9AZFiy0+nPFBDpQnwVasDKXnw Date: Fri, 4 Jun 2021 01:58:02 +0000 Message-ID: References: <20210421050243.130585-1-haiyue.wang@intel.com> <20210524012346.496560-1-haiyue.wang@intel.com> <20210524012346.496560-4-haiyue.wang@intel.com> In-Reply-To: <20210524012346.496560-4-haiyue.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.55] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a1c9d7b-d06b-4125-ee44-08d926fc2fc9 x-ms-traffictypediagnostic: BL1PR11MB5349: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9iQ6UlQwE0sEgoOXkpybOidT/8bxkAf0Li0FnJXgBbqQRphd5LdpZG18ifa4okjz5XsHevGGuaDw0x6NzkYQUeoOwdYn7LBMObmh8ueSuIrs7/S3hsU46AAqgPJ/Zc5gxFStHWKCCrZ+uaAlpsDdQ9Obi5AhotnhoZcanuzqYw1VA1sO86z9OQyeDPNA5ZdoAtLAR4vnO6BVfxYeFiVXIjhJUNnFuzxYDvrbRO7uIlx7ovdydx1VVmBeQrKo2tKr77bWjB1MfH07T7GLmI31XYRGbcof1C7XADuuzP8O4oGNA/uw2A1X8FPZjsL0SdJfIgs049eINXuDoIvziocwAP+MNxvw6mX7kOcnZ1y5bzisPJdwidhzjHIm+uZ1LjN5kIzGGQSyt74b6JoIgYpiYrFnL4Cc9WmDlAV39yzINJR62tQXX7xJoTloAdI6hPVh6z97D6Nef7iLH3XYEeUCik/Swm6R5T81PB8qtYI+oVZwHWZeKGUqxan9q4wytgrv1TsD1Q5E6TtHvgeSNRV52udQwdy3mWuXGtX0FOexBtvwh7gw1cxqQrDfl93RfogF6b9cMMkRMq5uGRzEUHFG3sB9as+QESpgJjlb/4JPdnk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(346002)(396003)(376002)(39860400002)(366004)(55016002)(33656002)(9686003)(2906002)(5660300002)(86362001)(6506007)(53546011)(38100700002)(7696005)(316002)(71200400001)(26005)(186003)(122000001)(76116006)(52536014)(110136005)(66556008)(66476007)(64756008)(66946007)(54906003)(4326008)(66446008)(8936002)(478600001)(8676002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?F7YDDgfLxbIKiueJKhvhBYa/cmjgfcyY5khXiRe9Qk3Dhy6RlGuq6hs8UBor?= =?us-ascii?Q?7QamJ0h8QfmgzM2m6Gk94Nr6S+y7AHqDP8mw7uuhiSLSgr/O4bXWL78tdaDd?= =?us-ascii?Q?331u3VyBCeOFtKTTIG7jhZvZtYVOILRVpFjPnZb81yvWn9Q+6/wxC6chDBrC?= =?us-ascii?Q?uhvg+K1DTkq6SLExh7WqF06uIeJm8+Uy48CJ1rEcBvSHUONLzJDYJA9lzo5J?= =?us-ascii?Q?oqZ6iWfFRe+fWpmmDYsgQO2T9a5tkZQgCrS4c51ptcq2r84/hjxIyRTg5NDg?= =?us-ascii?Q?UUgAFwr6ii1oEfijuoad39CgkAai70uA7/MoCdYpOyIfd4XVAg0NNJBS50oL?= =?us-ascii?Q?h8Qo4K7dXYZBLtuGgp2vyQgCkYysI7Y6PjeREPtavbknM+3lPXMCNy3+OcpY?= =?us-ascii?Q?Wc4qrMmeUNKSG0S8AXz4GbAURHw1OsCx+edMHj687FAwQAkZEunWOFWmzrIt?= =?us-ascii?Q?LzoXUwKfIKFwsMR72JwitX5SPCfULTCc5jZN2DCjyZzL4GOqtFde15YGK1zY?= =?us-ascii?Q?4qmBC8Qe9XTltb6Hb1S5MKN9UiVtN7B1XyEphD2drQ1iW4jRDAVM2S+OiG8c?= =?us-ascii?Q?KtaC39ou/E/saLPQo3NH8OfsWbv6osBz/RWAoYJ+cX/MzJ8AOe3Qg+L34DFB?= =?us-ascii?Q?puF6T51ks1HfhM0sb7usj8okNmsI/C6alaUVAD0r/zC1cTl3S5WQmC6MtlZ9?= =?us-ascii?Q?VLqLaEkv6dY1N3Qikz2zfF4Jz4zl26N8h4jHaSm0hILkmjwotxK6mGfao0Bj?= =?us-ascii?Q?iosRABlL/+mU+B3mmyjl9aUFOGGCokNwSffirJBcGUdu2v+o/pBJaP79ezVe?= =?us-ascii?Q?p58isOlneYhNy5m1NDyWbEo4HoMdFn90aZgehcXW/fETE82CIfQPrzAsoQeU?= =?us-ascii?Q?kSW85XcK9NBV7kbTyNaH9+b+LAd74AZGsgbtYgwEMIbDhZN7p4obbNqsj4fj?= =?us-ascii?Q?VqVqI9BgAvKKyFAEnkXWyIOlaoJsDR7DP9GmWR4S6kEucWRrh5XVuOsf4VT/?= =?us-ascii?Q?F7yPDyYZxSRWFHrlFgFvqxgkFI8WcfVo6RlYzGCw9XObDedaG/GTD/1q1J5v?= =?us-ascii?Q?HPavqYJ27SrlcrXqbPBdVfPrLRdqdzuOi7jYmxJmROp8XX05hIWPaGf/OCNy?= =?us-ascii?Q?x7d0S2sEYogQVVgpeAb017Nd9yIbJgErRmAe0C8VN8dq1a4OVgdh5GIkTiu/?= =?us-ascii?Q?KGRw1DNk3mmaiKWC9Hnte8oPcyfXRakfau22vE7Brc6Ir7qAjHCUWycFk9oQ?= =?us-ascii?Q?sMjw3K0TfDBjwCrOE2pD4awc0MWIaCDRoxfbh16Hp/Srm0cpcs7P2bfD9PER?= =?us-ascii?Q?olIsH5V2kdlBVwAtFkpFvAQG?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a1c9d7b-d06b-4125-ee44-08d926fc2fc9 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2021 01:58:02.4003 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YCW8QUY2hMicY8lEzccuZ4Uwj3DiIxh7Hq0yI21salQkPOU5spXu9La0jRMMECRq5KSORk0s932BtPQ/AkdKYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5349 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 3/3] net/i40e: enable PCI bus master after reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Monday, May 24, 2021 9:24 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Liang-min min.wang@intel.com>; david.marchand@redhat.com; Wang, Haiyue > ; Xing, Beilei > Subject: [PATCH v7 3/3] net/i40e: enable PCI bus master after reset >=20 > The VF reset can be triggered by the PF reset event, then the PCI bus mas= ter > will be cleared, the VF will be not allowed to issue any Memory or I/O > Requests. >=20 > So after the reset event is detected, always enable the PCI bus master. > And if failed, the device or system may be in an invalid state, so keep t= he VF > reset state to mark it as I/O error. >=20 > Signed-off-by: Haiyue Wang > --- > drivers/net/i40e/i40e_ethdev_vf.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index cb898bdb68..385ebedcd3 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1213,7 +1213,6 @@ i40evf_check_vf_reset_done(struct rte_eth_dev > *dev) > if (i >=3D MAX_RESET_WAIT_CNT) > return -1; >=20 > - vf->vf_reset =3D false; > vf->pend_msg &=3D ~PFMSG_RESET_IMPENDING; >=20 > return 0; > @@ -1392,6 +1391,7 @@ i40evf_handle_pf_event(struct rte_eth_dev *dev, > uint8_t *msg, > switch (pf_msg->event) { > case VIRTCHNL_EVENT_RESET_IMPENDING: > PMD_DRV_LOG(DEBUG, > "VIRTCHNL_EVENT_RESET_IMPENDING event"); > + vf->vf_reset =3D true; > rte_eth_dev_callback_process(dev, > RTE_ETH_EVENT_INTR_RESET, NULL); > break; > @@ -2468,6 +2468,7 @@ i40evf_dev_close(struct rte_eth_dev *dev) { > struct i40e_hw *hw =3D I40E_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > struct i40e_vf *vf =3D I40EVF_DEV_PRIVATE_TO_VF(dev->data- > >dev_private); > + struct rte_pci_device *pci_dev =3D RTE_ETH_DEV_TO_PCI(dev); > int ret; >=20 > if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) @@ -2490,6 > +2491,16 @@ i40evf_dev_close(struct rte_eth_dev *dev) > i40e_shutdown_adminq(hw); > i40evf_disable_irq0(hw); >=20 > + /* > + * If the VF is reset via VFLR, the device will be knocked out of bus > + * master mode, and the driver will fail to recover from the reset. Fix > + * this by enabling bus mastering after every reset. In a non-VFLR > case, > + * the bus master bit will not be disabled, and this call will have no > + * effect. > + */ > + if (vf->vf_reset && !rte_pci_set_bus_master(pci_dev, true)) > + vf->vf_reset =3D false; > + > rte_free(vf->vf_res); > vf->vf_res =3D NULL; > rte_free(vf->aq_resp); > -- > 2.31.1 Acked-by: Beilei Xing