From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB6B1A0547; Wed, 21 Apr 2021 05:25:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D006E418DB; Wed, 21 Apr 2021 05:25:42 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 70D98418AA for ; Wed, 21 Apr 2021 05:25:40 +0200 (CEST) IronPort-SDR: UKTVt2NgYLOy6UAGaMUIohOoiBdo+8BZS/oO7/NrFyHOtEwc2OcKCigTVgTUapC4i2gwPCrvHM G5pfQyeW5dXA== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="195746636" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="195746636" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 20:25:39 -0700 IronPort-SDR: ALXs28hEWncoe20o+Rfc9M3vMSodkl+q3H6qPKnq+xu371lg54gxM/7yDbfF5balkcED4UEKHk NjypOu8V3yPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="384322677" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga003.jf.intel.com with ESMTP; 20 Apr 2021 20:25:39 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 20:25:38 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 20:25:38 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 20 Apr 2021 20:25:38 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 20 Apr 2021 20:25:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wr2YAW9YHz/Wkgbb+VeoK7MiN6NqhNj1yfNLCWFs9ZOPdcer2+x9TBLDqroL0GSp9A//CpYzfU+0WS0yc4G4DRiqvZDtwfAQZE4UC9R6CQTGGKvz/iOwekarNSruJv7TUiUcRONpO3iq6hn6i7cVZ+jfxaM7n2Dzy7eJQPiLmpTJFBh1ZDt+LGZpFK/CRNO1pn8b+omRa2I06hzCR053cHbOVxBIQteiVuZtIZBpb94gKVYzBA+jl5uaTxOgwa88rrxmPsG9SKWMcKl1MOQVHsawnpsuUHc5hnNb+orUik4ks1SgN0Gb3+NYHDmz77BvfF11x3/u2UmwTBZrLDEOeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W8Z18idyOqUKIxHU8hSQLZil4v/sPAuVshnQZwv6/Yg=; b=d4SJzrLK2w0LDeFH+QxufBvRcy4OiKM6l/BSt5Dv2iRWyiXTJNc49Ala3XaynzEM8OxQY6FeN+4KXluFlw3CbjAGa203LMA2s3pna4QWZioA5XakExXycB44hVbhVlnSKRfZ1TgewVsXUyrdZbc34y1N47IfTkhyKaSkwjRYSa13En0u7oXqriHrikp8zuiahmDvF2DXd+0rBfPf0gZboo0oZTK2s3IsSeIKBAegYeD9tsTRJA8lPL2lThe1/iIWOsPsG3+7a/RNPR2aSkFD6HQxH05WWOMhkFjAuKUwVonFqSkuFPo1emeUu/8lncNr+GjjUMcK2VeQ6UFidBWSKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W8Z18idyOqUKIxHU8hSQLZil4v/sPAuVshnQZwv6/Yg=; b=zfXkTwWDr3qOgNmOvYrpF3o8yG9U8ZD+gGJ7XaJIwHCOcSGb8uFIaxY8nRBZaqtuMwm+w71fvzVgC/Q6a6wWp9ggVIJ/4a/suEFkvGbC1Sd3K1/3r1GjubIIOg0qD4a/LJ8Y95ZyTfWA5DiSTTbwZmfdD4G2t3VgQ8kCLkeggcY= Received: from MN2PR11MB3807.namprd11.prod.outlook.com (2603:10b6:208:f0::24) by BL1PR11MB5384.namprd11.prod.outlook.com (2603:10b6:208:311::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.19; Wed, 21 Apr 2021 03:25:35 +0000 Received: from MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::e554:7a73:44fd:37b7]) by MN2PR11MB3807.namprd11.prod.outlook.com ([fe80::e554:7a73:44fd:37b7%6]) with mapi id 15.20.4065.020; Wed, 21 Apr 2021 03:25:35 +0000 From: "Xing, Beilei" To: "Yang, MurphyX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Guo, Jia" , "Yang, SteveX" , "Zhang, RobinX" Thread-Topic: [PATCH v2] net/i40e: fix FDIR issue for common PCTYPEs Thread-Index: AQHXNlR6Bsw5OZq8xUqO0sb4vLFW8Kq+Tiyw Date: Wed, 21 Apr 2021 03:25:35 +0000 Message-ID: References: <20210416021955.9790-1-murphyx.yang@intel.com> <20210421020830.4989-1-murphyx.yang@intel.com> In-Reply-To: <20210421020830.4989-1-murphyx.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55bf6963-15c9-47ac-4300-08d9047520d7 x-ms-traffictypediagnostic: BL1PR11MB5384: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:159; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zb5BQ44dxyNKpHGqQUS1MD6YW1I7kueXEO8N8LLV1qr19GnCKBV9seq7BPDT7WrQDSg3Hg6ZF1RfvUnUjBcxIQNgulwQUczHoOolRIzaK0ap2W/+JXZWGKwd2IrFJreWeDiL0JRYH6mRtQVasXDVEmVw1LH5Sjk4S0NoIiHvDkyRwqtRNPVKoY46xvpJQafZB1mLiX5q0/4ZeHx2P6gzD/lxeIiqzDC94v0j16GdCjUzfEFgOnU/5mktaII1fOOX8m2LUF1nooVq9pjaSFnQF3CswARkUvGWPHqW/lOIUfhEzvLo5KptwAg8viYmKesbYdLM/zPDrLJV0IkQEGlb+sAqSP+mybn8xJGB0WmMX7nDgf7eLVBTkCHANnapKCQHJhIJgBHAtE4c22088oftNKhGhjMW32jwSmMMc8BEA3PAolKBWTwda7BD5Y9LxfIU5U8lyI1+D//AjuqQ057qonAYmoJguW5sRSX414XhrNIUDNaqd3pdfW4dBNd1OEgJkXA1gGvBHvcLM1mf/FfU2Nhf9i6bgTGt9KpzF62iTezdd0QMwcGD7svUiWJBa4hQFxEANbR2khtbk8YAmTxOVj/TvCQcmrpL+Cdm8Jbjygw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3807.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(136003)(366004)(346002)(376002)(396003)(4326008)(66446008)(66946007)(9686003)(64756008)(66556008)(8936002)(2906002)(86362001)(6506007)(316002)(76116006)(186003)(52536014)(5660300002)(110136005)(7696005)(66476007)(8676002)(83380400001)(54906003)(38100700002)(26005)(33656002)(478600001)(107886003)(71200400001)(55016002)(122000001)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Mq5NaaaHRVahIDOhpL5y57USvtAv1jQxBJPJp57IGLKP1DTTnGK/IyrfqwSg?= =?us-ascii?Q?RERRebP64aZZ5kxisqmPFazwk7PqXY8hpNWhUn9Db3syNsRflYeBqGLBDW8y?= =?us-ascii?Q?bh8/L+qz0osz9g7jdTsCoBz6Y4395GTpJtlVGKjjQCNYvi7EJFlhDTe5zyuA?= =?us-ascii?Q?SUBm2i7+XjUJVF+kUuP9L5fhJ47OtL6FlKBerkaOIqhcg3cyHlRqV8NEUR3J?= =?us-ascii?Q?sNx1Q82KlWvjyqGaOCy73JzwZUE9Yg6oRUNYGhWyp9Z/YEsLvKURhYug5OqQ?= =?us-ascii?Q?NRm2GiIBf41HYv8X8jFeNosC5tNLIBRnkNaUNYleTpJste/uJt70AEpfLAo9?= =?us-ascii?Q?QZSDUK7pyvB+3RPDyU0aXd8rCufI468t5X9P5fVOrH7ss6bNbt293mE6T8Qq?= =?us-ascii?Q?ZMXbUaeau1pTfhRIprDdhKl+GbO24ECl36fMz3H7/QGPy2DZ3uyc5onULzwe?= =?us-ascii?Q?XQxg5hpd3Uv/uQr9WhYxjiJAHES0g1mqBcJEvea2/6Qnk54JqDUzTaxVYBEY?= =?us-ascii?Q?vAFVLP6PhNPHLfuX2Y5yvEDu8yMu1+gmJdlmBsWA0+c/EYeT3kRQmrua01qX?= =?us-ascii?Q?/PJ38JcD/BoL7IBqbARIYhy7RRNaVklBaVkr6AfxJjjyFQRhIOsrk2maXf+R?= =?us-ascii?Q?yP1Wc/h52q3qBonM6VhZc6m9lzG7gaYESkSzInzP6WOEU0taycZPZGm/Gots?= =?us-ascii?Q?q5zeRnATqqUWl/URUHDLRqwSDLPglQHzFLF0QWJ84gbgk6DeU8hqXKgKaRyZ?= =?us-ascii?Q?Ik5nhMDnvL+/r97DAb2YOplfQd4VvYbnFJ5EkGuEhZCSsYTcSUx08KRHeo7z?= =?us-ascii?Q?n1FJWd1riMFoQnEGDUJ9FIlwkd3kqgOpuIcezCGmsOho7wGTSJPfLFGoE5e6?= =?us-ascii?Q?Z+KqfSpMWI8EU0ucBREcxUyY1alHWoeIbzoRfZKe0XhDBXxdlOaL8CFU8MSn?= =?us-ascii?Q?bDK5Sh0Xfli+lVLnm4M/yKn25vPRkS1rOOOsiEuKW8Mr4N6E31c1J/a2h8NT?= =?us-ascii?Q?zUY20zbI9soS4QmosaiFeE6f52jsa8EvS70iGCIEoDMuJNM+T/YDUeDf2+hA?= =?us-ascii?Q?wJe6HGFC3BLYAaWEHEebYjwCzMv/g92JeIMQMehMxlsNdLK3mHGKU64bnsCb?= =?us-ascii?Q?js28it0SIJv7Vef+bY2Jl3HUn8xkpfXWW8CmADrMliuAA7kBA5VXxht6OUqs?= =?us-ascii?Q?BqhrRqWYR4hRCE9Cr+DzmNSGCYxpEpWdIWhI0UywLl1rebBusaCPsck/+uvl?= =?us-ascii?Q?g/dcsQvTBVJcM+gGRK7BEMn7IOKnzU0hLRuvPaR+en7/uq9wI8FTDh4ushUz?= =?us-ascii?Q?DyY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3807.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55bf6963-15c9-47ac-4300-08d9047520d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 03:25:35.6809 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AhSCLr6lQE6rOrpx/RNem+ktUkZZRpalaoFPAWhDiFuWXwHhCQ7vWXbDtrzAOvjsHrMd77vQr1vJZn2nIGe+fQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5384 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix FDIR issue for common PCTYPEs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, MurphyX > Sent: Wednesday, April 21, 2021 10:09 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Xing, Beilei ; Yang, SteveX ; > Zhang, RobinX ; Yang, MurphyX > > Subject: [PATCH v2] net/i40e: fix FDIR issue for common PCTYPEs >=20 > Currently, FDIR doesn't work for all common PCTYPEs, the root cause is th= at > input set is not configured. >=20 > Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow valid= ate") > Signed-off-by: Murphy Yang > --- > v2: > - tune the code and modify commit message drivers/net/i40e/i40e_fdir.c |= 13 > +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c = index > da089baa4d..6b81e09db5 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -1607,8 +1607,10 @@ i40e_flow_set_fdir_inset(struct i40e_pf *pf, >=20 > /* Check if the configuration is conflicted */ > if (pf->fdir.inset_flag[pctype] && > - memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > - return -1; > + memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > { > + PMD_DRV_LOG(ERR, "Conflict with the first rule's input set."); > + return -EINVAL; > + } >=20 > if (pf->fdir.inset_flag[pctype] && > !memcmp(&pf->fdir.input_set[pctype], &input_set, sizeof(uint64_t))) > @@ -1762,18 +1764,21 @@ i40e_flow_add_del_fdir_filter(struct rte_eth_dev > *dev, > i40e_fdir_filter_convert(filter, &check_filter); >=20 > if (add) { > - if (filter->input.flow_ext.is_flex_flow) { > + /* configure the input set for common PCTYPEs*/ > + if (!filter->input.flow_ext.customized_pctype) { > ret =3D i40e_flow_set_fdir_inset(pf, pctype, > filter->input.flow_ext.input_set); > if (ret =3D=3D -1) { > PMD_DRV_LOG(ERR, "Conflict with the" > - " first rule's input set."); > + " first rule's input set."); The log is duplicated with above. > return -EINVAL; > } else if (ret =3D=3D -EINVAL) { > PMD_DRV_LOG(ERR, "Invalid pattern mask."); > return -EINVAL; > } > + } >=20 > + if (filter->input.flow_ext.is_flex_flow) { > for (i =3D 0; i < filter->input.flow_ext.raw_id; i++) { > layer_idx =3D filter->input.flow_ext.layer_idx; > field_idx =3D layer_idx * I40E_MAX_FLXPLD_FIED > + i; > -- > 2.17.1