From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC7C0A0093; Tue, 23 Aug 2022 14:36:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8265240DDE; Tue, 23 Aug 2022 14:36:18 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 48BB940DDA for ; Tue, 23 Aug 2022 14:36:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661258176; x=1692794176; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZcfDqaDrQxJt2hfQ2TS4VDsmOvxkQELHQ/yW4bGiAIU=; b=mY9sxlUMrNLsWxIAOu8SGv0aDVKZCI9DCP/wakDD2fz35AwjrgEp0558 e06USlRCkF52haWYis586Vwrz5BUxpIn9qkGHQb65ZQ81UDB7ZWSsruy6 vSUJLZoS8b4XdiauYkTp1KntItdb7NKNtoM9YOmABVx1SanuCDszyRuSN Us41UC367GzpjYB8/KQgnO5bAtl2pyqO1k0bvc0zntHLjb+hJdzTvg4Q3 G3rhjnjz+ZABDCmdWDuq6WA0t9OPLIedaBfM2vITSAbiNaWXXFE97O2B+ PtklUcTpFUXwjyYtfEMfK5ia1TYQYwC0AR+w+AU/mm/o6P1DigCl4lFWf A==; X-IronPort-AV: E=McAfee;i="6500,9779,10447"; a="319720500" X-IronPort-AV: E=Sophos;i="5.93,257,1654585200"; d="scan'208";a="319720500" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2022 05:35:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,257,1654585200"; d="scan'208";a="585949855" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 23 Aug 2022 05:35:58 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 23 Aug 2022 05:35:58 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 23 Aug 2022 05:35:58 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 23 Aug 2022 05:35:58 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 23 Aug 2022 05:35:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QUZs6C/1TRxcEDGOErsStiIqhPMFm639bo9AumHKp/nhzheE2TdKtzGhCJOaWC7LT8Xnk8xplKFTI8Ypqa1RMiDV8jD4wpm1y2D+jymRoQ70tNXpGkhjOpmyJfDpZcbZjN6/ZAfQKEevOp1expL89Asph2FYL9yCuu6qfeJs2JHme8ZkMx/Km8UY3pvjqtVBfNtufNW+skC4TIxJd9R1DeEKoyJmdhZPwXcDDSsKjr3+JKlDgsaVdcBhhGMhc0xdVPV1tRJcH/e0Ie4lq7O4D1RtJr3si9/fZ6qgQCsvamP74PvVAA0PsEtE4ljc82IVMX46relNS7dS+1x7uIeL2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sxgA3i2IOTb8lnBhiN459z5vevIO+A8txhbcIgqBCS8=; b=bHw0pCIpGLYe9WxZVWF+svYHeDYw5Z6ArHDwIRGoqeuqSLoKYgewjMtM4w1KYyaFsD9aMaK7UjqY5urX+PKaWDfefxdqmRWYnrMF/JxSdzrT4ewKE4FSC3ReKf8SVtLj6+M1t+/Wvaovqeqf7tI5pa5eMDwKV3Cizf741+YXGXXyo3TThZNgENKS8PKkud4ccrNIUvefwS8h/stD3TTtm+l1u4dfnWVmfSxUBMHKs0xWdTcCzNx2ruATSVC0gsGtW3ybdv5W+uC3gyRqKIar09x0oe8oNPGBRKAbnKnmGLIdRl3WoC9w92AvAKjb9R7aOqDBcJBYq/cXwbq6XhwOkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by DM5PR11MB0043.namprd11.prod.outlook.com (2603:10b6:4:69::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Tue, 23 Aug 2022 12:35:56 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::348b:463a:1ef:b74a]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::348b:463a:1ef:b74a%7]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 12:35:55 +0000 From: "Power, Ciara" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Richardson, Bruce" Subject: RE: [PATCH v2 00/13] telemetry JSON escaping and other enhancements Thread-Topic: [PATCH v2 00/13] telemetry JSON escaping and other enhancements Thread-Index: AQHYoESwMiVo5jdqZU6MswcBufjryq28mK8Q Date: Tue, 23 Aug 2022 12:35:55 +0000 Message-ID: References: <20220623164245.561371-1-bruce.richardson@intel.com> <20220725163543.875775-1-bruce.richardson@intel.com> In-Reply-To: <20220725163543.875775-1-bruce.richardson@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c61cee06-4be3-4934-080f-08da85040651 x-ms-traffictypediagnostic: DM5PR11MB0043:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RwDl4OuY1+bijfu6kEArOtmNnW7UoPUDTMeaBkVc0j72kqfHTV58tJk6VDYsSU2d4YaOV6NLD9AK0d6wsO9onLjr7fHvOOwq6/4qj0Wt6gxBSFYRy8fFiyzHTaDXPHwut0IdK8OVWfZLMQn+/3PQmgvnwp6rgzNmRf0AvC69P76MfUVJ8ivAiZjx85YZ+j42JRi64+RC4HdFDrqoo36uprVqBacRzCfbbV637/uhVaPxH0UF7cu+YcPvUHfcEchx/nukleSbkosbvDVd4DMT7n5XdvWSlUGCMtzOXS4opvST1tRlBvQl1fJ/rtz8TjilFjbCEYoVP+jHUErIjtpssiKgAcqCGY6Q21DuEqeGYFtZkHGNMqDXOBIxv+GEz5fp7vrhlxn8bR0VEY7oawyCLUTsH6tQ4OrVqbdm9CFRf39vydHu0X/DeXo893FNQJYywJIrK2GqUNuDP1RJEYErz4Fjr6VtFOZW/LzhSLOAyJX7q9i8/0nM3VIVU4aBoyEVjmW9SKMyjzIQopLmeJfmBqNc5XuJbkyb43pYnoLYYBLmHOpZ9bGfUTh7/ayya+GrqIHZml7wn0Fg2amrNGrzPCtfFZaMw8NoPxCoVKG69YvP4udcyzYy9gzQg9Okmq0fZ8pfdtO9ILDXlf8VQkHBFyo7EAzBKyLJAFpatIeklFZWKRVxxo6NtQ7CU7IQ8nAsGDf4GseNDnzCoKqXksalmYbRzFD8f5twHRw7m4EPw0a/VT7D50N8L5LCw5/KlfKAgnHrEzQlCTt9phv1TtbGkw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(346002)(366004)(396003)(376002)(136003)(52536014)(7696005)(26005)(6506007)(5660300002)(8936002)(2906002)(55016003)(9686003)(53546011)(107886003)(186003)(83380400001)(86362001)(38100700002)(110136005)(122000001)(66446008)(66556008)(66946007)(66476007)(41300700001)(4326008)(8676002)(82960400001)(33656002)(76116006)(478600001)(38070700005)(64756008)(316002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sxEsFi5CC7BxEBhw0VTnvNBuOCn54GRgHg9DEiCoQEWjpO3qHcYllo3VL3do?= =?us-ascii?Q?An6xrG205NorcXbUrEvf3s2kR/EEmd8ODv/pHeOBfwN186BNgKlAo92Kt42u?= =?us-ascii?Q?Mtrm+VmzDtsoZDpv24ZCJaxuCUYqFIPsj4fBHo6f+uIBiA02fBfvXlfC6P2i?= =?us-ascii?Q?NepjhFkp3Dz+NTMNSdOB4cr60DBQ97DLuPfj8YYpe/MPSMCggfMS3E+tYKnt?= =?us-ascii?Q?f7G0yTQUMhKt4FUnIdqPrDNQQisTlSUkLQOLAD+UUlQdgbqP+S2Hq/WbaBo7?= =?us-ascii?Q?625Xa3sdGHrohHCMk+BbVCZjBHo0lAG0z7wOItu8nyjkzCYPGa2Q3BC+JxkQ?= =?us-ascii?Q?+aK2eUP5RJP0LgSKv/LKd0hFzq0HBrw6gH9KoPj1AvQ0AvgeKDObqwjyYodu?= =?us-ascii?Q?UGhyz9vSL+BomhzODRaQdqag6whn7OrrUICV0lkQSPXcvxBWPdE2d5/Jg1FA?= =?us-ascii?Q?AbIOJC4ipZdsu7Lh2GspMl3IrVqKI89uKk46lCPNvgY6EvLSYUfkmcYRrCOc?= =?us-ascii?Q?ygyhm/d7XWBnLXyyLCf1VcZ616PoIy0X7qqRrd6MNnW25U1t0EJyMZjXl5k6?= =?us-ascii?Q?0BKxlPrnd6AFMumkaLpesHwX8wNbXTklzP9PQXL8Zl+QAr+ZDsLWSsJMxWPo?= =?us-ascii?Q?AH0LRUwjtDDYQfbVGCW/uYiPNo+aFQxiEM7wHwItq3Ow2CrWhdkPnrxzGOEK?= =?us-ascii?Q?DIx1QtKJIRULsINqpmStiJVNlwtd8pA2z+Fek7bDgdMctL+46HxJbYNEHRGc?= =?us-ascii?Q?CGrc1uyofLLJHZ27+/6EHuf/ByomEBGe7shDZ3O+JhFbQRs3kU1DuKrDIUI3?= =?us-ascii?Q?01omCHYvKvdfOFkwctwIBcLw5h4A95j7OGxo5xpCXI9dJ7aQHI0LMM2oXwCU?= =?us-ascii?Q?UHWiEncox3eryqAdnz8Ki1FXcOt6QwTffkPyYyHFiP4yhlY7c5zqkzreiwAr?= =?us-ascii?Q?5Z6A/c6nfP/V5Mu6/A/2IyWbcS2YQY68wAvqs27BrWvKZ+4rH9uDKgTCAZ59?= =?us-ascii?Q?LTBeuyXW++pmo3n3mQbOP4ecj6mY0KqKB2zxZIUP8FMNhOg65Bg4EdqQn9AA?= =?us-ascii?Q?wN29WhNDC260edLbAuQqtchDK/NeRUeRQ8aQSipXfD5Pli2I23d2nv3TE0Ay?= =?us-ascii?Q?rWlFO/7eyVke80JaozOVU4jfT+K7VIXQXmODwfXGQj1z5p5m2+kgW3h2Rkhw?= =?us-ascii?Q?8Yl2IokI2cPm1CBdfI3BZBcqwsYHOBkapUvhmEtnis6EwzLE9l7MQINN+bcG?= =?us-ascii?Q?A6hIKPEN/JrtrO3oAcriB2NDrwxCOgIIB9dCdMaxdGj1WuD6ct9aii0ZB19K?= =?us-ascii?Q?UM2o+mdQIKSjfpx3wjksXbZ+1zAq0tCMICeX0RcnYMnOa83A5LZQTYYbBRH+?= =?us-ascii?Q?NTk4uN2sYIdFYhf0eofnzQII7f9nNsASBHRQiHfVwwLT4C6Aa8rnXvTL/Khf?= =?us-ascii?Q?5nDTLiRbbUNM4YCbKP4vJYE/3sLmlLLyQipXyCykRUHMM8lNKB6VC+MF0xbk?= =?us-ascii?Q?XKJToYweVR2TRkjBK/L7EBM4mHLjqw/2zwRSSkprSIMn1AaExqY+cjrj9CBZ?= =?us-ascii?Q?mk33ctXc7TVOSJ5EIRt8dw3S01QFSZwyADS6vuN5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c61cee06-4be3-4934-080f-08da85040651 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2022 12:35:55.8214 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uYbiRdeZ2GQwzD2LNncq5/8+dVsxvAwxdcevMH63+9J8ycWxNoOXJ0N55w8+HUjR1wpxom5c7oWZlSyQdnyLiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0043 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Bruce Richardson > Sent: Monday 25 July 2022 17:35 > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [PATCH v2 00/13] telemetry JSON escaping and other > enhancements >=20 > This patchset contains fixes for the problem of handling characters retur= ned > by telemetry callbacks which require escaping when encoded in JSON > format. It also includes unit tests to validate the correct encoding in s= uch > scenarios and a number of smaller enhancements to telemetry and > telemetry testing. >=20 > RFC->V2: > * limited characters allowed in dictionary element names and command > names to side-step the encoding problems there. > * added support for proper escaping of dictionary string values > * added more testing and test cases > * added other misc telemetry cleanups and refactoring >=20 > Bruce Richardson (13): > test/telemetry_json: print success or failure per subtest > telemetry: fix escaping of invalid json characters > test/telemetry_json: add test for string character escaping > telemetry: add escaping of strings in arrays > test/telemetry-json: add test for escaping strings in arrays > telemetry: limit characters allowed in dictionary names > telemetry: add escaping of strings in dicts > test/telemetry_json: add test for string escaping in objects > telemetry: limit command characters > test/telemetry_data: refactor for maintainability > test/telemetry_data: add test cases for character escaping > telemetry: eliminate duplicate code for json output > telemetry: make help command more helpful >=20 > app/test/test_telemetry_data.c | 138 +++++++++++++++++++-------- > app/test/test_telemetry_json.c | 98 +++++++++++++++++-- > doc/guides/rel_notes/deprecation.rst | 8 -- > lib/telemetry/rte_telemetry.h | 8 ++ > lib/telemetry/telemetry.c | 51 +++++----- > lib/telemetry/telemetry_data.c | 32 +++++++ > lib/telemetry/telemetry_json.h | 72 ++++++++++++-- > 7 files changed, 318 insertions(+), 89 deletions(-) >=20 > -- > 2.34.1 =20 Looks great, thanks Bruce. Series-Acked-by: Ciara Power