From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64C31A0C47; Thu, 7 Oct 2021 11:04:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 227A6411A6; Thu, 7 Oct 2021 11:04:19 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 20A16411A5 for ; Thu, 7 Oct 2021 11:04:16 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="223602547" X-IronPort-AV: E=Sophos;i="5.85,354,1624345200"; d="scan'208";a="223602547" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 02:04:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,354,1624345200"; d="scan'208";a="715092821" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 07 Oct 2021 02:04:08 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 02:04:08 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 02:04:07 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 7 Oct 2021 02:04:07 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 7 Oct 2021 02:04:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HIZiPF5f/IB7gA2W2s6KYdjItWmOgB1zV++4g22K1do514zRzYaKwl/XHPYAteqs0IJ2ASOd4wWajWogcMEf9l2cVlgzYdZDF6UvIEe4NQcvL9/1Z0Bj3zSHikyZ5bReIXInAdvv7mY6NUzm2Dw3vwe1/cTEaNFwQhrIviGW7i0tC9hi40ioRa8wxaT2rTueQUHIytPuwDOcFQJZRJpvDYByFPx2vRS7N4TU02PMcFEtGJ5/WV3l2gw1oBGaNjDPQoBTTIbU9eVcug1kLdCqWXSkdieB7wrXQ/jPz8ST+dcVmSXR9o48IXWd/7TJ7W+ZMDSm2A2gnd+bkaFfsE/PEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fl3GNlZJJvt51mzmxIcDhr9m04skauh/2qKOnCVnt9g=; b=NNohZfiw6hcztTmUzXiqv0R/VbtqmjpNo/bk+e8eFFQBoMHUzDsJk9TNnKu929uabJ+n3oZdukiiP/a1ezLD/Odn2VWvr4xA/xIY8XQZn98uGpCVHnv6CPvi4XwVuVC59JgSP+8c8Oyb48vvLL6Z+MVHyfEBZpwWQd31dTYtBNUtYk6CCZUp+s7NlBEyLUs9L3T8+7m9e9YA3Tj/+cC4qwVmTGqfAOtHXHB/yucv/OOfkn2Obm1xcUrQN4Q1ljdCbWO2/ENA2NxtX60ntavLTdRBi+pR5299LlbVE2I3qBRreBMiBOVz46MKZLUGKLdVBSxUgwqAW5dh/oKFhex0DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fl3GNlZJJvt51mzmxIcDhr9m04skauh/2qKOnCVnt9g=; b=XSu138z5tmdtN7rBrC0DrpPf4toMHTAGb5Mmu0mPI++Hk6mStjA+q4giYP+7F9eo93dcnpAH7j3Mezsc4h9M6aIW6nAKQ9rakRv+mvJghume1ekTpVJnlOBuYU//3LZqscED9i2b23U8/c6WvbSeceJ8lUxjNRxMWBrJmLDuOn0= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3805.namprd11.prod.outlook.com (2603:10b6:208:f4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Thu, 7 Oct 2021 09:04:04 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4566.023; Thu, 7 Oct 2021 09:04:04 +0000 From: "Power, Ciara" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: "Richardson, Bruce" Thread-Topic: [v2] telemetry: fix json output buffer size Thread-Index: AQHXrthAvQTHEc+Z0EiUoJioWg7zR6uvxxUggAFZ2gCACzB9MIAABCaAgAr/NvA= Date: Thu, 7 Oct 2021 09:04:04 +0000 Message-ID: References: <5a95b25b81e7ee57edfdcea73b9266bc8dae8d77.1631120194.git.gmuthukrishn@marvell.com> <20210921110243.1919933-1-gmuthukrishn@marvell.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 25db8e22-654d-4ec5-b465-08d989716965 x-ms-traffictypediagnostic: MN2PR11MB3805: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qu2uN3QJymG+UFIpt7OWz127Jk9NqdB8VtgKxj7kcrzAp7iIfeWyp0+ukNV5LtGR2sV1ZUKb4Qpj8wzJnl5D7gvkbZoc9ATD9Kdpo7arCAnDO8glFOSe5C8guV8nm4PM+Z0Gep+LIg1Q1L8RzcLLmg0ASO+ox9BJ0rtOpHVApR/z61rE6oPJIVHI47kfLcEAHePcbERVjtUDMqmvgYWmkhD8O2QzCR9Xk8ZnXNFfThoYqsMDpB0sO3BN1OYBGs5hIrIVALKOtzsrOMcUTgUeAnCWLoRPrO+mxwYPAyZtXdjjTreuSe7P8USxtIscyBaY41Cbhk4gT3sv8MkhRlI7hGFrW8NALMEN+S8NpB/TwhzO4tRyJRq9mjwD0d0wX2ia0hzmo+L/tAegLtr81l7focIvpN374dE7t51sqrCLnVBCbP7UgJCuOQOhwVWbn+r+c9eaS4dDIdsaJW5chVMj/xu5aHeWRZr/rqPE4rKuxXAj3vdexqlP7c91eRnYLviqvYpvh/wLXkjIeHuTOQQY3fdScAugPPA1Hi7rxo0Ja52Y4U0VyIgngf7r3h1fTPfZC4kjDuZ83v90AL00V7v7Th6hWA9FgtOx+0WC/IiWBBRb6LvOuorInVvvmxmZ6L3zFUInaQ/Dl8tjuPhsODHnqE/T93vM7F4uD5BFn6njQBxzJBDa38ljWlTPRbdfvdoGH0+T05nzRd0lbC/OcOeAqw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(83380400001)(66556008)(52536014)(66476007)(33656002)(66446008)(110136005)(76116006)(8676002)(7696005)(64756008)(38070700005)(8936002)(2906002)(316002)(55016002)(9686003)(508600001)(5660300002)(86362001)(122000001)(6506007)(107886003)(71200400001)(26005)(38100700002)(4326008)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8ZnLwsgmxyu4tUjzja6mrMOmnnGtxqw7DiFYmAsVLwBurSAcZOXSTAZYzCLZ?= =?us-ascii?Q?Sjced//nUDCaNajuBf4CCKRFDybZT1jLCSDmZqAnTgnAgWBUP6LciU+A0pyl?= =?us-ascii?Q?o+HZV7Dtns45O5cLfaFumI0lZYCt8zmRqlerZ8u0E/HA32JJqXRKq5L2FuVa?= =?us-ascii?Q?Ez/Y8CQURAkXuYBgnjhrWjz+qx5rain4hQbtvODzpl0tbeTIkhSq9nFQ8SVn?= =?us-ascii?Q?0db8SVGJDpaFigMwkoT5sGD08aJ7leOwtyFx/GOGHJMc9flD6N0lKO/JnSLH?= =?us-ascii?Q?wwVPF3UHjaeoL9DBHYwBIFsAi1Xb+rMnoPjABoxN3cAEkFpmjPfOjbW6Jhb0?= =?us-ascii?Q?DSqKBvAzclROGeNNJFgr06d80mf9oC5JK6KmP72CYFjp2wzCs0JwWNP9Ps8l?= =?us-ascii?Q?9iurimFdSsWZfCoJ4tSP0jrnuuqeYb+I9sXEK0HMDLwJBQPP3bLe4pzNwcqH?= =?us-ascii?Q?4AlUwsl4h+f1biEx/J92Il56Gxh6o7rMwk8PidG61adJzuyhn8s6SWUb9LYQ?= =?us-ascii?Q?x5WkORiEB0rDFENzaX2V7gvJAP4uTtJ0fePSQacpJeZoH5idvc6kWnX4RAvx?= =?us-ascii?Q?Kb2DxASb46ucTusYutsnwq7RCZfXN153qztqSGrMocH1fVookD8UoG0hfVEh?= =?us-ascii?Q?h9LBBaC7iOUTM8h+SsGl/7Ex1Lhz8IZph2uKUSIe1Z/tdjzqVnq6rEREhKaW?= =?us-ascii?Q?3r7/buy5dEuXyhGAfMinv9EAPVothThhdfvlhhfrWvmdTdPMeZNqMRSIfLOx?= =?us-ascii?Q?UmJJbiGw2HWXbcEpIoRfSsrdAtWLmqgE7ILi9JYEdtnGWjao68o9SHaUa3uF?= =?us-ascii?Q?X4TRrTKomkTR1dzjgHCxI8JrC3J41gcaB+JU+PNWQNf53f3epm8DNvc7ioww?= =?us-ascii?Q?JVLspJcb8LfpmzbMOm6oQPfXLrxy9/MY8EghCmXN+Ze+FDmHaOs5wV7qmiUB?= =?us-ascii?Q?9QbaaERkQrKVxVIOX4SCdQLrmSzqZibYNf0iciMxeXDUMwpgIatBsjflRN/4?= =?us-ascii?Q?DyYKv3DL7tX1gD+6ahuBPp574e4qdcIEF54wkO5Vc8MGqIIj8tPRmUDVbTTQ?= =?us-ascii?Q?0Sm2kZSeAvmuHNlOPjEKF0zYHpQ9W3YoJV6F+7PZKQu431uHkbHeXopxtlD8?= =?us-ascii?Q?RkPtaDBoDGxdJjBURwtPF2beYrtL+t47cnK+JPylikXXDzhotaNLSlojOJRG?= =?us-ascii?Q?6sbeGdcUDck+9dWXkx/jawCMbSbYKsNbAshOpieIyAuKzRciZ9/43hrG5LKq?= =?us-ascii?Q?VJJ4Y877zWOsImuSeYHc6lQJNRe5ehDT2FbqgwzmICWFfUihSesWAkBWPrc4?= =?us-ascii?Q?k4A=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25db8e22-654d-4ec5-b465-08d989716965 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2021 09:04:04.1499 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zn938UY33Qi6O/PWkVzqMF5CXFmm5TAeJD7JuSSWdepM9hVuDozzU8tYwrpzDHlfMUlAI+rnzV+U4fNqDlDOkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3805 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v2] telemetry: fix json output buffer size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Gowrishankar, >-----Original Message----- >From: Gowrishankar Muthukrishnan >Sent: Thursday 30 September 2021 10:01 >To: Power, Ciara ; dev@dpdk.org >Cc: Richardson, Bruce >Subject: RE: [v2] telemetry: fix json output buffer size > >> >Also, I propose if we can have platform defined upper limits (esp >> >MAX_CMD_LEN, MAX_SINGLE_STRING_LEN etc) so that, we need not revisit >> >lib/telemetry for platform needs (and I don't think one size fits all >> >platform, may be excess too). >> >Thoughts ? >> >> I am not sure why it is needed to have limits defined per platform - >> can you explain further about why it is necessary? >> > >Mainly, for the endpoint in driver. In case, if the endpoint data is bigge= r than >MAX_SINGLE_STRING_LEN at the worst case, endpoint will not work correctly. > The MAX_SINGLE_STRING_LEN is currently 8192 - if a value is turning out to = be bigger than that, maybe we should be looking at why the string is that l= ong and if it needs to be - i.e. could it be broken down to be more consuma= ble rather than modifying the lib to accept an extremely long string. I don't see an issue with increasing the MAX_CMD_LEN a little in the lib - = although it is currently 56, it probably doesn't need to be a huge increase= , commands are easier used when concise. Not sure having platform specific values here is necessary.=20 Thanks, Ciara >Thanks, >Gowrishankar