From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0D54A0C47; Thu, 7 Oct 2021 15:11:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D1CC40685; Thu, 7 Oct 2021 15:11:55 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id B69F84067E for ; Thu, 7 Oct 2021 15:11:53 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="226197078" X-IronPort-AV: E=Sophos;i="5.85,354,1624345200"; d="scan'208";a="226197078" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 06:11:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,354,1624345200"; d="scan'208";a="458781386" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 07 Oct 2021 06:11:52 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 7 Oct 2021 06:11:51 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 7 Oct 2021 06:11:51 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 7 Oct 2021 06:11:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HQraOVLwOUJMQVlkyuCrfljTLXRPUNWMVp6C3aLErszqnvXbs6GaU5hUb5TNgn/+7FIa6ABm5iJl6YZYipfmV71iEcT4zPVbeJhyx+TZ9im4S55WuYqAtpFvlcJv9NOXA3SgjpykeseP4DtZuvgVeGNSqRPT3j4r8hJD68wyuWG54hmc2ZI0xUiCY6Hsv2Ig+QRFxLrrIulEs2wHZDbzLzvipFWFcgWH8SP7OG8w7/apmvxqoxK0zxQvpyqDLeRGMwHrk/gxIkaVqkWb1Jp4gN+ptnQxKY0pecOAodnAMutIc+S+3ZxId23zEJ7yAGR/hr2uB9dgv25iIxbiUQpBRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9dZbSlL3iLLL5pHkpUdKVOVFc96UsilECZC5by+NXSA=; b=kxJnpD0QuE43nZ0Vm6OiYlgHltIHN83eH6rIpE410iNS1uDHnqoywmDESAWAzMxyXUgJ8QlwZHpj8bLXOi+wJGl6heJunZ8EY4br2qjjp97KngP8yifZNlQ0cvoGYrvL1qukemZU2eKyTG98MUBw26PgE3SEX7H/58z86kwPXyktHsTNdJI2yE+syYOHOmss+m8k13kHC7btEVJVgTwV18IJR1/G1YOJTSgECyAGoczKO/YD3E6Kk4kgqdsnqy9Zdkpb49QQvOIGpDwg3H+eK/Y8LOEgZoz0SLBG9YobKiS52pir6Q+nL5hxkozJ+3gBIwK7GZUPVkaNWd3zSBbwHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9dZbSlL3iLLL5pHkpUdKVOVFc96UsilECZC5by+NXSA=; b=muVCD6uby8tWRkDWLORW963BF6CXBUpMsI2fyaVlDN8EKQi9Wg4zhAWo2rmh21D1Y5Mn/vdTdmEFc+ctmvOvcg8inA6rnM/lqbou5+s6CozY0UqSlcDcepnBkwaa31zyVKExA7LGnYp1Ybw0F71mPVTMFmdmoTEKLeDw97uHYlE= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3648.namprd11.prod.outlook.com (2603:10b6:208:f0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct 2021 13:11:49 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021 13:11:48 +0000 From: "Power, Ciara" To: "Richardson, Bruce" , "dev@dpdk.org" CC: David Marchand , "Burakov, Anatoly" , Kevin Traynor Thread-Topic: [PATCH v6 1/5] eal: limit telemetry to primary processes Thread-Index: AQHXufFxHBkLFarKXkuDN0TDWYjgnKvHhZeA Date: Thu, 7 Oct 2021 13:11:48 +0000 Message-ID: References: <20210915141030.23514-1-bruce.richardson@intel.com> <20211005135909.726091-1-bruce.richardson@intel.com> <20211005135909.726091-2-bruce.richardson@intel.com> In-Reply-To: <20211005135909.726091-2-bruce.richardson@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0ddecec7-f152-4d5f-8a05-08d98994055f x-ms-traffictypediagnostic: MN2PR11MB3648: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TQgcGY0VxiLw8w8ljeKgq9zkOkoJSoRi1XQNjH777TANOmR85d69QZlnhQz+QODP9TiBccP+VtWjXu811bOYnmQTrqfj7Re0ZY1+kjxSZQQCL3SkotAQ3bKmZsJ5pYwWaDGo/Mxn1AvzcysIms4Wl7gvE9lnQOvLtn4bBq37ach7bRrBhj7F8rUQqmnOYeSFI5sYX795cz2RcjgF/gI7BSXdHPo06sb5jEU7eQQaVKYaxI1LVkDXe+K3EUTwAj2ou07rohDvOdQDhXIWAydA/AHIV2jYKlxPMpUPQy0Cun0Iz9+nDW+W6UoRiCgWWy9R9+6ZoDev/fLELEI3UxH3EjrouycXGUx4ObQ5WO8cyiKhxeeHEfZZxSRei4SALRth8QRHmpOSSa25Ym+zTrhlFXTMmlyjKsqhF1RXru/RK7NIuwfEDyJgLnyFIhEFuqIppUunGpeTY1eRATmI7GcqSx5dGfNfLONYGVT5MInYYPwMptlTZt50Z0cGq94OkIjAwQhiALLnYECSJQNZccwZ+hoG2F727naLTF4+BMviaOCIxBtrfjt63/4jV8X3s577nv+a0RxFTaHrSUkEQmQt0Tfg0ze8yMulCpOvFaFhUJ0godSuA6zOrYqQEO2yYcnI0y5abxp3TimJBIN0pWrMohPFvpKf7QwtQAyFkNJS3bU8LFYdhS+S2fGe5vbZIcpJP9IpPBmRruZ6dqNtFZluBg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(71200400001)(8676002)(5660300002)(2906002)(33656002)(316002)(55016002)(4326008)(8936002)(86362001)(26005)(66556008)(76116006)(186003)(66946007)(64756008)(66446008)(508600001)(7696005)(66476007)(83380400001)(38100700002)(6506007)(122000001)(38070700005)(52536014)(54906003)(110136005)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5rURo+JAdih946R73tL/7UWb47CWzB29W/oAUxgYVlMdUw2v2hVlYVXmlYb0?= =?us-ascii?Q?ega4PSj8srOIMgC6PZCTQaDEFfmAnJBGc4MIOp2oeFZlPUKFaIDM+Oqt+rvW?= =?us-ascii?Q?r5j5fR00kMSVx54vKZIYhO8qjbQ/xeuVM0UppCWtfPrA+mgZ3dFpi+Cwn74p?= =?us-ascii?Q?7FIJLzmK75/wEcfVf973ZHNrm6boaUVxysh2vOZi1qCZWu23RUNOBJ3VT5dM?= =?us-ascii?Q?vA70X/EtnalZMmbrldx7znCpOYaXbjy3AUtgn16PfBTJaF0ClPRRh0q46Ks8?= =?us-ascii?Q?JVcygzPGSCN9VgwxMy8Pb2sh2cLtjPP1UiEHrzW1Y5gw53RrKny3m+lEUFZ9?= =?us-ascii?Q?BkbSSqC00tPUiyOzYoLzzdXmxWTcm6yqNWwa59k355nBw958I5BmloRlQo/r?= =?us-ascii?Q?WMyzOdJ7r0Hz3y4YDi0T9wx6lPJkJBsV3i9yOzO7vyQq8rXc23nZk/ggN9oI?= =?us-ascii?Q?tVrhqQhI0ZHfYdA/Wfan2kGYnYbzHOzGuplzna9IZAAMcunqockil1bVJB/Q?= =?us-ascii?Q?CI9M7Xf0NGApL3qP0HBqcq93uOayVtqZ+qVbi2irN4L+VHUGWgIk4aCKoUKG?= =?us-ascii?Q?CiB4k2bFHQ38k5rop7dFpnzHUHF71LZYSsDifQfwBuOGx62QMiXhTMA5deCj?= =?us-ascii?Q?urU85IYlqxnfjhxXC1LepsfVnbO1qprs4pK6vJcUiNL6nLj6vRZ9tMhvH+A4?= =?us-ascii?Q?tOWI0GpClqVxHyRZNzeEKdxR3AIuM5CYjIlEVRPUCOqdMZEahL/UwqP65At+?= =?us-ascii?Q?Jy0RdK736g0Skd8arC3ky6guUpDl1So1zU8hSoKAsILt4nZgLa2ESfikgN/K?= =?us-ascii?Q?szRwWd6F4HPS2Raw8P6/WfFfdbyBCn+C4cJtnl/fjq7F/2JEjEMy1K701bAo?= =?us-ascii?Q?vCZ8hLAVa9OYqsvLU1zzEpjgYXzWphfH/PHr6dSjm4IIrrol5diFu5PO4h1p?= =?us-ascii?Q?vOzRSwoNqjladsYt4+8V1Ia8/mkD8C2iitfsso9WsIUTCSTI57J/BgHMstQw?= =?us-ascii?Q?636YQ0687oo/1CT5uYAjBWmBCDu5cqKEcbq6EyYWzcCHkTnTB0Pwl0vbsIHH?= =?us-ascii?Q?XqmVk7HD6UANkb9cYuaVPMHtiTj2fzbT/DHyxuc4AGNYZWQShNhWAHJ+M1nj?= =?us-ascii?Q?hS4b5RXE1819wv75hExlvNDn7DNYjut9LzQPI6eANO6HWlkdDW+oqSoEYGBa?= =?us-ascii?Q?4exQMQqZuBvxvwbDLaXt3q6QgzmIvagWQiNmBRud15nnt74n9Wlmt7toYmAm?= =?us-ascii?Q?9sHdOpjvBOiT+kmZTgSuo6KgJeLrO0NOsloJLZPfOm9+FwiqhX7tN9vVdosR?= =?us-ascii?Q?vGI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ddecec7-f152-4d5f-8a05-08d98994055f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2021 13:11:48.6579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Jov1wvcPbMnrRQNJvgVA4cdAoSlv0OSuhid0AlxVnc+ERjYLLQSEaMjj3M0ypqulevLtUbMP3uTij7gVh8mp9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3648 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 1/5] eal: limit telemetry to primary processes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, >-----Original Message----- >From: Richardson, Bruce >Sent: Tuesday 5 October 2021 14:59 >To: dev@dpdk.org >Cc: Power, Ciara ; David Marchand >; Burakov, Anatoly >; Kevin Traynor ; >Richardson, Bruce >Subject: [PATCH v6 1/5] eal: limit telemetry to primary processes > >Telemetry interface should be exposed for primary processes only, since >secondary processes will conflict on socket creation, and since all data i= n >secondary process is generally available to primary. For example, all devi= ce stats >for ethdevs, cryptodevs, etc. will all be common across processes. > >Signed-off-by: Bruce Richardson >--- > lib/eal/freebsd/eal.c | 2 +- > lib/eal/linux/eal.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index >6cee5ae369..b06a2c1662 100644 >--- a/lib/eal/freebsd/eal.c >+++ b/lib/eal/freebsd/eal.c >@@ -946,7 +946,7 @@ rte_eal_init(int argc, char **argv) > rte_eal_init_alert("Cannot clear runtime directory"); > return -1; > } >- if (!internal_conf->no_telemetry) { >+ if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY && >+!internal_conf->no_telemetry) { > int tlog =3D rte_log_register_type_and_pick_level( > "lib.telemetry", RTE_LOG_WARNING); > if (tlog < 0) >diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 3577eaeaa4..0= d0fc66668 >100644 >--- a/lib/eal/linux/eal.c >+++ b/lib/eal/linux/eal.c >@@ -1320,7 +1320,7 @@ rte_eal_init(int argc, char **argv) > rte_eal_init_alert("Cannot clear runtime directory"); > return -1; > } >- if (!internal_conf->no_telemetry) { >+ if (rte_eal_process_type() =3D=3D RTE_PROC_PRIMARY && >+!internal_conf->no_telemetry) { > int tlog =3D rte_log_register_type_and_pick_level( > "lib.telemetry", RTE_LOG_WARNING); > if (tlog < 0) >-- >2.30.2 Good idea, thanks! Acked-by: Ciara Power