From: "Power, Ciara" <ciara.power@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header
Date: Fri, 26 Mar 2021 11:03:20 +0000 [thread overview]
Message-ID: <MN2PR11MB38213B23A4AEC51FC84A3DDEE6619@MN2PR11MB3821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210326103223.GA1607@bricha3-MOBL.ger.corp.intel.com>
>-----Original Message-----
>From: Richardson, Bruce <bruce.richardson@intel.com>
>Sent: Friday 26 March 2021 10:32
>To: Thomas Monjalon <thomas@monjalon.net>
>Cc: David Marchand <david.marchand@redhat.com>; dev@dpdk.org; Power,
>Ciara <ciara.power@intel.com>
>Subject: Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header
>
>On Fri, Mar 26, 2021 at 10:32:03AM +0100, Thomas Monjalon wrote:
>> 26/03/2021 09:24, David Marchand:
>> > The experimental banner can be removed.
>> > Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET
>> > is unneeded for an internal header.
>> >
>> > Fixes: 0e64ae618e10 ("telemetry: move init function to internal
>> > header")
>> >
>> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>>
>> good catches, thank you
>>
>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>>
>+1 thanks.
>Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thanks David,
Acked-by: Ciara Power <ciara.power@intel.com>
next prev parent reply other threads:[~2021-03-26 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 8:24 David Marchand
2021-03-26 9:32 ` Thomas Monjalon
2021-03-26 10:32 ` Bruce Richardson
2021-03-26 11:03 ` Power, Ciara [this message]
2021-03-26 16:16 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB38213B23A4AEC51FC84A3DDEE6619@MN2PR11MB3821.namprd11.prod.outlook.com \
--to=ciara.power@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).