From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84925A0548; Fri, 2 Apr 2021 16:30:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70AA9140FD9; Fri, 2 Apr 2021 16:30:04 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id B530A4069E for ; Fri, 2 Apr 2021 16:30:02 +0200 (CEST) IronPort-SDR: hm+5NQ7Tk7d9i6uNjZ85Bedqj4QdJuXnQ2PcOn8WAE7NDzXsSHYz8mhJNMCzCH8RrG1uYMWyCC 3xT56OKQCPhQ== X-IronPort-AV: E=McAfee;i="6000,8403,9942"; a="171896394" X-IronPort-AV: E=Sophos;i="5.81,300,1610438400"; d="scan'208";a="171896394" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2021 07:30:01 -0700 IronPort-SDR: jhPxBtQYO5Bqlse1/EsJO+BBMkvrVpQPGxwPra0vHgq4Lr1sGEapqvDxoPdSEjl+NYs53K0eQj Gw9CkhsTx7eA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,300,1610438400"; d="scan'208";a="413201068" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 02 Apr 2021 07:30:01 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 2 Apr 2021 07:30:01 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 2 Apr 2021 07:30:00 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Fri, 2 Apr 2021 07:30:00 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Fri, 2 Apr 2021 07:30:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=izaeO5+qtMRZT4LUuABROcwtSyhZ2Fw8a+Bfsazw3OEIhg2WYPOHfiAzsfQhXWXTnxGqQ3S/zupmNou3OwqviV7Q7QjrORghcqcrHevH/J9Q4w+iQ/uPjb7KePE6VFCVLroKzXjxhCfVjH7WwYDQo2MEr8aWsK3KnbrBfrX3X9JAQvCxwNpVWYqFn/0CIfHmUIhnR1ajtBfIeigENxeL6EX56LWfRcOVtCSfu0jfQPj/ZKWd3lh8QoG0oYsKXFXk9xOg4fhhxyYlhNuqzoTo6bIj+Qyt9RxPgdXDsNg3Fc4w1RQb1ucfA/qC6RpTr48PzLb3QlXMtNVoz7ZI7xOtGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GOVACc94i/+1TfJ7siqOZ6wrqW1Ew1fPbxO1IshnN2w=; b=mxYmehnrsJBLgs3DG5ketVYTfQu+n0oUF757P7PJbB21Q3qUi6c25JUM8v9GqsuPH0Gn3DsPenMNbyWefs4XnXycI7daYWnLnH9OTlgWUUzsyoGN5XN/EnXmVblsaTBSSK1qqdQltcSzWzCC/omW2qWNCXIqB3rlNN3/7aYNRNKD+t0Pi3FowO8O3ajyYAHkylXLF62ShifUAXqs0yJ2EFQYjJP+E2+vo9sEn9GZsaeVvGh9bfg9ZuEt+kwqFL2SHnH46QemTg/7f1NOBjgChC+wMHYVjTsKQxtPGfdtv8KSx24bpOPlZVMPwx9Biqz9h3RDWWwnCvxoIQihnshMJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GOVACc94i/+1TfJ7siqOZ6wrqW1Ew1fPbxO1IshnN2w=; b=LPI89egg28o5Y/qvJVlLu+saM82hnp8M7Vxad2H3RFPsedf1C0SpoNU+UlJc51GZDi+SoUdAv5Xb507YeWjey6dGvDsZcOG5xPpFBQ4Y64ReBXMcyrUvdfRf0bQeghFJfgM+VjPJHEQGvOGBubpG6WT5inycEPZInmjGCyq2fIo= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB4032.namprd11.prod.outlook.com (2603:10b6:208:135::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Fri, 2 Apr 2021 14:29:58 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::546c:75a5:fe9d:de32]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::546c:75a5:fe9d:de32%5]) with mapi id 15.20.3999.028; Fri, 2 Apr 2021 14:29:58 +0000 From: "Power, Ciara" To: Ruifeng Wang , "dev@dpdk.org" CC: "Doherty, Declan" , nd Thread-Topic: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework Thread-Index: AQHXGnFLRYIOl55I7k+g4UEd1VfPDqqfFRuAgAJObvA= Date: Fri, 2 Apr 2021 14:29:58 +0000 Message-ID: References: <20210316143253.3849182-1-ciara.power@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [37.228.239.233] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ab94782f-5cab-41fc-9964-08d8f5e3cad9 x-ms-traffictypediagnostic: MN2PR11MB4032: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OBtyDOD0FlCT0NED+zITSfEMZqLAHYHcHQ1/7a7EGbS4Zald7kJhZRenv+Hn31RH6G67wibwnwhXea3bCNC40tbKMrtrQu+MMEIAp8fS5aQmvMMICv2kcnqTZWdCC/MktV837BuLOtG4++p3dZhi/6zaE41tghOrJ9HbB6il2eQw2jso3Rw0oRn/2K4o0Hms28+ljU5lWtF6YzKYwPYLoE5somc6zt5VYy88xpftyADwOe6u3UGDvwCQJcsU1nAblWLLGvfcPKboxa3kVAgAB5113CJghhKMXABa+OT6H0NkSuV6WwAIlq0/YTFGgCgYQqe0mzPR5fblgGFekfKxo2Z3YxJY5fajFp5pr8ah8vSvnT6qWXiKrk0KiNvINCqx/JNdz4ZvtiH6d6PxoelUC7ONb4SOvkFZ1jFyyCt1uL1dQpFLX/fKM2Q1aeh1hMf4QiaIwjMdsM25U2l+IuyFPDJBTnAQTL/AoNE91VgtEoXblWdZCe6vjAs5E+TlCqI2cweXc8404KbZjFujdMy/UGxCdfM94vojSOsau4PKq+CewTtECnJtT2jH+peBgfYbJMLu4ByFXNTdaBak09A0OXSOWZvpUW7ffQHTrkFzPcaw/4aCl0mBNp+jgKN+pUiaE8dohJ7vOnG4j+D7fp1QqZda8wwcOuxrQRYM4wlUqdvXtJJggB3Id/zs2DW93RJ17qr+wuRUdMjwyte1nytYAHH3c55jjfG6c3wHubmqij+rBP0T4g3ufWr3TnyIzaiE x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(346002)(366004)(396003)(376002)(39860400002)(8936002)(4326008)(186003)(110136005)(71200400001)(316002)(6506007)(53546011)(5660300002)(38100700001)(7696005)(54906003)(83380400001)(86362001)(76116006)(966005)(66446008)(64756008)(66556008)(8676002)(66946007)(66476007)(478600001)(2906002)(52536014)(55016002)(26005)(33656002)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yoOVb5+uszN/vYawy0/j0mZMQPDAwUT9qJ2S6FE4/JPQ4zk/DqjkxFszijT8?= =?us-ascii?Q?If8iq5E9Gxg+eIFu5z7HG72V0fX3daSMsURLcBt1xDp/h0YX4pKwzBNvm1M8?= =?us-ascii?Q?NtPIzbTSwwfAIJ24saoCjlJZOUfodh9zbXkCeAKX8rOxPvxwZH4RdzdtP0Qo?= =?us-ascii?Q?P3A1RSbazG+x1YXWzptLCz2Y7+L24dlCC4NI7TH+ZuoJayZg26aTzXLUyMGg?= =?us-ascii?Q?1gOY8uyqt92USbY1hD6joN0emQhjfJk4q9BVTclZhogP8wrdY6XCTPYSnRhd?= =?us-ascii?Q?/Hy0cQ2KbBHcfIrTJwRS51LZwTuTGOJjoRiiOPaI4dyyaa2jZPuvqmXxeM7X?= =?us-ascii?Q?3hAxKawz7WPlTOg2J3wmElcobHxocs4aOs11kR0e1UwTC3vD06Zv4747FffJ?= =?us-ascii?Q?eE3PKCDYl2QV48nWKbDzfZgtBEsn5Arx372nLjDkYezSRg1bp2LgOXtlwnMb?= =?us-ascii?Q?KNHqHbqbRD41NPT0xC1y0FWzthkbQj1C6UF/7HcM1tEOidARHMAIOIrl2s8I?= =?us-ascii?Q?D5dqbX1NqJ8AThWKbVCc8MEKKQd9J8K6++lp0ifX9k7CbgrEJayxwC1CeavF?= =?us-ascii?Q?xCyOi1oVBgjQ1yhuDZxGQBj7y3QCEhhdWoB5bEp1xTkfi8M/A9kJ38aaLN84?= =?us-ascii?Q?0H84PlgHpHyh6qTm8QhruzN6Vjs+YW+6HJ0BTre5ar2jucxAmObI3zkTiDhA?= =?us-ascii?Q?kqx3+LK2/R6Ej9MIAk+1ImCMYU9SJi/sZ0fRUpkJmkjArXS43ejGG3FPfjUr?= =?us-ascii?Q?DDvSSy3DnyaLh1AIOb/BTGba0Piu+gaWcmo8hGVJAy8a56dEXVwcRpzIBGcl?= =?us-ascii?Q?Dozumzu4lp+RxPTlDqvITB8rsF+ozsiL/MD4B5mDh3QH36f7JDStf7Mr0ENE?= =?us-ascii?Q?aeAX+VXFM9BTmoBjCMfUpDE2fdYV1/EEIp0jBcBrEzfua/JdeM2qZuDIyOri?= =?us-ascii?Q?qE7rft7GxYXtf+onWj+d6o8YsIp0v+7d9M+jo/5dPXOPulupHjQcZhkddWnv?= =?us-ascii?Q?iHkAem6NC4dEUyJXQ7V7zicNl2kXbPRKwmIe3ft7CMN68oEeQteAODdId6vN?= =?us-ascii?Q?3VkGDK/orXarj3O/mU+pktMuoVnxfK/vL9NfcTW1YPiga8GP63+Ylrt/IXT4?= =?us-ascii?Q?IzBH/qCURWJUNwQF9bjBefwT5yaZto90MKBzgt/Ef5UeR9mSFwAebiCeds5V?= =?us-ascii?Q?e7u3IXxSOft75DAJu4d6cHYcRG9V4/TXzw3Q7STX2qbP0ROLjCDbZ9DGoGNE?= =?us-ascii?Q?dcRxDYpnItCkytQ0dT7oX/86TNYOtlIgB5yxjy/DzW6/iKW09SUm0rX2pdYM?= =?us-ascii?Q?1TpwqPm0BfqRctgchmhoTPv4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab94782f-5cab-41fc-9964-08d8f5e3cad9 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2021 14:29:58.1725 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uimNQUHAHSYsAxwaD+RfQ0fMzP/RFG7Ah5RWIYE6u538WliaV4dqhe+9fY7k7mZGl2cQ+DFT/Ql4y5mwHLzMug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4032 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Ruifeng Wang >Sent: Thursday 1 April 2021 04:14 >To: Power, Ciara ; dev@dpdk.org >Cc: Doherty, Declan ; nd >Subject: RE: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framew= ork > >> -----Original Message----- >> From: dev On Behalf Of Ciara Power >> Sent: Tuesday, March 16, 2021 10:33 PM >> To: dev@dpdk.org >> Cc: declan.doherty@intel.com; Ciara Power >> Subject: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test >> framework >> >> The current crypto unit test framework is not granular enough to >> accurately track unit test results. This is caused by one testcase in >> a suite actually running multiple testcases, but only returning one resu= lt. >> >> The approach taken in this patchset allows a test suite have either a >> list of sub-testsuites, or a list of testcases as previously used. >> The unit test suite runner can then recursively iterate and run the >> sub- testsuites, until it reaches a suite with testcases, and it then >> runs each testcase as it had done previously. >> >> By allowing this further breakdown into sub-testsuites, a refactor of >> the crypto unit tests solves the issue of inaccurate reporting, as >> sub-testsuites can be used in place of the testcases that had multiple >> testcases hidden on a sub level. >> The blockcipher tests previously had these hidden testcases, but are >> now sub-testsuites that are dynamically created and added to a parent >> test suite, allowing for each testcase status to be reported directly to= the >runner. >> The cryptodev test suite is broken down into smaller suites that are >> used as sub-testsuites, which allows for more flexibility choosing >> which sub- testsuites should run for the current device autotest. >> The introduction of sub-testsuites also allows for more precise >> setup/teardown functions, rather than general ones loaded with >> conditions as was seen with the initial setup function used for all cryp= to >testsuites. >> >> For example, when running the cryptodev_aesni_mb_autotest, the AESNI >> MB parent test suite has its own setup function to initialise the >> AESNI MB device. >> Various sub-testsuites are added to the parent test suite, such as >> some of the static suites that were once in the cryptodev_testsuite, >> and blockcipher suites. >> The unit test runner can then run the AESNI MB parent test suite, >> which in turn will run the sub-testsuites. >> >> Documentation will be added in a later version of the patchset, adding >> to the test document that isn't yet merged. [1] >> >> --- >> [1] >> https://patchwork.dpdk.org/project/dpdk/patch/20210309155757.615536- >1- >> aconole@redhat.com/ >> >> Ciara Power (6): >> app/test: refactor of unit test suite runner >> test: introduce parent testsuite format >> test/crypto: refactor to use sub-testsuites >> test/crypto: move testsuite params to header file >> test/crypto: dynamically build blockcipher suite >> doc: add unit test suite change to release notes >> >> app/test/test.c | 168 +- >> app/test/test.h | 22 +- >> app/test/test_bitratestats.c | 4 +- >> app/test/test_compressdev.c | 4 +- >> app/test/test_cryptodev.c | 2020 ++++++++++++++++++------ >> app/test/test_cryptodev.h | 20 + >> app/test/test_cryptodev_asym.c | 105 +- >> app/test/test_cryptodev_blockcipher.c | 121 +- >> app/test/test_cryptodev_blockcipher.h | 12 +- >> app/test/test_ethdev_link.c | 4 +- >> app/test/test_event_crypto_adapter.c | 4 +- >> app/test/test_event_eth_rx_adapter.c | 8 +- >> app/test/test_event_eth_tx_adapter.c | 4 +- >> app/test/test_event_timer_adapter.c | 4 +- >> app/test/test_eventdev.c | 4 +- >> app/test/test_fbarray.c | 4 +- >> app/test/test_fib.c | 8 +- >> app/test/test_fib6.c | 8 +- >> app/test/test_graph.c | 4 +- >> app/test/test_graph_perf.c | 4 +- >> app/test/test_ipfrag.c | 4 +- >> app/test/test_ipsec.c | 36 +- >> app/test/test_ipsec_sad.c | 4 +- >> app/test/test_latencystats.c | 4 +- >> app/test/test_link_bonding.c | 4 +- >> app/test/test_link_bonding_mode4.c | 4 +- >> app/test/test_link_bonding_rssconf.c | 4 +- >> app/test/test_metrics.c | 4 +- >> app/test/test_pmd_ring.c | 4 +- >> app/test/test_reorder.c | 4 +- >> app/test/test_rib.c | 8 +- >> app/test/test_rib6.c | 8 +- >> app/test/test_security.c | 4 +- >> app/test/test_service_cores.c | 4 +- >> app/test/test_trace.c | 4 +- >> doc/guides/rel_notes/release_21_05.rst | 5 + >> 36 files changed, 1898 insertions(+), 739 deletions(-) >> >> -- >> 2.25.1 > >Tested against armv8crypto PMD and the result looks good. >Tested-by: Ruifeng Wang Thanks for testing this Ruifeng. I have just sent a v2 of the patchset but didn't add the "Tested-by" tag, a= s it has quite a number of changes. I don't think the changes should have affected armv8crypto PMD, but if you = could test with the new version that would be really appreciated. https://patchwork.dpdk.org/project/dpdk/list/?series=3D16085 Thanks! Ciara