From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69DEFA0C43; Thu, 23 Sep 2021 13:26:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8CE341257; Thu, 23 Sep 2021 13:26:51 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2DB7E41250 for ; Thu, 23 Sep 2021 13:26:50 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="221933711" X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="221933711" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2021 04:26:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="534274859" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 23 Sep 2021 04:26:49 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 04:26:48 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 23 Sep 2021 04:26:48 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 23 Sep 2021 04:26:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzumZD7tBfOcXX+iP7U4/ih4kidB4tCIacVzefqnTghNc+Ya7MJgE+2UZQIel6Eu/MNPgkV5BxO8DYZPYUimQC/AtIFVKWCKqnEmMqrBKqglCCN+RqWOt1iBRlrarkH712vYFvFC75ZKZH908SBs1i9oGGv40T3ylH/7OLLqA43GQDO/oZD8AOLzvF0gTeOA6GcgYLZyoa3xYpA73hUUFeVPsclfx7UDDoAMd7Dya4eJifSY8cB/Dma3DsryWGM5v5LAioi1dDyM54+38wVO85F9HldUjdSch0dy27Z67Y6/xYck+xFyBcR2+9O56zN9JlPiA7gAJ656sGDMaREJng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9JPey7ZPofeKRWcRtDk6hJPubyDAdsXmvqa3oDWB8FU=; b=WtohtuF4rS5ekYLouDnQykLmUiMczejSAnWjksI3v2KeAin2Um+hb5Pa/tAo6eRU29d9h8KIwrYmECfUM/ZszhthxZDrteOosjXXu4B9sBqkRPFDWozzQpifBzzJFFSSMSRVncs2iuFKuSHnqnbAKNqcPpg5o4NODLWunwVeRxOEmUtemnzwzPCkiGvvRLvTPGXMzt17dTFlHnpu1pjgZDdvJEJEQQbSEyGZmVeL1u7QEVZYxjKOODmHpW/c6UVWPsfv7tHttX/zPb1dLK2kaqUorCMLleiIno0rFha/FM5Pic/uqFBCH40Uc0OQq4OPltfE9kXzrMHxhrpDpS1G9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9JPey7ZPofeKRWcRtDk6hJPubyDAdsXmvqa3oDWB8FU=; b=G71DObGqRPEMfarh1O5hzGOWHOHvZDmjVhYCsMu/5j4FIoRdo7QQawFRdcHLX3yos3g+CyCi5bBAEZI1v8mWe6FyKJIdguWJ2MBW+Bsz6+K5DPs0i3Y9J+qObpNScN9L6DdJakUxhCKqp1s97gxbWRhOP6eN0HhHWEzw9PrSljs= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3885.namprd11.prod.outlook.com (2603:10b6:208:151::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Thu, 23 Sep 2021 11:26:47 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4544.014; Thu, 23 Sep 2021 11:26:47 +0000 From: "Power, Ciara" To: Anoob Joseph , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" , "Ananyev, Konstantin" CC: Jerin Jacob Kollanukkaran , Archana Muniganti , Tejasree Kondoj , "Hemant Agrawal" , "Nicolau, Radu" , Gagandeep Singh , "dev@dpdk.org" Thread-Topic: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests Thread-Index: AQHXq8YnqMF94+DiZ0e38i32H2Jd4auxdlZQgAAIz4CAAATdMA== Date: Thu, 23 Sep 2021 11:26:47 +0000 Message-ID: References: <1630644420-1256-1-git-send-email-anoobj@marvell.com> <1631884523-836-1-git-send-email-anoobj@marvell.com> <1631884523-836-2-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bdfc4422-f56e-4e37-1fa8-08d97e8507b3 x-ms-traffictypediagnostic: MN2PR11MB3885: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4d4vW2EPWxY0+nCF3KC3WL4j9kgVM6ulTax7ViNTb1EoqjnxQZaxDIBIKb9Lkg78F6oFhR5n6FrHDuq8DlKm9RISD1QLknBnMYSnOMPmqSMl4UNd3i0oyN0ECeTsZ+YT7vGvJZoBS2lfT/Ps8C3E6oDd1904mnl3yuVTMMUGQJrd0JfGUdOQ3mJVLeTsCw7N8bnjSk7rREL8E+C4tsppQwC043XpwdvjkwG0bB6kET7wY9MNbaGi3Bwfem6/KW2xjcguH3CuKfJ8/gnt0ZsWwteCYXvtiK7sdZm10Mh0FzU6ljXqJ1JxqZMzC9Dl8WVSMUtbjyU4o/OBZjAgpXg61OquzQCGGzmw0vpCERI3JKiTi8w4er6tuzuhqmecZ0S9mpfg75jR7KvNWbHpxEfH2tZfHa7LJ6LODmkxaKcngTtCe8U6AXD9iw7TVzHFrpanNPZG8/TO7HzLk0AnBFxImAzbrSJVYG50/tni3rtgnp5NH69oke8oj3RXlHyeU839iwpRiRgO8f9XitZwAaw6GiuZg4ZUJa6MaX8KUgRxgZhMnzzef4adyQPK0RqREjO8V2JHy8N5JyCUne6qG5I2mYRKSmnEFU4w0fBshdRJ1H6xbE/OeyL3S5vG5urh7RC+3uMXPBSiIEFUgt4uavT6sU+7NxmajihgCLqXykZIDQhXAAnnyH4yxNmDdFCihe/jqahqv03MsEiKkUBkz/F3Tw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(186003)(38070700005)(54906003)(33656002)(53546011)(6506007)(66476007)(4326008)(64756008)(316002)(38100700002)(86362001)(71200400001)(66556008)(5660300002)(52536014)(76116006)(83380400001)(110136005)(2906002)(66446008)(66946007)(6636002)(122000001)(55016002)(9686003)(8936002)(7696005)(508600001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wZgT5MPhvpjyLNerBjPcb08+upFfc7JZyr9prOWX4nG2Pvvf/92DXi0t7nss?= =?us-ascii?Q?m6aclQttqzgsTR+iM29clLBNfmFyXDY3PtqQKnliVFAAJJsJkKLO92aCi9ED?= =?us-ascii?Q?XrFdd+BKGRcQcOgvJDXyWnmBsDhFue1sD5xQhmmlhyQ6Fyp9NCNdYcrWl3Hb?= =?us-ascii?Q?O4PugZAkbQpWermEWY3wGfrEWz2NKCFZ7mFJs2tzzGqYSLHk025HMovcVycm?= =?us-ascii?Q?cwjVsYc19Dx5YclSGktttF8clyownHVV7UHsOxKMwMt1TfNb8Io9yqhJiuVa?= =?us-ascii?Q?nNoBAMAvimEenGg115rHme1bBU4b/8MmMjTKt1y2Au2q20NxLEsBMmWzmy82?= =?us-ascii?Q?+0SGiLaYwGLMuijcw7Bf02gOuJd/ftUVuZ/iwGY2qzb+X8FN3YbHsTYiZNEq?= =?us-ascii?Q?A1yCZJGhnJd0yiWIUoh+NBsTGEFhCD1SlK7b/meXDlTeed5Egn472heAqK6y?= =?us-ascii?Q?4ayeO8F//vg8xnxQb9Ol5wSK5KazHNldCvidVGJKp3ik8AbLpuCSEOIotxFW?= =?us-ascii?Q?xH5kXoRqdET9iu9Wh5D+XvgKq6M8z7seyUE5sWFMRPKJjQW+TKW3p+nLKMCH?= =?us-ascii?Q?UNEjyjWRsqkTctXjOG9pI117p0bF+VY8iZvX+Hw2jt5kQwRQiFlE1RiWPNDz?= =?us-ascii?Q?tCuqUehw9dubwaVmHF8c9V6wCdS+L3bTQH8qBGcioqV+IbMbDrsXSg9Zve3c?= =?us-ascii?Q?vBtss7oGnlZYlHfChjkpbP+dTgQQ5WBPs6exCOUeclMQhWPIy8acf5U8hOoq?= =?us-ascii?Q?a1smS9y7GZPcBA4FunGZpYaO2VRNihgpDH6AkGdULSGJKGbvuo+YvOleMdL2?= =?us-ascii?Q?4rTTJoefpB9Zcw9TJPWvljOUTi7Du0H4pdAmKLGjUL2kYE+Kt/HH46kzO3zg?= =?us-ascii?Q?DS60V4NAmTynGDeOnZ/wCFyNg5PG8ldex2oZ+h14Cqcsr1wBYjAUtgeLS7Am?= =?us-ascii?Q?h4UKo6KtGTN5lePq1x6EjE0IotvIrJVdojiX09xBvsZccbsl+JJzS74CKTVE?= =?us-ascii?Q?wmceym8cnQJc8EHQMwk5gg4Gx+WOKf7+KcXIoFUTcRTICrZuMM3iDcJXxgGJ?= =?us-ascii?Q?n3DwK+O1b+twKW8a/OcziWPTm0HAOEnpOwuCsCf7XD5ISQPF1Z4MxxMjcT0J?= =?us-ascii?Q?SGqs8i6zWNYkeREpNTEo5DRx194W8zlU2pNdIcYdE3buazj1xndqNUywgUVG?= =?us-ascii?Q?ZgObTIu0wrFqZXAQw/uOlkTMMkdCIZehzpqmy0NnA4cv0d+51zYwlsSjjJJF?= =?us-ascii?Q?op90sDeRKE0M3RwGlq+Hh5XHupGktdUrVbSO+T0Y/REpBKgt323/T+I/hZN6?= =?us-ascii?Q?I+kO+hC+ScpZi8vNhkikdck4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdfc4422-f56e-4e37-1fa8-08d97e8507b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2021 11:26:47.2606 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B1gvWyNUA16AkKVrldgV+IoiX3G4nn0B5ng9TMjUveodcISZF4vAso/2OzrzY/nSfSA6L02HuMp7RqKYAa6txQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3885 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, >-----Original Message----- >From: Anoob Joseph >Sent: Thursday 23 September 2021 12:09 >To: Power, Ciara ; Akhil Goyal >; Doherty, Declan ; Zhang, >Roy Fan ; Ananyev, Konstantin > >Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti >; Tejasree Kondoj ; >Hemant Agrawal ; Nicolau, Radu >; Gagandeep Singh ; >dev@dpdk.org >Subject: RE: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests > >Hi Ciara, > >Please see inline. > >Thanks, >Anoob > >> -----Original Message----- >> From: Power, Ciara >> Sent: Thursday, September 23, 2021 4:09 PM >> To: Anoob Joseph ; Akhil Goyal >> ; Doherty, Declan ; >> Zhang, Roy Fan ; Ananyev, Konstantin >> >> Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti >> ; Tejasree Kondoj ; >> Hemant Agrawal ; Nicolau, Radu >> ; Gagandeep Singh ; >> dev@dpdk.org >> Subject: [EXT] RE: [PATCH v4 1/5] test/crypto: add lookaside IPsec >> tests >> >> External Email >> >> ---------------------------------------------------------------------- >> Hi Anoob, >> >> One comment inline. >> >> Thanks, >> Ciara >> >> >-----Original Message----- >> >From: Anoob Joseph >> >Sent: Friday 17 September 2021 14:15 >> >To: Akhil Goyal ; Doherty, Declan >> >; Zhang, Roy Fan ; >> >Ananyev, Konstantin >> >Cc: Anoob Joseph ; Jerin Jacob >> >; Archana Muniganti ; >> >Tejasree Kondoj ; Hemant Agrawal >> >; Nicolau, Radu ; >> >Power, Ciara ; Gagandeep Singh >> >; dev@dpdk.org >> >Subject: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests >> > >> >Added test case for lookaside IPsec. Inbound known vector tests are >added. >> > >> >Cipher list: AES-GCM 128, 192 & 256 >> > >> >Signed-off-by: Anoob Joseph >> >Signed-off-by: Tejasree Kondoj >> > >> >--- >> > app/test/meson.build | 1 + >> > app/test/test.h | 6 + >> > app/test/test_cryptodev.c | 232 +++++++++++++= ++ >> > app/test/test_cryptodev_security_ipsec.c | 212 +++++++++++++= + >> > app/test/test_cryptodev_security_ipsec.h | 66 +++++ >> > .../test_cryptodev_security_ipsec_test_vectors.h | 321 >> >+++++++++++++++++++++ >> >> >> > #ifdef RTE_LIB_SECURITY >> > static int >> >+ipsec_proto_testsuite_setup(void) >> >+{ >> >+ struct crypto_testsuite_params *ts_params =3D &testsuite_params; >> >+ struct crypto_unittest_params *ut_params =3D &unittest_params; >> >+ struct rte_cryptodev_info dev_info; >> >+ int ret =3D 0; >> >+ >> >+ rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info); >> >+ >> >+ if (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_SECURITY)) { >> >+ RTE_LOG(INFO, USER1, "Feature flag requirements for IPsec >> >Proto " >> >+ "testsuite not met\n"); >> >+ return TEST_SKIPPED; >> >+ } >> >+ >> >+ /* Reconfigure to enable security */ >> >+ dev_configure_and_start(RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO >> >| >> >+ RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO); >> >+ >> >+ /* Set action type */ >> >+ ut_params->type =3D >> >RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL; >> >+ >> >+ if (security_proto_supported( >> >+ >> > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, >> >+ RTE_SECURITY_PROTOCOL_IPSEC) < 0) { >> >+ RTE_LOG(INFO, USER1, "Capability requirements for IPsec >> >Proto " >> >+ "test not met\n"); >> >+ ret =3D TEST_SKIPPED; >> >> The device still needs to be stopped here I believe if capabilities not = met. > >[Anoob] Here we are just setting return value. Function returns below only >(after stopping device). > Apologies, yes I missed that. Thanks! >> >> >+ } >> >+ >> >+ /* Stop the device */ >> >+ rte_cryptodev_stop(ts_params->valid_devs[0]); >> >+ >> >+ return ret; >> >+} >> >+