From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4034DA0C43; Thu, 23 Sep 2021 15:34:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF76E41273; Thu, 23 Sep 2021 15:34:33 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 4B85D41260 for ; Thu, 23 Sep 2021 15:34:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="223873688" X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="223873688" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2021 06:34:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="474850738" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 23 Sep 2021 06:34:31 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 06:34:30 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 06:34:30 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 23 Sep 2021 06:34:30 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 23 Sep 2021 06:34:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dH/nUt7bOsX2cSr9vFmP/kcjVu+pey5KD3gM0T5STzc9EZrve3MoK9l5AEMSB50PvmNo2CmZE3me5iH3PUUrEBxLud4A6EkfZHEu78rmdPbHVJ30J9SiPgIfX/sDl9DoGsbhGzB+A0x6VmyNXTlypybVHpysKot9+Ia1JuiXJ9bTkhEKeNmKZ/Y74U7gB3y3fOlCd+8GByLc/OjVp6NOjw1eWui5Wdfei6b4ZCGD21LGzkswzPQi+gOiu/IV7M7c8jAf7nnXzc88Cv+OwOeYOxwqLzJOzkdG4LaPXmCNDJhNStTpJ1ylMid6cy7VV6UPbutXA6lfnsq3KcC28jZDXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=asdcrLO1y2vpb4Ua6Kc//z4rv04gsvx80m97Wy1UxUI=; b=VB/vHdd4B6YfeOoX+EjAVCc9rNWxToLtjTFtDh/5q5jkjDabRRl12jYSRJ5H5logriPBxLus429dob7wu8yJBkKTIsCXJKdIAdE+i7VT9T119+EnB6hxbi/A3Fo8jBBZzTARy6ThFMBSMg1sDcGCxAMYQoHcDo9YVhw65JXMs8WNCoFNaMNAO/CUg05k0fUYvy8C3Xyn+Cbi3FC83hl9xfz0OvCm4pQXlcB8y3jISqlZzlZeJNAR6ky8/+vfzfJCcdFcHUugDT6RNQb4IEGXtkrZWahzljGQMDT20iuOkAHyfTp0kAbP5hFN0+w3nNdRRpNrRoLezgh22fXQpmlHcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=asdcrLO1y2vpb4Ua6Kc//z4rv04gsvx80m97Wy1UxUI=; b=vE8bUixi/I1Zm5SyyCQopyKrDpZ3h7UWFwl9C6uefnkwxclJ8GSUgfruskBF3BPF2LPi5MLVVENtZ8HwigoebRz+qppBubj3yTuD7OSY6GtyuDIwMP5ls2QgGe7mmGH3je0sdLni8P+Al4oh1NuYPhp/cnbcOUld1AHyb8OTBoM= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3728.namprd11.prod.outlook.com (2603:10b6:208:f4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Thu, 23 Sep 2021 13:34:26 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4544.015; Thu, 23 Sep 2021 13:34:26 +0000 From: "Power, Ciara" To: Anoob Joseph , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" , "Ananyev, Konstantin" CC: Jerin Jacob , Archana Muniganti , Tejasree Kondoj , "Hemant Agrawal" , "Nicolau, Radu" , Gagandeep Singh , "dev@dpdk.org" Thread-Topic: [PATCH v4 0/5] Add lookaside IPsec tests Thread-Index: AQHXq8YkNkJ9Nc/jD0CoZI3m/Rj+d6uxp0ug Date: Thu, 23 Sep 2021 13:34:26 +0000 Message-ID: References: <1630644420-1256-1-git-send-email-anoobj@marvell.com> <1631884523-836-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1631884523-836-1-git-send-email-anoobj@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c68ad27d-8308-4769-09af-08d97e96dcf8 x-ms-traffictypediagnostic: MN2PR11MB3728: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0J3Qy7ZhStASToX//OcDWnraHs7HBklP2jEN3b72WWu8LjQPMpyIHUKPewojeXysXw4XJFrVKi1UlbszKAua5jK6WMsSDyb+kCGyJiNAnVnxRjWIMnA01W0rg9rPbc5AEbcRcxMSUB2n7WIwf/C1HsMiTWXGWDdVahNbQJsYtLHqJzy4bSKjDJdy2Cbiz+E2vh8o0ybU+8kmcmdEJDtJAhOVETPUc2Kk+sg3mSEYH8x/+WAA2HoBH2+dzSWZ8UZbWB3EvaomX1sj7B7IWzWr1dEy4/RNVh0L34czfpmRm+bcMydGrcwdE4NEmj6Yh1r574YjnBdIpdd+7ezIzbR5SNjUb1pEu2pdo+SK5YzpzL06xcwZHugLPdOScFUad2AWHYnF9ijtlNg+Fa0f3dvzWUzCe920Eviw+mHJyI0a0Vxfly+IuzWcr5c5VxzmOsDqccp6uanNRXHmCRE7U81Mpkd6Wb1BM14TKbhGFFxZw1QOnD9FluIQeIYP6R8xKXCyb+ubFIGRJImQdv/IX99v98tvglD6FAec0QkVLkilxcOn/5xmnylcka7Rn2+RVFitOA6u2A3NDGTtNrdmPDxmZpTyql0b9viEYvQCm5BBaNH8RcInPmaEz/r9GawGfmFtwfyZxb1l0DlTAYJJNeiAezxe9L1IqZU5LTiyfsiWQ4EEZWXuqyGizITxW9eCFnKaXu3nXu1TZSr04iHCbPDyghgmmrpL4sYv8Y6OVPOUEN+jziXPZt9+OJwyEbU8kbYLOchdhbaSqpPxk00vs4J9/nPaEoITP46eMw6LoEMmxqY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(8936002)(9686003)(6506007)(508600001)(38100700002)(71200400001)(5660300002)(66476007)(316002)(186003)(55016002)(7696005)(33656002)(122000001)(66946007)(38070700005)(54906003)(83380400001)(8676002)(6636002)(86362001)(76116006)(66556008)(64756008)(66446008)(26005)(52536014)(4326008)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ATPAQ0mt6kzs+edB0FsFNO7bEE9bPej4T0rYeDcH3Ikk30vwAdRpj4MHeYPT?= =?us-ascii?Q?OfYTdv0VwMMs+shQzs+URauCEFgfFBR+Z10qe9a0bHu7uP8ECQCQLr/VnBvX?= =?us-ascii?Q?1uWIQKv3Ypb0mYz/sIP/2EUjqMhYOK7YXVO6Y8ItalLhvWKBTkUxUrzJaZz3?= =?us-ascii?Q?InUulpI2prKPVY5jd9ewyb9j95n1N13PhKK6a0aODqRcOmONK4QvRyA9ATqF?= =?us-ascii?Q?kImF8ot4Z9tnMDzYF5GGk+Vqbaqk+hzkXM5N81GWYq3ot8a0FwEGcvmNXAOu?= =?us-ascii?Q?4E4q9K1URT2j3nGwm1zN6nq7gnRGevOsKxpT/+5A2gteEUrse7T8d/lkWkw5?= =?us-ascii?Q?snJLB59SHrEt0p6xlDyssd/QoclOEVEAbONw4WmH88oReXv1WULoae16b1bO?= =?us-ascii?Q?9b3anQLYi10WpZAHWQzlwQx7Iqh1e+ODm5Wd/U7spApDS0UTDWozrh7k7EVk?= =?us-ascii?Q?Zg3ZFwZVJ9Rvrxu1hSf8MCs1xW82tzqpg6dLJzXHqH3gVk3Ga7WjdWqgOLZt?= =?us-ascii?Q?JwdXkaXl7+Y5c0lLPz0IIhnChgnplTIepDt0Ud5n9Eh6QtaKis/0SWMaaA2H?= =?us-ascii?Q?I6Ve+iURFGLQN9ObJRU7BEtnKbyzzCEd/DeTQVCnGf0naOr3dSKwK+HnVjHv?= =?us-ascii?Q?HA/3u+U+hsxkuZ+pGUZJGDqdFxKPAxCiJHWIXPP0t17IJQGSRLsemVn1N2WJ?= =?us-ascii?Q?U/K0pZj2WHQPCYE0ebsyS6xoBGyB+LCF+28Hk5MY+pXZePb68fLXZo1abVVM?= =?us-ascii?Q?PtasFheYbJ7Z7qCRXhR47D7uhUz7mnpb0MHlZv6TkzJuER8bw9X+cweR/NeS?= =?us-ascii?Q?WOmP8Lvoir7tgakiNgEw5CavJJ8CBz/wHRJyD2kn24Jy9uLGVMVt4m3hlTX0?= =?us-ascii?Q?cf9euIKpxQIK/ZbBqYj5c6XMyE+izkct85KSguP3GeZkFZDs6U9lFhioXt3Q?= =?us-ascii?Q?0X9NCmh5mH1vTozKXEPrAQMwbopW0WvWaUhwp+GME+3KH3b3RWdp/vyYq0aT?= =?us-ascii?Q?vIlcXHlpHfpVEbMKv+Ej14+cgrvxaHu2L2Cvxg/HP9qzrBoW32bh16TjZ76c?= =?us-ascii?Q?cyTpdXUmJTYnmkrEoYvnCgjWVXO1uopEeNyntKk/g3KQdM+hY1daN0CeQJ8R?= =?us-ascii?Q?Lz36ClC+ENTRE/47DGT2LQODEDdgDflIqQBl0wUeeNqmLZ2GsoWekIr4aJqq?= =?us-ascii?Q?kmWndZV/Ll6b42fOQs4B3P5JhD0nP1hFoCeFCzT1tbCgevMgswmn+5F22Azp?= =?us-ascii?Q?IEJRt4UL3V8D2w2xnJJxNhx2s4OD82jAqVn+5Ik4oHGGX3ViNI+TORZ2YOjd?= =?us-ascii?Q?LBdq09nISISKScO8WDy0Li/j?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c68ad27d-8308-4769-09af-08d97e96dcf8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2021 13:34:26.6043 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R38RLA1Hy58UQWEsE+E2f/fjvhAf0jTfxL7fmnrjQcNJWT1flb5w07iQn3jMcji+Jo8RpYm1DGv8Wf4j+8x7lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3728 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 0/5] Add lookaside IPsec tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, >-----Original Message----- >From: Anoob Joseph >Sent: Friday 17 September 2021 14:15 >To: Akhil Goyal ; Doherty, Declan >; Zhang, Roy Fan ; >Ananyev, Konstantin >Cc: Anoob Joseph ; Jerin Jacob ; >Archana Muniganti ; Tejasree Kondoj >; Hemant Agrawal ; >Nicolau, Radu ; Power, Ciara >; Gagandeep Singh ; >dev@dpdk.org >Subject: [PATCH v4 0/5] Add lookaside IPsec tests > >Add lookaside IPsec functional tests. Known vector tests and combined mode >framework is added. > >Known vectors are outbound vectors based on >https://datatracker.ietf.org/doc/html/draft-mcgrew-gcm-test-01 > >The vectors are updated to have sequence number as 1 & L4 checksum >computed correctly. And they have following properties, 1. ESP 2. Tunnel >mode 3. IPv4 4. IPv4 tunnel > >Known vector tests for inbound operation would generate test vectors by >reversing outbound known vectors. The input_text would become encrypted >packet and output_text would be the plain packet. Tests would then validat= e >the operation by comparing against plain packet. > >Combined mode tests are used to test all IPsec features against all cipher= s >supported by the PMD. The framework is introduced to avoid testing with an= y >specific algo, thereby making it mandatory to be supported. Also, testing = with >all supported combinations will help with increasing coverage as well. > >Four test cases use combined mode, >1. Display algo coverage and basic in + out tests 2. Negative test for ICV >corruption 3. IV generation 4. UDP encapsulation > >IV generation test case compares IV generated for a batch of packets and >returns failure if IV is repeated. > >Upcoming additions, >1. AES-CBC-SHA1-HMAC known vectors & combined mode 2. IPv6 3. Transport >4. Mixed mode (IPv4-in-IPv6 etc, all combinations) > >Tested with following PMDs >1. crypto_octeontx2 >2. crypto_cn10k >3. crypto_cn9k > >Changes in v4: >- Fixed lack of device stop in case capability check fails (comment from C= iara) >- Rebased and updated release notes > >Changes in v3 >- Added UDP encapsulation tests > >Changes in v2 >- Dropped outbound known vector tests as lookaside protocol would require >IV > generated by PMD. The tests would be introduced with spec change to allo= w >user > to specify IV. >- Added IV generation tests >- Minor fixes in combined mode tests to handle multiple packets > >Anoob Joseph (2): > test/crypto: add lookaside IPsec tests > test/crypto: add combined mode tests > >Tejasree Kondoj (3): > test/crypto: add lookaside IPsec ICV corrupt test case > test/crypto: add IV gen tests > test/crypto: add UDP encapsulation test cases > > app/test/meson.build | 1 + > app/test/test.h | 6 + > app/test/test_cryptodev.c | 351 ++++++++++++++++= ++ > app/test/test_cryptodev_security_ipsec.c | 401 >+++++++++++++++++++++ > app/test/test_cryptodev_security_ipsec.h | 119 ++++++ > .../test_cryptodev_security_ipsec_test_vectors.h | 321 >+++++++++++++++++ > doc/guides/rel_notes/release_21_11.rst | 7 + > 7 files changed, 1206 insertions(+) > create mode 100644 app/test/test_cryptodev_security_ipsec.c > create mode 100644 app/test/test_cryptodev_security_ipsec.h > create mode 100644 app/test/test_cryptodev_security_ipsec_test_vectors.h > >-- >2.7.4 For the series from a crypto test framework point of view, Acked-by: Ciara Power