From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47BADA0547; Tue, 26 Oct 2021 18:25:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A466C4111F; Tue, 26 Oct 2021 18:25:11 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id A87D3410F0 for ; Tue, 26 Oct 2021 18:25:09 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="229902900" X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="229902900" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 09:25:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="724218050" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga005.fm.intel.com with ESMTP; 26 Oct 2021 09:25:00 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 09:24:58 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 09:24:58 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 26 Oct 2021 09:24:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iPNAPICBFNz3/zCEfWj83kgrNZmqbzPCmhGorbGYcHG0IH3yQS5Rx69UFmIfQCZeTkcpALkwU+z32a7/FhtYaXhst3EMMGidk0Ee9KGknWiY56+AQzBZBSUBBkKUDDhxEply77cYLY/Q37s24cBQv1R1bm/985ka7hi3VH6TebNSM6EVf00OzrE6e8xm0BaOfAn6g0i7Unw6yh+PqTOJgexR4SIKpNKUdZgWU7qWEFS33BL68k5ExoxCy4glwFR5taFHEj8UdLMbXsWNArboZDGYYmdLaHpl7+jLGL9QbzEBXnpl+Wr1utX4GkZhxVD101rdfQ3B/Hqn4Qc4PAhwjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Os+SR6QC6283wIgrJMY3yCq9Bz98cMiUC2d1jTHCfzw=; b=K96evjFnDsKqSi6nEIi46/yPk95AMigK8XXdQbJaPTOgkXIJ685ln+zhNzGTF29uMNQoZbEbc3yUd4OkC2wzcTJgo04hrkM0Qm6VNk9kTJNYbHhUgJDesfIBDKGXYCFfO2Bcgfy9chtDFO7GIES6Db01dqx8l0OjyT0FjIiq95E7j2QQE7U/fCt6Tam7lhgo6Td4bdzFAntRlz0fHLFOqudZX/PN186d9DTkZILg0ile4XFZMubAwMoNGwZXYgnaONGdUqHBNLKSGQ7koMiStdeR4jmWcqVtu706ByTzB69WuRBBD24QACeh8anEiEIbD9LMEJ0ARmHEqIFaQFQtMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Os+SR6QC6283wIgrJMY3yCq9Bz98cMiUC2d1jTHCfzw=; b=xrw2KXs4f/Di666E5ncf6osOUiokYPxBz1vGwSi6EGnUSDMy9WwcWfHlY3m4nPgfo4s0a8HMqzQn4twAfQYNnJb8dl5rkD53gLlaUIeODzDpqVlB3bABHp02VF/H2qm8O0lXe9TPVZ69cQ4Fe2IdtQhF0Cg1PjlMMBmuZuBF8NY= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB3902.namprd11.prod.outlook.com (2603:10b6:208:150::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Tue, 26 Oct 2021 16:24:56 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021 16:24:55 +0000 From: "Power, Ciara" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "gakhil@marvell.com" , "Zhang, Roy Fan" , Adam Dybkowski , "Kusztal, ArkadiuszX" , "Ji, Kai" Thread-Topic: [dpdk-dev] [dpdk-dev v4 6/9] compress/qat: add gen specific implementation Thread-Index: AQHXx2cObab8UkyFx0WK5LWGChwO76vlfGuA Date: Tue, 26 Oct 2021 16:24:55 +0000 Message-ID: References: <20211014161137.1405168-1-roy.fan.zhang@intel.com> <20211022170354.13503-1-roy.fan.zhang@intel.com> <20211022170354.13503-7-roy.fan.zhang@intel.com> In-Reply-To: <20211022170354.13503-7-roy.fan.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d6115d96-5318-49c9-8d41-08d9989d2587 x-ms-traffictypediagnostic: MN2PR11MB3902: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AXtwTtvfClBgyP0krYwodaJEea35oXTb47opz394+wL9Jm4FwvQ885ZIlEBXqAG80MjDMPL2TCbu2Uod4QfBydBmHJ6+0hSofjGlXZrpdhI/sh7iktE1atAZN10QRoqD2P7njPbgWDl2d2LbuHMqCRnWSJ/74ZGniQYSy/WuoS0mz/QGB1DaWXgOAeoc8AdMJuynLIi2e//hAdFyFUvtjvAar/GtQUo2SOqf8uSLHHw+z/HYTN9IJpT1EhECdjKzAk9iwZAXF+UeagCh5WxxuF8Naf9qMVBrhyKeL5G5WZq1PJD6oGFqBSPPeF9+9d9L2WbU2uRTcbMlDIqfApTc4aJW0lQVNp/jtkdlr5a8hGzcu+sR72gmt/jhuxXudyuiJNQh9DJ9cQZ5Vlmqu81ORixsKDH45iLVH74bq18QML5IvawWXfDicBt8KpVJly0sJLmE9qv6tWtvi7WieR+87gNbOZHZCGLlRcv9vXFWkPIUIXyfOf68eOcYli0AkIuV36mLaw3cQW5ew6gvL5BICazVuiIfqg8ZAyhnHWEFmyGSNx7V+occfQP4KT9udXY2KTsLxNBwIy4ZDyVzIGfCgT2xcKJEgSCqy3gr1+6BGRxQ30XQinudiZK1zTQDnWuL+HXRDLF8PiBc+1k9i4PQNp9HtTg8u9e2evF9e0q14DOdPO5dcYbVN6LVVlPAMgpq9mIHWadbvh3AJizlREQSbQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(316002)(4326008)(66556008)(82960400001)(2906002)(86362001)(508600001)(9686003)(64756008)(66476007)(66446008)(7696005)(6506007)(55016002)(52536014)(8676002)(76116006)(122000001)(71200400001)(110136005)(54906003)(83380400001)(107886003)(8936002)(38100700002)(186003)(26005)(5660300002)(33656002)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iibYEXZafzIGSAwIfjQahXhgxc3tHwDUxVSo8vHSvgb/wTF7uRQs+Wmt1DLx?= =?us-ascii?Q?lc9odFPGO/tuDREx15gNZmUzOAZHRBf0Xvs0nNd48UNUZG9aYoXxtdhgDhuL?= =?us-ascii?Q?RwaonnP1K8UjF11CGBN/nJNQp6hK5b+z1f/EY54tKWs9zpjHXkqGfos0xalC?= =?us-ascii?Q?XfHU5J3WzKbB9pbncceN88dUB1gch+cmV377Sq1XsdxKAOYbzZxOn3aEQH8I?= =?us-ascii?Q?pOKh5nY1BCMajo8wqI1cdldFMCZZlJc4RHkULxhwUJ1U6/lQHt4EcH+rF7Wf?= =?us-ascii?Q?YALlGxTqZivqbNEdmboXGlJbtnlRQHOmInAnPWUKf3StwifKQY8Q9DGnoxjO?= =?us-ascii?Q?WrwnhcnyGoF9UMPN8LROoEBsncRMYdNRuuhD9S8uDvZI+nlb/jIwOdJEVrli?= =?us-ascii?Q?1+5k4wXwq3GQvc4Nii0rFT/LqtiDoIxVlu/ovo6K9Bbw8rGq2VMAD8GW/lPi?= =?us-ascii?Q?7pquJbGq1oiOSZDs6MLjZeRLScRRw2CZfy5qAGBrxnDZhNTw/hQjS8jPffNK?= =?us-ascii?Q?iYcCitCpfqPk3cE2LpFG1fYUmyyR3xXkzSQHZtYtLsTvQGKsJzki9DsJu6EB?= =?us-ascii?Q?R0wgOTrHBiCWUhQr2zRERaotcWiqBPFKMj54vBWWM58yhEh/8balCtNMwcKK?= =?us-ascii?Q?M4Qpx2uSQzmEuTwZr6Ge81DMZ+mjxQunfs7+XWf6gU5U45U1v1W8X92tud+V?= =?us-ascii?Q?CH0YKHq6/Vl8aG32fTljxDiSONxbtX0lTXpWgkx42zMReqh3FVMU1umfzaES?= =?us-ascii?Q?kybXbclgXp5CF0jCi6B3wlcwzwDm7h00vaXnqcvA29qgYkIf8va+rlfoDDk3?= =?us-ascii?Q?12BVfL+dlsO20wHtf2bbCzfvF9QcCKZgCphD035hVLfx+8yW+ac3EmYmhACp?= =?us-ascii?Q?Qz4ZvH1wPWdav6huReWa4XqoChlv1I5DxBSdLu5S1bAtCP944ADVsduP4TUd?= =?us-ascii?Q?mXiZVxmWk82s/3NVB3alOnxlth8s7ByQvGLhgTCS0BcSfPiAXb3zdq2vlWk2?= =?us-ascii?Q?ZtNweAPeuYbcLxpxXxqZ42jD/WF/B9PwLlKlGOrrmK26cyabZ9epP2KgC2zD?= =?us-ascii?Q?1k7sFfLNuuqVANe5cefCCMW/hfuH2DdelhHCgbJH7zaqshZkvXh+zvdvhA+z?= =?us-ascii?Q?1qaTwERqSTi3BC2ANDuLsMY6I+JXSAVYlUntIUbuNPzT7PGcVS0ZYqJfFVLr?= =?us-ascii?Q?Bqm8hea66Lnk/Ik50w+zjJ5vvwFFKT4H3kzkrBNym367AvHnnU/hxGtzMK3O?= =?us-ascii?Q?d67fLu1WXb/yRp2Ekykm9MEKxd2at1ovpS9eCzwZ9AqiqN3+1LUuaKjcK8Nz?= =?us-ascii?Q?3OdtpHTbgGmi/R9i0CkaiOyMEF7fzZkiJpK6Fx0JU7z0g+oiO38tqs7mnZ7g?= =?us-ascii?Q?0erVmTwcrL8/0LREw9txivY384FPAEktTivy2UmSHwDZRQYEN8ao5V1TcjN/?= =?us-ascii?Q?5R0r+SZYFGi2ORNDmS+uuS5JbkljO/HPpOlY2KaIuZMTlR0/rmflEDB6QzSg?= =?us-ascii?Q?uhRpawyRZOYStSdOr9+6sUlOoP7UzDQRJW51ev0McIXNglK9xp9CSXGu6lHJ?= =?us-ascii?Q?Wr4Hb6ZVJXMpuk2+rJ7hXri7qmqkL9WoI6i3O+Ghy/h1A917fGEsMMTVHjI6?= =?us-ascii?Q?jRjlsLwWv6hXd6xsuxRIP3k=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6115d96-5318-49c9-8d41-08d9989d2587 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2021 16:24:55.2246 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qefC0IMn+6/s2Kl8TWt1aatL9wY9CxWdf3bTZppUkgIGyrazsc5eOx8NQiyj/J6QkDA598bz2SRwuu/DZisd/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3902 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-dev v4 6/9] compress/qat: add gen specific implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: dev On Behalf Of Fan Zhang >Sent: Friday 22 October 2021 18:04 >To: dev@dpdk.org >Cc: gakhil@marvell.com; Zhang, Roy Fan ; Adam >Dybkowski ; Kusztal, ArkadiuszX >; Ji, Kai >Subject: [dpdk-dev] [dpdk-dev v4 6/9] compress/qat: add gen specific >implementation > >This patch replaces the mixed QAT compression support implementation by >separate files with shared or individual implementation for specific QAT >generation. > >Signed-off-by: Adam Dybkowski >Signed-off-by: Arek Kusztal >Signed-off-by: Fan Zhang >Signed-off-by: Kai Ji >--- >--- /dev/null >+++ b/drivers/compress/qat/dev/qat_comp_pmd_gens.h >@@ -0,0 +1,30 @@ >+/* SPDX-License-Identifier: BSD-3-Clause >+ * Copyright(c) 2021 Intel Corporation >+ */ >+ >+#ifndef _QAT_COMP_PMD_GEN1_H_ >+#define _QAT_COMP_PMD_GEN1_H_ >+ Maybe this should match the file name. >+#include >+#include >+#include >+ >+#include "qat_comp_pmd.h" >+ >+extern const struct rte_compressdev_capabilities >+qat_gen1_comp_capabilities[]; >+ >+struct qat_comp_capabilities_info >+qat_comp_cap_get_gen1(struct qat_pci_device *qat_dev); >+ >+uint16_t qat_comp_get_ram_bank_flags_gen1(void); >+ >+int qat_comp_set_slice_cfg_word_gen1(struct qat_comp_xform >*qat_xform, >+ const struct rte_comp_xform *xform, >+ enum rte_comp_op_type op_type, >+ uint32_t *comp_slice_cfg_word); >+ >+uint64_t qat_comp_get_features_gen1(void); >+ >+extern struct rte_compressdev_ops qat_comp_ops_gen1; >+ >+#endif /* _QAT_COMP_PMD_GEN1_H_ */ >-- >2.25.1 Asides from that small comment, Acked-by: Ciara Power