From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45F99A00C5; Thu, 27 Oct 2022 10:53:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA5A542B85; Thu, 27 Oct 2022 10:53:45 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 08464427F6 for ; Thu, 27 Oct 2022 10:53:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666860824; x=1698396824; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=azCRahOGVMhwkV/NNPHDaFCzgZJfmXIKQDxjZxUQa6Q=; b=PVgGBdE07yVuG5uK4W+t3/U0LDWtBC233GM60KUebdhrrQ40uti9DJfE c0mK+gfFyTwBp5coZQuELEVbntZp48l4nQjAj3L4TTbi9/biCF1wfD3je VqDLKibY7QrzjL6TwTxbmutoEjA2G6HlaCe3J6iwtiDMzNCGdVZO41oig squwEM8cu1gOshLk2ZSmIrSmDbAKUMXGMidMMVeIhuk34hSJ0n7h174gk TbSbZunqQiry6Ml3hMmI/2UdlFiQ0W98siVgyGcGZs8vJXgzknH9vVCZL +LGdCqbqYk4zSSbZZjgtPCaITfy19YZdN+RMUm9PvHHBS/YZousSvXxQK g==; X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="287885295" X-IronPort-AV: E=Sophos;i="5.95,217,1661842800"; d="scan'208";a="287885295" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 01:53:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="701266370" X-IronPort-AV: E=Sophos;i="5.95,217,1661842800"; d="scan'208";a="701266370" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 27 Oct 2022 01:53:34 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct 2022 01:53:34 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 27 Oct 2022 01:53:34 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 27 Oct 2022 01:53:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PWPY6UdGJlaPgt4BnZL5RVd0rkIGxkWRNtCV9Qa219S7fCh+Snvs+79YzleJsH7Ibkrqcy0CHNI5KyIVvcUrRXSsnGSAlFvJ5Xa3PmTSJ2J+QTfV8+YQ659jjqfFhFX7AMEy0dvzGJ9wUYg3tR9NHT0rTJ06fHGtX+yEhZ6f2x75aienxNYFx2gs09Z4NljnH1Lk6tCoJC05iX6I+bA3B/oFp6ylxpvI7HFLjzCj+RnV5AvzobsswGlB8ll2e/2D63708WiabOZWNCLignk9wDrzJPu9wNFvD4erL2i3HO1k8FEyCMrAXC/uENwGcl2tDx2+eWUyCqjEFX7wdz8iXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=azCRahOGVMhwkV/NNPHDaFCzgZJfmXIKQDxjZxUQa6Q=; b=QJyrI0UNHVOHBs6UUyur+Y6BXIRScsWZ/acz0eojAjLbnJMDeY2jwd51xi8wnkoE0RHUyEB9L9PqYsq0hL5+zlJgjbVGPd0msM6pA9/xh3cQMBR4PZN5tb8psm3fl0yAoe61zrIGOMyB7IwjcutMmHNSWo7ENkasxf1aSRyz7ixiRLnvE7OcC2VVGi3YFOv9qnLYucoHxpGdy2ZD+VeS568FHON5wfYtn0GUHPH6zzww3HSOWkcLM/Dc//fXoul9jBsg+15ZiDPBwModu4/eZ9XL3VvSDylz0+y5oqo8jSL5Dms6GkTOT/eQwpQvWVm51eWpDlTbqGf+jQt31RI0MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MW3PR11MB4618.namprd11.prod.outlook.com (2603:10b6:303:5f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Thu, 27 Oct 2022 08:53:32 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::fd53:6908:50cf:13ab]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::fd53:6908:50cf:13ab%7]) with mapi id 15.20.5746.028; Thu, 27 Oct 2022 08:53:32 +0000 From: "Power, Ciara" To: "Richardson, Bruce" , David Marchand CC: =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "dev@dpdk.org" , =?iso-8859-1?Q?Morten_Br=F8rup?= Subject: RE: [PATCH v3 1/4] telemetry: support boolean type Thread-Topic: [PATCH v3 1/4] telemetry: support boolean type Thread-Index: AQHY6FBbHtD9AIOQh0Cc8bHL+eP8Y64e2TOAgAACo4CAAA9oAIADBt6Q Date: Thu, 27 Oct 2022 08:53:32 +0000 Message-ID: References: <20221013074928.3062458-1-david.marchand@redhat.com> <20221025090052.429232-1-david.marchand@redhat.com> <20221025090052.429232-2-david.marchand@redhat.com> <6de84928-8f39-7e82-44ec-da40eb992380@lysator.liu.se> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR11MB3821:EE_|MW3PR11MB4618:EE_ x-ms-office365-filtering-correlation-id: 3f580d1d-ea5f-43e5-03a6-08dab7f8b9c4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EuhSC9C98RhwW31QUIT/UlOP63B2KSFQPG9bM6TCtEw0JiVwD0IO1tD+82nS3jy6GVe0CxV4ppckRznMN9739u0the0UZwT8H8H/Jno3Kps1U6W5whcw9rGriff6WSJh3t/9DN2LoEIh+5lE4iQQDeIdsQOhWITfkGGf2YHI0KWsRU+zskjxMIFP7On90tyZoa6axW4hJ+VsI/7MnOEtkuhEHpKhVcTGamzBnr21BklfViuW2Jy8ZvyjbjCHQCwWpVigWFG/Ttj+OC1Q/r/Nw98PWDdupTuh6SOaYpJNFkCNHv8h/DV7AUDASAZiHMu9gg/HTcjk7SxvcTWnzUykl6Y6U6eCfeG8wqpPJB5K7wGKzqmipQi5zgNJxi4m21DDjA3S+lstf7Qz01czjK6w/hgWzeYsop2eQBkq/TtcojKAjj1+SoIwsnVn0rczFr3NjlMdbkZtnhFinuUa+RxGgaSgRJITXp/gUPUFwgDei7IGkC6jX/jNxKM400KJpcM9U4nZdx0y2l3i6KaJr561iJQggFUNkT3Ia89Ove/AE6z23O6DcDPh1yEyQtKbKRkmuld3NJzj5JE6IpkDKgC7sUS8MmEvFcqIqnJ02ARkYrbD5RdVDWQrG2ulRl9lVtMzdLX8RL4YSgrnLuLrPDGgxGhCoc1Vmgzr/M6iQ5Suc5Ccrl+zAz2j+nK6oVckEZI1q4hgl4Qhi+1V46hfsTF0/n6G0/NuFwsvMQEfukA+Xh8l6XzDp4B3LsueNtJSr6g8xOqyTSWhsAf+eeXsZ5myIQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(346002)(396003)(376002)(136003)(39860400002)(451199015)(55016003)(38100700002)(122000001)(2906002)(4001150100001)(5660300002)(82960400001)(83380400001)(86362001)(33656002)(9686003)(38070700005)(186003)(26005)(53546011)(71200400001)(478600001)(54906003)(110136005)(316002)(41300700001)(8936002)(4326008)(8676002)(52536014)(76116006)(64756008)(66446008)(66476007)(66556008)(66946007)(7696005)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?tBK153ADakYkfWnkdbSfA0pzZVpGtbupFZf49XaxwScCzybhTIUikbm57F?= =?iso-8859-1?Q?PP4dnA0eiws9KoMEytQyTm3CGGGvdlZyobRMNUZljeR/cKYSRDL6jN0HX2?= =?iso-8859-1?Q?H5HqwBp271kuht3Mjv4Blf0KOKyO43B91BAR48SCdyBU+xiK6YOJ63Dqn+?= =?iso-8859-1?Q?lwIpb+QW4lEjnU1YaSeIqIK7HHuaHSn52UYFOoA7B5le0OL28Xr96ewC1Z?= =?iso-8859-1?Q?w6dooAArolX8EIjzXB7ED8f0P/UoJ+dXZqnT6GIdE2Uq+KuLqj2ct7gYhz?= =?iso-8859-1?Q?M9SJuuUaZhwaQgoPBTz595Jzjm7Sknfbuav1g3dsh7mwhaNHvxmzGmLDwb?= =?iso-8859-1?Q?A8K4ucQYmQoJ7+ZynAoN8dDNg86j+eDvyBskzbV2A2UaYCnVgNGg5MR+qf?= =?iso-8859-1?Q?uUZORNBfb34OWtGg/wTBiPtAKnREQHQ8JkGgb1ZZFlHkayMLXsPWoiR5Zm?= =?iso-8859-1?Q?mOoSXAMFnADW14ZuI/ynQtwmYakafmNn9dCWaoP/duP9mj3zU7Y6cOUppg?= =?iso-8859-1?Q?/PfqzM+L9xHf3PrgfQU+nxl327wo7bUFvYxJ37IGTavyBUyOxoja7tW9Qo?= =?iso-8859-1?Q?gm6oujJTwJwgVEuyRACqP0z4db2jpe95qvoxUFO5XPYO/9qb1spfCltEKA?= =?iso-8859-1?Q?k1ORK+mcRL0+lOUvTIPePcgZKcuEED9pVUaHdoWzdHOtrZuf3Nul0TyEYS?= =?iso-8859-1?Q?PNRDmkypzBxRrAXUGjBjZOfDB0yM/gwzguFHQ0erlCyXs13vHuOS849zyM?= =?iso-8859-1?Q?4LgzDrocS/yItZBq4ZvulXDVMdodtDFI6VrdW56X8HH79JYfrVgXzJW10h?= =?iso-8859-1?Q?XYbD0v4qNXb0XxhNfiQMuJvnSGIL3JVQVj7ozM6/UkSIXBsHf4s2Jthgn7?= =?iso-8859-1?Q?IcqK30sPyOnxz75oYF/KOIAgg1p6gwlWC+M2iF3LQhYJo76whZiirjYJbD?= =?iso-8859-1?Q?3RcHJXEkoOajaEISoeTHjHsC3eMJX0TIzUpmuYECCgLZuB4sswZD1uzTan?= =?iso-8859-1?Q?SCt6iViF8mGQABSD6QKk1JVqrZnNIe8Aw3fCuJP2YG7ADI7NOd7JOaAnV8?= =?iso-8859-1?Q?Rm4q1AyXMGrd/lu/afCrBxEhdB1QQZarcsoYpOMBg1b4L4CKENzfVksJzy?= =?iso-8859-1?Q?4Dkbr5JYsRcYyqkG9U1RhmtcYJ8oeW+E4tdyuGsydeNS2BpskGYVd8/qDZ?= =?iso-8859-1?Q?W5GHVNWq7GO239s6BZr6YtWre75SpcRxw0Y6F5j23cUW5/aVyYf9hBVlG1?= =?iso-8859-1?Q?Gzb5FUscPAaR2F0LBv3OvBx/I2BCPQ16Ul/mjJi9ixzvkZO5qjls/ONXkf?= =?iso-8859-1?Q?cpu4fEyoYVBk0ZWh6iE0KbTuehKo0hLlJhBhZjw6OU7Mtc0qH0GnQQ2xl3?= =?iso-8859-1?Q?ciuLJpr26KnK3qgDvPJN+1oWK0rKBeFbLafRmBpIENDdm0/yP8MtK2kPkM?= =?iso-8859-1?Q?ZyR8mx7mbV4ghDPk8eaomGGIITsb1Q6r71bQRT/AddO2fLStjcUarq0IG0?= =?iso-8859-1?Q?Gvq8IyXnh5UqFvRXubLu53nOvMcLnvVP6XJxeDxtgoTbldARp/LEEjb7zw?= =?iso-8859-1?Q?RBUbGPMjLSNxhu+eYqSiiGc+wRBAcpej4BZMZ3FoyNYJjx04adnfz4xn85?= =?iso-8859-1?Q?9qRPKVeLRqt3qaafB6dIc3S5rtab7St6Lk?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f580d1d-ea5f-43e5-03a6-08dab7f8b9c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2022 08:53:32.2281 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3kNJz8dOs7zYv4Y/d3Zzku2oepwBdfEpkGJMB+af7lJ8N1PbJCqmCo4OrwRBz552tT07mFi/UaCiokU75+mDeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4618 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday 25 October 2022 11:39 > To: David Marchand > Cc: Mattias R=F6nnblom ; dev@dpdk.org; Morten > Br=F8rup ; Power, Ciara > > Subject: Re: [PATCH v3 1/4] telemetry: support boolean type >=20 > On Tue, Oct 25, 2022 at 11:43:27AM +0200, David Marchand wrote: > > On Tue, Oct 25, 2022 at 11:34 AM Mattias R=F6nnblom > wrote: > > > > > > On 2022-10-25 11:00, David Marchand wrote: > > > > Add the boolean type RTE_TEL_BOOL_VAL for values in arrays and > dicts. > > > > > > > > Signed-off-by: David Marchand > > > > Acked-by: Morten Br=F8rup > > > > Acked-by: Bruce Richardson > > > > Acked-by: Ciara Power > > > > --- > > > > Changes since v1: > > > > - fixed doxygen description, > > I'll let the telemetry maintainers decide on the fate of those patches. > > Thanks. > > > Well, given the lateness in the release process, if it's a choice between > getting the patches in as-is, vs not getting them in at all, I think havi= ng them > in 22.11 is the better choice. While there is cleanup that can be done, I= don't > see this patch as making the overall code any worse. >=20 > My 2c. >=20 > /Bruce Agreed, it's a good addition to the library, +1 to having it in 22.11 Thanks, Ciara