From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6396BA034F; Mon, 7 Feb 2022 15:51:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0AA1410F3; Mon, 7 Feb 2022 15:51:00 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 54E69410EA for <dev@dpdk.org>; Mon, 7 Feb 2022 15:50:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644245459; x=1675781459; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ljMz0bfdBFI/GS2hyKEiXkaTuExwh7j4Q88jYGUuZRw=; b=UpdZHsnQcLpgsi/Hsif2Ob0llITMABydEgxy8jqileh4zXv/W1tjpIs5 qjcepu2gqKwIFJq27WgXhdVaa8T7MtIH88j1a/9+JhkTFHDtAtfqbsg/g cZjfBCMFNplyIRe74WhU3XvpTqxNR2RawH4OIE+xLRqDvlUMB8wp6+Meo ey+m9UMokyeJWpcjFlgU0xugQA0aH/0vcBlyuceVK6ih/m4dbzu45LpbP IuPpYL1mquMIpP1y8J38I4jDdB2QESIiKa//kFipcHIVqMaLIpcgh8f/r LpvgOFWrOcADJ2HlsY9bMDNSo8DlOCLrL10r+csLe/n6uVMU8u/UB2rrA A==; X-IronPort-AV: E=McAfee;i="6200,9189,10250"; a="309473527" X-IronPort-AV: E=Sophos;i="5.88,350,1635231600"; d="scan'208";a="309473527" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 06:50:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,350,1635231600"; d="scan'208";a="770653421" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga006.fm.intel.com with ESMTP; 07 Feb 2022 06:50:54 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 06:50:54 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 7 Feb 2022 06:50:53 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 7 Feb 2022 06:50:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EuJAMTT62dD/YnucXsKZmIdv81sLCVHK29dOvancZNciTz/QQJ3Uo+/xbGggGeRPv+mzPWKfyNg8M27opYvvwcSObWvY5ycd4mND2IMkdKHzej/3/sohJknsHWqafqNQnKO9XrH9ZTzaS5qljzaPuezIOZAxnAy2BPXcE7BVz9UVtgXWopOpnDSw8Lfmo01ABuL8mxxxzooc5LPZb5JcH/TgE8zREfdmv9tEGC1W+K5AX24vLOasF94iK0q/1xBAg6Uo1VS2kOWzoSVIDc7xiLPubAUp4GXsdCboUCd2Ggo45N73FsDf4nKzrmMxApZBIf8geeWaNBw3VNXZzNStqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xXZxdngK7dSfWKRz5MrYyGp+qwrVtEdKAdrhyFVM9A4=; b=dm6i4/hHsyxYfxCJypq3/gPU36J2e+7ISc5Q2cvlpK8mVkB6R3W4J0+/boQITdfTO8jHA5BxffK5je+KLM1IM9Kx/EQDV8T9xvZ92tb05thn0vqYKXkOKtiOfJ7piw0LnMVMgOXbrRxID4sE7ZXG6cm4jSWJ059SwLBmeXDlhzrF3IidaALezajRgkj2fH/Or0wTV18WU6HCim8+3cZEvoD3VuLi6xaMninRDf5B0l6afHdg2k4F9goN16MXPbmIe0UXTy4+6Qiw3ZtExe+TJeSU/+pLZ1rgHZnsW4mdugAGeBRTsJFwquC399oing71uUgk9DQTvcEtxQUmer9kMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by CH0PR11MB5737.namprd11.prod.outlook.com (2603:10b6:610:112::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Mon, 7 Feb 2022 14:50:48 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::4fd:a9c7:1eda:c93d]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::4fd:a9c7:1eda:c93d%6]) with mapi id 15.20.4951.019; Mon, 7 Feb 2022 14:50:48 +0000 From: "Power, Ciara" <ciara.power@intel.com> To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net> CC: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, Anoob Joseph <anoobj@marvell.com>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "Doherty, Declan" <declan.doherty@intel.com> Subject: RE: [EXT] [PATCH v3 4/4] crypto: modify return value for asym session create Thread-Topic: [EXT] [PATCH v3 4/4] crypto: modify return value for asym session create Thread-Index: AQHYGRfzXT73UQPhxUe0CwdFIggJTqyH0T4AgABZDoA= Date: Mon, 7 Feb 2022 14:50:47 +0000 Message-ID: <MN2PR11MB38219B6980F963CC84B8C801E62C9@MN2PR11MB3821.namprd11.prod.outlook.com> References: <20220203160449.1638311-1-ciara.power@intel.com> <20220203160449.1638311-5-ciara.power@intel.com> <CO6PR18MB4484D0AB3663D14DF7F19A0ED82C9@CO6PR18MB4484.namprd18.prod.outlook.com> In-Reply-To: <CO6PR18MB4484D0AB3663D14DF7F19A0ED82C9@CO6PR18MB4484.namprd18.prod.outlook.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c24238c1-bddd-4c2f-da48-08d9ea493a3d x-ms-traffictypediagnostic: CH0PR11MB5737:EE_ x-microsoft-antispam-prvs: <CH0PR11MB57371F208059CE501F32A572E62C9@CH0PR11MB5737.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pKxdVbHUX/fZ+0N0W/hmnQSshij16UFAUhakvszAHnZuULesOCkxogTYzJ7g3UkJGbfpFCg3LK5V5YodQYejvYDN29EyJ4YoqAHZTgoRaBbwUv9KMBcoipvdgY8tgUW/DgbXEluhUYwYrx0DjEf4RQA2j2rcmJVJCeBPwFL/YK6o4kvfujNjeJAIX9pUijtAE/GAyGoDZGx6EigXBLzwtF6iPW2WPAGdSvT0je3Phtv+B5GTBedZriWelI7diZVPGwMoUozXHbCvePBGP1I6n8il9ATyCsVK9VJJ576yAwYZj/FgNvNyG1IS/hpJPqZHibj1Q+OEtdi5ksUTBnwWFa0nUUt66GDQOetZqNJ73z2kGHX84zwm7DQSi3jKrugnq5VSuXjG+fSRg0XmufOAqsCTYFTz8zJOIHFvwAv2KcVKfT4981eQO2qXdTdyeFlC9JyYp2sJJC2FMVl6/DlNRAdkQAFs77tXXqUe0pU3MkhKhRc7vaeWCe6v9KEOI2YxxgImC8nKuDZIp0Zm2b3SBOyRgnk941SHS8EWEa26fJmTkkw+qVXjc/qXNyGUBAv3H3t0dtHofu7+SPkU5io3WVr76nOu5JqRXp+Oo7Ku5MjAMDeEJJbueZpTxjuTeJbS6eV9lmuYPS4Zw9+WPodJ5Vca7OV5Aq6fiYeiJNk7OEAAVvfgcDvZlInDE1myDCDBiHRoIDzXzHRKiKGL8u9qcQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(5660300002)(26005)(107886003)(38070700005)(2906002)(508600001)(82960400001)(38100700002)(122000001)(66476007)(86362001)(76116006)(33656002)(71200400001)(316002)(52536014)(54906003)(6506007)(7696005)(110136005)(9686003)(55016003)(8676002)(64756008)(4326008)(8936002)(66946007)(66556008)(66446008)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t1GHzqGC0wWDRlRPUmxy2WaQb/4FkhCS6SJN7zn/Nmhzo/ogYXuqtiQbVbhL?= =?us-ascii?Q?qQyfW2S+WtyZdXR9VXg/SlolkCiObcp68gCHiKMZ7d/OvIcEzw9oZ73KaJML?= =?us-ascii?Q?G2lNDZ4Mn/m/dJ0i61RnRHaxc3AFqi98To9yG/Xw5L5k8TWBEULcvJmLMja6?= =?us-ascii?Q?Phdwgp4S2pBYbZftybC1Sb0NMACGSfIl64/hEyzLDFk/gujQfqnNa/JOuP/9?= =?us-ascii?Q?3imADG1X6pdbOG4ZoDeGEdinXJvMMZ57fzjjaydus/Po1YAbjfINCgFWLyOw?= =?us-ascii?Q?RaXNxdYFirt7U4eUts9940cEL2qPUyzfVXscsTXNHTnaBnz1nvs4IRQqPHHx?= =?us-ascii?Q?UkhrD64tgZ63/IOdPFWaC3zyyhSy5BxGpK0xVaw4eXwpC7Jqwi0DWJ/7ZW7O?= =?us-ascii?Q?Df+2RPdB+MI9cDHGRTjr02gK4luNujgzyRxMFCGGTk60IV/WvehvVbXMg+cE?= =?us-ascii?Q?vjYLgr6nB2WI4yDaTknFcp+PO1TWtyffFcKmBoxWFc2DZPOrHLDiqyGzdOVF?= =?us-ascii?Q?beLwDOTQ+ZKYKyFo5lnY+lbLQsJ3pIJnZy92UXXDk9YjnmneuB5KfYcQqOLs?= =?us-ascii?Q?BhIm/w7/QWM4JYpz3JTPHYvj8bKQ89gycpnAawgpjJyDCjSNwMT4zUTGMSMM?= =?us-ascii?Q?g9w9Rq+tZAWL0MeHJ4bYaq8jXYYi+HrxtIZ7UFKCzCBRIfUTxkmiN8gSaDFg?= =?us-ascii?Q?n3lnoJAGjJ5b0T5Jd4KQTAo9Gd1M/jRj76e1EmTfk4sCwcORWZKaxFt06XyY?= =?us-ascii?Q?8UGoeshyTOQpuV51xVLE3hKu4kkSCSCF8B24lEFGYcmmVQkxMYQSTme3KSyw?= =?us-ascii?Q?JHU9RX/sWAYAOnjg9K5qp+Nrg2J9lyuR3eZAseAv4lbWT2TDGclpiZ0MDYyC?= =?us-ascii?Q?Gab7S6XeOrzd4XSx/Rm5jrkKSZVL9ziZZfnCvFQZwGRy7VnIHK2vd2lni1Qm?= =?us-ascii?Q?eCDdFoJM7VVja4h6NpOk750yYEsypwcMZht00YxKrumWZlh5nHTQtCUznfNF?= =?us-ascii?Q?HKXigkbRCPnIjHd5lytTnpqaaxMGAbC0uKq97imuTBtNr3nm/39mdm/LkKB/?= =?us-ascii?Q?YKqgGdwH88xU4HrLkG/FECFHwvsyE46Pso6bG+IRo02cXwWFBcyUC3NhG63P?= =?us-ascii?Q?vhDOxTrqJZmY/zxbWOHsWiuj5cR6CdGFqNpCUDfstpBt+nX7xMZcGxVBEOx+?= =?us-ascii?Q?+bPYlETRjq/453LeFYrmYrLZwoIjF0Euy3WUt3WfubiWuQT4TeMiKcxhKbx1?= =?us-ascii?Q?sakxWzxYzsfIlSUTuu3yhaH7wnOTSu6iOwR7+3wn+78CgFzQAAMOKjArZ99G?= =?us-ascii?Q?WT/CjXOUA45C9di76gh6wmlnDQtwRIMG3zF2JG/zrtVmujIyUjCqo8FpdVjF?= =?us-ascii?Q?CPzVQNFypE+Yx90PwF3bjJcQqHMSCTn0JpQFtCQUSp3LIzCZCrE0PBQJDzZU?= =?us-ascii?Q?AXeHXc/CJdstwnEgNEionAPKI0oxcauG68h/tOJqyz7GeTrXgG4+tD4CvnpB?= =?us-ascii?Q?z0BZoxsuJqWMlDsLuI2HZo1rO+Qa4TkjEXW3AdJp+n//Q2aNkQso8XNxoLbA?= =?us-ascii?Q?PfdeoobxdE+WRcFtKX9yInPrtGJ9ywH+y+33p7CSowHoe6mAV6F3MWBUfLtw?= =?us-ascii?Q?OC85nxJQFSakIH4BbSp2ssM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c24238c1-bddd-4c2f-da48-08d9ea493a3d X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2022 14:50:47.9498 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rtV9UzTDP6ouCG6GKWb7tn0wfEWiVT7CY9UZlGqH2tfTQRE3/Tf7iZL8jBkNaOz+8D5PbVdtQuCvg5oZsIu8dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5737 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Hi Akhil, Some replies inline. Thanks, Ciara >-----Original Message----- >From: Akhil Goyal <gakhil@marvell.com> >Sent: Monday 7 February 2022 09:05 >To: Power, Ciara <ciara.power@intel.com>; dev@dpdk.org; >thomas@monjalon.net >Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Anoob Joseph ><anoobj@marvell.com>; mdr@ashroe.eu; Doherty, Declan ><declan.doherty@intel.com> >Subject: RE: [EXT] [PATCH v3 4/4] crypto: modify return value for asym ses= sion >create > >> diff --git a/doc/guides/prog_guide/cryptodev_lib.rst >> b/doc/guides/prog_guide/cryptodev_lib.rst >> index 62bd3577f5..8e16461dc6 100644 >> --- a/doc/guides/prog_guide/cryptodev_lib.rst >> +++ b/doc/guides/prog_guide/cryptodev_lib.rst >> @@ -1236,10 +1236,10 @@ crypto operations is similar except change to >> respective op and xform setup). >> * Create asym crypto session and initialize it for the crypto devi= ce. >> * The session structure is hidden from the app, so void * is used. >> */ >> - void *asym_session; >> - asym_session =3D >> rte_cryptodev_asym_session_create(asym_session_pool, >> + void *asym_session =3D NULL; >> + ret =3D rte_cryptodev_asym_session_create(&asym_session, >> asym_session_pool, >> cdev_id, &modex_xform); >> - if (asym_session =3D=3D NULL) >> + if (ret < 0) >> rte_exit(EXIT_FAILURE, "Session could not be created\n"); > >Sample Code in the rst files is no more added. @Thomas: Could you please >confirm? >Probably a separate patch is required to clean this up. > [CP] I see Thomas replied on this - thanks. Will try find a section of exam= ple/test code that does the same thing as being shown here. >> diff --git a/lib/cryptodev/rte_cryptodev.c >> b/lib/cryptodev/rte_cryptodev.c index 0d816ed4a9..005f0e7952 100644 >> --- a/lib/cryptodev/rte_cryptodev.c >> +++ b/lib/cryptodev/rte_cryptodev.c >> @@ -1912,9 +1912,9 @@ rte_cryptodev_sym_session_create(struct >> rte_mempool *mp) >> return sess; >> } >> >> -void * >> -rte_cryptodev_asym_session_create(struct rte_mempool *mp, uint8_t >> dev_id, >> - struct rte_crypto_asym_xform *xforms) >> +int >> +rte_cryptodev_asym_session_create(void **session, struct rte_mempool >> *mp, >> + uint8_t dev_id, struct rte_crypto_asym_xform *xforms) > >Do you really need a double pointer for the session handle? > [CP] Yes I believe so, the return value used to be session, but now that we= have an int return value, the session needs to be passed in as a parameter= somehow. We need the double pointer because we need the call to rte_mempool_get() to= set the original session pointer that can be accessed outside of this func= tion, rather than just the local copy if it were a singular session pointer passe= d in as a parameter. <snip>