From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3203A0A0C; Tue, 29 Jun 2021 16:32:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72A7F4117E; Tue, 29 Jun 2021 16:32:20 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 3913E40E01; Tue, 29 Jun 2021 16:32:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="208195438" X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; d="scan'208";a="208195438" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 07:32:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,309,1616482800"; d="scan'208";a="643732204" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 29 Jun 2021 07:32:13 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 29 Jun 2021 07:32:12 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Tue, 29 Jun 2021 07:32:12 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Tue, 29 Jun 2021 07:32:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kVHAk6SwWz/1OL5ESfNMjYRAJSrzhhgqeEcqVfpRuw1Dpw2/Q3vrS/GaCLnJiV0x2yvcjh7dpJ53+0AHfwSj9TS59rIPB87yaks8RSOymtb7JS+RaG8FO9ieEthImV/KwZMQ39lvHhcY/xJEAKuusZV7ABVwezlSZlwYfUqAIG4Wac4t7ojJqBfS4d72Ap84ml+4J/J7sTyBpAbOcAe+Bae6EU4t7Paf7TTpttRnmFz8dfUKpL6WcSyWqkwFrDrF14gKVp5GZF5sMNMLZ3v8khiR64Og9L0mNLZYuqfoAxIUhOR19iw9I5JiL2sPnnPtK0IjsrrWPBcPZ3C8a70MIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0PzwB2pEuSNqMBrdq3ZlT42IcG08Wa58DziJ0mDxrHw=; b=dcx8q6IHLjVekQLrxcwsXTiawTc+NJcvcWLuMmjfRhWpROMDWyXTKqFSJfEs6hFuomrNGFCPY1IVyUAaF5xnXbQCJAUZTzyD5c331Bk9nVIw7syb8DHLB3hL0tCER4/d4crjulVlh43uSm1H7eekLYs4y7Aa7nAFlr4+5bP1oIH6XHgne+QwyLhcwRX92A8anVvvF/5okUcWaUuQMYcJLHUgFvSBAzcttcyPtK2WYfrASzfOeCntR8k4fYAotGnDilj/aYIZklL9wPPG8nf6gnu+ENm0MiXbxGEMJmEl5/m8Bc7BUfklm9hxqMwGNYHIPLQOFHTSnxrqkur3Df8ckA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0PzwB2pEuSNqMBrdq3ZlT42IcG08Wa58DziJ0mDxrHw=; b=nxySwMN4qbGV1VwOLp05pU45QadMOLeUPUumexjpqOBgMyr75lVdrjQ3ik7XcoWt6L+Aj2blmm9nzNfutE4vzUvzXFHXtoEoyeBAGOQ3HPi+A31xMDkvnn9UpXVhg31nuXfubJzNxirHgJFpxbkSCnoyB0KhJhsTN/1gPqVqJC0= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB4014.namprd11.prod.outlook.com (2603:10b6:208:137::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.20; Tue, 29 Jun 2021 14:32:10 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::9900:c6fc:a30f:7933]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::9900:c6fc:a30f:7933%7]) with mapi id 15.20.4287.022; Tue, 29 Jun 2021 14:32:10 +0000 From: "Power, Ciara" To: "Troy, Rebecca" , "dev@dpdk.org" CC: "Doherty, Declan" , "jianjay.zhou@huawei.com" , "De Lara Guarch, Pablo" , "Zhang, Roy Fan" , Akhil Goyal , "hemant.agrawal@nxp.com" , "stable@dpdk.org" Thread-Topic: [PATCH] test/crypto: fix autotest function parameters Thread-Index: AQHXbDjs+63ewx6k5E+wFdhWaAUu+6srCC4g Date: Tue, 29 Jun 2021 14:32:09 +0000 Message-ID: References: <20210628161529.386889-1-rebecca.troy@intel.com> In-Reply-To: <20210628161529.386889-1-rebecca.troy@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [212.129.74.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc2ef2b6-7f70-4f0c-d4d8-08d93b0aade9 x-ms-traffictypediagnostic: MN2PR11MB4014: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BGj6GKWylCP+nsJNcWBrcOdIdYw4TMIWfyb8Zn9oFdJIHtnkxltsXHqCAuKCgW7nI3VkJJ0hDpmZV51jbJDvPJxvyvZkiP3iG0Y1obDWbLxR6/Ol0UKDnIhJZHMCuJ1tAQ5cwh7EJ2fTLVgIRn8u9w9H2K2pslTve9LydMwDk+wQ3hbQ4YPJSO4eOuxnoa4xTbOJQc0AIo1TeoLKeQynlLQxJnKAmjQNPS8g9S1WOD+AUPfzdwvBxVUVKWQSdLWEgSwsqivsHCTwGWpPqPT0ST2ejqSALi6OjQAgDwVA/ZmT2BQoPoS2Jfc6zyB58uVwaJUhh9Kov6NkMUhF6DhmEMurtSTm+1PSNAqfGgS2CkpQVtpKWoKJkfPUdS9K92w8hiYWLSmccfYExRDZWqXGh6roPK77C4JOuXjQMs7rShgfmVWL5L4pgPtWxGl1cqrRvItEQchukmS3d/q2h03extaQit8atM3saajFkgY83D0j6rJKREIdV2+7+qbpESAFs6WX8VURrDUnpDR85//TyI56Xx8dy3Mb6EpTzGsYBSqbtbM/l5MXQHDD79m9Ql3fnlEd8TtT+67zlUmcHl+mBjnpeneyzX+FCvz3kZci+ooGKDeTtrtYiQ1t2RNrz4RRgMhv8JcKjKJNX38AT8Tuzw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(396003)(136003)(346002)(366004)(376002)(33656002)(7696005)(316002)(8936002)(110136005)(71200400001)(9686003)(26005)(122000001)(186003)(76116006)(86362001)(83380400001)(38100700002)(4326008)(55016002)(54906003)(8676002)(6506007)(66946007)(64756008)(66476007)(5660300002)(2906002)(66446008)(478600001)(52536014)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AiHnHXZXvYp9KY+2fifpNM9HEymFcRBr6Upe3RbpGYyCbZHsQ7N5SRpbFRfL?= =?us-ascii?Q?qFsyaFROL6MF773RStgDr8abQWbWnTzaQVUmqKMLoUR3DBoZTSC+MFPsfXcn?= =?us-ascii?Q?AcKN5cdwPxK57r+4eF8oU99ujVwU2cilJKhCVksaq78nOgFQHq4x5mvB9/ED?= =?us-ascii?Q?tPZP4JoD6S7iMiVSBEpcSwSQ+opHi6EUZo6pGRNBNrO7oM3fXO/Az/MqJDuI?= =?us-ascii?Q?V4Ytlv1It8VXhSU0IPXJziLOlKQLWHmR5F3x2h6BS5Ld5lQRTHQP0kqj633w?= =?us-ascii?Q?D9QWnNCDQAAPmL++fPgoYJcL+INe9IJwAYsuR99guM7XXMn/mcY+dxKFt+Be?= =?us-ascii?Q?gBzJFEHB9RgUb+jDrBkB4gSdXWxZ1tQ5ILrIHqXhwccADmna/5sEgt7D/wez?= =?us-ascii?Q?bLk8KbwWYxzFKxEzTFOBnjvXF4A/uZuga/9hMKWNMILrI+yWKp6wjPdodDDy?= =?us-ascii?Q?T4YzWHvYz6xGT8u+4uR9aRe8Vh0/r1m4Mm05O2nRBi07JNS/PIh9DPx2i/C2?= =?us-ascii?Q?5AD7kZCM3fSHfXRfpbhCMYywPMRzHPlWS8wX7fAKF3Gk3CVfIeFU91tSy+CO?= =?us-ascii?Q?hqgRdXtGZ1Chsxb5dnR8b8BNmgBi/ux+NqhI4kxsJhtWmnUccRdNJpVnMLA0?= =?us-ascii?Q?2/gAcflvgVDc98R5jA2YoevX4sP9TPumdmSm/AGI48l3XBhaTVgfMpc7zvoR?= =?us-ascii?Q?Trf88GsWOE2Sr41OG2x/jA59zx/wJQp1LnlAZxRIou4OpfOu6hCvArsXkBdv?= =?us-ascii?Q?mE0dHpx3syLuMGQodm827tTBIBjOUcFaDCP05wcaQzofAFdTv0UJTFX56oU9?= =?us-ascii?Q?9eKJdjhudKjb+Z3uDZXXXoeKOhjiSXh7Ellwinzseog4/6zw3UQDx+d1DtF9?= =?us-ascii?Q?9dgebof3+U3HnOoxwKLi1QL0Qizkmn+7ZYPORPC2IvNuAkmT9Cj9HVEX+cwP?= =?us-ascii?Q?lACsNBy5HQUCfKtkv0rZocLVQ7EaL8XEcgtMqM7wevgDnnK6hK3fE27MYwWe?= =?us-ascii?Q?6vBAeW+C722SC0h83S+4f7cK3xyShgOLC4zL+B5gO7hucybhyhvdJe9jAr98?= =?us-ascii?Q?6wYPDep4GZ9Zh46Hl/aefivV8ZiW/n7WrnPIXeT+vkEKih/FkHky1ETbGm8O?= =?us-ascii?Q?UW2URr/cUsFy3MaYfXIgkiI4l4qz9ChxO1klt+3kAkKPbARcYUojcNseDNn8?= =?us-ascii?Q?JLwSNESIp5PDRbFJuWT4oh9nnzyNY0hGeE93vH8Pd7C+mG4EvRgGKrUv7QBF?= =?us-ascii?Q?3H1KtyjSDtIYI/PtNaZaJ6bySLjkCZeKIFJJpcsmK6C0IIZcYCZVceQq0MUb?= =?us-ascii?Q?6Yrh+A0OHYUcTh/EhhsM2clS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc2ef2b6-7f70-4f0c-d4d8-08d93b0aade9 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2021 14:32:10.1041 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nEMWO1ZsNwuLnM3FW2WyQ0zthl3w2SO8uoDR+d47Zuup/rINrjjqRfXS784iGhjcAvQBrOMZ8pUdVahY12VReA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4014 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test/crypto: fix autotest function parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Rebecca, Looks good, thanks. One minor change added inline below. With this change, Acked-by: Ciara Power >-----Original Message----- >From: Troy, Rebecca >Sent: Monday 28 June 2021 17:15 >To: dev@dpdk.org >Cc: Power, Ciara ; Troy, Rebecca >; Doherty, Declan ; >jianjay.zhou@huawei.com; De Lara Guarch, Pablo >; Zhang, Roy Fan >; akhil.goyal@nxp.com; >hemant.agrawal@nxp.com; stable@dpdk.org >Subject: [PATCH] test/crypto: fix autotest function parameters > >Fixed parameters on autotest functions by removing comments. > >Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") >Fixes: 4ed1e79e7819 ("test/crypto: add tests for virtio-crypto") >Fixes: 3aafc423cf4d ("snow3g: add driver for SNOW 3G library") >Fixes: 27a1c4714d54 ("app/test: add KASUMI crypto") >Fixes: 4c99481f49c4 ("app/test: add ZUC") >Fixes: c8e69fce7046 ("crypto/scheduler: add unit test") >Fixes: ae002048bbea ("test/crypto: add DPAA2 crypto functional test") >Fixes: b674d6d0381a ("test/crypto: add dpaa crypto test cases") >Fixes: a8dbd44d6b4c ("test/crypto: add CAAM JR validation cases") >Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API") > >Cc: declan.doherty@intel.com >Cc: jianjay.zhou@huawei.com >Cc: pablo.de.lara.guarch@intel.com >Cc: roy.fan.zhang@intel.com >Cc: akhil.goyal@nxp.com This should be updated to Akhil's new email address (cc'd): >Cc: hemant.agrawal@nxp.com >Cc: stable@dpdk.org > >Signed-off-by: Rebecca Troy >--- > app/test/test_cryptodev.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > >diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index >39db52b17a..c18730f138 100644 >--- a/app/test/test_cryptodev.c >+++ b/app/test/test_cryptodev.c >@@ -14521,19 +14521,19 @@ run_cryptodev_testsuite(const char >*pmd_name) } > > static int >-test_cryptodev_qat(void /*argv __rte_unused, int argc __rte_unused*/) >+test_cryptodev_qat(void) > { > return >run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)); > } > > static int >-test_cryptodev_virtio(void /*argv __rte_unused, int argc __rte_unused*/) >+test_cryptodev_virtio(void) > { > return >run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_VIRTIO_PMD)); > } > > static int >-test_cryptodev_aesni_mb(void /*argv __rte_unused, int argc >__rte_unused*/) >+test_cryptodev_aesni_mb(void) > { > return >run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_AESNI_MB_PMD)); > } >@@ -14579,19 +14579,19 @@ test_cryptodev_null(void) } > > static int >-test_cryptodev_sw_snow3g(void /*argv __rte_unused, int argc >__rte_unused*/) >+test_cryptodev_sw_snow3g(void) > { > return >run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_SNOW3G_PMD)); > } > > static int >-test_cryptodev_sw_kasumi(void /*argv __rte_unused, int argc >__rte_unused*/) >+test_cryptodev_sw_kasumi(void) > { > return >run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_KASUMI_PMD)); > } > > static int >-test_cryptodev_sw_zuc(void /*argv __rte_unused, int argc >__rte_unused*/) >+test_cryptodev_sw_zuc(void) > { > return >run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_ZUC_PMD)); > } >@@ -14611,7 +14611,7 @@ test_cryptodev_mrvl(void) #ifdef >RTE_CRYPTO_SCHEDULER > > static int >-test_cryptodev_scheduler(void /*argv __rte_unused, int argc >__rte_unused*/) >+test_cryptodev_scheduler(void) > { > uint8_t ret, sched_i, j, i =3D 0, blk_start_idx =3D 0; > const enum blockcipher_test_type blk_suites[] =3D { @@ -14719,13 >+14719,13 @@ REGISTER_TEST_COMMAND(cryptodev_scheduler_autotest, >test_cryptodev_scheduler); #endif > > static int >-test_cryptodev_dpaa2_sec(void /*argv __rte_unused, int argc >__rte_unused*/) >+test_cryptodev_dpaa2_sec(void) > { > return >run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_DPAA2_SEC_PMD)); > } > > static int >-test_cryptodev_dpaa_sec(void /*argv __rte_unused, int argc >__rte_unused*/) >+test_cryptodev_dpaa_sec(void) > { > return >run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_DPAA_SEC_PMD)); > } >@@ -14749,7 +14749,7 @@ test_cryptodev_octeontx2(void) } > > static int >-test_cryptodev_caam_jr(void /*argv __rte_unused, int argc >__rte_unused*/) >+test_cryptodev_caam_jr(void) > { > return >run_cryptodev_testsuite(RTE_STR(CRYPTODEV_NAME_CAAM_JR_PMD)); > } >@@ -14767,7 +14767,7 @@ test_cryptodev_bcmfs(void) } > > static int >-test_cryptodev_qat_raw_api(void /*argv __rte_unused, int argc >__rte_unused*/) >+test_cryptodev_qat_raw_api(void) > { > int ret; > >-- >2.25.1