RE: [PATCH v2] app/test: add additional stream cipher tests

["Power, Ciara" <ciara.power@intel.com>]

Hi Tejasree , Akhil,

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday 21 June 2022 13:51
> To: Tejasree Kondoj <ktejasree@marvell.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; Power, Ciara <ciara.power@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Ankur Dwivedi
> <adwivedi@marvell.com>; dev@dpdk.org
> Subject: RE: [PATCH v2] app/test: add additional stream cipher tests
> 
> > Adding zuc, snow3g and aes-ctr-cmac auth-cipher test vectors with same
> > auth and cipher offsets and total digest data encrypted.
> > Existing tests have different cipher and auth offsets and partial or
> > no digest encrypted.
> >
> > Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> > ---
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> 
> @Ciara Power: Do you have comments on this patch?

[CP] 
Tested this patch and there are no fails for QAT, SNOW3G, ZUC, AESNI_MB PMDs (a combination of passed and skipped).

One observation is the test vectors don't appear to match the spec for cipher and auth IV - although this seems to occur for other existing auth_cipher vectors I have noticed.
This is based on the spec I see here:
SNOW3G: https://www.gsma.com/aboutus/wp-content/uploads/2014/12/uea2uia2d1v21.pdf
ZUC 128: https://www.gsma.com/security/wp-content/uploads/2019/05/EEA3_EIA3_specification_v1_8.pdf

Thanks,
Ciara