From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BA13A0C41; Wed, 15 Sep 2021 12:46:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77AB64003F; Wed, 15 Sep 2021 12:46:42 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 827244003C for ; Wed, 15 Sep 2021 12:46:40 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10107"; a="244648141" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="244648141" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 03:46:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="544787132" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 15 Sep 2021 03:46:39 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 03:46:39 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 03:46:38 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 03:46:38 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 03:46:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HwUNgOlfJy/+60pbjHA1pKNh4uAKv9X5vbqGkBAY0ZX5JWl+v/kNPBkpbJ3q7wz3ZSSKD+IhvVi7h4jPGwOeiGo+AEIdYcre2mlTVosJp7nWMXu4O/2r1O51+aT6lMASnqoXkZxbiWtOicSendx5Oi4UyziVymlu9u13HQRi1j4FKcG9U8f+mavWm0Dbi3THLPqT6PwA7eM2qkmuV5/tSD8oHR4UvBOSQ4MgzX5Tme/yrxz9vK/4eS6GlQkbT8cGDTwa8L8Nd7FgxXKRorNbZrg/aZsgtYK29g/782REmtpGvBusTfCoG5XwCQjmS1yhsypKsO3SNx0HQsJkUlX0Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ds7lGhEuRqT9vP7fQvFSCqiPKM1WomfiZyXz8LfgieE=; b=Hnr0W2rwGFd1YPI+R4hjvhSYKKjweRdeqG4Z4pSohhN5ObocWBKD5d0tww1iCfqvzBQBjfVTmzXeRLIcvuyIKVXujpnJlBcv/blMDV3Zhv1I0atqzkUZff37QHTY23J0PDUFHB7nNbRAYJxoMmM1nBTP7ZulA8/OWWHg0X9hbyRJbPNHjAOQJRSPees/YEDW/ip/jfBil0d1QkZDBfw1wmHIqESPxXW3yEB0s2DotcTSVcSaFD4NYLkybZta6V/8Fw0hBY8rQ5E55X10Dtp3lBDDAaNm70UYP757my489WL1X9RRFNVwZyS8RP8ZGYLEExnlKxEortyVWwWvEuVF6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ds7lGhEuRqT9vP7fQvFSCqiPKM1WomfiZyXz8LfgieE=; b=Bsj24JvgUxyd94qAh3ygN8ibcACtXJSTJay6h1RDLygrMcpB7UUGPP7qBi/NmlvYf/lvohWV8ZISRAooWo7SQsSTt9sQLaId6lfHSpHHWnc75QKtggyKPYEOTHOmwTQBSg5A4NqLn0b0OGg7u8I8zkc1EX8ur+0Alj4qX+tLEZ4= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by BL1PR11MB5397.namprd11.prod.outlook.com (2603:10b6:208:308::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 15 Sep 2021 10:46:36 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4523.014; Wed, 15 Sep 2021 10:46:36 +0000 From: "Power, Ciara" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Hunt, David" Thread-Topic: [PATCH 0/3] improvements for telemetry script Thread-Index: AQHXqI1hfnfQg6zu40qze7tcEKaAqauk7HRQ Date: Wed, 15 Sep 2021 10:46:36 +0000 Message-ID: References: <20210913105137.130097-1-bruce.richardson@intel.com> In-Reply-To: <20210913105137.130097-1-bruce.richardson@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9cba7436-e56b-4422-d6b4-08d978361729 x-ms-traffictypediagnostic: BL1PR11MB5397: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wDpioro2hCur2LeeFEwS6u4FICCXU7y6dMzMVVa1VdoDrwsNkZ8p4D51xOv4c0LVhLXl2/7qVwM4iJBtG8T0MtZZXju3rlYI4+70yh5xho3CsTQrKfTYJJLyFSsvxZvvVAl8Oqu983g9Yy8JhLoKlPVV4DUyeddHN0PWZGHRroHsF/w6A5Ytw7gJGv0HRdmUw0kZ8WAw00aueNUNL3BB50Y4PI26KJ1nSbaxjUdfCdmbZiTlwgTr3rbIw+Ixt/i3oeKGzj5r7OKdNw4uhosozGVNzasNNOf/FxoAjrbEFrDmn0Q/2R1uB33e2vzY/H/p0dJ3iAwoG2FLyVRHKKuy5eiWNrH6p4GlOQAUi/+1ysXPW/Ow4hkd8bYL+gg7p1ehsiZBhgVB+1rTpsQmQYXd0EWxuMBywHoDNhR2J1IKMv+hqOwz1cFBTDAG0pNnTsLG87H8hGa+DJJE+tCxidbaDxRLGkXmswdsaxNb+I3sTW9jZWjD52jVCEQ7o8TKj70iZLtw7SZSreJ/AYW9c2UNoIMzUh1F1JA7fuJ8ni/xy4SP6oUdI6XGlOTC02AEpF6LYuqllGsrLtLIwWQORPKCcnCmMVbsH/fm4WdrCnVjU35ZnQVHyr0tS3hBamgy0JuKCcm2qi9tTXJKkyLdM6wWR0gF7bCv+bxpdtjtQP3tmj8jqMB5VWz/a1dP3Y6VtQUbY3GpO1xnofGK9HLTT5UOvTZa6Iz71EogcWuI6kVj9sKSCnH480lc88maoRZOjZVqSClbTw9yfwhDR4TY7TiMjBlLV11bEAQ1NTYpwPLFjhs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(396003)(366004)(376002)(136003)(316002)(66946007)(38070700005)(8936002)(55016002)(9686003)(66476007)(66556008)(64756008)(7696005)(966005)(66446008)(38100700002)(110136005)(122000001)(76116006)(2906002)(33656002)(71200400001)(107886003)(8676002)(6506007)(186003)(83380400001)(5660300002)(4326008)(52536014)(478600001)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XcZpliEpVsGvVUK4Mz9FxuKlcmaq3/khPYflrlvFyj05FTmLoSBqhXrAJhWC?= =?us-ascii?Q?KCSP3uUs+HCM4EobwGxYRGMieaK+i6XRAngXPJqcjh1gj+QuG6BaL1vC1gke?= =?us-ascii?Q?ZbU8yeM6IAdPKB8b7+muWFjK/zYDs8eNhERmU4I8J4ubHqZNqV5Z7cIe+Sgi?= =?us-ascii?Q?9+QKPWUe33YnkdmVPvMoLS5f/Qb30Vk0rGjOnGesS1T83gC8dQ62s4oeH786?= =?us-ascii?Q?Mp+KJN8DTyVx93PEh5iUGRFSku4NcOruuL2LcugDdCNj4F22Nl97NGuRokOC?= =?us-ascii?Q?uKYRVQrrPVLWnLvnSn32wzRXoG6WxS12HPEdFSTQI87s9PGnHLMS1KtQik9y?= =?us-ascii?Q?PSv/qtI0AC8zV5/C79UGguFPE/Dx+2UhPqIuVVySBL67eP9unjqdOASRn2XQ?= =?us-ascii?Q?ugAWX1ImPUB0zHFlhJSMwwCP+3JAcdEFNA3gY9cocc+eimH9BqvbOrZMaoCc?= =?us-ascii?Q?zK6zn4KeFUocVqMwRElxOO2IIrTubaYMivMvi5h1Onn5VE8tzcQeaKEcIXcC?= =?us-ascii?Q?rco5geDxZv717qg096FBclzv7S1yj4/wXzOBE4fPWxGIZ8HhxrHAf4hsL2HM?= =?us-ascii?Q?cslyrDrYJPZKQy/FIxhovvChmWlQXnn2IPvyg+pI9npGB4hcv3mrPMIIRVZg?= =?us-ascii?Q?iac+O3QnZk5Z5PzClaYBwMG1dwYaGmMGv8GzjNU8K9mEAe4WCwyMVRLfyI+4?= =?us-ascii?Q?cim1eLkZ+AYek3BkVMsiBYOOlYEaILbskCvOq3aruj+fbALGc73H/9r5OSpz?= =?us-ascii?Q?giv8QS/8Kd+Bnh4HCfeQvh2ZkLlEMxikLOp3oaRAX8sKvCXL9osio3EXpYcY?= =?us-ascii?Q?so7KKAQYS2bWtWgBCs3eilpjGYvOq+HrPBjaNyCK+eMpaOh8uRp8zXJsUA4d?= =?us-ascii?Q?K67170e17tKo4ISA+COTXItx/OW6s0XBRT0R4vn9VggjJCuCkARHUPW32OFh?= =?us-ascii?Q?C6G9/SHDD07h3RvFTTMR2DiwjRbhMymm1FuwCIasTpVke5Mv82YXKoMcRJXY?= =?us-ascii?Q?dSWhJCddmYyLXfSM4YjrWnC0SROLqnkt5f/Qofw9K7945EeAx3ZchaiKurv2?= =?us-ascii?Q?tk/lP6fuxr0ZXEiRh6QZSXcCSxrGC05vXzdfYiTm30F7dQsWWUub6JuVr9g/?= =?us-ascii?Q?LqWfsijKU9sRSLH/B4o3NizbsLreA9hJnPRqhijDIBF6ha9UYLu/gR11vUFn?= =?us-ascii?Q?fuxibtGFrrrx9q4E5foYFzPFj1Lk1H31J7gYpnJswv/hiaixSMG6EYKTkJ7U?= =?us-ascii?Q?N05aZoXucHQcmeR67Mpe/AxG5Tyj16j6VaNvfW1qMlCXmucsx2A5dEm51deQ?= =?us-ascii?Q?/fT0LUAbyQOd4Q9acWaPo55wtquedITEdqtC7wgwxA/pDk612ZqF7k9ZU5+h?= =?us-ascii?Q?pRV4DPHYzR9k9UZdXMbgRIPfBpfH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cba7436-e56b-4422-d6b4-08d978361729 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2021 10:46:36.0881 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2+2Hve3rcPTrhJz4PIbJhTT80+mJdC15AUHE1WDs7LXFNvMx4djgRUqka+m8vzAaz9EpeDD0HzzkJNHsqpGX8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5397 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 0/3] improvements for telemetry script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, >-----Original Message----- >From: Richardson, Bruce >Sent: Monday 13 September 2021 11:52 >To: dev@dpdk.org >Cc: Power, Ciara ; Hunt, David >; Richardson, Bruce >Subject: [PATCH 0/3] improvements for telemetry script > >Patch 1 fixes errors reported by flake8 in the telemetry python script. >Inspired by the work by Dave Hunt [1] the final two patches look to adjust= the >script so that it works nicer when commands come from an input pipe rather >than from an interactive terminal. > >Without this set: > $ echo "/eal/params" | ./usertools/dpdk-telemetry.py > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > {"version": "DPDK 21.11.0-rc0", "pid": 130033, "max_output_len": 16384} > Connected to application: "dpdk-test" > --> {"/eal/params": ["./build/app/test/dpdk-test", "-c", "F", "--no-huge= "]} > --> Traceback (most recent call last): > File "/home/bruce/dpdk.org/./usertools/dpdk-telemetry.py", line 109, i= n > > handle_socket(os.path.join(rdir, >'dpdk_telemetry.{}'.format(TELEMETRY_VERSION))) > File "/home/bruce/dpdk.org/./usertools/dpdk-telemetry.py", line 78, in >handle_socket > text =3D input('--> ').strip() > EOFError: EOF when reading a line > >With this patchset: > $ echo "/eal/params" | ./usertools/dpdk-telemetry.py > {"/eal/params": ["./build/app/test/dpdk-test", "-c", "F", "--no-huge"]} > > >[1] http://patches.dpdk.org/project/dpdk/patch/20210909155625.24581-1- >david.hunt@intel.com/ > >Bruce Richardson (3): > usertools/dpdk-telemetry: fix flake8 errors > usertools/dpdk_telemetry: fix handling EOF for input pipe > usertools/dpdk-telemetry: silence prompts for input pipes > > usertools/dpdk-telemetry.py | 38 ++++++++++++++++++++++--------------- > 1 file changed, 23 insertions(+), 15 deletions(-) > >-- >2.30.2 For the series, Acked-by: Ciara Power Thanks!