DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Power, Ciara" <ciara.power@intel.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Doherty, Declan" <declan.doherty@intel.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	Anoob Joseph <anoobj@marvell.com>,
	"ruifeng.wang@arm.com" <ruifeng.wang@arm.com>,
	"asomalap@amd.com" <asomalap@amd.com>,
	"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
	"g.singh@nxp.com" <g.singh@nxp.com>,
	"aconole@redhat.com" <aconole@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 5/6] test/crypto: dynamically build blockcipher suite
Date: Fri, 2 Apr 2021 14:34:06 +0000
Message-ID: <MN2PR11MB3821F42BFB6DCA457D4A0456E67A9@MN2PR11MB3821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW2PR18MB2284FB57CD985B51580C0B7FD87C9@MW2PR18MB2284.namprd18.prod.outlook.com>

Hi Akhil,


>-----Original Message-----
>From: Akhil Goyal <gakhil@marvell.com>
>Sent: Wednesday 31 March 2021 15:46
>To: Power, Ciara <ciara.power@intel.com>; dev@dpdk.org
>Cc: Doherty, Declan <declan.doherty@intel.com>; hemant.agrawal@nxp.com;
>Anoob Joseph <anoobj@marvell.com>; ruifeng.wang@arm.com;
>asomalap@amd.com; ajit.khaparde@broadcom.com; g.singh@nxp.com;
>aconole@redhat.com
>Subject: RE: [dpdk-dev] [PATCH 5/6] test/crypto: dynamically build
>blockcipher suite
>
>Hi Ciara,
>
>Nice work. I have below comment on the output of the results.
>
>++ more crypto PMD maintainers.
>
>> In the existing implementation, the blockcipher test cases are being
>> run and reported as one test case per type, even though multiple test
>> cases are hidden in each. For example, "test_AES_chain_all" runs 46 test
>cases.
>> Each blockcipher type should have a testsuite instead.
>>
>> The blockcipher testsuite is dynamically built, depending on the
>> blockcipher type chosen. The testcase struct is modified to allow
>> running a testcase with data, which is used for data required when
>> running each blockcipher testcase.
>>
>> The blockcipher testsuites are added dynamically to parent testsuites
>> as sub-testsuites where needed.
>>
>> Signed-off-by: Ciara Power <ciara.power@intel.com>
>> ---
>When I run the patchset, The output I got is
>+ Sub Testsuites Total :       24
> + Sub Testsuites Skipped :      2
> + Sub Testsuites Passed :      22
> + Sub Testsuites Failed :       0
>
>Is it possible for you to give more details in the end like Number of tests
>passed/failed/skipped/unsupported as well for each of the suite.
>
>The reason is that, people normally check the report in the end.
>For example:
>Crypto General(A/X passed, B/X skipped, C/X failed) //one line for each of the
>suite.
>
>
>Regards,
>Akhil

Yes, that is a good suggestion.
I have added this extra detail in the v2.
https://patchwork.dpdk.org/project/dpdk/list/?series=16085

Thanks!




  reply	other threads:[~2021-04-02 14:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 14:46 Akhil Goyal
2021-04-02 14:34 ` Power, Ciara [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-03-16 14:32 [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework Ciara Power
2021-03-16 14:32 ` [dpdk-dev] [PATCH 5/6] test/crypto: dynamically build blockcipher suite Ciara Power

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB3821F42BFB6DCA457D4A0456E67A9@MN2PR11MB3821.namprd11.prod.outlook.com \
    --to=ciara.power@intel.com \
    --cc=aconole@redhat.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=anoobj@marvell.com \
    --cc=asomalap@amd.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=g.singh@nxp.com \
    --cc=gakhil@marvell.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=ruifeng.wang@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git