From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD9EDA0C45; Tue, 26 Oct 2021 17:11:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDF6A410DD; Tue, 26 Oct 2021 17:11:44 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 0A81A410D5 for ; Tue, 26 Oct 2021 17:11:42 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="316139916" X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="316139916" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 08:11:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="446790817" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 26 Oct 2021 08:11:42 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 08:11:41 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 08:11:41 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 26 Oct 2021 08:11:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IJa7DBalpIMTFuSLN97iQPdzMIFAbPt8mjJEFSW8UEdqFJio3+zR6LNFzsZX3onarnRr/XijtNfsC2ZyYpSercTMFvQZDm5GtAzE/Ma/sxVE78uN2sXbfyP3pDxkMOmzCkygolTF5KhZRSGB8xNB3tu5AkCXYhpQMLXnHPZH4Dgic5XtfTg9lKeBllfwMb5ErRe2TsOymAYZy1ymSdllhmPP8Dn6aMmsSCjnJK7WSIVQMoPRyOuowh56HhL8FUy4HEdOlY4qc1XA7SFP+Tr4mNsD/ahNiDfEAgU/l84t8u1NLuu5uV3H/ox39mBjRoREmBufgMh+smupVh/Den8DGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u3IfU68VB3i2MKvl406MiLwrxAv9LSBunBUJgNmGSOM=; b=PbojdjIq58Ov4asEfIxb71AvH5ETEYE0/X3KnBF50vFiOyLaFD8BkI+MAxZh/RFRlaTOtxmIaXEaV5/iVxxWLc14hm3tyvpAhkvPBnaBZ/dxWH71pWlQEBfjNj8sDEOaceG05NySpg3XZRlJma2Y42egDM4VH2jMzuW9F8dgZjUaNzo0DUuUvf7YqHUok2sLPZXxP656CsEQEM2FINWvcVQ09LL5zK/K++NowGjmjMT7JYwnZGheplJw5gP08KNSl3zFK16YX9bSh66oEupMpxDMrCNyXfGWS9oXlgbR3TQeIVAp94r/lFZJG7CeuHMi50age0OUPPLR9LG9uO1J5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3IfU68VB3i2MKvl406MiLwrxAv9LSBunBUJgNmGSOM=; b=FJktesxLs6EZpQ+sYXXNyHc2ALuikj5vK5KjchSZDEttG8J5IhTZmDHqq9/VdsLRU4Yj4otQjXB1lZ5FUAto56J2ZKs+2Sq9XOfPlc0hFsvYOYr92rFF4TaMETXtZZdweMwaHwzuCVM/EvoK1xz8es+VFFomBKev2DkhjC6VVzk= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by MN2PR11MB4728.namprd11.prod.outlook.com (2603:10b6:208:261::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Tue, 26 Oct 2021 15:11:40 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021 15:11:40 +0000 From: "Power, Ciara" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "gakhil@marvell.com" , "Zhang, Roy Fan" , "Kusztal, ArkadiuszX" , "Ji, Kai" Thread-Topic: [dpdk-dev] [dpdk-dev v4 2/9] common/qat: add gen specific device implementation Thread-Index: AQHXx2bnF42wJy9tXkGnJRctXrbqsKvlZ6hw Date: Tue, 26 Oct 2021 15:11:40 +0000 Message-ID: References: <20211014161137.1405168-1-roy.fan.zhang@intel.com> <20211022170354.13503-1-roy.fan.zhang@intel.com> <20211022170354.13503-3-roy.fan.zhang@intel.com> In-Reply-To: <20211022170354.13503-3-roy.fan.zhang@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 915da3d4-f32f-42fd-f558-08d99892e9ac x-ms-traffictypediagnostic: MN2PR11MB4728: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 53bOYNQ9nrAzLZhfUuDhCYeCbtkB0E9TVks+GMm1RSrwoIqHlVIII5z4SbhA2zuX+8kFTg+lx9rYDjU2fWPvXbDRT5E8Sst9de/8XaUSoI+3nNa+umDWg0Xs5RSJFUQkFT3lJaJgHqq1NEZ73/Z1m2muNB/TbOR1wKVzTZO5jpQY6W18CrvbBHm+whuOvJTJDG8264lDxWx+C4e7CU7n36kOfxhaVrfWXw9FHFbwUbVxg9hl8Nby/ILlsRN+D/KInLl67nxLRelY/UG7n8r09+ZU1QTT3c01a4olfcajYg94Xbdi3kXkyQN9e6R6+5FjDjbmTUYxIDKaERIsTzNnT1I4aro51aVIZN0pMRgO14+U36L8VHNLd+xq3tFtdPYs91kr/bKcVvMj9t+B/GKgtX4R1l4c1Rqcm+UYi4PlRC+9y7S+IRw59ddkjzYkvjTlyOs7LsrHxIwOCkUehMP3XUOxJmhmS/QwCYN07nCUXGdxJDyqQD4fHqCd7sXshvM5rbXkjvsxFhole+Uv2mh7SqKpTlZwmAiMRBSeq6Dezdgx++G0yMV42G5YOyi56Vr55B3SPwwTn1IO47u10sig+6ratd1rRnADBDA+1XgBmnPO7qc0OAGTpqXmAjpcUmukMVX6dpqFbeDsrNie2KMLlxRaONYVd7fZq3iUuBeLzKogtXt9p2MovJ45vLKXYfSn3CgSN2by0z36gISR892Fmg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(122000001)(316002)(110136005)(33656002)(83380400001)(71200400001)(8936002)(55016002)(52536014)(76116006)(5660300002)(8676002)(4326008)(26005)(82960400001)(54906003)(6506007)(7696005)(2906002)(107886003)(66556008)(66946007)(66476007)(508600001)(66446008)(38070700005)(186003)(64756008)(9686003)(38100700002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xNexIT8aBeNGEgWkhv0ht5MdIpvwPYIn/reySrzunBEqq8uCDJiv929QzhRW?= =?us-ascii?Q?opVnWdRxMJJMpzD29PPagjyC0zUWbEOjeSRY0jT2uLpwh4VKnEXXpMlvPF4H?= =?us-ascii?Q?C3EEjEw708cCMApAF7HP39NecVh4QAQVjeFfM7KKtOQd2FppdWGL/QLReOig?= =?us-ascii?Q?n3F1YtbcOCCvN3NXPZVIV4yTx6Cine9nTgn0q4B4APv1VPBkk954fLXk5xyl?= =?us-ascii?Q?1hjLTkd+cl8VCGL0rmDS6h5eJl7aihmdSCVmmq2ZXQd1ZBsQhXQeMt0QgtkW?= =?us-ascii?Q?hN5H3TKV5kJlSLoNCcQXVrMHAnELxh3jGHLLYpu3Dcv0IiHPXHTrodoOPxl9?= =?us-ascii?Q?wWwJ5zdV4QViMwxgF9D4fQkWY2vnZMKkCb3Ljz/6JVg0jGsLtfWoIVtUMDQB?= =?us-ascii?Q?YZcjbkeEwSlONsTbUdHTInZegZkbpZrEJN2sFqo+GVO9w+qzxwlKVxTcNCMP?= =?us-ascii?Q?zfw0ALKccC3rt9d+NvyjsViIBfxdvNs8jB+HdXklj81k7yw2KcND0qBKF/+y?= =?us-ascii?Q?m3FW7IACVF4RtdfdDZDcWja4E2TxPiTmymebo/9Orunnepfpwss5JPUOQZCY?= =?us-ascii?Q?uVk0Rf2/kwfQ5z75h4D6D765xqyi9I7LYrGhk81yM8OpMQXeggd90sa0HcO0?= =?us-ascii?Q?DKSJo7GJZRT7Ez22mfq5eyT6YgHdY8JH0CdNGE72xIoJJlsB84DjG6eqOj4O?= =?us-ascii?Q?h425gBWtox+3uflIQHCZp7RZWV/yN7gEjsV1XJUHncFS4y1Gspp94ZYECHeo?= =?us-ascii?Q?QqJelj7B9KJUpt5VUTcbqFhI18b8Bdh4msOBmt4p51G8L/fj2EWQrU+ViMKN?= =?us-ascii?Q?/DXq4X5VyoB0F3MbC7/LqEOayP1vjGstIUc5hCDzoohRDpHX/0+O86wVHb0u?= =?us-ascii?Q?nWFHqC4AY5kS23Nnty+EaDdNxmY0SHmM9vcAFDOpK9w/eKEcqvJmkcfTfdFl?= =?us-ascii?Q?+76P8SG7P1961pHUh7WwzeB5QEtAe4PtGDXBOKqL837CeMsboeTCR0TmdgWn?= =?us-ascii?Q?As9A0nhsK4wpHhs0jNh9qfeDqE600PFX6cvQ0CtPyVSYoHmiJrZYlUsA6PgI?= =?us-ascii?Q?/J1hr+dnKdYSagf+pByXo60996wKeiwfwgxR+wX0IyVUVQbs8y21YyVvAqUp?= =?us-ascii?Q?HWsnq15Ei9xiYTyh2rKpowtLbF4DLe6TBy7MixnmDPZlppCEo8OwpPHhypa/?= =?us-ascii?Q?0breEb0jC6bXtvMkKnm0mVoLx+oedsse9bFA5rFeK80e/ZIhHVhUDVdZ1nGQ?= =?us-ascii?Q?b/qdPc7S3n/+0EV4F+XC2Sx6S+2CANUo153pyYHdwB0rV7GfMTSu39+rQVRS?= =?us-ascii?Q?UPp1AGB6DT56xpIrh7PyROPj2Y0U3mBBUUztXfbMI25BooA2OXdi0GJHMzSS?= =?us-ascii?Q?8cMh3WCJtfDNxQURM/8GgsHX564KSywtnuoez2gWoCtUh5UjGfzpeu1Jo2U0?= =?us-ascii?Q?2b9UXr/NT6I5noJ+ifcW+kupe9wbtM0F7iORWvb6q5Z0uTX8O0VBLaQg9tmZ?= =?us-ascii?Q?MsphxzMtqAaxZZw4LymLcKD57FUR5MUJuIkyBgKuHRH7n7f9RcFsiCgcKTe2?= =?us-ascii?Q?/X/MoWkuQajYrGZujuHOBHUzp7TVlf31mJ2vzII5lCQaunmVy4NYp/AZQYu7?= =?us-ascii?Q?Ju5G7+4486f88esjFOSUowE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 915da3d4-f32f-42fd-f558-08d99892e9ac X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2021 15:11:40.1599 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EDE8xikQtojFTL5ohTYUrTQLOf971CVE7HVZI8Vpp63YYoK0xwXShERUIEmzhK9sVts/gSET+gMgb5FgSD3YtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4728 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-dev v4 2/9] common/qat: add gen specific device implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fan, >-----Original Message----- >From: dev On Behalf Of Fan Zhang >Sent: Friday 22 October 2021 18:04 >To: dev@dpdk.org >Cc: gakhil@marvell.com; Zhang, Roy Fan ; Kusztal, >ArkadiuszX ; Ji, Kai >Subject: [dpdk-dev] [dpdk-dev v4 2/9] common/qat: add gen specific device >implementation > >This patch replaces the mixed QAT device configuration implementation by >separate files with shared or individual implementation for specific QAT >generation. > >Signed-off-by: Arek Kusztal >Signed-off-by: Fan Zhang >Signed-off-by: Kai Ji >--- >+RTE_INIT(qat_dev_gen_gen1_init) >+{ >+ qat_dev_hw_spec[QAT_GEN1] =3D &qat_dev_hw_spec_gen1; >+ qat_gen_config[QAT_GEN1].dev_gen =3D QAT_GEN1; >+ qat_gen_config[QAT_GEN1].comp_num_im_bufs_required =3D >+ QAT_NUM_INTERM_BUFS_GEN1; >+} This line for setting the comp_num_im_bufs_required field seems to be remov= ed in patch 5, is it needed at all? If it is needed, maybe it is also required for GEN2/3/4 , which aren't bein= g set below. >+RTE_INIT(qat_dev_gen_gen2_init) >+{ >+ qat_dev_hw_spec[QAT_GEN2] =3D &qat_dev_hw_spec_gen2; >+ qat_gen_config[QAT_GEN2].dev_gen =3D QAT_GEN2; } >diff --git a/drivers/common/qat/dev/qat_dev_gen3.c >+RTE_INIT(qat_dev_gen_gen3_init) >+{ >+ qat_dev_hw_spec[QAT_GEN3] =3D &qat_dev_hw_spec_gen3; >+ qat_gen_config[QAT_GEN3].dev_gen =3D QAT_GEN3; } >+RTE_INIT(qat_dev_gen_4_init) >+{ >+ qat_dev_hw_spec[QAT_GEN4] =3D &qat_dev_hw_spec_gen4; >+ qat_gen_config[QAT_GEN4].dev_gen =3D QAT_GEN4; >+ qat_gen_config[QAT_GEN4].pf2vf_dev =3D &qat_pf2vf_gen4; } Thanks, Ciara=20