From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AA58A04E6; Tue, 17 Nov 2020 18:08:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C598C37B1; Tue, 17 Nov 2020 18:08:53 +0100 (CET) Received: from alln-iport-3.cisco.com (alln-iport-3.cisco.com [173.37.142.90]) by dpdk.org (Postfix) with ESMTP id 32FCBF3E for ; Tue, 17 Nov 2020 18:08:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3201; q=dns/txt; s=iport; t=1605632932; x=1606842532; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=C5aZyYPu0hUgYOdGtEZKT2fWfrofCEgPb2xaO99/5/c=; b=b5DChMnGduotobhEv0yimoAcoT0oEY2eCEeBGHm1t88c+Wle0hbdoSlf fSIllHCc+0LhU1kE1C+PEljwvHBsk7HArhKXDHCXAqLtxscgSvSQDZA/j BwCzP94OZwEVw4bMNQT2jCAyRon5gCql5RR9JE8wtsoCWK5X6mFDAw4M8 w=; X-IPAS-Result: =?us-ascii?q?A0BgCgAdArRf/4ENJK1igQmDISkoB3RZLy6IBQONWpkEg?= =?us-ascii?q?lMDVAsBAQENAQEbEgIEAQGESgKCIgIlOBMCAwEBAQMCAwEBAQEFAQEBAgEGB?= =?us-ascii?q?HGFYQyFcgEBAQMBEigGAQE4BAcEAgEIEQQBAR8QMh0IAgQBEggTB4MFglUDD?= =?us-ascii?q?iABo0wCgTyIaHSBNIMEAQEFhQkYghAJgTiCc4pNG4FBP4ERQ4JPPoRABYNDg?= =?us-ascii?q?iy4NwqCbYkRkiqEQ502k1OgVgIEAgQFAg4BAQWBayOBV3AVO4JpCUcXAg2PR?= =?us-ascii?q?AEIgWVeilh0NwIGCgEBAwl8jUwBAQ?= IronPort-PHdr: =?us-ascii?q?9a23=3A534LRxyxUkJiY+XXCy+N+z0EezQntrPoPwUc9p?= =?us-ascii?q?sgjfdUf7+++4j5ZRWDt/RrkFLNG47c7qEMh+nXtvXmXmoNqdaEvWsZeZNBHx?= =?us-ascii?q?kClY0NngMmDcLEbC+zLPPjYyEgWsgXUlhj8iK6N1RYHID1YFiB6nG35CQZTx?= =?us-ascii?q?P4Mwc9L+/pG4nU2sKw0e36+5DabwhSwjSnZrYnJxStpgKXvc4T0oY=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-AV: E=Sophos;i="5.77,485,1596499200"; d="scan'208";a="584861796" Received: from alln-core-9.cisco.com ([173.36.13.129]) by alln-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 17 Nov 2020 17:08:50 +0000 Received: from XCH-ALN-003.cisco.com (xch-aln-003.cisco.com [173.36.7.13]) by alln-core-9.cisco.com (8.15.2/8.15.2) with ESMTPS id 0AHH8oPL007825 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 17 Nov 2020 17:08:50 GMT Received: from xhs-aln-003.cisco.com (173.37.135.120) by XCH-ALN-003.cisco.com (173.36.7.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Nov 2020 11:08:49 -0600 Received: from xhs-rtp-001.cisco.com (64.101.210.228) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Nov 2020 11:08:48 -0600 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 17 Nov 2020 12:08:48 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TlZ4ct9LP74fqIDSkBItaYjg5OkqEB0NdnqrNSpGBm+a5iBN78Bv2Vm00ujJRnZZ8Mvjpf5FHyfAXjk7cj2CcR77qcU1BCRDT+PVp1PAttZTNHXscgyHTdXSqp3QfT9olKZL9fUIfh2ldu1CSoKv/9AHc9/fKPaDdQsUIYYiOSHIeACOVklPNskdLsa31Ff8o966ci4NokyCeKHGYsRg0Qeqx+yPaTkMNinquc4HX7fuTEBPz7eHM/DnD5InNeKD3KQhdf98V1lqIoebuJV7HX1WEmHlI0DS8rzXG5cdfNhvtFGndnV8UIGmKiHhLZsKUkMAYImm+PtEDUm9Qo2BBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mpl2pI2yBHY5PzexIMdcefDj18K/T1x0/kUqNlbLxIg=; b=d0NBbmdhFNCym+noRV5PU9FC1sYdDFhsmxF863AAJWEVLqq2anrHdyMWhd+tI6ni6ZUUH4hGTI+jtfD1tH1QzCwMsp2+R0hGiZdkN1Zk7SEXuCY06hRL1NJnHeT/FXrBv5IfPaMYlPR7R2rbp6hNuHkQU+ick+YUn7Dm/wtDZuPhjToFT/Xj00NqYePm7qrmGnFWVhG1BO/MscQQ9cBwJilCOMkT23u0ldMMxsSJyHcFxoXIBDVHqKUIrtxsZeb53DaLJNZ3InSRgaCPm/jTUkLjqs8g17b1PHngKDgx5s+Gse12EejIrAJ1zP4umUj4W5xIa12QNTd1DBkcirxAKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mpl2pI2yBHY5PzexIMdcefDj18K/T1x0/kUqNlbLxIg=; b=0W6ajr3NDcd9lH+y1+wLTIPivbfc7/W5rZkq0Pt7lunuPXo8zf6/3KiXhfmZc83WQqhnvXw3JPXhkqThgdj/55hHi3iNmzZ0d1IEZtZlXs76JCbPGmXBOHpg52btZpFSHzBwdAsHudoX3kbTFIoQ4WkDkD4v87DDdqUisWzUOZI= Received: from MN2PR11MB3886.namprd11.prod.outlook.com (2603:10b6:208:137::15) by MN2PR11MB3565.namprd11.prod.outlook.com (2603:10b6:208:ea::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Tue, 17 Nov 2020 17:08:47 +0000 Received: from MN2PR11MB3886.namprd11.prod.outlook.com ([fe80::e4ce:8b23:f0cc:ed77]) by MN2PR11MB3886.namprd11.prod.outlook.com ([fe80::e4ce:8b23:f0cc:ed77%7]) with mapi id 15.20.3477.039; Tue, 17 Nov 2020 17:08:47 +0000 From: "David Harton (dharton)" To: Bruce Richardson , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC PATCH] build: allow passing extra config header to build Thread-Index: AQHWuRFov7sv5yvqrkWmmPPQm6RROKnMdQMg Date: Tue, 17 Nov 2020 17:08:47 +0000 Message-ID: References: <20201112163134.1893190-1-bruce.richardson@intel.com> In-Reply-To: <20201112163134.1893190-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=cisco.com; x-originating-ip: [2600:1700:720:b0d0:4d50:92a8:5b0b:ffd6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d15456f0-d15f-4eda-683e-08d88b1b72c7 x-ms-traffictypediagnostic: MN2PR11MB3565: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OyM74O7rRiv3P/mv2o9WDftyRRxHDnQYnOs8OZ2Ezp9eJsg0BczlqTrgkwxQbNrL2ZyeDRWLByUtIRNgt0jbaNyvVI6Cl8ZPOgoX2ZiN7ZaSFEMXwUgo/T33BxSgFBU/z+iiu4391d3roqOAgBx2NtvBxvqv0+1bg2PFwop12NBXQSsgdPhfCh5fGZzJ1Acbk0O8mCcjBkeYxuOyB4iGRToA1LJvgaGSITE5ZNe+aocPwpWtqPLQdVD/2fZ4C6NemdAsaWtZnNyeZGn2yTi/h/bIXttEqqF1UMrvl6VEvmj6PIKy15gpOU6/LPv37jMpagIpyA7U8Q1qZNLagPZyXQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3886.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(376002)(346002)(366004)(136003)(39860400002)(110136005)(33656002)(71200400001)(76116006)(478600001)(66946007)(66476007)(64756008)(66556008)(66446008)(52536014)(6506007)(7696005)(2906002)(86362001)(83380400001)(316002)(53546011)(8936002)(5660300002)(186003)(55016002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 0UEb4lwaFWH8wX9MDmUgic7Duzw0CneaBrmHqSLJHJ+J4Kq+UMe6QuHscX//PAKBI5+alQxRO1gH3fKT6OACl1pExfnvpO39SwONPpCMscRjy/ar5I27in1J5tPxlMr5V9bw5yb4MftHI7sTZ4yQKqsOXV1iDVkM2RAi8MprkOtqRvCgBQTsCVrp1St7osH1z7cop79Z7FUi7GfUQBbDmP6Yzpz4gkCOXRrZQ0DsEghq8wng3pi2mReoQe8nyJgdj/ce3hJyBNTNuTdiwzKh1JiJW1fw9kNSsPjY3rnkbJ6him6lGXvQBACvQQZAjWfIF1AS6PR3feH3VFinEJmRO5+K4jqnGpz1d6RKVkTp+bN+vvBeyO1hAOJaC5iX6IOdz7ck+8zayBfZdAs3WJ8JF3JIDTje2LLFepuG8JPbiaHDKY2SjNflONQZW6koDSIWMKBn3yNjeJwvoP6QfwGg8xyd1Msh/e4AWTqW0pME2qgB47b1eM3jNgWCouV1KkBrFPwSSm8vXDV7moNAUMome2VJbg4XIJduzJ8GDnd/3hgszcmtMmnO10M/I7Ut2sAlKaRlJ14BPbjyxolt7KhoBhowSEBIa6U3J3fAweG6j2y5pbdyKNpRKpFP/2AJNoCFrtES9k1CiWXc6JyNq/FWoAsoJfxbXIEdyhNB8/Bca1pReyMYSQURTb3Gb6WeSZFSIKOC+BuEAnELzc95lKn1uQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d15456f0-d15f-4eda-683e-08d88b1b72c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2020 17:08:47.8104 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fUkTnlAe+HjcU4Qz2ZZFVVfYQy3YSfQ9oeNwxYGIo2QTF6AepuGlSlIVS2SDWFtDehL37ckaaSrP9krm9kfwrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3565 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.36.7.13, xch-aln-003.cisco.com X-Outbound-Node: alln-core-9.cisco.com Subject: Re: [dpdk-dev] [RFC PATCH] build: allow passing extra config header to build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Bruce Richardson > Sent: Thursday, November 12, 2020 11:32 AM > To: dev@dpdk.org > Cc: Bruce Richardson > Subject: [dpdk-dev] [RFC PATCH] build: allow passing extra config header > to build >=20 > To allow per-build override of some settings, without having to change > DPDK source-code files, i.e. rte_config.h, we can add an option to allow > the user to pass in a file containing their own defines for the build. >=20 This is definitely better than what we have now. Even going forward with this as a temp solution would be good while we work= out longer-term strategy would be good. What I believe is missing in the existing code base: - knowing what all the knobs are - ability to tune knobs in a build specific manner (providing per build con= fig) Regards, Dave > Signed-off-by: Bruce Richardson > --- > This is just a quick RFC to show what might be possible and to help keep > the discussion going on how to improve build config in DPDK! > --- > config/meson.build | 10 ++++++++++ > config/rte_config.h | 4 ++++ > meson_options.txt | 2 ++ > 3 files changed, 16 insertions(+) >=20 > diff --git a/config/meson.build b/config/meson.build index > 258b01d06..5c137e4f5 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -14,6 +14,16 @@ foreach env:supported_exec_envs > set_variable('is_' + env, exec_env =3D=3D env) endforeach >=20 > +if get_option('extra_config') !=3D '' > + extra_config =3D files(get_option('extra_config')) > + configure_file(copy: true, > + input: extra_config, > + output: 'rte_build_config_extra.h', > + install_dir: join_paths(get_option('includedir'), > + get_option('include_subdir_arch'))) > + dpdk_conf.set('RTE_BUILD_CONFIG_EXTRA', 1) endif > + > # MS linker requires special treatment. > # TODO: use cc.get_linker_id() with Meson >=3D 0.54 is_ms_linker =3D > is_windows and (cc.get_id() =3D=3D 'clang') diff --git a/config/rte_confi= g.h > b/config/rte_config.h index 25219f04a..2f5ecf999 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -148,4 +148,8 @@ > #define RTE_LIBRTE_PMD_DLB2_SW_CREDIT_QUANTA 32 #define > RTE_PMD_DLB2_DEFAULT_DEPTH_THRESH 256 >=20 > +#ifdef RTE_BUILD_CONFIG_EXTRA > +#include > +#endif > + > #endif /* _RTE_CONFIG_H_ */ > diff --git a/meson_options.txt b/meson_options.txt index > 9bf18ab6b..91319b0e4 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -2,6 +2,8 @@ >=20 > option('armv8_crypto_dir', type: 'string', value: '', > description: 'path to the armv8_crypto library installation > directory') > +option('extra_config', type: 'string', value: '', > + description: 'path to a header file with extra build defines. Will > be > +installed as rte_build_config_extra.h') > option('disable_drivers', type: 'string', value: '', > description: 'Comma-separated list of drivers to explicitly > disable.') option('drivers_install_subdir', type: 'string', value: > 'dpdk/pmds-', > -- > 2.25.1