Re: [dpdk-dev] [PATCH] vdpa/mlx5: improve portability of thread naming

["Xia, Chenbo" <chenbo.xia@intel.com>]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Thursday, April 22, 2021 1:59 AM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Viacheslav Ovsiienko
> <viacheslavo@nvidia.com>
> Subject: [dpdk-dev] [PATCH] vdpa/mlx5: improve portability of thread naming
> 
> The function pthread_setname_np is non-portable,
> so it may be unavailable in old glibc or other systems.
> The function rte_thread_setname is workarounding portability issues.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> index 404e135d5c..ca6e985336 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> @@ -544,7 +544,7 @@ mlx5_vdpa_cqe_event_setup(struct mlx5_vdpa_priv *priv)
>  			goto error;
>  		}
>  		snprintf(name, sizeof(name), "vDPA-mlx5-%d", priv->vid);
> -		ret = pthread_setname_np(priv->timer_tid, name);
> +		ret = rte_thread_setname(priv->timer_tid, name);
>  		if (ret) {
>  			DRV_LOG(ERR, "Failed to set timer thread name.");
>  			return -1;
> --
> 2.31.1

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>