From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB550A0540; Thu, 16 Jul 2020 04:26:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B23471BE95; Thu, 16 Jul 2020 04:26:21 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A7E324C7B for ; Thu, 16 Jul 2020 04:26:19 +0200 (CEST) IronPort-SDR: ZRNaP0coviXKEtyfCLqLbcPxmKpgOf883SBrVAGfiqg57oey9YCjxO3oAQNhN5ZY4ZVG4miA41 AGr8Pu5rBqpg== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="149297119" X-IronPort-AV: E=Sophos;i="5.75,357,1589266800"; d="scan'208";a="149297119" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 19:26:18 -0700 IronPort-SDR: FTO/P3+39BrByGmUq4DR13VMUpw62eM2khZf7LustI3BeTQ3NYHPSHu0gg9OTULDg/5BpIR9Ak 5J/lPTcTmN3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,357,1589266800"; d="scan'208";a="326373888" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 15 Jul 2020 19:26:18 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 15 Jul 2020 19:26:17 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 15 Jul 2020 19:26:17 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jul 2020 19:26:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gBnYrMDFmgDWGPGFLc1154V4tFVJ38N4oBlCLGboJ84yjHInOt9UslcDbwvFgRNqrHAkTdryVMQnJrVTcaOM1Kc7euOneNLiQvcjguXURPbxaEEX+g2VyIZjVatu+en8nVhi7UiEfcOPFAjnXEi59fC+OvR5pHlodFu9Keyciox996PMwaPp3f1C+ci+mTGYoE1HO/h4rjrKwjn8/MVtsGz9RdLclgob1KwUwOH5WA23TbXJifzlSjfy1LKSQsayrKUTN/fOKDghD1OqsBmwM4GOB5eur5WwLnOoDNLdFrf8FKmxc45vUX3XJZO3GIo7mTalBJn3QTGq5S2pntQRXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DjAf1V9gf3apzRndCSCYd4TA7i/2Y2V3fmrMqycdCHA=; b=AmFPIA64fC/rDu4SSLAOY2htJI45FGrdrSlLlPdLl0vi99BmGGSdMXajMex9+RHKBjf103bIqXwbp6xgxWR2oMmiBFLSlSMRtyOByAsqG0XTsDNdl1cFWIdZ1RgJuNZgiFNKrVu0d7UzpBGeZo8vETsMfqGV6nkK47AqejxY5cbuSob2wwRlvMbp1GMc+VOxTnu8YHlEN8xyZ1osU74YFijWfH/5JBHCjf5U3nmwFjZzMoXyHqFzZhhxvP8v0lzfFC425hLH2GMyXgjiMLDAaCkFGAx4RcCiQfw/6PI5AbPqwVHhOM9BO0SnAydkqIirwLjCOJyMnuPgSZQ2Gp78AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DjAf1V9gf3apzRndCSCYd4TA7i/2Y2V3fmrMqycdCHA=; b=sLShq98PWQYwon1UeOCKLKOmcy2mSqw1EI+bin8wQXLazFnwtyHNZi94/y7A92+w2CAu+bcYCiDTgB9lmdOgXQo/tcwFSsJwxYV3BCgoMW5EYjo2Wc9Ucwsh8Y1UNkeCQkoyGmt3wWGcV2f//SPFOKvwbO/c/Y/eJeC8g16S8L8= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB3984.namprd11.prod.outlook.com (2603:10b6:208:153::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Thu, 16 Jul 2020 02:26:13 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::7cde:8326:5010:c47e]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::7cde:8326:5010:c47e%7]) with mapi id 15.20.3174.025; Thu, 16 Jul 2020 02:26:13 +0000 From: "Xia, Chenbo" To: Adrian Moreno , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "Wang, Zhihong" , "Li, Miao" Thread-Topic: [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit Thread-Index: AQHWWswNBVcDdD80Ak6k18gq5pXB46kJegHQ Date: Thu, 16 Jul 2020 02:26:13 +0000 Message-ID: References: <20200715171828.95887-1-amorenoz@redhat.com> <20200715171828.95887-3-amorenoz@redhat.com> In-Reply-To: <20200715171828.95887-3-amorenoz@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a31ea776-e779-4674-506d-08d8292f9c71 x-ms-traffictypediagnostic: MN2PR11MB3984: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CEAOe+Xfaw/xtZgSAvSRszfh99dj+XUbkf0jFG6fzPV+ZmeVAAmCQNh8SEEZQh63vmvXzX/mQ4eAA5mmNJERJpsZii8FyNUD8os9Zx5aMxZrRCNgJWRLA4oD1ShtWzsKLotLhYD6iPUgSmlDCE+t/kEnMz8zNNuWEapsSzw5lH9j9SDQm82ne4QhgsdaL4H/BZwBuL1J9Ybw9TzWdYA0QCz9yRVqtkKxDMATvS08MYkc8QIscPpVP7fafoFsTMyH/Ql1FZwI1ExvMle5BlodkPI9eo8236by9poCDCaEYsfrMLewc2lJCGCL3Ct6LLeHILDmgcXXPu+xfnvNuskYtg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(346002)(136003)(39860400002)(396003)(66446008)(54906003)(110136005)(33656002)(8676002)(478600001)(316002)(2906002)(52536014)(5660300002)(8936002)(86362001)(64756008)(66946007)(66556008)(66476007)(76116006)(186003)(107886003)(55016002)(6506007)(53546011)(83380400001)(26005)(4326008)(7696005)(71200400001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: iUGnkSTexCCULcxV3AzxG6qEJQx+NsU+SSiwKCiVyPCdsFQfnF0eM42Ozzjja7GmGAhi5ptomYDAG3MClt7tOKyc6zxGcvfpRjNAqoADCmvAYNrIdbP+GYNCJJw4Q9LItaN71QgLOu62logj++ndgHQdUUt3QYz+oiMXulROH5pYvR6zTwq4MLYrQKlZQY8/ju61yEYE85zvcN7UGIwBBQVMNEbdVrJ3SYavfW47p6lQV1aXtumB/9jlaHemnCRDO7n10OIHjLTFbNrcW9XojwTyGLjtX4PgNUDbk1XZkspGUbrzk5dkscdGwnIX5YnejF0Vc1eCFa6dvkdvLmX5/XgErw/gyqnV7Nt8gt360vnQT0v5nM6t5BN6gECb9mQPMAMzbf3QSd59ZRO3ssDQJDmOvnzqJ29/sd75TdW+UbGFEaEsKwbX/Oe809bX70xCJE6tdnZn+z6UK+9j/Y7gjcc7X39SAgU/mdyQuAZD69DBxBE6dAPu8heGo3A4dRtZ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4063.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a31ea776-e779-4674-506d-08d8292f9c71 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2020 02:26:13.6949 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VfhlHjbjBp6nvyH63A8GwWwxAjIk8EhZ2Y1Mcpf3mQzF5ztgBZwr4P9nH1V9PSID+YjbcaBYr9fm0q+hyOwM8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3984 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adrian, > -----Original Message----- > From: Adrian Moreno > Sent: Thursday, July 16, 2020 1:18 AM > To: dev@dpdk.org > Cc: maxime.coquelin@redhat.com; Wang, Zhihong ; > amorenoz@redhat.com; Xia, Chenbo > Subject: [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit >=20 > For the sake of completeness, add the definition of the missing status bi= t in > accordance with the virtio spec >=20 > Signed-off-by: Adrian Moreno > --- > drivers/net/virtio/virtio_pci.h | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_= pci.h index > 74ed77e33..ab61e911b 100644 > --- a/drivers/net/virtio/virtio_pci.h > +++ b/drivers/net/virtio/virtio_pci.h > @@ -57,12 +57,13 @@ struct virtnet_ctl; > #define VIRTIO_ID_9P 0x09 >=20 > /* Status byte for guest to report progress. */ > -#define VIRTIO_CONFIG_STATUS_RESET 0x00 > -#define VIRTIO_CONFIG_STATUS_ACK 0x01 > -#define VIRTIO_CONFIG_STATUS_DRIVER 0x02 > -#define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04 -#define > VIRTIO_CONFIG_STATUS_FEATURES_OK 0x08 > -#define VIRTIO_CONFIG_STATUS_FAILED 0x80 > +#define VIRTIO_CONFIG_STATUS_RESET 0x00 > +#define VIRTIO_CONFIG_STATUS_ACK 0x01 > +#define VIRTIO_CONFIG_STATUS_DRIVER 0x02 > +#define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04 > +#define VIRTIO_CONFIG_STATUS_FEATURES_OK 0x08 > +#define VIRTIO_CONFIG_STATUS_DEV_NEED_RESET 0x40 > +#define VIRTIO_CONFIG_STATUS_FAILED 0x80 Do we need to delete ' VIRTIO_CONFIG_STATUS_RESET'? I see vhost lib does no= t have it now. And I read virtio 1.1 spec and find the description of writing= 0 to reset device is deleted. I think virtio 1.1 spec is not very clear about re= set status. Does 'DEV_NEED_RESET' equal old 'RESET'? Thanks! Chenbo=20 >=20 > /* > * Each virtqueue indirect descriptor list must be physically contiguous= . > -- > 2.26.2