DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Ibtisam Tariq <ibtisam.tariq@emumba.com>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	 "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: remove unused short option
Date: Wed, 31 Mar 2021 08:31:04 +0000	[thread overview]
Message-ID: <MN2PR11MB40632E3D2A10CEC3972A14E39C7C9@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210204080542.3812-1-ibtisam.tariq@emumba.com>

> -----Original Message-----
> From: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> Sent: Thursday, February 4, 2021 4:06 PM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Ibtisam Tariq <ibtisam.tariq@emumba.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Subject: [PATCH] examples/vhost_crypto: remove unused short option
> 
> Short option "s" was passed to getopt_long function, while there was
> no condition on this option.
> 
> Fixes: f5188211c7 ("examples/vhost_crypto: add sample application")
> Cc: roy.fan.zhang@intel.com
> 
> Signed-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>
> ---
>  examples/vhost_crypto/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index 29c8f7228..66bde38c0 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -219,7 +219,7 @@ vhost_crypto_parse_args(int argc, char **argv)
> 
>  	argvopt = argv;
> 
> -	while ((opt = getopt_long(argc, argvopt, "s:",
> +	while ((opt = getopt_long(argc, argvopt, "",
>  				  lgopts, &option_index)) != EOF) {
> 
>  		switch (opt) {
> --
> 2.17.1

Fix two things before apply:
 
1. Change Fix commit id to 12 digits.
2. Add cc to stable tag and cc to stable as it needs backport.
 
With above fix, patch applied to next-virtio/main. Thanks!

      parent reply	other threads:[~2021-03-31  8:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  8:05 Ibtisam Tariq
2021-02-04 13:07 ` Zhang, Roy Fan
2021-02-04 13:08 ` Zhang, Roy Fan
2021-03-19  9:18 ` Maxime Coquelin
2021-03-31  8:31 ` Xia, Chenbo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB40632E3D2A10CEC3972A14E39C7C9@MN2PR11MB4063.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=ibtisam.tariq@emumba.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).