From: "Xia, Chenbo" <chenbo.xia@intel.com> To: "Xing, Beilei" <beilei.xing@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net>, "david.marchand@redhat.com" <david.marchand@redhat.com> Cc: "stephen@networkplumber.org" <stephen@networkplumber.org>, "Liang, Cunming" <cunming.liang@intel.com>, "Lu, Xiuchun" <xiuchun.lu@intel.com>, "Li, Miao" <miao.li@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com> Subject: Re: [dpdk-dev] [PATCH 2/9] vfio_user: implement lifecycle related APIs Date: Tue, 5 Jan 2021 09:58:11 +0000 Message-ID: <MN2PR11MB406334BED8A73B793B7B5B019CD10@MN2PR11MB4063.namprd11.prod.outlook.com> (raw) In-Reply-To: <MN2PR11MB38076C6651DF5E20C8E3D1BCF7D10@MN2PR11MB3807.namprd11.prod.outlook.com> Hi Beilei, > -----Original Message----- > From: Xing, Beilei <beilei.xing@intel.com> > Sent: Tuesday, January 5, 2021 4:35 PM > To: Xia, Chenbo <chenbo.xia@intel.com>; dev@dpdk.org; thomas@monjalon.net; > david.marchand@redhat.com > Cc: stephen@networkplumber.org; Liang, Cunming <cunming.liang@intel.com>; Lu, > Xiuchun <xiuchun.lu@intel.com>; Li, Miao <miao.li@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com> > Subject: RE: [dpdk-dev] [PATCH 2/9] vfio_user: implement lifecycle related > APIs > > > > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of Chenbo Xia > > Sent: Friday, December 18, 2020 3:39 PM > > To: dev@dpdk.org; thomas@monjalon.net; david.marchand@redhat.com > > Cc: stephen@networkplumber.org; Liang, Cunming > > <cunming.liang@intel.com>; Lu, Xiuchun <xiuchun.lu@intel.com>; Li, Miao > > <miao.li@intel.com>; Wu, Jingjing <jingjing.wu@intel.com> > > Subject: [dpdk-dev] [PATCH 2/9] vfio_user: implement lifecycle related APIs > > > > This patch implements three lifecycle related APIs for vfio-user server, > which > > are rte_vfio_user_register(), rte_vfio_user_unregister() and > > rte_vfio_user_start(). Socket an device management is implemented along > > with the API introduction. > > > > Signed-off-by: Chenbo Xia <chenbo.xia@intel.com> > > Signed-off-by: Xiuchun Lu <xiuchun.lu@intel.com> > > --- > > lib/librte_vfio_user/meson.build | 3 +- > > lib/librte_vfio_user/rte_vfio_user.h | 51 ++ > > lib/librte_vfio_user/version.map | 6 + > > lib/librte_vfio_user/vfio_user_base.h | 4 + > > lib/librte_vfio_user/vfio_user_server.c | 690 ++++++++++++++++++++++++ > > lib/librte_vfio_user/vfio_user_server.h | 55 ++ > > 6 files changed, 808 insertions(+), 1 deletion(-) create mode 100644 > > lib/librte_vfio_user/rte_vfio_user.h > > create mode 100644 lib/librte_vfio_user/vfio_user_server.c > > create mode 100644 lib/librte_vfio_user/vfio_user_server.h > > > > <...> > > > +static struct vfio_user_server_socket * find_vfio_user_socket(const > > 1. How about vfio_user_find_socket which is consistent with other function > name? Good! Will fix in v2. > 2. According to the coding style, I think it's better to use such format: > static struct vfio_user_server_socket * > vfio_user_find_socket() { > } > And please also check all other functions. OK. Will fix the format and check. Thanks! Chenbo > > > > +char *sock_addr) { > > + uint32_t i; > > + > > + if (sock_addr == NULL) > > + return NULL; > > + > > + for (i = 0; i < vfio_ep_sock.sock_num; i++) { > > + struct vfio_user_server_socket *s = vfio_ep_sock.sock[i]; > > + > > + if (!strcmp(s->sock.sock_addr, sock_addr)) > > + return s; > > + } > > + > > + return NULL; > > +} > > + > > <...> > > > > -- > > 2.17.1
next prev parent reply other threads:[~2021-01-05 9:58 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-18 7:38 [dpdk-dev] [PATCH 0/9] Introduce vfio-user library Chenbo Xia 2020-12-18 7:38 ` [dpdk-dev] [PATCH 1/9] lib: introduce " Chenbo Xia 2020-12-18 17:13 ` Stephen Hemminger 2020-12-19 6:12 ` Xia, Chenbo 2020-12-18 17:17 ` Stephen Hemminger 2020-12-19 6:25 ` Xia, Chenbo 2020-12-18 7:38 ` [dpdk-dev] [PATCH 2/9] vfio_user: implement lifecycle related APIs Chenbo Xia 2021-01-05 8:34 ` Xing, Beilei 2021-01-05 9:58 ` Xia, Chenbo [this message] 2020-12-18 7:38 ` [dpdk-dev] [PATCH 3/9] vfio_user: implement device and region " Chenbo Xia 2021-01-06 5:51 ` Xing, Beilei 2021-01-06 7:50 ` Xia, Chenbo 2020-12-18 7:38 ` [dpdk-dev] [PATCH 4/9] vfio_user: implement DMA table and socket address API Chenbo Xia 2020-12-18 7:38 ` [dpdk-dev] [PATCH 5/9] vfio_user: implement interrupt related APIs Chenbo Xia 2020-12-30 1:04 ` Wu, Jingjing 2020-12-30 2:31 ` Xia, Chenbo 2020-12-18 7:38 ` [dpdk-dev] [PATCH 6/9] vfio_user: add client APIs of device attach/detach Chenbo Xia 2020-12-18 7:38 ` [dpdk-dev] [PATCH 7/9] vfio_user: add client APIs of DMA/IRQ/region Chenbo Xia 2021-01-07 2:41 ` Xing, Beilei 2021-01-07 7:26 ` Xia, Chenbo 2020-12-18 7:38 ` [dpdk-dev] [PATCH 8/9] test/vfio_user: introduce functional test Chenbo Xia 2020-12-18 7:38 ` [dpdk-dev] [PATCH 9/9] doc: add vfio-user library guide Chenbo Xia 2021-01-06 5:07 ` Xing, Beilei 2021-01-06 7:43 ` Xia, Chenbo 2020-12-18 9:37 ` [dpdk-dev] [PATCH 0/9] Introduce vfio-user library David Marchand 2020-12-18 14:07 ` Thanos Makatos 2021-01-14 6:14 ` [dpdk-dev] [PATCH v2 " Chenbo Xia 2021-01-14 6:14 ` [dpdk-dev] [PATCH v2 1/9] lib: introduce " Chenbo Xia 2021-01-14 6:14 ` [dpdk-dev] [PATCH v2 2/9] vfio_user: implement lifecycle related APIs Chenbo Xia 2021-01-14 6:14 ` [dpdk-dev] [PATCH v2 3/9] vfio_user: implement device and region " Chenbo Xia 2021-01-14 18:48 ` David Christensen 2021-01-19 3:22 ` Xia, Chenbo 2021-01-14 6:14 ` [dpdk-dev] [PATCH v2 4/9] vfio_user: implement DMA table and socket address API Chenbo Xia 2021-01-14 6:14 ` [dpdk-dev] [PATCH v2 5/9] vfio_user: implement interrupt related APIs Chenbo Xia 2021-01-14 6:14 ` [dpdk-dev] [PATCH v2 6/9] vfio_user: add client APIs of device attach/detach Chenbo Xia 2021-01-14 6:14 ` [dpdk-dev] [PATCH v2 7/9] vfio_user: add client APIs of DMA/IRQ/region Chenbo Xia 2021-01-14 6:14 ` [dpdk-dev] [PATCH v2 8/9] test/vfio_user: introduce functional test Chenbo Xia 2021-01-14 19:03 ` David Christensen 2021-01-19 3:27 ` Xia, Chenbo 2021-01-19 18:26 ` David Christensen 2021-01-14 6:14 ` [dpdk-dev] [PATCH v2 9/9] doc: add vfio-user library guide Chenbo Xia 2021-01-15 7:58 ` [dpdk-dev] [PATCH v2 0/9] Introduce vfio-user library David Marchand 2021-01-19 3:13 ` Xia, Chenbo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MN2PR11MB406334BED8A73B793B7B5B019CD10@MN2PR11MB4063.namprd11.prod.outlook.com \ --to=chenbo.xia@intel.com \ --cc=beilei.xing@intel.com \ --cc=cunming.liang@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=jingjing.wu@intel.com \ --cc=miao.li@intel.com \ --cc=stephen@networkplumber.org \ --cc=thomas@monjalon.net \ --cc=xiuchun.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git