From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FA29A053A; Mon, 27 Jul 2020 14:52:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DAFE81BFE9; Mon, 27 Jul 2020 14:52:52 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2ACD91BFE0 for ; Mon, 27 Jul 2020 14:52:49 +0200 (CEST) IronPort-SDR: sDTbP+bVFWkrRCqRCG6fVabSYcV8ksHmpen0xd6jn7lJGb69DZ//O+gv/XTIlJsoBAecvw9AsI D0MQ3/MZzQXg== X-IronPort-AV: E=McAfee;i="6000,8403,9694"; a="212529221" X-IronPort-AV: E=Sophos;i="5.75,402,1589266800"; d="scan'208";a="212529221" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2020 05:52:49 -0700 IronPort-SDR: B5ahU9BwvGKVCA0PrbZfUi2cXFiSZANuAIQmCVXo1c2R9uXfy2BpLwcAIXdHD7qoxfBfs/NlLV boyiTrS4wJMA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,402,1589266800"; d="scan'208";a="364110883" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 27 Jul 2020 05:52:48 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 27 Jul 2020 05:52:48 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 27 Jul 2020 05:52:48 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 Jul 2020 05:52:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yy+sqFIg2hCg3uHSJ+DZmCEfBJ6ulrL0Y76moYDfZJwjePCcJyyDs+gKAcRbFqWlFj1wGsGCEAfdNTFMNdvBY7Lgh9By7pIcmTvJ+1kWqz6sZdw4gqCHiC5rCwUftk5d5gGCD/l6zLdGofKe36KF/oRtIRDTwqjLehdDwaUP9I7usdtMt3Fhw+lhemOI08PckSbg7folDmOgMvWK6kqihtcfvapEWRRXfAXwWH9oeZRvU1+oslK6q1DDZTSY/aYY1xMzNKoio1kMVdrGTB9+GhTMaXRputxwxAJ9FWfGgRRVBP/nAiZt6jV7meI3e9gOePvW9hclSspJI7ueeW/a5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3jKnSaCBzmckimV8FRrSKZUZs2pJPzTdrEGXhiB89mI=; b=gCYTAIKYIE3K/o1FCnasMwuKks/JoYomOLlwb7D+V3dfgCO6EIBDOk15Tm3Lkz3zQ2CYi6H2hE8/AvD0+AARhe19eYtxC5RpHUaryUojU84HQ6JDWv/XcCIJ3GXaOxTIp2NxKWRUlm95T9Uj1FVvygXtIIwBROqTdcAIYALoJu6dvy/Xhy0Ta2nrlFijNbZe0mGnlf5+ui5/S/FbcriN/gNIgOKQkbknZb09viFKtE0pRQA7dyhSt6CAaFr4Hv3CxYSzy9Cgb5w+x3jp88ssoWYybcgsXsh9XNJoaE6KGHoh2dQGM5Oel5NtRMO9ZQyvmcD3tYvwZSgOQavPCQYY9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3jKnSaCBzmckimV8FRrSKZUZs2pJPzTdrEGXhiB89mI=; b=sjV5G/edlCUhixhsUbz1VYp3RqN+/wTKimy7gGFCBScacHh5XTKVtARIdgMGpBSO7u7CCMxmLPWKwcX1oK598yOmtaKhVSuRhac1ADws+3JbhsxAnrjEO6xWBsSqm/hX+DEOd22covaoFwtPsYPgzQSkAUYYVZYFzr3fXZ5fg1I= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB3856.namprd11.prod.outlook.com (2603:10b6:208:ef::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Mon, 27 Jul 2020 12:52:45 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::b898:36f5:61cb:42ca]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::b898:36f5:61cb:42ca%7]) with mapi id 15.20.3216.033; Mon, 27 Jul 2020 12:52:45 +0000 From: "Xia, Chenbo" To: "Fu, Patrick" , "dev@dpdk.org" , "maxime.coquelin@redhat.com" Thread-Topic: [PATCH v1] vhost: fix async callback return type define Thread-Index: AQHWYLPvhPq+jL2i6U+fKk8beOpcYakbZ+Ow Date: Mon, 27 Jul 2020 12:52:45 +0000 Message-ID: References: <20200723053906.3616989-1-patrick.fu@intel.com> In-Reply-To: <20200723053906.3616989-1-patrick.fu@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c3387496-3485-4719-f90e-08d8322bf577 x-ms-traffictypediagnostic: MN2PR11MB3856: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zezoOq5AAksQXTxIB6cM8J5Jx6MeJbMK0Ezfhfw00T5UEVoKABUFImzSioUb7s9Pu+slI4ZjBzTMT4ZF+RcPkpBLlG+xNm1xIvBgGRKlFrbFj++0Nx4z40sY9nPAXkHfEmgD4/lGUR8wHRJehIRXsZRttS63ANLF6/7tjWFHZ6xnYEUR6FODA7KRq0lv/KaqZl2b0vO0OcFwQthwJi6HE+HI7iWbPZB8dqc+efz3H6oDuI3hPh8FNSfb0RsW5UHQW5CZakRXkpcXcezzt5OOVYIi8WaEj4aM2LwE+VIlrpjVKOX7iFaNCmS6T5Uys8/myMwJyev6fOPflrZrQlnTnQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(53546011)(55016002)(6506007)(66446008)(66556008)(316002)(64756008)(9686003)(478600001)(76116006)(52536014)(26005)(86362001)(110136005)(7696005)(2906002)(33656002)(66946007)(66476007)(8676002)(71200400001)(186003)(5660300002)(83380400001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Saga67Y+SMEzx1gFLxSqxGtZaiyKOODijn+xwEIJWJI92BHvCICuFKpmX8t4kTVRx9fZLv31O6qWL2o6Qbzq1aIykB6OyyG7TDxGILYHv9Jrh0ZMM/HxTULcGG/OQWnTWAENYmrXiZH4PQQexXLYOD+wWZVgaw7UHnijTzNKJ4DWb57Qi0mLljEkAfZoASTALP1rMYeXXdMLX4xnzPIBRKBVbMmYcA5NxckrjYRlL4sPMYqghvI/lHv+xZm4hiBUs/e8kqEkSQR0MSaSW2NL6qckJzpABziey7kh5N+m5UhkUBf7yzO0IYxFLoQSauR2BjK8I09fXrCDys5Z/IuU0MU+sVvcDqWnGxivmhjKoGVlduUZ0rcdK7Y8w/RlcJuzg7I7fRGRva/TEXckKUen2aYvkK9KTtNmBOZ+dNF0Tx5PaC6K0xRp7zIDJGyRT58Ww4ZnNhHLWVIPfQFHOUW0fRE5YG6tGORkButnshh4nw2yXOOzw6nn8/kcZAJJWLJ4 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4063.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3387496-3485-4719-f90e-08d8322bf577 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2020 12:52:45.4029 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vU/sufzAxyG/0wQSDhLRQIp7c8QItq5FLOKUgduF6PhtjUnvgRPHclhj8prVDQRq9LTYnNlOtgXcbhhiEUVm0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3856 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] vhost: fix async callback return type define X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Fu, Patrick > Sent: Thursday, July 23, 2020 1:39 PM > To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo > > Cc: Fu, Patrick > Subject: [PATCH v1] vhost: fix async callback return type define >=20 > From: Patrick Fu >=20 > The async copy device callbacks are used by async APIs to transfer data a= nd > check completion status. Async APIs return the number of packets successf= ully > processed to the caller applications and no error (negative) value is all= owed for > API return value. Thus, negative return values from async device callback= s don't > have meaningful usage, while adding overhead in checking the return value > validity. This patch change the callback return values from "int" to "uin= t32_t" to > get aligned with async API definition. >=20 > Fixes: 78639d54563a ("vhost: introduce async enqueue registration API") >=20 > Signed-off-by: Patrick Fu > --- > lib/librte_vhost/rte_vhost_async.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/lib/librte_vhost/rte_vhost_async.h > b/lib/librte_vhost/rte_vhost_async.h > index c8ad8dbc7..66d258abe 100644 > --- a/lib/librte_vhost/rte_vhost_async.h > +++ b/lib/librte_vhost/rte_vhost_async.h > @@ -59,9 +59,9 @@ struct rte_vhost_async_channel_ops { > * @param count > * number of elements in the "descs" array > * @return > - * -1 on failure, number of descs processed on success > + * number of descs processed on success > */ > - int (*transfer_data)(int vid, uint16_t queue_id, > + uint32_t (*transfer_data)(int vid, uint16_t queue_id, > struct rte_vhost_async_desc *descs, > struct rte_vhost_async_status *opaque_data, > uint16_t count); > @@ -70,15 +70,15 @@ struct rte_vhost_async_channel_ops { > * @param vid > * id of vhost device to check copy completion > * @param queue_id > - * queue id to check copyp completion > + * queue id to check copy completion > * @param opaque_data > * buffer to receive the opaque data pair from DMA engine > * @param max_packets > * max number of packets could be completed > * @return > - * -1 on failure, number of iov segments completed on success > + * number of iov segments completed on success > */ > - int (*check_completed_copies)(int vid, uint16_t queue_id, > + uint32_t (*check_completed_copies)(int vid, uint16_t queue_id, > struct rte_vhost_async_status *opaque_data, > uint16_t max_packets); > }; > -- > 2.18.4 Reviewed-by: Chenbo Xia