From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E627A053A; Tue, 4 Aug 2020 10:01:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9516F2BB5; Tue, 4 Aug 2020 10:01:04 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C622429D2 for ; Tue, 4 Aug 2020 10:01:02 +0200 (CEST) IronPort-SDR: GgQFueGxD/cmwLKuWlf1g/s+mEgM4XYhL4YObr8TEPejxRhwRoMNn/pZzvwQcrc0HeNmrYg29C cYBB5otHgVQg== X-IronPort-AV: E=McAfee;i="6000,8403,9702"; a="237130143" X-IronPort-AV: E=Sophos;i="5.75,433,1589266800"; d="scan'208";a="237130143" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2020 01:01:01 -0700 IronPort-SDR: +1trluAi6EJ4eDAaLNZq6Ukpk9EjKrU22ubprgDXA42QYwzzqs/YR+em9JJDwXjLNUBpkiMpEQ AHc6kNcPM46g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,433,1589266800"; d="scan'208";a="306259427" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga002.jf.intel.com with ESMTP; 04 Aug 2020 01:01:01 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 4 Aug 2020 01:01:00 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 4 Aug 2020 01:01:00 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.57) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Aug 2020 01:00:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GjXy2cjcmL4j62YxNCs0pnEsrvAVGt6SkYLCsD+p7bn1OJ4nfL4AoWCRJ3FIOX4ZNwyllVG/QAEMCHfX2fhL1N0XKUjWBGhq7GYBFwqv82Xa/icqY7h6avKcOMf1ebXvwTo3fuyGfU1pCreVcIO4tSfGj9voH5SqqoUKe/6q9hsrLDuP+qM35Da21NHlt/RM2eRhhzWHM4yuf7mKMzmBIqHorImRDE/r7xjDCex2jn7zuxCefLGJOQSn6Siqyg/LZXUouGWoZKy6RTi/FoPkGHJI2vMlezWgJhvmdiJbWe1P9n4MWH4ibQmykx6mdMkkhGkknoYhS2Bo+TJs/3w5yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SzuLVQF4rWmODPozLH10INhK44tB52uN/JeqoWmmPJg=; b=QHaKxDlDIi2j1BVeD7j1J++5qaOV+mfTJjJFGvS9LtfRFrzzQBflf7NdiR+UCOQej87qEhcmRmKOWlMCLQPzjSjKyTj2Lw0/RbGbzefZgtH1kVuwu7l5gZo+4yQkKrSDxQvWjUBp43cVcevzfAjZERlEXbqZiOAcspiBIbms5ew1O5f+GUROr3XqNfdGBEZiGf2VXu7C+hqVkEydwLlwCgh3H6vh39LcbR8uRvCg8ihkXY3yTgDiFsYNOxNbKYFzF19h4INBw3vvHYhm7HojhYHOmTrdGYrGKKlmtMOBk+Z+E21ZGS469aHPaydfXwAYX6k692aRPRAggjVgyXSKHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SzuLVQF4rWmODPozLH10INhK44tB52uN/JeqoWmmPJg=; b=y7cFurClGENmx2fMFwh7C8m2YctZUDK3JVMKZATWNr8dIh+A/NiPpMKz/hHj5x3w3EWkkOpzLrSpfBH3bRiltT7JWYW44BjIDQxMk0J/WfvBC8X5ycutQxSEVrtjMmyse3Z6m8L3/m+bww7X6kmBWGvtVc6OvNNm4iN7YvSxDsk= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4015.namprd11.prod.outlook.com (2603:10b6:208:154::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.19; Tue, 4 Aug 2020 08:00:57 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::b898:36f5:61cb:42ca]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::b898:36f5:61cb:42ca%7]) with mapi id 15.20.3239.021; Tue, 4 Aug 2020 08:00:57 +0000 From: "Xia, Chenbo" To: Adrian Moreno , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" Thread-Topic: [PATCH] devtools: ignore PREFER_FALLTHROUGH Thread-Index: AQHWajJaIKOeWEZS80G5O95HYMa18aknlfhw Date: Tue, 4 Aug 2020 08:00:56 +0000 Message-ID: References: <20200804073837.88189-1-amorenoz@redhat.com> In-Reply-To: <20200804073837.88189-1-amorenoz@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5bb2905c-0834-4edf-eb7e-08d8384c84e9 x-ms-traffictypediagnostic: MN2PR11MB4015: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MuKIg/Y+bcsgqDH7Px66XZGu7O4cNPc9d55wo8zpqFUEf+NATiKgYMla6YWQLtCJcVuIx1tr3impUinF3yMvJ4GiuCT4t3yhA4OGtDjJkCX4M3PjKM5cKDL5oqVfs20xqqFtRVnzK30EFhRVGMBsLH/NJNyO24M/b2po/awQ3cbw5ou5Aa3KvthKgAs/8caFh4y7hCLEU3YZVmbbJXXpPr1Fv/ov33/PH9OuEGU/hdn82P/W5b018fSBRmFt1R4JTGdJIc7+DGlAs/tKcVg2BQnlxpckaNywZHC7v8PCR1WcblZNMcCzzo+iIqu77GUgtSJZWCCxv+TIu+ETRE6vcw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(136003)(346002)(376002)(396003)(186003)(53546011)(7696005)(4326008)(71200400001)(316002)(6506007)(8676002)(33656002)(8936002)(478600001)(26005)(55016002)(52536014)(5660300002)(2906002)(86362001)(54906003)(110136005)(66556008)(66446008)(66946007)(76116006)(83380400001)(9686003)(66476007)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: D0zsMCBDf+OQ5nACFmvPf/Bad+wBbkzYCCKUEoVOcsjfXt3YxcX+QLbCNOaJ6qqcTaBkJs2vVvRHTUn/8jW4+qPzd7C7JzEOFsCV4mFTAopADz3Xg1v30ENHvGz4dj1c0XVqflXqz8ZFCnEU6d3y2BlB/Czk/P0uM/gXqLyxuXebvBVhMhxwHxr6kX6+aAIwAOJjYzP/tgeZCmgKdksb5cChdwrJVxAc5Sl66Tm9W3l9W+FXbGJbnMfDPMahnkQopMpyhfqGBA4Zg9LYYqhGzjkD7WztNoDjBRQCI1GQWI3nhpiCzLIrvWQQT+hPUwT7YN54mbqGlzMFwy0//EYr6iUCtiW1J5H6wLQtYFY8vFX5WTlRxkF4Wms25R/iv3oHqkW95vb00wdUbGNJ0WcvuDVmsU+CwNS9i+SEyWhlMgAQq/TuyDZZuk33Bf1aStJou81innfmVOZWscs1KW+IRQs5ch3Pw2hW6fVaROcQzGa6PdZej4qjyoL3me8E0ch8ppexVS5S1wXXuVUFpzWdcvg81mwhKAUPiu4RDPBdjzOEMWg5/0cdhk+u7uEKndJPYJSFpUY0r5P5R1tp8RSFOCXq6Uvat1PlLqWi5LN58y/cyyYkz0hWdgb0YaOxaAb+Drwwwrc0x/oQ9OiyOtDHlA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4063.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bb2905c-0834-4edf-eb7e-08d8384c84e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2020 08:00:57.0158 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mLZ2ZabVzqJ/CtPTadUE9LvBJBblGjsBnP5V1NJ3MZW54CXUY7zyURRtIw1/K2X2rBya4SuGvXPQthv9NypWMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4015 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Adrian Moreno > Sent: Tuesday, August 4, 2020 3:39 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Xia, Chenbo ; > david.marchand@redhat.com; Adrian Moreno > Subject: [PATCH] devtools: ignore PREFER_FALLTHROUGH >=20 > The PREFER_FALLTHROUGH check warns if a passthrough comment is found > because, in the kernel, the special macro "fallthrough" is prefered. >=20 > Since that keyword is not defined in DPDK, ignore the warning. >=20 > Ignoring this check does not affect the MISSING_BREAK check that will war= n if a > switch case/default is not preceded by break or a fallthrough comment. >=20 > Signed-off-by: Adrian Moreno > --- > devtools/checkpatches.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index > acf921ae0..4283ca82b 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -33,7 +33,7 @@ > VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ > SPLIT_STRING,LONG_LINE_STRING,C99_COMMENT_TOLERANCE,\ >=20 > LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_ > STYLE,\ > -NEW_TYPEDEFS,COMPARISON_TO_NULL" > +NEW_TYPEDEFS,COMPARISON_TO_NULL,PREFER_FALLTHROUGH" > options=3D"$options $DPDK_CHECKPATCH_OPTIONS" >=20 > print_usage () { > -- > 2.26.2 Acked-by: Chenbo Xia