DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Stokes, Ian" <ian.stokes@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/4] net/vhost: remove dequeue zero-copy support
Date: Wed, 23 Sep 2020 05:41:39 +0000
Message-ID: <MN2PR11MB40635E5C666113B7FD7B1C1F9C380@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200915133558.210639-2-maxime.coquelin@redhat.com>

Hi Maxime,

You left a helper string here 😊
(http://code.dpdk.org/dpdk/v20.08/source/drivers/net/vhost/rte_eth_vhost.c#L1677)

Thanks!
Chenbo

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, September 15, 2020 9:36 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Stokes, Ian
> <ian.stokes@intel.com>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH 1/4] net/vhost: remove dequeue zero-copy support
> 
> The dequeue zero-copy feature from the Vhost library is
> being removed in this release, this patch remove its support
> in the Vhost PMD.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  drivers/net/vhost/rte_eth_vhost.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/drivers/net/vhost/rte_eth_vhost.c
> b/drivers/net/vhost/rte_eth_vhost.c
> index e55278af69..b8f0072361 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -29,7 +29,6 @@ enum {VIRTIO_RXQ, VIRTIO_TXQ, VIRTIO_QNUM};
>  #define ETH_VHOST_IFACE_ARG		"iface"
>  #define ETH_VHOST_QUEUES_ARG		"queues"
>  #define ETH_VHOST_CLIENT_ARG		"client"
> -#define ETH_VHOST_DEQUEUE_ZERO_COPY	"dequeue-zero-copy"
>  #define ETH_VHOST_IOMMU_SUPPORT		"iommu-support"
>  #define ETH_VHOST_POSTCOPY_SUPPORT	"postcopy-support"
>  #define ETH_VHOST_VIRTIO_NET_F_HOST_TSO "tso"
> @@ -41,7 +40,6 @@ static const char *valid_arguments[] = {
>  	ETH_VHOST_IFACE_ARG,
>  	ETH_VHOST_QUEUES_ARG,
>  	ETH_VHOST_CLIENT_ARG,
> -	ETH_VHOST_DEQUEUE_ZERO_COPY,
>  	ETH_VHOST_IOMMU_SUPPORT,
>  	ETH_VHOST_POSTCOPY_SUPPORT,
>  	ETH_VHOST_VIRTIO_NET_F_HOST_TSO,
> @@ -1501,7 +1499,6 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
>  	uint64_t flags = 0;
>  	uint64_t disable_flags = 0;
>  	int client_mode = 0;
> -	int dequeue_zero_copy = 0;
>  	int iommu_support = 0;
>  	int postcopy_support = 0;
>  	int tso = 0;
> @@ -1561,16 +1558,6 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)
>  			flags |= RTE_VHOST_USER_CLIENT;
>  	}
> 
> -	if (rte_kvargs_count(kvlist, ETH_VHOST_DEQUEUE_ZERO_COPY) == 1) {
> -		ret = rte_kvargs_process(kvlist, ETH_VHOST_DEQUEUE_ZERO_COPY,
> -					 &open_int, &dequeue_zero_copy);
> -		if (ret < 0)
> -			goto out_free;
> -
> -		if (dequeue_zero_copy)
> -			flags |= RTE_VHOST_USER_DEQUEUE_ZERO_COPY;
> -	}
> -
>  	if (rte_kvargs_count(kvlist, ETH_VHOST_IOMMU_SUPPORT) == 1) {
>  		ret = rte_kvargs_process(kvlist, ETH_VHOST_IOMMU_SUPPORT,
>  					 &open_int, &iommu_support);
> --
> 2.26.2


  reply	other threads:[~2020-09-23  5:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 13:35 [dpdk-dev] [PATCH 0/4] pick Maxime Coquelin
2020-09-15 13:35 ` [dpdk-dev] [PATCH 1/4] net/vhost: remove dequeue zero-copy support Maxime Coquelin
2020-09-23  5:41   ` Xia, Chenbo [this message]
2020-09-15 13:35 ` [dpdk-dev] [PATCH 2/4] examples/vhost_crypto: use vhost async-copy flag Maxime Coquelin
2020-09-23  5:43   ` Xia, Chenbo
2020-09-15 13:35 ` [dpdk-dev] [PATCH 3/4] examples/vhost: remove dequeue zero-copy support Maxime Coquelin
2020-09-23  5:43   ` Xia, Chenbo
2020-09-15 13:35 ` [dpdk-dev] [PATCH 4/4] vhost: " Maxime Coquelin
2020-09-23  5:44   ` Xia, Chenbo
2020-09-15 13:41 ` [dpdk-dev] [PATCH 0/4] vhost: remove dequeue zero-copy support (was: pick) Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB40635E5C666113B7FD7B1C1F9C380@MN2PR11MB4063.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=ian.stokes@intel.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git