From: "Xia, Chenbo" <chenbo.xia@intel.com> To: Adrian Moreno <amorenoz@redhat.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "Wang, Zhihong" <zhihong.wang@intel.com> Subject: Re: [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user Date: Thu, 16 Jul 2020 03:31:04 +0000 Message-ID: <MN2PR11MB40636B5A2A2B136B8E01EAF89C7F0@MN2PR11MB4063.namprd11.prod.outlook.com> (raw) In-Reply-To: <20200715171828.95887-5-amorenoz@redhat.com> Hi Adrian, > -----Original Message----- > From: Adrian Moreno <amorenoz@redhat.com> > Sent: Thursday, July 16, 2020 1:18 AM > To: dev@dpdk.org > Cc: maxime.coquelin@redhat.com; Wang, Zhihong <zhihong.wang@intel.com>; > amorenoz@redhat.com; Xia, Chenbo <chenbo.xia@intel.com> > Subject: [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user > > This patch adds support for VHOST_USER_GET_STATUS request. > > Only vhost-user backed is supported for now > > Signed-off-by: Adrian Moreno <amorenoz@redhat.com> > --- > drivers/net/virtio/virtio_user/vhost_user.c | 2 + > .../net/virtio/virtio_user/virtio_user_dev.c | 39 > +++++++++++++++++++ .../net/virtio/virtio_user/virtio_user_dev.h | 1 + > drivers/net/virtio/virtio_user_ethdev.c | 2 + > 4 files changed, 44 insertions(+) > > diff --git a/drivers/net/virtio/virtio_user/vhost_user.c > b/drivers/net/virtio/virtio_user/vhost_user.c > index 2332e01d1..43c630e47 100644 > --- a/drivers/net/virtio/virtio_user/vhost_user.c > +++ b/drivers/net/virtio/virtio_user/vhost_user.c > @@ -279,6 +279,7 @@ vhost_user_sock(struct virtio_user_dev *dev, > switch (req) { > case VHOST_USER_GET_FEATURES: > case VHOST_USER_GET_PROTOCOL_FEATURES: > + case VHOST_USER_GET_STATUS: > need_reply = 1; > break; > > @@ -373,6 +374,7 @@ vhost_user_sock(struct virtio_user_dev *dev, > > switch (req) { > case VHOST_USER_GET_FEATURES: > + case VHOST_USER_GET_STATUS: > case VHOST_USER_GET_PROTOCOL_FEATURES: > if (msg.size != sizeof(m.payload.u64)) { > PMD_DRV_LOG(ERR, "Received bad msg size"); > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c > b/drivers/net/virtio/virtio_user/virtio_user_dev.c > index 2c400a448..613caef56 100644 > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c > @@ -804,3 +804,42 @@ virtio_user_send_status_update(struct virtio_user_dev > *dev, uint8_t status) > > return 0; > } > + > +int > +virtio_user_update_status(struct virtio_user_dev *dev) { > + uint64_t ret; > + > + /* Vhost-user only for now */ > + if (!is_vhost_user_by_type(dev->path)) > + return 0; > + > + if (!(dev->protocol_features & (1UL << > VHOST_USER_PROTOCOL_F_STATUS))) > + return 0; > + > + if (dev->ops->send_request(dev, VHOST_USER_GET_STATUS, &ret) < 0) { > + PMD_INIT_LOG(ERR, "GET_STATUS failed: %s", strerror(errno)); > + return -1; > + } > + if (ret > UINT8_MAX) { > + PMD_INIT_LOG(ERR, "Invalid VHOST_USER_GET_STATUS > response 0x%" PRIx64 "\n", ret); There's a coding style issue here: CHECK:CAMELCASE: Avoid CamelCase: <PRIx64> Could you fix this? Btw, in case you don't know, there's a script in dpdk for check these issues: devtools/checkpatches.sh. 😊 Thanks! Chenbo > + return -1; > + } > + > + dev->status = ret; > + PMD_INIT_LOG(DEBUG, "Updated Device Status(0x%08x):\n" > + "\t-ACKNOWLEDGE: %u\n" > + "\t-DRIVER: %u\n" > + "\t-DRIVER_OK: %u\n" > + "\t-FEATURES_OK: %u\n" > + "\t-DEVICE_NEED_RESET: %u\n" > + "\t-FAILED: %u\n", > + dev->status, > + !!(dev->status & VIRTIO_CONFIG_STATUS_ACK), > + !!(dev->status & VIRTIO_CONFIG_STATUS_DRIVER), > + !!(dev->status & VIRTIO_CONFIG_STATUS_DRIVER_OK), > + !!(dev->status & > VIRTIO_CONFIG_STATUS_FEATURES_OK), > + !!(dev->status & > VIRTIO_CONFIG_STATUS_DEV_NEED_RESET), > + !!(dev->status & VIRTIO_CONFIG_STATUS_FAILED)); > + return 0; > +} > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h > b/drivers/net/virtio/virtio_user/virtio_user_dev.h > index a76d7cfaf..1a045af6f 100644 > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h > @@ -75,4 +75,5 @@ void virtio_user_handle_cq_packed(struct virtio_user_dev > *dev, > uint16_t queue_idx); > uint8_t virtio_user_handle_mq(struct virtio_user_dev *dev, uint16_t q_pairs); > int virtio_user_send_status_update(struct virtio_user_dev *dev, uint8_t status); > +int virtio_user_update_status(struct virtio_user_dev *dev); > #endif > diff --git a/drivers/net/virtio/virtio_user_ethdev.c > b/drivers/net/virtio/virtio_user_ethdev.c > index e52f11341..40330deed 100644 > --- a/drivers/net/virtio/virtio_user_ethdev.c > +++ b/drivers/net/virtio/virtio_user_ethdev.c > @@ -281,6 +281,8 @@ virtio_user_get_status(struct virtio_hw *hw) { > struct virtio_user_dev *dev = virtio_user_get_dev(hw); > > + virtio_user_update_status(dev); > + > return dev->status; > } > > -- > 2.26.2
next prev parent reply other threads:[~2020-07-16 3:31 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-15 17:18 [dpdk-dev] [PATCH 0/5] Add support for GET/SET_STATUS on virtio-user pmd Adrian Moreno 2020-07-15 17:18 ` [dpdk-dev] [PATCH 1/5] net/virtio: split virtio-net and virtio status Adrian Moreno 2020-07-15 17:18 ` [dpdk-dev] [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit Adrian Moreno 2020-07-16 2:26 ` Xia, Chenbo 2020-07-16 7:34 ` Adrian Moreno 2020-07-16 8:14 ` Xia, Chenbo 2020-07-15 17:18 ` [dpdk-dev] [PATCH 3/5] net/virtio: add VIRTIO_SET_STATUS support to Virtio-user Adrian Moreno 2020-07-16 3:15 ` Xia, Chenbo 2020-07-16 7:43 ` Adrian Moreno 2020-07-16 8:58 ` Xia, Chenbo 2020-07-16 9:51 ` Adrian Moreno 2020-07-16 11:18 ` Xia, Chenbo 2020-07-15 17:18 ` [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user Adrian Moreno 2020-07-16 3:31 ` Xia, Chenbo [this message] 2020-07-16 7:53 ` Adrian Moreno 2020-07-16 8:18 ` David Marchand 2020-07-16 8:28 ` Adrian Moreno 2020-07-15 17:18 ` [dpdk-dev] [PATCH 5/5] net/virtio: enable feature checking on virtio-user Adrian Moreno
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MN2PR11MB40636B5A2A2B136B8E01EAF89C7F0@MN2PR11MB4063.namprd11.prod.outlook.com \ --to=chenbo.xia@intel.com \ --cc=amorenoz@redhat.com \ --cc=dev@dpdk.org \ --cc=maxime.coquelin@redhat.com \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git