DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	Gaoxiang Liu <gaoxiangliu0@163.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"liugaoxiang@huawei.com" <liugaoxiang@huawei.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Thomas Monjalon" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection
Date: Thu, 16 Sep 2021 12:37:41 +0000	[thread overview]
Message-ID: <MN2PR11MB406394B2F33992FB599C071E9CDC9@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <f814ae6a-4c7c-2579-72fd-42291bd5e6ad@redhat.com>

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Thursday, September 16, 2021 8:33 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Gaoxiang Liu
> <gaoxiangliu0@163.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; liugaoxiang@huawei.com; stable@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of socket path on
> adding connection
> 
> 
> 
> On 9/16/21 14:28, Ferruh Yigit wrote:
> > On 9/14/2021 12:30 PM, Maxime Coquelin wrote:
> >>
> >>
> >> On 9/7/21 2:51 AM, Gaoxiang Liu wrote:
> >>> Add log print of socket path in vhost_user_add_connection.
> >>> It's useful when adding a mass of socket connections,
> >>> because the information of every connection is clearer.
> >>>
> >>> Fixes: 8f972312b8f4 ("vhost: support vhost-user")
> >>> Cc: stable@dpdk.org
> >>>
> >>> Signed-off-by: Gaoxiang Liu <gaoxiangliu0@163.com>
> >>> ---
> >>>   lib/vhost/socket.c | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>
> >>
> >> Applied to dpdk-next-virtio/main.
> >>
> >
> >
> > Hi Gaoxiang,
> >
> > I can see you are in the git history as:
> > "Gaoxiang Liu <liugaoxiang@huawei.com>"
> >
> > Since we are trying to keep unique identity in the git history, I will use
> the
> > one in the git history. Please let us know if that is problem.
> 
> I fixed up the Author field in my pull request to match the SoB.
> Did I miss something?

History is Gaoxiang uses @163 email to send patches but signed-off with @huawei email,
So I told him to align and Maxime to fix when applying. Maybe it's my bad about not
being clear about which to use because it happens several times Gaoxiang uses two emails.

I notice people from Huawei sometimes use two emails for author and SOB tag.
So I have the same question :)

/Chenbo

> 
> Thanks,
> Maxime
> 
> > And is there any specific reason to use two different emails?
> 
> 
> > Thanks,
> > ferruh
> >


  reply	other threads:[~2021-09-16 12:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-04 14:28 [dpdk-dev] [PATCH] " Gaoxiang Liu
2021-09-06  5:35 ` Xia, Chenbo
2021-09-07  0:47   ` Gaoxiang Liu
2021-09-07  0:51 ` [dpdk-dev] [PATCH v2] " Gaoxiang Liu
2021-09-07  1:35   ` Xia, Chenbo
2021-09-14 11:30   ` Maxime Coquelin
2021-09-16 12:28     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-09-16 12:33       ` Maxime Coquelin
2021-09-16 12:37         ` Xia, Chenbo [this message]
2021-09-16 12:57           ` Ferruh Yigit
2021-09-16 13:16             ` Xia, Chenbo
2021-09-16 13:36               ` Gaoxiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB406394B2F33992FB599C071E9CDC9@MN2PR11MB4063.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gaoxiangliu0@163.com \
    --cc=liugaoxiang@huawei.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).