Re: [dpdk-dev] [PATCH] net/virtio: improve logs in Vhost-vDPA DMA mapping

["Xia, Chenbo" <chenbo.xia@intel.com>]

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Wednesday, November 18, 2020 4:08 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; amorenoz@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH] net/virtio: improve logs in Vhost-vDPA DMA mapping
> 
> This patch adds debug logs in vhost_vdpa_dma_map() and
> vhost_vdpa_dma_unmap() to ease debugging.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  drivers/net/virtio/virtio_user/vhost_vdpa.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/virtio/virtio_user/vhost_vdpa.c
> b/drivers/net/virtio/virtio_user/vhost_vdpa.c
> index c7b9349fc8..528ff60f29 100644
> --- a/drivers/net/virtio/virtio_user/vhost_vdpa.c
> +++ b/drivers/net/virtio/virtio_user/vhost_vdpa.c
> @@ -93,6 +93,9 @@ vhost_vdpa_dma_map(struct virtio_user_dev *dev, void *addr,
>  	msg.iotlb.size = len;
>  	msg.iotlb.perm = VHOST_ACCESS_RW;
> 
> +	PMD_DRV_LOG(DEBUG, "%s: iova: 0x%" PRIx64 ", addr: %p, len: 0x%" PRIx64,
> +			__func__, iova, addr, len);

Use PRIx64 to print size_t (len in this case)will cause compile errors in i686.
Should we use %zx ?

> +
>  	if (write(dev->vhostfd, &msg, sizeof(msg)) != sizeof(msg)) {
>  		PMD_DRV_LOG(ERR, "Failed to send IOTLB update (%s)",
>  				strerror(errno));
> @@ -113,6 +116,9 @@ vhost_vdpa_dma_unmap(struct virtio_user_dev *dev,
> __rte_unused void *addr,
>  	msg.iotlb.iova = iova;
>  	msg.iotlb.size = len;
> 
> +	PMD_DRV_LOG(DEBUG, "%s: iova: 0x%" PRIx64 ", len: 0x%" PRIx64,
> +			__func__, iova, len);
> +

Ditto.

Thanks!
Chenbo

>  	if (write(dev->vhostfd, &msg, sizeof(msg)) != sizeof(msg)) {
>  		PMD_DRV_LOG(ERR, "Failed to send IOTLB invalidate (%s)",
>  				strerror(errno));
> --
> 2.26.2