From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF149A04A5; Wed, 17 Jun 2020 09:33:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD6931252; Wed, 17 Jun 2020 09:33:09 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 893681150 for ; Wed, 17 Jun 2020 09:33:07 +0200 (CEST) IronPort-SDR: OSVZDgL485i/RD9XNwKVHN7qosTRGNqFu+Ct00t6GmGDd+Y6feAtyIv70S26jYIlQn9WrJ7DJK bk29TuwjVN+g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 00:33:06 -0700 IronPort-SDR: A/iT6uNmFssJa3UGLD/xceDUhPy9aJNuMNI+huAVByRtXPXfbbC/qjMrCVaEEa1WXjjKrGXDKH /Z6Rk6WET7/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,521,1583222400"; d="scan'208";a="309392967" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga002.fm.intel.com with ESMTP; 17 Jun 2020 00:33:06 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 00:33:06 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 00:33:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UNX7WLoJa4XG6LNDLBBaql+yttfS6cbSbLDd2fjHvtnnAu2ttek7/T9Bg0XYilmtFmHhoW86SD33E2mCXa4uPvGavGig0TkTRZ5TbrjFLEqttCIsy4oIFizj4KGpKLoK8FO+kKowElIXIfUXARduNlMgX4EtyHJBynbgM3U4GpC8uWtET2GEdqkrMYZk9Ytw7rKmLcRRycmBrLnvav4w1BTZgG3Z2uNK/8NRsSFHirc0PoHQzrkS2nlzo1hHOTdppZgzlrQs4jZ0vEYYg1T5ZTcZqmyV9M13ptEAjSuqws3y08o5dDAODlJhmTyzMZSYaSeRWJuNvBCAzTDcKBgekg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPtgd5yQFLse2LTj92EDOxNKr1+jzzx2CTi+nqGd66s=; b=ATahyccpGR3uFVGIjYYnAYzMZvcnqEyU/c52PW88C4/mY7Opvyu9djjUvASD0z5QMLKzFPeK0N9DCpps7n/HQj6VCiSvdF+5lp4ic8x/R0eWncR9/hZSiPaCc7ys25J4ryTHctjYBEvaf6VT+HkDhQLmIWUxrIgZBT1zlsh2r71whbnQs7fNijJ0PzdxUnp5YINTtDL93k0B+73dcxdMG/4Kjrpwr+Tjg+ISJILtyIjEb+6dL7M9LaUQueEZS5dsPzvUYNuG3NAnvZRi4/Ccfx5aAdwF7VvyT1JoVCd1jIVkzd++uLBlnvOTJdzyicZr7w39i7v3rH90bSJjVPDqIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPtgd5yQFLse2LTj92EDOxNKr1+jzzx2CTi+nqGd66s=; b=gdDjKWGlNdtfFMEOgodvvZvXHKbKe2YsbylL4HofOge0/TBFVdR6z92qleJ3QFk1byyMhRMFl5p7FDQjRDt7+TqF27pai4wfqjnIMVvlZwEmj4wZR9C/Te0LxbaxF2G3j/yyIN+ol/SapWDxYh9pwI2+EWMS7KAMDYXNeo7QfAo= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4696.namprd11.prod.outlook.com (2603:10b6:208:26d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Wed, 17 Jun 2020 07:33:04 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::7cde:8326:5010:c47e]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::7cde:8326:5010:c47e%7]) with mapi id 15.20.3109.021; Wed, 17 Jun 2020 07:33:04 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "Ye, Xiaolong" , "amorenoz@redhat.com" , "david.marchand@redhat.com" , "thomas@monjalon.net" Thread-Topic: [dpdk-dev] [PATCH v2] vhost: enable reply-ack systematically Thread-Index: AQHWNM8WRm8FNpkP302WnSPBscCMPajch+sw Date: Wed, 17 Jun 2020 07:33:03 +0000 Message-ID: References: <20200528090347.441445-1-maxime.coquelin@redhat.com> In-Reply-To: <20200528090347.441445-1-maxime.coquelin@redhat.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 54f5f18c-4b66-4f95-da84-08d81290abd1 x-ms-traffictypediagnostic: MN2PR11MB4696: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2201; x-forefront-prvs: 04371797A5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UKkntVXbjX4doX/uP4fSQXZc+al9RrxzVfqSt0EyCUPcLco/C2RSUCx/Jqr1Lanqv17v/v4/RsI9gCh0TCvKlWHJ3zedirpQWEaHS6p9iS9yhOra0p1OnpTVT+lARd2KHJcI1y+nls+wnXhCdl1rFQDvIZl9BsDus1nY+Rek4NGqp8m3753J1grWpTdor73pX52eNqyvzPKhlqT78d2k0WbRAR7+/gmOUT6vVFBeNixXQCodEUN8JjCyz9V5gPhHdTzno89hTXkbaht0tabZ/Jc6a3LwGSfArhglsYvEBJccXfwCZVurBnG0lAPgfVq5sSDKGf2/kJqH9DToaGm7mA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(8676002)(71200400001)(2906002)(33656002)(55016002)(186003)(26005)(8936002)(5660300002)(110136005)(478600001)(9686003)(83380400001)(7696005)(76116006)(52536014)(316002)(86362001)(66446008)(6506007)(66476007)(66556008)(64756008)(66946007)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Hk+UF7/P6pXYvUITUtl2S2kOk+2+v4k2SowYTtAuJIgWZ3n8DdfJ2XIhROrS83N0yZyQGoD33h0ON9eKTSZPw2lY7068+CnrPaxCtMchO+ArQFD8Ic3lnzsLrFftBo3t5+ahSyZQHOIM+bWwdrcAWuv4CiTuUAo4I6OETGZAxNczxR5sGKB66PRBhh9paAq1UELEC1Jav/fLTSujn/oUYflTcv+e8A9xv3gx7IY1e9/Kc+gvC+YRTHWeMhpMFNOUdEih+US3B/zUlqbrwuW/Zz1i8sQt61qpYEML3avXr4RS4JB6WU5ti/mI3+bc2oyOErnFIswkKz+DIXE9gKq52J9gX+X/vYCJ2la99CbCrwXCRax1ab31y4q4slqXhrLS4IK4Kbam+1X6ElFlwYCP/643KO6hR+mZuVPgoXh8W6HQBv8ZKRiAyce4NCr7CXU3SXgx6MNtssc4aT+HLDH1E/1fiufNf/HPS+BiWfH9rdwE39I3xqNEZ8+21dtoyp5J Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 54f5f18c-4b66-4f95-da84-08d81290abd1 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2020 07:33:03.8703 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DgyHThmh8zNB9I5jkOcIEITEczVnVrztt/+xkYe64hWK4xSnpJbCaIhayhAN+ywSWFbTPq/dBhJl6WqF7KkbIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4696 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] vhost: enable reply-ack systematically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Maxime Coquelin > Sent: Thursday, May 28, 2020 5:04 PM > To: dev@dpdk.org; Ye, Xiaolong ; > amorenoz@redhat.com; david.marchand@redhat.com; thomas@monjalon.net > Cc: Maxime Coquelin > Subject: [dpdk-dev] [PATCH v2] vhost: enable reply-ack systematically >=20 > As announced during v20.05 release cycle, this patch makes reply-ack prot= ocol > feature to be enabled unconditionally. >=20 > This protocol feature makes the communication between the master and the > slave more robust, avoiding for example possible undefined behaviour with > VHOST_USER_SET_MEM_TABLE. >=20 > Also, reply-ack support will be required for upcoming VHOST_USER_SET_STAT= US > request. >=20 > Note that this protocol feature was disabled by default because Qemu vers= ion > 2.7.0 to 2.9.0 had a bug causing a deadlock when reply-ack was negotiated= and > multiqueue enabled. These Qemu version are now very old and no more > maintained, so we can resonnably consider we no more support them. >=20 > Signed-off-by: Maxime Coquelin > --- >=20 > v2: > - Fix commit message > - Remove mention to the workaround in the doc >=20 > doc/guides/prog_guide/vhost_lib.rst | 5 ----- > lib/librte_vhost/vhost_user.c | 9 --------- > 2 files changed, 14 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/vhost_lib.rst > b/doc/guides/prog_guide/vhost_lib.rst > index 07e40e3c5e..db921f922b 100644 > --- a/doc/guides/prog_guide/vhost_lib.rst > +++ b/doc/guides/prog_guide/vhost_lib.rst > @@ -104,11 +104,6 @@ The following is an overview of some key Vhost API > functions: > from accessing memory the virtio device isn't allowed to, when the f= eature > is negotiated and an IOMMU device is declared. >=20 > - However, this feature enables vhost-user's reply-ack protocol featur= e, > - which implementation is buggy in Qemu v2.7.0-v2.9.0 when doing multi= queue. > - Enabling this flag with these Qemu version results in Qemu being blo= cked > - when multiple queue pairs are declared. > - > - ``RTE_VHOST_USER_POSTCOPY_SUPPORT`` >=20 > Postcopy live-migration support will be enabled when this flag is se= t. > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.= c index > 84bebad792..ea9cd107b9 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -2012,15 +2012,6 @@ vhost_user_get_protocol_features(struct virtio_net > **pdev, > rte_vhost_driver_get_features(dev->ifname, &features); > rte_vhost_driver_get_protocol_features(dev->ifname, > &protocol_features); >=20 > - /* > - * REPLY_ACK protocol feature is only mandatory for now > - * for IOMMU feature. If IOMMU is explicitly disabled by the > - * application, disable also REPLY_ACK feature for older buggy > - * Qemu versions (from v2.7.0 to v2.9.0). > - */ > - if (!(features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))) > - protocol_features &=3D ~(1ULL << > VHOST_USER_PROTOCOL_F_REPLY_ACK); > - > msg->payload.u64 =3D protocol_features; > msg->size =3D sizeof(msg->payload.u64); > msg->fd_num =3D 0; > -- > 2.26.2 Reviewed-by: Chenbo Xia