From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Stokes, Ian" <ian.stokes@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/4] examples/vhost_crypto: use vhost async-copy flag
Date: Wed, 23 Sep 2020 05:43:42 +0000 [thread overview]
Message-ID: <MN2PR11MB4063E76EC99FB28DE31C409D9C380@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200915133558.210639-3-maxime.coquelin@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, September 15, 2020 9:36 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Stokes, Ian
> <ian.stokes@intel.com>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH 2/4] examples/vhost_crypto: use vhost async-copy flag
>
> The crypto backend uses RTE_VHOST_USER_DEQUEUE_ZERO_COPY only
> for the shared areas to be populated at mmap time. It does
> not use the other mechanisms the feature provides.
>
> Now that RTE_VHOST_USER_DEQUEUE_ZERO_COPY is being removed,
> let's use RTE_VHOST_USER_ASYNC_COPY instead which does the
> same thing.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> examples/vhost_crypto/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index 1d7ba94196..4bdd12f695 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -588,7 +588,7 @@ main(int argc, char *argv[])
>
> for (j = 0; j < lo->nb_sockets; j++) {
> ret = rte_vhost_driver_register(lo->socket_files[j],
> - RTE_VHOST_USER_DEQUEUE_ZERO_COPY);
> + RTE_VHOST_USER_ASYNC_COPY);
> if (ret < 0) {
> RTE_LOG(ERR, USER1, "socket %s already exists\n",
> lo->socket_files[j]);
> --
> 2.26.2
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
next prev parent reply other threads:[~2020-09-23 5:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 13:35 [dpdk-dev] [PATCH 0/4] pick Maxime Coquelin
2020-09-15 13:35 ` [dpdk-dev] [PATCH 1/4] net/vhost: remove dequeue zero-copy support Maxime Coquelin
2020-09-23 5:41 ` Xia, Chenbo
2020-09-15 13:35 ` [dpdk-dev] [PATCH 2/4] examples/vhost_crypto: use vhost async-copy flag Maxime Coquelin
2020-09-23 5:43 ` Xia, Chenbo [this message]
2020-09-15 13:35 ` [dpdk-dev] [PATCH 3/4] examples/vhost: remove dequeue zero-copy support Maxime Coquelin
2020-09-23 5:43 ` Xia, Chenbo
2020-09-15 13:35 ` [dpdk-dev] [PATCH 4/4] vhost: " Maxime Coquelin
2020-09-23 5:44 ` Xia, Chenbo
2020-09-15 13:41 ` [dpdk-dev] [PATCH 0/4] vhost: remove dequeue zero-copy support (was: pick) Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4063E76EC99FB28DE31C409D9C380@MN2PR11MB4063.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).