From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71AB4A04A5; Wed, 17 Jun 2020 14:07:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 50B181252; Wed, 17 Jun 2020 14:07:13 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 14EF21150 for ; Wed, 17 Jun 2020 14:07:10 +0200 (CEST) IronPort-SDR: 5egYtFabcuNrdonpK0qmY04HyPvtSuohhl2FAHvOFFPQJPnLgAk0TaBvrXAlwAsXTqwHr58Maa baP2PqRWBAkQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 05:07:10 -0700 IronPort-SDR: QdrLMBKpZAQkXP63SkYs1E8cPmzoLFTTcAuumKoOXmb33TnEmHs9fKCcnX6Pf5HJieGOm7xV6+ X6QOys+tKPIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,522,1583222400"; d="scan'208";a="450225397" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 17 Jun 2020 05:07:09 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 05:07:09 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 05:07:09 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jun 2020 05:07:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=anZNWhVvXy/JRKIpuXvC8i/m9EwQiXO6KQbsivzztHMHKV5Jzs28twgPkpQmYDdLF9F1nePGiryYyqqawL8XAH+JbMjb3aClIZSV3rb1H0v5ZJ0+0HQndOVDN1Cvv67yBKkn/l5Een8YUYpD/4E4+AINVi7R40KDOi0YC+ZJia557ZkqhUJeyw0lkrcENVnNYsnLHqbk6t7bmCC6eG06TgbYVPsVa3rzyROJO2SOFWiy84NBlCIuYAis3uP2cIaCt/7IzZW6JI1umRk3ofDMRraclM9DsoAP60U+VMusYT+xtwGZDvrKu0DWFTq+JKUeoSOOYXc5CfdbC/do0Y0OrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+pAqfhSa/c0l1CA/w2HyAoXxsyQNybv3FQttWiZUdWw=; b=a8E8Xd82zu2Gt3uOYZ0fHgQ0WLw/7UByCEOBvL9RD6vU5NpMSZDxnv7JfyKRX/SnGs7o4gEsU2gKGu2nSlr38d9B+xP232WqgpRvzKrkxrtH1SjJ/rEtrzX+qT66MT9RsBTk+kp0QmfP4JII/95ER558zkcH29Mvd32tJqd/OcfhBVtOxfQnf5YoVmRb1CYYH1LXxash22LyXo8yEivob3JANkI7An325ZkHBAXQLpfWKScSZO6bKFnMUeBUhAdeH0zXKeuvFqeYDa182aMXcQK1JzmukkzOlWkFKGpMDTKwJFz5644SMyI7CG/KCG79sUzsI1PkuC/fXKxrE4DIhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+pAqfhSa/c0l1CA/w2HyAoXxsyQNybv3FQttWiZUdWw=; b=QqCZpyaDV6EE6tHakFuvhN1CI6HMlCS4AfYo+XD2UuyW9gN2VG2m7iovRvBpqr1s8eLlqUMLD6Ax3hcHj78OGxY2qFAgzH0OfgMnUpYbxfsULdJ3Ncq0Czhb57GjAha23pngzboY+t87lC1TDRnAWrOvuZTqy1qzdk9e6DrvBco= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB3936.namprd11.prod.outlook.com (2603:10b6:208:13f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Wed, 17 Jun 2020 12:07:05 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::7cde:8326:5010:c47e]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::7cde:8326:5010:c47e%7]) with mapi id 15.20.3109.021; Wed, 17 Jun 2020 12:07:05 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "amorenoz@redhat.com" , "Ye, Xiaolong" , "shahafs@mellanox.com" , "matan@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH 3/3] net/virtio: add Virtio status support to Virtio-user Thread-Index: AdZEnu3IRWLiIf56Q6+2rpinH1PNcg== Date: Wed, 17 Jun 2020 12:07:05 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4019c27c-c799-46e6-5421-08d812b6f3c7 x-ms-traffictypediagnostic: MN2PR11MB3936: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 04371797A5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8bR4Npmc/Dso9VRvyzoLGRAoZcAe5a6pofmQsyvz9Z1f8VMZwj2tIxD1Si8WG4G2hIXw+QA9oyx8DLjcJPNQjJ/juTBPDV23fY29/ogRzhBtA4JYt8TYTqO4qFWh95WA1U3uEqMTE/IV9M/yGKnQU5BX5D46+X5vW6guSKTraWbrpGPzflN0vkSBGFWRl7SYfkKGDmuaKgKVlBMM3zyONBaaSFdpYomHXn3v+vhbiKygrmrTDmzVKqRqAK00ld2VSiikmZN9Lm+ReMIy3sUiYeqpi0Pb1YFdz42ci+NrW1kePKCO6OrCj9CAMqKQe8K+ROWtQoUW0P/ylWPIBuRdmXmZbIazNpL+DZX1EBWWNV35CaQhvlspyCO7XWEWEHvCLDqZx+Q9/CZRJSm78ajpog== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(66446008)(6506007)(2906002)(53546011)(26005)(66556008)(66476007)(64756008)(76116006)(66946007)(33656002)(186003)(55016002)(7696005)(9686003)(86362001)(316002)(478600001)(110136005)(83380400001)(8676002)(71200400001)(52536014)(5660300002)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: JZ5TqJeugabrbNAtA0yhCmVB+v+hurTBxmS/rZ5zs9Ou24AmArzEJx1LpZRliL2mVm2RIqTQs4wZobNJCw+NKPHQkePlpOxTlxYiT4Vesh4rs+aTggyatyi7f3X0hXY+xBKyCjtzzXa2w7OBe5D0MtThLVVgFYu/6vfpzLGCqtDo+jolrbqC65Kwz73ry1AEImjBhc0A4onJMCC+hKOkXVsombkQGlnsGu8JaUeIy6vtZ84lowhqC1I2vIa7o8n8rhjV+FFHzeWwEJPDNa7LMwrTv7phHSLgJyRloN7/SkkPZpBXWrWb3wYbFHghx5Q9ZjlAIAJTNAIUfEYmE1MRBd56Zjqnb21m+KvwcTiYrydWbUutyXnnM/N31KlOxmaGrHtfvVmnV4m5fX86EiahM21wFF+8HH4bVOdaCVx6pRD5wLflguEDzVX9pkJWPfAqmE5VvzKs5HJIGPUbVEmv1AxziwYzj1nqaEJhjUNhEu0IOxIr23ExC59FIywgC3Sv Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4019c27c-c799-46e6-5421-08d812b6f3c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2020 12:07:05.3970 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M2bAPFBzm8LaOeKiv0l5J6edX8LPJp756MkZS9GHumQuKxxUcEFXOahmT728ifRh4AaiQPoVECKIQUA6ENOZeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3936 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/3] net/virtio: add Virtio status support to Virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Maxime, > -----Original Message----- > From: dev On Behalf Of Maxime Coquelin > Sent: Thursday, May 28, 2020 3:46 PM > To: dev@dpdk.org; amorenoz@redhat.com; Ye, Xiaolong > ; shahafs@mellanox.com; matan@mellanox.com > Cc: Maxime Coquelin > Subject: [dpdk-dev] [PATCH 3/3] net/virtio: add Virtio status support to = Virtio- > user >=20 > This patch adds support for VHOST_USER_SET_STATUS request. It is used to > make the backend aware of Virtio devices status update. >=20 > It is useful for the backend to know when the Virtio driver is done with = the Virtio > device configuration. >=20 > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_user/vhost.h | 5 +++++ > drivers/net/virtio/virtio_user/vhost_user.c | 8 ++++++++ > .../net/virtio/virtio_user/virtio_user_dev.c | 20 ++++++++++++++++++- > .../net/virtio/virtio_user/virtio_user_dev.h | 1 + > drivers/net/virtio/virtio_user_ethdev.c | 1 + > 5 files changed, 34 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/virtio/virtio_user/vhost.h > b/drivers/net/virtio/virtio_user/vhost.h > index 260e1c3081..fc360564eb 100644 > --- a/drivers/net/virtio/virtio_user/vhost.h > +++ b/drivers/net/virtio/virtio_user/vhost.h > @@ -57,6 +57,10 @@ struct vhost_vring_addr { #define > VHOST_USER_PROTOCOL_F_REPLY_ACK 3 #endif >=20 > +#ifndef VHOST_USER_PROTOCOL_F_STATUS > +#define VHOST_USER_PROTOCOL_F_STATUS 15 #endif > + > enum vhost_user_request { > VHOST_USER_NONE =3D 0, > VHOST_USER_GET_FEATURES =3D 1, > @@ -77,6 +81,7 @@ enum vhost_user_request { > VHOST_USER_SET_PROTOCOL_FEATURES =3D 16, > VHOST_USER_GET_QUEUE_NUM =3D 17, > VHOST_USER_SET_VRING_ENABLE =3D 18, > + VHOST_USER_SET_STATUS =3D 36, I see in qemu's vhost-user spec (https://www.qemu.org/docs/master/interop/v= host-user.html#protocol-features) that '36' is used by VHOST_USER_GET_MAX_MEM_SLOTS. And I don't see VHOST_US= ER_PROTOCOL_F_STATUS. Do I miss something here? Also, I see in drivers/net/virtio/virtio_pci.h, the status definition is to= o old and does not align with the spec now. Should we update that one? Thanks! Chenbo > VHOST_USER_MAX > }; >=20 > diff --git a/drivers/net/virtio/virtio_user/vhost_user.c > b/drivers/net/virtio/virtio_user/vhost_user.c > index f8d751c98e..68232d75d7 100644 > --- a/drivers/net/virtio/virtio_user/vhost_user.c > +++ b/drivers/net/virtio/virtio_user/vhost_user.c > @@ -278,6 +278,14 @@ vhost_user_sock(struct virtio_user_dev *dev, > need_reply =3D 1; > break; >=20 > + case VHOST_USER_SET_STATUS: > + if (!(dev->protocol_features & > + (1ULL << > VHOST_USER_PROTOCOL_F_STATUS))) > + return 0; > + > + if (has_reply_ack) > + msg.flags |=3D VHOST_USER_NEED_REPLY_MASK; > + /* Fallthrough */ > case VHOST_USER_SET_FEATURES: > case VHOST_USER_SET_PROTOCOL_FEATURES: > case VHOST_USER_SET_LOG_BASE: > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c > b/drivers/net/virtio/virtio_user/virtio_user_dev.c > index ea22af5dc4..cf29ea0b88 100644 > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c > @@ -424,7 +424,8 @@ virtio_user_dev_setup(struct virtio_user_dev *dev) >=20 > #define VIRTIO_USER_SUPPORTED_PROTOCOL_FEATURES \ > (1ULL << VHOST_USER_PROTOCOL_F_MQ | \ > - 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK) > + 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK | \ > + 1ULL << VHOST_USER_PROTOCOL_F_STATUS) >=20 > int > virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues= , @@ - > 782,3 +783,20 @@ virtio_user_handle_cq(struct virtio_user_dev *dev, uint1= 6_t > queue_idx) > __atomic_add_fetch(&vring->used->idx, 1, > __ATOMIC_RELAXED); > } > } > + > +int > +virtio_user_update_status(struct virtio_user_dev *dev, uint8_t status) > +{ > + int ret; > + uint64_t arg =3D status; > + > + /* Vhost-user only for now */ > + if (!is_vhost_user_by_type(dev->path)) > + return 0; > + > + ret =3D dev->ops->send_request(dev, VHOST_USER_SET_STATUS, &arg); > + if (ret) > + return -1; > + > + return 0; > +} > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h > b/drivers/net/virtio/virtio_user/virtio_user_dev.h > index 56e638f8a6..c49a896a88 100644 > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h > @@ -71,4 +71,5 @@ void virtio_user_handle_cq(struct virtio_user_dev *dev, > uint16_t queue_idx); void virtio_user_handle_cq_packed(struct virtio_use= r_dev > *dev, > uint16_t queue_idx); > uint8_t virtio_user_handle_mq(struct virtio_user_dev *dev, uint16_t q_pa= irs); > +int virtio_user_update_status(struct virtio_user_dev *dev, uint8_t > +status); > #endif > diff --git a/drivers/net/virtio/virtio_user_ethdev.c > b/drivers/net/virtio/virtio_user_ethdev.c > index ccb5a18e25..bed161ba07 100644 > --- a/drivers/net/virtio/virtio_user_ethdev.c > +++ b/drivers/net/virtio/virtio_user_ethdev.c > @@ -271,6 +271,7 @@ virtio_user_set_status(struct virtio_hw *hw, uint8_t > status) > else if (status =3D=3D VIRTIO_CONFIG_STATUS_RESET) > virtio_user_reset(hw); > dev->status =3D status; > + virtio_user_update_status(dev, status); > } >=20 > static uint8_t > -- > 2.26.2