DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"amorenoz@redhat.com" <amorenoz@redhat.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 3/3] net/virtio: pack virtuqueue struct
Date: Mon, 11 Jan 2021 02:56:00 +0000
Message-ID: <MN2PR11MB4063F76DF48B04AD015B220C9CAB0@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201221161456.31696-4-maxime.coquelin@redhat.com>

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, December 22, 2020 12:15 AM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; amorenoz@redhat.com;
> david.marchand@redhat.com; olivier.matz@6wind.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH 3/3] net/virtio: pack virtuqueue struct

s/virtuqueue/virtqueue

> 
> This patch optimizes packing of the virtuqueue

Ditto

With above fixed:

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

> struct by moving fields around to fill holes.
> 
> Offset field is not used and so can be removed.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  drivers/net/virtio/virtqueue.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> index c64e7dcbdf..3b08aac931 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -245,6 +245,15 @@ struct virtqueue {
>  	uint16_t vq_avail_idx; /**< sync until needed */
>  	uint16_t vq_free_thresh; /**< free threshold */
> 
> +	/**
> +	 * Head of the free chain in the descriptor table. If
> +	 * there are no free descriptors, this will be set to
> +	 * VQ_RING_DESC_CHAIN_END.
> +	 */
> +	uint16_t  vq_desc_head_idx;
> +	uint16_t  vq_desc_tail_idx;
> +	uint16_t  vq_queue_index;   /**< PCI queue index */
> +
>  	void *vq_ring_virt_mem;  /**< linear address of vring*/
>  	unsigned int vq_ring_size;
> 
> @@ -257,15 +266,6 @@ struct virtqueue {
>  	rte_iova_t vq_ring_mem; /**< physical address of vring,
>  	                         * or virtual address for virtio_user. */
> 
> -	/**
> -	 * Head of the free chain in the descriptor table. If
> -	 * there are no free descriptors, this will be set to
> -	 * VQ_RING_DESC_CHAIN_END.
> -	 */
> -	uint16_t  vq_desc_head_idx;
> -	uint16_t  vq_desc_tail_idx;
> -	uint16_t  vq_queue_index;   /**< PCI queue index */
> -	uint16_t offset; /**< relative offset to obtain addr in mbuf */
>  	uint16_t  *notify_addr;
>  	struct rte_mbuf **sw_ring;  /**< RX software ring. */
>  	struct vq_desc_extra vq_descx[0];
> --
> 2.29.2


  reply	other threads:[~2021-01-11  2:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-21 16:14 [dpdk-dev] [PATCH 0/3] net/virtio: make virtqueue struct cache-friendly Maxime Coquelin
2020-12-21 16:14 ` [dpdk-dev] [PATCH 1/3] net/virtio: remove reference to virtqueue in vrings Maxime Coquelin
2021-01-11  2:17   ` Xia, Chenbo
2020-12-21 16:14 ` [dpdk-dev] [PATCH 2/3] net/virtio: allocate fake mbuf in Rx queue Maxime Coquelin
2021-01-11  2:50   ` Xia, Chenbo
2021-03-15 11:29     ` Maxime Coquelin
2021-01-11  5:39   ` Xia, Chenbo
2021-03-15 13:46     ` Maxime Coquelin
2020-12-21 16:14 ` [dpdk-dev] [PATCH 3/3] net/virtio: pack virtuqueue struct Maxime Coquelin
2021-01-11  2:56   ` Xia, Chenbo [this message]
2021-01-08  2:50 ` [dpdk-dev] [PATCH 0/3] net/virtio: make virtqueue struct cache-friendly Xia, Chenbo
2021-01-08  8:25   ` Maxime Coquelin
2021-01-25 17:30 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB4063F76DF48B04AD015B220C9CAB0@MN2PR11MB4063.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=amorenoz@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git