From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D80A2A04BC; Fri, 18 Sep 2020 02:38:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CED671D6D9; Fri, 18 Sep 2020 02:38:16 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D8E6F1D68B for ; Fri, 18 Sep 2020 02:38:14 +0200 (CEST) IronPort-SDR: WS5I0YKM+OptvTNbkw84Fv4pf9h7+537MF8mja843/bUfrTdf4ySqt8GUAjUg3YEA9MwxhuMDV loxfQP57T7Gw== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="147507936" X-IronPort-AV: E=Sophos;i="5.77,272,1596524400"; d="scan'208";a="147507936" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 17:38:08 -0700 IronPort-SDR: Q4PQgKcaYhqlnDlqsOcE8scQK5X1yzSi1QBNwVCy1vLVEK6KNnT/fZPJvpj4b77H2B/i+lOuZH zMMMK4WJKMRw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,272,1596524400"; d="scan'208";a="320424321" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga002.jf.intel.com with ESMTP; 17 Sep 2020 17:38:07 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Sep 2020 17:38:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Sep 2020 17:38:04 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 17 Sep 2020 17:38:03 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 17 Sep 2020 17:38:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d8fzkIoUa371n4WS5WsQqWKAqrZ6qjcljrhiLhpKjQqrW/lpg4QP+NBE6ka2RGYoS20LWLnEEz94f2MBMsILnWQsdAYPHnLaH0zZk+OB+8dwqYMKSFW4HKT5n1ZDNHlfu+KUxor4K0Em/viOslGH7QF5L2/yPvKQIAM6suzaVaaYdpe+2mpGP64eJDAQdwPwCMQzN15K9c8xXdNurFqTwf1Htr9pNnuE7p3a7f9QAK2ieJrP+ghVjm8BoTlX2/QhjDm9+wsPB3w3wNfmQx+ft5zTwYWjYqXV2tHMIzRpyhFDTNy+6yYNM5Y0uEFMn7UA2hr+HBjCFSXWnfKlt5ra+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K7VU+PppFYuC9opeZJGbOu7lamUz3uWhfVYMjtq8rsQ=; b=MJNRwuN23YsK1BtF3REmkQy6l6A4QSM3Pdgp17SzTClQaK/419h4y40wUSXOG6ClcqIRmutbmDBiLuiqlM9pQgcfNup1s+BU7bGme0OQbfclpnAbYzdVSiIFss9ca3DMiO3XgKoqJrqoTgHmM6TupUeqE3u/hnDFsY2LXYcRTSCc2iOcCeoR4b4IeyKqwG9TSODVqTdax1tuF2JZshs0B1QLXHHqN+QjLtiXbLAuSSEdy73cR3jc5BXPXWENdOLLLVxFp/zv0WJkB7dzpYpaupzb+piYwmeLacQcnVW/hxOrrhmGVew+OGLr1uGeeMNolvKq0Niz/ZydiJzhub6Yaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K7VU+PppFYuC9opeZJGbOu7lamUz3uWhfVYMjtq8rsQ=; b=bL3Tj7bThRwPsFL9TUhKYkaTSc2M5h2r6MvgPMTEOnjohwFNxmKjV6xhS2yrwHX1nViSIXyKIDX8RQPrkRJg6KFaPdFPgWGEF5iLsYV0lR7S6mhUMQRk0YoDDVDlW9EK5nSCINmP8lHj915vO6m23MTrKP+g4/QvXxsdsxnNufQ= Received: from MN2PR11MB4431.namprd11.prod.outlook.com (2603:10b6:208:18c::15) by MN2PR11MB4111.namprd11.prod.outlook.com (2603:10b6:208:138::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.18; Fri, 18 Sep 2020 00:37:59 +0000 Received: from MN2PR11MB4431.namprd11.prod.outlook.com ([fe80::4cf6:9040:b290:30d8]) by MN2PR11MB4431.namprd11.prod.outlook.com ([fe80::4cf6:9040:b290:30d8%6]) with mapi id 15.20.3370.019; Fri, 18 Sep 2020 00:37:59 +0000 From: "Chen, Mike Ximing" To: "McDaniel, Timothy" CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , "jerinj@marvell.com" Thread-Topic: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats Thread-Index: AQHWiHqLTcxGINdRWEauHnwRu2CX/6ltVpiAgAAKLxCAADU+kA== Date: Fri, 18 Sep 2020 00:37:58 +0000 Message-ID: References: <1599855987-25976-1-git-send-email-timothy.mcdaniel@intel.com> <1599855987-25976-8-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [69.141.167.85] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41317240-643a-4912-3f9e-08d85b6b17f7 x-ms-traffictypediagnostic: MN2PR11MB4111: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XIqRJ1c9zFelNIuAKWcx/MaJuTyrANlX/iplo3iJldNBJJR4RrMCYvM9N5NMbf4yRoROkCKVLElXNcICa6vHjLmz+2Sw0q0J9kfQCuYReCrlrzsVGpYZClI9ejVg7QqgWhu8MYbda3LXrDXH6AmDsWp70NjHxQ97k75bm9IsBPV8EIss1nIqxNGnKxHCjBPInUP+MXo+72RtN411HgEWAK6DIEWJULiUzGWe06Y02ZZduYsT/pfTPsT78WkeUzCcpAbNS04eD6oHiziRdJIR7egg1fpo1haX9B2JWy95I2CdV2khBaaqlT68pJ7DCnKhqQOdCbqVnMlL9AfCZE/91SnPASKtMqsSkgDat+fn9d9XERbPIHmr/Yqjs5uWWrL9+sMCoZdXH55ZxvM3hHA9A9B3hxVa70SC65XGtfl599lL4DfOnM4ld2w1oT6uCBDP x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4431.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(366004)(346002)(39860400002)(376002)(55016002)(9686003)(83380400001)(33656002)(6636002)(8936002)(54906003)(2906002)(66446008)(71200400001)(66476007)(66556008)(66946007)(76116006)(8676002)(64756008)(316002)(53546011)(6506007)(966005)(7696005)(186003)(52536014)(6862004)(26005)(86362001)(4326008)(5660300002)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: GXxnetOE0eAy0Rcsb6DUK8bjbZi1T+JWZNW7Jtc4sIRd/4byxwp94n67xqOYeN+FnPSwM8wsdo8+IMPHJX4N72k0TlNtPH6SN/gdif3ZzgdF9Z763ifUl6QktW8jc0+c+N3L7j3grABRQWGs3faHC3vBgD3a8w/g+3rxdYznoNPwA1xIcwFDSZ6iq87A/38DjKZ/K6Q9rqszxymfbIEcVTQNrn5yIm78Tkz8ALe4K8kCeYdavHshi3l2LocDEH1PYB4j//Y93xMjdtk7KMczWsrIcS1hUEl7Vfa+OopWe51MF1qhVMPIv8QiOoR59Dj83k48JpU3V8PrMW8TeiAmpzeVOC/gL5y+HaupW7gERWn5BEHECoz9/QzSYOKe4kzk8IO3arYdTsQvb0vq7KeRKqcFPr5HS0Xm+/taKrXsLtM+0azbpKSV0Gju26KC6Cgi9ByrKl16QR8etAtc9pCJqylDOdnmBPJG/r85w4lgdrfouiqoxtLn0MKJck4S/GbJCyxg9L6uTgmCfoMHfE3TdJgW5FHE6sbnbxLnv3nWC9ufq/1lym5gBR6AE3foIekSmdmKRpY+Dekk0FlLR7tBMnNLiojQiSQrm4nPVLxNz/yblve3krI64M1CD5Mvg76uubqFM/FfI60js8EdKB/d+w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4431.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41317240-643a-4912-3f9e-08d85b6b17f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2020 00:37:59.2794 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8tIGxdKnaSQjSh//xnMZCUphkiDTmQOIRz0HEFjxHRpGTGp4byIXZBBG0RY0r26f5wSBH4WV+n0DR//dS9VTOa2L3cE4yzgPl1YQtHx+2v0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4111 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: McDaniel, Timothy > Sent: Thursday, September 17, 2020 5:26 PM > To: Chen, Mike Ximing > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > jerinj@marvell.com > Subject: RE: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats >=20 >=20 >=20 > > -----Original Message----- > > From: Chen, Mike Ximing > > Sent: Thursday, September 17, 2020 3:58 PM > > To: McDaniel, Timothy > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, > > Gage ; Van Haaren, Harry > > ; jerinj@marvell.com > > Subject: RE: [dpdk-dev] [PATCH 07/22] event/dlb2: add xstats > > > > > > > +dlb2_eventdev_dump(struct rte_eventdev *dev, FILE *f) { > > > + struct dlb2_eventdev *dlb2; > > > + struct dlb2_hw_dev *handle; > > > + int i; > > > + > > > + if (!f) { > > > + printf("Invalid file pointer\n"); > > > + return; > > > + } > > > + > > > + if (!dev) { > > > + fprintf(f, "Invalid event device\n"); > > > + return; > > > + } > > > + > > > + dlb2 =3D dlb2_pmd_priv(dev); > > > + > > > + if (!dlb2) { > > > + fprintf(f, "DLB2 Event device cannot be dumped!\n"); > > > + return; > > > + } > > > + > > > > Not sure if this is enforced. The DPDK coding style discourages using > > ! on pointers ( see section 1. 8.1 at > > https://doc.dpdk.org/guides/contributing/coding_style.html). > > >=20 > I see !ptr used in many other dpdk components, and it is not flagged by > checkpatch either. >=20 Yes, I do see !ptr in dpdk functions. I guess the rule is not enforced.