From: "Ma, WenwuX" <wenwux.ma@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
"Singh, Aman Deep" <aman.deep.singh@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>, dev <dev@dpdk.org>,
"Hu, Jiayu" <jiayu.hu@intel.com>,
"Wang, Yinan" <yinan.wang@intel.com>,
"He, Xingguang" <xingguang.he@intel.com>
Subject: RE: [PATCH] app/testpmd: perform SW IP checksum for GRO packets
Date: Wed, 11 May 2022 09:00:45 +0000 [thread overview]
Message-ID: <MN2PR11MB451900764D53E2F7100898A6EBC89@MN2PR11MB4519.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8yDqiY7zKs8xM=KnsVBSkjD4VQp76VD5xpWvUe+5vVyuA@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: 2022年5月11日 15:28
> To: Ma, WenwuX <wenwux.ma@intel.com>
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman Deep
> <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>;
> dev <dev@dpdk.org>; Hu, Jiayu <jiayu.hu@intel.com>; Wang, Yinan
> <yinan.wang@intel.com>; He, Xingguang <xingguang.he@intel.com>
> Subject: Re: [PATCH] app/testpmd: perform SW IP checksum for GRO
> packets
>
> On Wed, May 11, 2022 at 3:40 AM Wenwu Ma <wenwux.ma@intel.com>
> wrote:
> >
> > The GRO library doesn't re-calculate checksums for merged packets. If
> > users want the merged packets to have correct IP checksums, they
> > should select HW IP checksum calculation for the port which the merged
> > packets are transmitted to. But if the port doesn't support HW IP
> > checksum, users may perform a SW IP checksum. This patch add the code
> > about it.
>
> It looks like a fix, please add a Fixes: line.
ok
> Out of curiosity, would there be an issue too when using the gso library?
>
yes, gso library has the same issue. IP checksum need to be re-calculated for fragmented packets
> >
> > Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
>
>
> --
> David Marchand
next prev parent reply other threads:[~2022-05-11 9:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 1:37 Wenwu Ma
2022-05-11 7:27 ` David Marchand
2022-05-11 9:00 ` Ma, WenwuX [this message]
2022-05-11 9:35 ` [PATCH v2] app/testpmd: perform SW IP checksum for GRO/GSO packets Wenwu Ma
2022-05-12 1:07 ` [PATCH v3] " Wenwu Ma
2022-05-12 1:33 ` Hu, Jiayu
2022-05-17 2:56 ` Ling, WeiX
2022-05-17 16:02 ` Zhang, Yuying
2022-05-19 8:23 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB451900764D53E2F7100898A6EBC89@MN2PR11MB4519.namprd11.prod.outlook.com \
--to=wenwux.ma@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=xingguang.he@intel.com \
--cc=yinan.wang@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).