From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 769F0A0524; Mon, 19 Apr 2021 18:13:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6AA741390; Mon, 19 Apr 2021 18:13:10 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2072.outbound.protection.outlook.com [40.107.236.72]) by mails.dpdk.org (Postfix) with ESMTP id 7E4384138A for ; Mon, 19 Apr 2021 18:13:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=msHsYcfW36pqjNvoUDWIhlsvBCfHBKmP6M/ua4v/5MvA8bN4UIo18yj39dZRera9/rEqnUlnn+KjDEFncqVuinOQ5zGYzizPjO1bJmzfhPs7csRMBsgULr5hQ7Ssu2AekQymY3XuNi6dfPnFi1Wjwu0j3UgvjgosPvxnVe7PsBvzmNA1f6br+muXsTI149Ugj800D7Daa/phVX9YJ8917/LaC7HIxN0klV51lpe/MEge2IvgjATjmrKCNqGKcwRGoYiEegtsW+7t4jEMd3ufnw2nemT+y5Jp/LngNL6xdGF03c7rTwVRohWewJQD+fQVKeNnMo8ZwmbVe4Ty8wqudQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U8I/fM0ZQRjjxATHH7gNxM+Dx4amppe8rqWc41DEt4k=; b=JgWUANZuwvZcNz1PPuqTHxOZUopy2db5KVGg47ABEQVGMrzLbmridZSXIyuWBNb5bgegRwYgFeoRC6Oom6Ij9xjpGswVl9h6R4AK7NV6V5KQ4elMu3lxt9M1+wPy6BUrXAuQU2mfNI8PvrFYlU4KPRcXXbODS+C5uVZcu1ubYl8oYASh3szmUMdxcz7O7OH805mUu18k4DoaWCIVq3CbFIgjemj4LCSlyYdmHeoWQLJU0fsxNJFwPuVdSer4OStt6FEV8kiZFivrlPJPWCwwAaDmvqv5+OmSf5dxP5rLJomWOkx7xiM6zJUhu/gq/67LvrK5Tc2Gw+GuhxDpH4KrbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U8I/fM0ZQRjjxATHH7gNxM+Dx4amppe8rqWc41DEt4k=; b=KuwvIYwvoJstDcJdja2sWNRb9fO4/7jnDnqh90oOFNqT/mR2NCMhYZJmN0DuegmS7b4BdT3u0gCHyV4poDX0+F9AwWcliwnojvtr10z58NmCAspphcII9rpZAGqUnKZnYEktJKQhLQTfloVmDxTho+atowaZ4WAOWCpRVD2THpsGXqMpTz6yu4NxohgSviunlS9PLMd3tctjF9P1kdHaRukMgcpcFfu6PTZuO2rG6u61s8JFEdnGPmDdGkVTXtVNJUJe5Qq50eP3oLiwkxKRQZgxPeUPXY2N4BSeGIfygenMz/haaIPfMWRrKjU4GcOO91d05g9AFmTwV8zaJNmDNQ== Received: from MN2PR12MB2909.namprd12.prod.outlook.com (2603:10b6:208:103::13) by MN2PR12MB2895.namprd12.prod.outlook.com (2603:10b6:208:102::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Mon, 19 Apr 2021 16:13:09 +0000 Received: from MN2PR12MB2909.namprd12.prod.outlook.com ([fe80::7cbc:e499:e936:7408]) by MN2PR12MB2909.namprd12.prod.outlook.com ([fe80::7cbc:e499:e936:7408%7]) with mapi id 15.20.4042.024; Mon, 19 Apr 2021 16:13:08 +0000 From: Bing Zhao To: NBU-Contact-Thomas Monjalon CC: Ori Kam , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "dev@dpdk.org" , "ajit.khaparde@broadcom.com" , "xiaoyun.li@intel.com" Thread-Topic: [dpdk-dev] [PATCH v3 1/3] ethdev: introduce conntrack flow action and item Thread-Index: AQHXMumNPgdl/ZrrgUSL6CvBcVnil6q75IOAgAAjO5A= Date: Mon, 19 Apr 2021 16:13:08 +0000 Message-ID: References: <1618062393-205611-1-git-send-email-bingz@nvidia.com> <1618595649-157464-1-git-send-email-bingz@nvidia.com> <1618595649-157464-2-git-send-email-bingz@nvidia.com> <3521936.dDA8s7yrex@thomas> In-Reply-To: <3521936.dDA8s7yrex@thomas> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [103.150.130.101] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ca389632-d3ce-4725-42b7-08d9034e05d4 x-ms-traffictypediagnostic: MN2PR12MB2895: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XYA69dHlnptaKvY/nqTcYxjcqIBaJnX4ZT1Rd66wVBtnxG/PSCRT5jD7srHZuUSW2qhW0da0WSSREpoVF3jpmAgplk7jNlBMGfDFAd88rt68ykQX7rItj9lPW/SQKjQojnrNaWNctj1cWfPt9CLXtJkJBSOSfLvsU5QIWdS75HIhcMVJFMe1uFCBirE3nAFZVs6dhAHTUVRVKLQXI1ddgiZqa4ajeQYMkIjvRCMenf5D3jbrDRHqBwJyv59JLVRjXWRKy8cTz9Dn0nFflob7A0FlaeZzmr9fQI8QKq3t9jQQAqN4gnbJT6S8SudEzV6mvYArT0K+19yeh6i77Zh6q6BhcOrIgYJw9hiP63MaN5CDjFDrZwrijoRpePcv5ILmZ8vrm2FyeWcVxjh3Fc0LHC18FQL38VgKU5nZhv2xxug8p3/k2wDEj3jRkWzHjUwlXDZ85UJNmuNy7PI8KIj+nhd/lS516X5XkCoWUIDLAKOOv3iyx0tyIX5Rb63O5Dnrs3qaFTAX80bKMhh5VL04PErWRk//eXpUfFdP9m/GXAU4q1y/tQRDaFeDRbdDeUyn+yFQIq2zv147IJ3sRhZtUpBaR2Q/7BuniK3dSYdpztI= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB2909.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(396003)(346002)(39860400002)(136003)(2906002)(33656002)(316002)(54906003)(478600001)(86362001)(186003)(83380400001)(76116006)(26005)(7696005)(4326008)(66476007)(6506007)(8676002)(52536014)(5660300002)(6916009)(66556008)(71200400001)(55016002)(38100700002)(9686003)(64756008)(122000001)(53546011)(66446008)(8936002)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?48rk3sPQpPpp4szpSTAUCIc4fhbF8wJ21DeFoqK5HN3rYji9PdwARgu0x/9N?= =?us-ascii?Q?mQI9abn1HPpNJ1WgHhGh5CtQOZ6EDasdTtwRPiDkFEhoLIXzYgbiLsoUmcdL?= =?us-ascii?Q?QVKCpVrRj9GknieNk8v5v6LpITgFHCyZvLx3exvK119GpJZkWyuepuQNEiAn?= =?us-ascii?Q?jvkQ4IoPLJuE0f4fCvC5dCLLkZVj1z0mpQ5i2Bouhby64CkKzLoPDQ3zA1Ri?= =?us-ascii?Q?6TTRxMBAEjLLDFFzCtEc8ZvyAwYJpUfGVCly7UEpkjFsNLKvFDuRiUF2pxwp?= =?us-ascii?Q?mftFNk57/aJSEGrA+VcJzGuG2jB/KSSLP4BIHDHIHrYwawsT0kaNAqiLA6Ny?= =?us-ascii?Q?Yl7sI/QmdO1gUkcPaZusgBAyHVFZkLrleq08Dv3MCZyfenxjjbEcrypqvfYF?= =?us-ascii?Q?IyFnOMWidgsu3jEdE0uiyOvFMgMHK1sNpl4Uj0i0zO4RlhrNQD/ks1nMIG62?= =?us-ascii?Q?hhoq8heL6ovMqu5yHZbB0m7qZF0AmMu9mnyEeuOfvNqXqnO9Wh5mzIdmQCb0?= =?us-ascii?Q?YzNym2ltnErGAYdB9OeVBFdp5qCNbASvSh7IbfPD9hwoOFa0BHYBaKet8Jj3?= =?us-ascii?Q?tEYWdtWCmTLzfTop4q8PUV9mg1P1PHQGwCX5YIc3/KoB2Ynh9wXAn19mNaLT?= =?us-ascii?Q?VEU+23cbnNegCVLxeX1Lp1c65cy3E6QQF3qR0aAd3VtEJnmdKfVVp9R+5RgR?= =?us-ascii?Q?PYZ75duOkFEimQW4VuMuUReIKISj4hZ2mRFAgjQi6dCIEBKIRbEikfqbFFTJ?= =?us-ascii?Q?0kjeMoxYALFiGGR9zRUuythSvfQFQ5thBPGtX2iJDGAIKuBiuLhIbcK/jicJ?= =?us-ascii?Q?jDBreZC/w1n1XZwxH/y75FpDKY9cO7j86tY4+xcKW1DbndB7shqqMiBlXRCn?= =?us-ascii?Q?s7CHMXHvybW8W3cFvueSrsx5rc4c1KKhzeeOwAZDHFgfcHbnxg0FekQOGh3w?= =?us-ascii?Q?59tmiD0pKzF0+JWgsa1y+12MAbUGqU7mGRQZyrO4ZFhtGhM75s2bYYrCgLC6?= =?us-ascii?Q?ISWl4qC7/mND4eX+R8Ib46hV7gvibS4+QwCwM/qDNc7YP1aIgzpMIAnZKMwK?= =?us-ascii?Q?VAY1qVEg9DQmBZbSg5wSAF+XjkdmOgpQqYcdLlXKIgtINqTwHT2wyY90I74B?= =?us-ascii?Q?H7+KnbnlGUzxd7BE5v+ESo86oCizhoUJitpZGLhT+gTu0jo9LGghtsbJOnfQ?= =?us-ascii?Q?D+C52b+tni8Oyk/gk9FKeM879NH0DNDq/u5b132OYZslRfo+ZK61pi4/s0w5?= =?us-ascii?Q?E4pqOClDbcLGwlez5q8vsWh0O2DpYwbeYn8dJXIx4XBzTKnvU/X7By5BcjRU?= =?us-ascii?Q?XFkn8DdqsorDY3snjJGZPs+A?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2909.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca389632-d3ce-4725-42b7-08d9034e05d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2021 16:13:08.8325 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RBJJriXPTVj07+IuNvCxVNQFm9EP7wFoYhCcYqT3R2RkVP3gj3Ah+x6UncKsuhiqxruW0F0T928y88uS/ih5/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2895 Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: introduce conntrack flow action and item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, April 19, 2021 10:06 PM > To: Bing Zhao > Cc: Ori Kam ; ferruh.yigit@intel.com; > andrew.rybchenko@oktetlabs.ru; dev@dpdk.org; > ajit.khaparde@broadcom.com; xiaoyun.li@intel.com > Subject: Re: [dpdk-dev] [PATCH v3 1/3] ethdev: introduce conntrack > flow action and item >=20 > External email: Use caution opening links or attachments >=20 >=20 > 16/04/2021 19:54, Bing Zhao: > > +/** > > + * The packet is valid after conntrack checking. > > + */ > > +#define RTE_FLOW_CONNTRACK_PKT_STATE_VALID RTE_BIT32(0) > > +/** > > + * The state of the connection is changed. > > + */ > > +#define RTE_FLOW_CONNTRACK_PKT_STATE_CHANGED RTE_BIT32(1) > > +/** > > + * Error is detected on this packet for this connection and > > + * an invalid state is set. > > + */ > > +#define RTE_FLOW_CONNTRACK_PKT_STATE_INVALID RTE_BIT32(2) > > +/** > > + * The HW connection tracking module is disabled. > > + * It can be due to application command or an invalid state. > > + */ > > +#define RTE_FLOW_CONNTRACK_PKT_STATE_DISABLED RTE_BIT32(3) > > +/** > > + * The packet contains some bad field(s) and cannot continue > > + * with the conntrack module checking. > > + */ > > +#define RTE_FLOW_CONNTRACK_PKT_STATE_BAD RTE_BIT32(4) >=20 > I like it better now that all bits have the same prefix, thanks. >=20 > > +enum rte_flow_conntrack_state { > > + /**< SYN-ACK packet was seen. */ > > + RTE_FLOW_CONNTRACK_STATE_SYN_RECV, > > + /**< 3-way handshake was done. */ > > + RTE_FLOW_CONNTRACK_STATE_ESTABLISHED, > > + /**< First FIN packet was received to close the connection. > */ > > + RTE_FLOW_CONNTRACK_STATE_FIN_WAIT, > > + /**< First FIN was ACKed. */ > > + RTE_FLOW_CONNTRACK_STATE_CLOSE_WAIT, > > + /**< Second FIN was received, waiting for the last ACK. */ > > + RTE_FLOW_CONNTRACK_STATE_LAST_ACK, > > + /**< Second FIN was ACKed, connection was closed. */ > > + RTE_FLOW_CONNTRACK_STATE_TIME_WAIT, > > +}; >=20 > These doxygen comments should not have "<" in them, because they are > "before". All "<" are removed, thanks. >=20 > [...] > > + /** No TCP check will be done except the state change. */ > > + uint32_t liberal_mode:1; > > + /**=20 > s,/**<,/** , >=20 > > + enum rte_flow_conntrack_state state; >=20 > Looks good overrall, thanks. >=20 BR. Bing