DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Namburu, Chandu-babu" <chandu@amd.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Somalapuram, Amaranath" <Amaranath.Somalapuram@amd.com>
Cc: "Kumar, Ravi1" <Ravi1.Kumar@amd.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/axgbe: add additional MAC address support
Date: Fri, 28 Feb 2020 14:15:49 +0000	[thread overview]
Message-ID: <MN2PR12MB302166055192D5049125728EC8E80@MN2PR12MB3021.namprd12.prod.outlook.com> (raw)
In-Reply-To: <97dd41f4-3e1b-3adb-36da-9be0bd8edb32@intel.com>

[AMD Official Use Only - Internal Distribution Only]

Hi Ferruh,

Thank you for pointing it out, I will correct them.

Regards,
Chandu
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com> 
Sent: Friday, February 28, 2020 7:33 PM
To: Namburu, Chandu-babu <chandu@amd.com>; dev@dpdk.org; Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>
Cc: Kumar, Ravi1 <Ravi1.Kumar@amd.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/axgbe: add additional MAC address support

On 2/28/2020 1:59 PM, chandu@amd.com wrote:
> From: Chandu Babu N <chandu@amd.com>
> 
> Supports adding MAC addresses to enable whitelist filtering to accept 
> packets implement eth_dev_ops mac_addr_set, mac_addr_add, 
> mac_addr_remove and set_mc_addr_list
> 
> Signed-off-by: Chandu Babu N <chandu@amd.com>

Hi Chandu, Amaranath,

Same comment with previous patchset,

Please check the "Contributing Code to DPDK" before sending patch:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdoc.dpdk.org%2Fguides%2Fcontributing%2Fpatches.html&amp;data=02%7C01%7Cchandu%40amd.com%7Cdaf59805e48d4384dc8708d7bc570ff4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637184954444477587&amp;sdata=PLWzmriaCP0%2FS51xJomCQWlT7EJ5bwz95ZOsJAP5fX0%3D&amp;reserved=0

And prefer threading for series instead of sending them one by one, as noted in above document:

''Shallow threading (--thread --no-chain-reply-to) is preferred for a patch series.''

  reply	other threads:[~2020-02-28 14:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-28 13:59 chandu
2020-02-28 14:03 ` Ferruh Yigit
2020-02-28 14:15   ` Namburu, Chandu-babu [this message]
2020-02-28 14:06 chandu
2020-02-28 14:20 chandu
2020-03-06  9:56 ` Kumar, Ravi1
2020-03-06 15:06   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB302166055192D5049125728EC8E80@MN2PR12MB3021.namprd12.prod.outlook.com \
    --to=chandu@amd.com \
    --cc=Amaranath.Somalapuram@amd.com \
    --cc=Ravi1.Kumar@amd.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).