DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Varghese, Vipin" <Vipin.Varghese@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Yigit, Ferruh" <Ferruh.Yigit@amd.com>
Subject: RE: [PATCH] usertools: suggest use of hwloc for new cpu
Date: Sun, 13 Aug 2023 02:12:03 +0000	[thread overview]
Message-ID: <MN2PR12MB30852A5C2671ECFCA217BF298216A@MN2PR12MB3085.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230812080025.7626a94d@hermes.local>

[AMD Official Use Only - General]

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Saturday, August 12, 2023 8:30 PM
> To: Varghese, Vipin <Vipin.Varghese@amd.com>
> Cc: thomas@monjalon.net; dev@dpdk.org; Yigit, Ferruh
> <Ferruh.Yigit@amd.com>
> Subject: Re: [PATCH] usertools: suggest use of hwloc for new cpu
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Sat, 12 Aug 2023 06:27:20 +0530
> Vipin Varghese <vipin.varghese@amd.com> wrote:
>
> > Most modern processor now supports numa by partitioning NUMA based on
> > CPU-IO & Last Level Cache within the same socket.
> > As per the discussion in mailing list, suggesting the make use of
> > hw-loc for such scenarios.
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@amd.com>
>
> NAK, no scripting hwloc, it is ugly and creates a dependency that is not listed
> in DPDK packaging.

There is no calls to hwloc within in thescript. Hence not clear what does ` NAK, no scripting hwloc it is ugly and creates a dependency that is not listed in DPDK packaging.`.

Requesting to cross check why NAK is shared for `print` as suggestion. Hence, I have disagree to this.

>
> It would be better to just add a footnote now something like cpu_layout script
> is deprecated use hwloc instead.

Please try and let me know, This is exactly what it is does as pre-footer.

> And include full deprecation notice in DPDK documentation.
>
> Maybe there is a standard python way to mark whole script as deprecated.
With respect to depreciation please check the patchwork for `usertools: enahcne logic to display NUMA` all these are already discussed.

We even requested to remove the script if it is not be used.



  reply	other threads:[~2023-08-13  2:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-12  0:57 Vipin Varghese
2023-08-12 15:00 ` Stephen Hemminger
2023-08-13  2:12   ` Varghese, Vipin [this message]
2023-08-13 15:52     ` Stephen Hemminger
2023-08-13 16:35       ` Varghese, Vipin
2023-08-14  8:52       ` Bruce Richardson
2023-08-14  9:13         ` Morten Brørup
2023-08-14  9:25         ` Konstantin Ananyev
2023-09-04 10:11           ` Ferruh Yigit
2023-09-04 10:20             ` Bruce Richardson
2023-09-04 13:22               ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2023-08-12  0:37 Vipin Varghese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB30852A5C2671ECFCA217BF298216A@MN2PR12MB3085.namprd12.prod.outlook.com \
    --to=vipin.varghese@amd.com \
    --cc=Ferruh.Yigit@amd.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).