DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/mlx5: fix thread termination check on Windows
@ 2022-10-12  6:49 Tal Shnaiderman
  2022-10-12  7:55 ` Slava Ovsiienko
  2022-10-18 11:47 ` Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Tal Shnaiderman @ 2022-10-12  6:49 UTC (permalink / raw)
  To: dev; +Cc: thomas, matan, viacheslavo, rasland, paul203948, idanhac, stable

The mlx5_is_thread_alive function always returns false
(terminated) regardless to the actual thread state.

Fixed to return the correct thread state.

Bugzilla ID: 1089
Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
Cc: stable@dpdk.org

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
 drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/windows/mlx5_flow_os.c b/drivers/net/mlx5/windows/mlx5_flow_os.c
index 48d7da41b1..5013e9f012 100644
--- a/drivers/net/mlx5/windows/mlx5_flow_os.c
+++ b/drivers/net/mlx5/windows/mlx5_flow_os.c
@@ -262,7 +262,7 @@ mlx5_is_thread_alive(HANDLE thread_handle)
 
 	if (result == WAIT_OBJECT_0)
 		return false;
-	return false;
+	return true;
 }
 
 static int
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] net/mlx5: fix thread termination check on Windows
  2022-10-12  6:49 [PATCH] net/mlx5: fix thread termination check on Windows Tal Shnaiderman
@ 2022-10-12  7:55 ` Slava Ovsiienko
  2022-10-18 11:47 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Slava Ovsiienko @ 2022-10-12  7:55 UTC (permalink / raw)
  To: Tal Shnaiderman, dev
  Cc: NBU-Contact-Thomas Monjalon (EXTERNAL),
	Matan Azrad, Raslan Darawsheh, paul203948, Idan Hackmon, stable

> -----Original Message-----
> From: Tal Shnaiderman <talshn@nvidia.com>
> Sent: Wednesday, October 12, 2022 9:50
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Matan
> Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Raslan
> Darawsheh <rasland@nvidia.com>; paul203948@gmail.com; Idan Hackmon
> <idanhac@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread termination check on Windows
> 
> The mlx5_is_thread_alive function always returns false
> (terminated) regardless to the actual thread state.
> 
> Fixed to return the correct thread state.
> 
> Bugzilla ID: 1089
> Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] net/mlx5: fix thread termination check on Windows
  2022-10-12  6:49 [PATCH] net/mlx5: fix thread termination check on Windows Tal Shnaiderman
  2022-10-12  7:55 ` Slava Ovsiienko
@ 2022-10-18 11:47 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2022-10-18 11:47 UTC (permalink / raw)
  To: Tal Shnaiderman, dev
  Cc: NBU-Contact-Thomas Monjalon (EXTERNAL),
	Matan Azrad, Slava Ovsiienko, paul203948, Idan Hackmon, stable

Hi,

> -----Original Message-----
> From: Tal Shnaiderman <talshn@nvidia.com>
> Sent: Wednesday, October 12, 2022 9:50 AM
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>;
> Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> paul203948@gmail.com; Idan Hackmon <idanhac@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread termination check on Windows
> 
> The mlx5_is_thread_alive function always returns false
> (terminated) regardless to the actual thread state.
> 
> Fixed to return the correct thread state.
> 
> Bugzilla ID: 1089
> Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-18 11:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12  6:49 [PATCH] net/mlx5: fix thread termination check on Windows Tal Shnaiderman
2022-10-12  7:55 ` Slava Ovsiienko
2022-10-18 11:47 ` Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).