From: Raslan Darawsheh <rasland@nvidia.com>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Slava Ovsiienko <viacheslavo@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Matan Azrad <matan@nvidia.com>
Subject: RE: [PATCH] net/mlx5: relax headroom assertion
Date: Thu, 13 Jan 2022 08:59:41 +0000 [thread overview]
Message-ID: <MN2PR12MB3086D7DB232F67C19EEA7828CF539@MN2PR12MB3086.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211228092043.3360072-1-dkozlyuk@nvidia.com>
Hi,
> -----Original Message-----
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Sent: Tuesday, December 28, 2021 11:21 AM
> To: dev@dpdk.org
> Cc: Slava Ovsiienko <viacheslavo@nvidia.com>; stable@dpdk.org; Matan
> Azrad <matan@nvidia.com>
> Subject: [PATCH] net/mlx5: relax headroom assertion
>
> A debug assertion in Single-Packet Receive Queue (SPRQ) mode required all
> Rx mbufs to have a 128 byte headroom, based on the assumption that
> rte_pktmbuf_init() sets it.
> However, rte_pktmbuf_init() may set a smaller headroom if the dataroom is
> insufficient, e.g. this is a natural case for split buffer segments. The
> headroom can also be larger.
> Only check the headroom size when vectored Rx routines are used because
> they rely on it. Relax the assertion to require sufficient headroom size, not an
> exact one.
>
> Fixes: a0a45e8af723 ("net/mlx5: configure Rx queue for buffer split")
> Cc: viacheslavo@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Patch rebased and applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2022-01-13 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 9:20 Dmitry Kozlyuk
2022-01-13 8:59 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB3086D7DB232F67C19EEA7828CF539@MN2PR12MB3086.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).