From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C9A6A00C3; Thu, 13 Jan 2022 09:59:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79AB24068E; Thu, 13 Jan 2022 09:59:44 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2072.outbound.protection.outlook.com [40.107.93.72]) by mails.dpdk.org (Postfix) with ESMTP id 3CCED40150; Thu, 13 Jan 2022 09:59:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SSdfE3bjTb6R9l38sisv+KxNiWoteo0IlATvxezdN8K5/vrH5jQimnVLs8i0t4PQWT/3v+VlLuPyg9kJN8C312vYz9JoTpAsR7Is9RBqsNoSr/qLGJIJz374nfe/1TgoKccx2ZXRv8pAUZr12F2ziGG6bjOFfHAIeKBG1YvZ8moMmz/UM7KxhIEg3sRRpPYBd0hLA+a8F1zYwpfZfpND+edPcoJPrWayx/J4wR6ArfPED0xSedRkUxO4zVGSh7uzx9uzxgqSeyH7w/2eTVAy7Reu3C2T1SQ/aaBOAHvsGGABpVzmvRPYkQM7Xcbz/7Nwe3uKF/GH1e3F4TEusWihwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=36wnmxZ/rj4dscWaaGp7t7Y/uwJoNtLq34MWIi6MJPk=; b=gZM74CFPxNQRxYFNn9xbZDc6b0zNiEq+vAZG7kg9mQzRSCUVs0UN46UiVSQEeKinpsgmKnpp8++lUh3vjWcL2DDznaOqpax0tSDYWQpieRqZSn3RYMalDT3vDEjrPyHDCPLPR3t4V4+8C6i6HqxlQlNSnw9StO4WvXvKYnxeOLKPAwy2ohPUNQIkvznQTh4+nrYydwrDOcQXBLWtBcyVu6aJxZgbBLNjVEm4gzDw5siB5PIz881JryqSxGn15f8lhZ1oX9808m6rDoIlSiowpGOIPJQ/fV83L/ovIhOm94Ag6jmENMB9TQSqD2A1jPuRJ3ZOE86I/AzJxrgH2fxMbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=36wnmxZ/rj4dscWaaGp7t7Y/uwJoNtLq34MWIi6MJPk=; b=IsyS40U6WYk+An+8JoFHseY9F65Dw8Zkya2l/xSXpeU6YPbG06q8wTdk/1K3m84nyamD25sIhbKwuuwu8hiTcRZwJspY09fPjxMR4Vw0YAEw9rUq7O1s8kMoo43YeDZHMA+y3yw1E15w8rFeHhcCNTRnmhVTR5C1H6sNO8krlloOWT2tQHDJ2V5oST+0TUsfLSYSnAJ72kwVEn2jTrDvXTw23h5DE/KF6b+PTTPvTSidKl+xXpxx23JYix7OYI078Z7nBkdIaDId/tOjbBoR7qA0hObS/4A7b8uMsI++r36rhRB481EkXyI4t2MmkTYV0JyvE8+TXeMtdcEtyr1PSQ== Received: from MN2PR12MB3086.namprd12.prod.outlook.com (2603:10b6:208:c7::14) by DM6PR12MB3801.namprd12.prod.outlook.com (2603:10b6:5:1cc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Thu, 13 Jan 2022 08:59:41 +0000 Received: from MN2PR12MB3086.namprd12.prod.outlook.com ([fe80::ec00:d95a:226f:ad24]) by MN2PR12MB3086.namprd12.prod.outlook.com ([fe80::ec00:d95a:226f:ad24%6]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 08:59:41 +0000 From: Raslan Darawsheh To: Dmitry Kozlyuk , "dev@dpdk.org" CC: Slava Ovsiienko , "stable@dpdk.org" , Matan Azrad Subject: RE: [PATCH] net/mlx5: relax headroom assertion Thread-Topic: [PATCH] net/mlx5: relax headroom assertion Thread-Index: AQHX+8w/McOVCv9yI0mdHFOboeMWQaxgwB7w Date: Thu, 13 Jan 2022 08:59:41 +0000 Message-ID: References: <20211228092043.3360072-1-dkozlyuk@nvidia.com> In-Reply-To: <20211228092043.3360072-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 645bd3b4-39f7-4b6c-0f46-08d9d6730951 x-ms-traffictypediagnostic: DM6PR12MB3801:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5uyH/kUCeNfgK+fm5uhONrkacvP+Z4F5ZBvSsN4OunUx1iRVhyRdliQTrDkew/S9W3r+xEw9tsnM8mFbjdkvx+XLIf1+okgUHK3EcK0iNekM7KzlMMPa8qRBYmZIerP5i6hDq6z7tYSMMGD/QkRPheuUKjJUDKcN6csuNJIX428z2nRwVdOPqJ53to9/th4h8eIkm0l5nVhiKJ0PsJDjgrmPz1fJdLDJIJ3IKAAWIfQmSsMJssXwf6+7abyO0vGh9ksQo2hycCAEZjnLc0WfQ2WTmR/tEP/UeykVsXI1jj5aXFft9TIDLJwiZKoaT5JjyOGfURoyFmzqKQ/0fN1Z8Q5ewOk3HP1Bd7rEkNFapAlGvOz9kG1eKHLR8dsT3P5UCvaV6+hlpbvH65/Ta1u1GLD+Ka4us8puuqsUQxRUUN48eqOKkgOhHxQ21E2AkTXU/cM3qzjYNCyfcjQuNmnVnx1X0LMSIcUGR3tSK/uFhGN+D07fCZDCv1/jEJJ+LfzjJVHqV7e+ZZT/NfyUlrCG3U64+QKovKsqrqwCd2cZ6Q3cIuwgEqSzqo2QhqoveqMIxBTVi9LPc1MqwHtQlWej+SBcAECkEIhb+aOakMHT0MT11Fs2z3bVsbOig0GY0fkXKcA8IYU2/n0EtiBjwoFMwYFdp61UJBmvGY35fsGhX01yOHYLx4hmP4M2uRYO/piKycPLpqmgcy7XScK4fEmJrw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3086.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(66946007)(55016003)(66446008)(66476007)(64756008)(54906003)(76116006)(52536014)(9686003)(83380400001)(66556008)(186003)(508600001)(2906002)(26005)(38070700005)(7696005)(33656002)(86362001)(8936002)(6506007)(122000001)(316002)(53546011)(5660300002)(110136005)(71200400001)(107886003)(450100002)(38100700002)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m3f/XL0PFxIObSsh2S26OCV6IxPt6j/qndz4HBBDADG6zvD2PLH+xNyD/D84?= =?us-ascii?Q?qh19nJAsUUp3YZbky24Zwo3dPmE8xF9tNuq3ctx0FxTo7x9gbrBp6iGzLe+J?= =?us-ascii?Q?PNWzXN/eefcv9knlpPtw8rLKlA3aCFKX0z5qEA2BDwGPWFF3cPGQif4nkZ2z?= =?us-ascii?Q?oQhJN9VgJEomFSj8BK9w4P9fYz9uwK75mu1lcIdJW11poSGQPT6fUZzoyDv6?= =?us-ascii?Q?f2tbFI7lsPOWBBXD02wU0aYX7tC5W2rI1Z1NEnve9VyDeWAU+E90gCMgJs9v?= =?us-ascii?Q?exsrftekk6dNs58fyLmPHvhdiZarpbZWVk3iOLHwvNZ2idA/M39yeCn5ET6y?= =?us-ascii?Q?vqOWsfwiJu/44cK/PGEWhEnMR3KoLshmlFP6FdeN/Ut6PltPf70L9vTjmXcI?= =?us-ascii?Q?yQ6kKRq4ZR1DJUOD8aKV0/Sc2quG3eTHIM0IYoLIq0pRrXqdu/EKzJEhs7dJ?= =?us-ascii?Q?EVe0d93uIx+yZZO+CjC83HxqQhUR65608knUg4UROi5bxxjbtqfikRW9N4yn?= =?us-ascii?Q?VkmHhSbMMwIcbGLLOG4eOjdBjk0rfBScr5yBKtx7o0kuWVR0hSdbzRpmfiBM?= =?us-ascii?Q?BfsAu/zOlnLZPe7fDiIqT1LwZtTtiKt9VMuqXqojuURz1s0SoTdnfytU/2af?= =?us-ascii?Q?/s7DTXl8K6Gc9xf2eAChSJzXJUGeVlMGjdJbGL1qsIrL0EQ3AOBn4s2b7Tgj?= =?us-ascii?Q?HV5XMkFJEuoh5ACUAR16v+/g4kO9pmXD6lY4SqBkUSNQqOO9/iMOSd/nPwyM?= =?us-ascii?Q?Y4LLkOgIedxSbbZtTLwE9I3m76I5/z5fnh55D+m3tHuAJ1dx89LsjY4HNvfj?= =?us-ascii?Q?iRNxEHw5FqfGl2cu1QIybuUus2qqI+bHnsf8efvWVe8MzE3iXnAmELyiWsLz?= =?us-ascii?Q?q+J/f/AWvB84HgWtNd8eMuXmLQZCOWkpPttk2mCNGsKz54uEaTBR71BzYvph?= =?us-ascii?Q?9trOP24/gfiO3wsWalM2kiWw2RibgBKUQobTdQl4X2zFcBz0o8DHO/04QieE?= =?us-ascii?Q?Dh6pqhYDYAIGGNDhNOGB1kv/qA4yhhHdCvgVxKzrSHCeiH9Mod/qcyk1ZhmW?= =?us-ascii?Q?2KsKHm7e0uh/8tgyTlV2STMzreCYqbDhYderyi7mZEAxARkh+B08yjx4rgUX?= =?us-ascii?Q?vQJvkNCTD25R98sfgSK1zUX9PyIl4Fl3wX9JOa4bwuD5SgsY/c+4Jw1fFyii?= =?us-ascii?Q?pUDWjC21lvkh0WHoT94PmFQdRhXFQX2wPAXqwidNlRzDhJeYaNODVKiLiTJ3?= =?us-ascii?Q?sQlX6zK0aQkBnotyq9CerOaNNgJoYYEsipE1S8EX+rcUzhf30gXTW3AkDjUd?= =?us-ascii?Q?yobcTWNqo5Sg4dfcacBHecuRWXWlnlI6WcbmYseP5ODZSuhfJjobPax4aErN?= =?us-ascii?Q?pVQddnkO3eJtS478yMQkcipF9mccBRsvlmXGnaevQ1Al+oFcnbjtoUgXimZ1?= =?us-ascii?Q?57aSPy0rhkwQL9EPMqVy/rCVrriaG+/+WRsatGs6fDjguge+8kPvP9Jie4mn?= =?us-ascii?Q?af3pXpQq2JB9C26KMW28ietSV1CrLJ+p0JUhRYcpkxMFp39b923MSSXnXhxH?= =?us-ascii?Q?QvTlL99Tn1RJJyD8oSD7KWodRkc0tlamjipYDnzABU36e+ya5HSMgw4y0T5G?= =?us-ascii?Q?pQhVuv80//TW0ACIfDCcGbY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3086.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 645bd3b4-39f7-4b6c-0f46-08d9d6730951 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 08:59:41.4432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sSgBjyJdMsQaLGp2owJduHXR30KA6enqsFnMBiOeTF5+KlphXSl3b8kHaqmk954ftYHLUjHpOgHlAEhB+Xr+Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3801 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Tuesday, December 28, 2021 11:21 AM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; stable@dpdk.org; Matan > Azrad > Subject: [PATCH] net/mlx5: relax headroom assertion >=20 > A debug assertion in Single-Packet Receive Queue (SPRQ) mode required all > Rx mbufs to have a 128 byte headroom, based on the assumption that > rte_pktmbuf_init() sets it. > However, rte_pktmbuf_init() may set a smaller headroom if the dataroom is > insufficient, e.g. this is a natural case for split buffer segments. The > headroom can also be larger. > Only check the headroom size when vectored Rx routines are used because > they rely on it. Relax the assertion to require sufficient headroom size,= not an > exact one. >=20 > Fixes: a0a45e8af723 ("net/mlx5: configure Rx queue for buffer split") > Cc: viacheslavo@nvidia.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Dmitry Kozlyuk > Acked-by: Matan Azrad Patch rebased and applied to next-net-mlx, Kindest regards, Raslan Darawsheh