From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C54D7A00C2; Mon, 23 May 2022 16:10:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B1B24014F; Mon, 23 May 2022 16:10:11 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2067.outbound.protection.outlook.com [40.107.92.67]) by mails.dpdk.org (Postfix) with ESMTP id 8B6C940141 for ; Mon, 23 May 2022 16:10:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mV55nCYAuq+sRG457RRbrcodXyyzxAHKLHLbuS9K4pc7/JNubkTMkdzBkF/H1rvkxeGEEaKIT0gysQIjccBBPujXyMYNC/lqCE5EjGZ01cPJ9b5ksIIeeRB0xXrpm18LoXtVAMkmRm4kMKxwcKJtMxi442EhpDUwUqIDen6yBfTHtORhE+SvCvXva+0suOVtOXg2TBLmtcw7xb58hJKZMTkqSnBLF2nfs8NiKRMdivsZYutB/LIWwhWZDAbjykUwww7URp+tn5xv0V3dc2ezxOdIQhIYDGMF3Usk47NuE/18Pg7Jfydusbilf1hnQueF2YPezzf3W2c+iW9wvhZmZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oR1Jn0HJFKY65GAXqRBkzY6q7cHC5MMZDMsHqrxhtcw=; b=Q+/K4TRBdCFlJArvgt4Qw1ky71kEiCo4dTJJO9pC3eZ3o134blm20G9Rd9qP7mciw2pgZrFzoE+elkyE39Tk7npP5ZJYRnFvdPi1Mt0U6cKwuzKs/BWPnwg//OBq0jyXnw6W6nsg8Ij0cPJ+TN1xly3N/Esr7HNnAZhfNi3j03zsN4dLviPEQD5p2Z02y3Pqzj2dR3jAtSgFtQiKhugLb4T7MQcxt9u7ppcZ1nYrU/ni31TIhOUnJCmjfKLaLfgr0gaPi5uhHGRW+ejQmnbykQYUlFGO7QwWVWBWw8BKLgkTpxpfjHrw0P+lPNKDiZzUeCwZRKjzmmz1Qe0WrWWbCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oR1Jn0HJFKY65GAXqRBkzY6q7cHC5MMZDMsHqrxhtcw=; b=GoZRuExX7VM6mULFXoJBaRq6I0YK1osdgsh79iUOJanoqspGJ8JAfa7MF/jGfuZqUvr8NeqwW8s44YfYQ0ki9Rmy6HF9CW70nLbGD5cCpTKgTvyJro9du1xqa6wPy9YK241SPXx9/GGiQps0Dwrxr37GZAXuskt8WPHvBLTfuSrOAfCVrDhSMXe3KnWQigwSaXVBc14Xgc6b3aBmXZrgNNfQjSLYEm5Kx2Yfh+bLjUyDLiDR77LFTABccGTVe/eR/bgbw1hfLn5u1LKb46pd4IzpFMxluLPY6eZX7aZCMzHyJzw3lePm1nXIGAyeeHGJxl8IKcBO0Rr/vZneavo6nQ== Received: from MN2PR12MB3647.namprd12.prod.outlook.com (2603:10b6:208:c4::17) by DM5PR12MB1404.namprd12.prod.outlook.com (2603:10b6:3:77::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Mon, 23 May 2022 14:10:07 +0000 Received: from MN2PR12MB3647.namprd12.prod.outlook.com ([fe80::f831:cec1:9c49:5988]) by MN2PR12MB3647.namprd12.prod.outlook.com ([fe80::f831:cec1:9c49:5988%6]) with mapi id 15.20.5273.022; Mon, 23 May 2022 14:10:07 +0000 From: Spike Du To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , =?iso-8859-1?Q?Morten_Br=F8rup?= CC: Matan Azrad , Slava Ovsiienko , Ori Kam , "dev@dpdk.org" , Raslan Darawsheh Subject: RE: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark Thread-Topic: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark Thread-Index: AQHYbmtqAz+l86Nfv02itzUhoBl7mq0sS1MAgAA0yLA= Date: Mon, 23 May 2022 14:10:07 +0000 Message-ID: References: <20220506035645.4101714-1-spiked@nvidia.com> <20220522055900.417282-4-spiked@nvidia.com> <98CBD80474FA8B44BF855DF32C47DC35D87097@smartserver.smartshare.dk> <3249537.9LS3J3VOpE@thomas> In-Reply-To: <3249537.9LS3J3VOpE@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41dd3f06-d7f9-47e2-2416-08da3cc5f0c1 x-ms-traffictypediagnostic: DM5PR12MB1404:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M1MxYG34Ls3oELEm91O8rR21kEsT2ktVYR1XtByxb7Q8CCxg9oAb/Hy574L4yTrotmxAUYX0l4j8KPtL+2uAnwe0/GuLSlXweNYAskX6TMpwMbA0K1ZEqW8CopltlrSWIPZ4nMrEMSTXX0U8GO+mRL+2gfszuZ+AsQqzziriqRP5s45UghuUAsLzi9MX8pJkDc5KLdRFJNQryBqhRNJxajnSzmfQC1dwsmnARfTpW9Kn+GQIp4l0hgWIb1Tkdp5lqZAz2GRR/POIlMtQByP8laA/lzk6/Qp+daxcxE4G9lxyaPg8+flfxPaWXzJaSr5jerfQ9X8C6XMUnoTQmmZCfq11btA7BkYOMCIqMF1PV6gWaFrjhAKH1cBuSM0kDPp1+8OAc9hdN9dQysyK1+mFha02qV5b+I1GTitNH4VFRsLV63pOXSq+M2BILyUZVmZgEu4DoxQk8WZMB5Ud7YxLeqSOxatrcguPRZ2/NGUeusVHMJBunk+6uMmTiVPwxxZzqqlNEI/o6b/HWANwMig4ZV5XLFZcbhwvi7yaFuK8u7kstJNLMqY4HvmsUU3tqSIel5r4nz6GxGm20oLKiCBvVGy+Ejnh2kLCIUYa3yKEvAsDiMe0wq6sCEZPpNz7lyMMlyXUqTgm5kITtC0jgdiu/vTCr0qJy6D96ccmCkM0epizsAVXesBkn4zd1N35H9zEtSJ0ZiK2GnZR+/QSgsDqVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3647.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(4326008)(8676002)(122000001)(110136005)(9686003)(38100700002)(38070700005)(53546011)(186003)(76116006)(66556008)(66946007)(64756008)(66446008)(66476007)(6506007)(71200400001)(7696005)(54906003)(4744005)(8936002)(83380400001)(33656002)(2906002)(66574015)(86362001)(508600001)(52536014)(26005)(5660300002)(107886003)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?T8dRMjv/g+rfgoe0tBO9fKtSLMdLAIYH7ltI/Wq6OlWvVTC4tY9lhuq+ux?= =?iso-8859-1?Q?3rM/xSpxObqKRTM49EkKsORi6xu0x7MfjEm3/Z9Jouk0HBa4ixWGEa3wxI?= =?iso-8859-1?Q?QIRp9g1RaBAVON9ePXpW2WxOk0i9dAeQTWujR2hI4CG9zevowYs05tQ3oj?= =?iso-8859-1?Q?vFohcQZyIylTI24upjPz8uGsvJEbgm+4ukE0Q8zZSLk7s+B1IUbbaRanfO?= =?iso-8859-1?Q?j7j+i86s5xT1Em+c9lkfz59s/lnMUZ88/+hPCh6j/s9vIgdnN0uyhgchqt?= =?iso-8859-1?Q?xQZbiVBPHk2iweCdAvcsRmGWh/tkIOHeCDzWyAGLJNwk6OGPdcjpGf0iGZ?= =?iso-8859-1?Q?dMIUb4V4Z6ZWynuUldN6AuXJ8L9rOz5h6qvQ00PEGpZxTbM99m4WkSFKAg?= =?iso-8859-1?Q?Y2GOUcrhXu3NzRCPIzbJNS1u9gEUYIEeMqgJckJLmzO0bTK6CiF/kd4Qfc?= =?iso-8859-1?Q?wdvWpl0GtLTIaDB3RS4mH6gyNDt1nikmFZk3zKvWSTVVObdr2Fuju2xpdW?= =?iso-8859-1?Q?RZwJSKb9xdMHMD+W6Dl6uEbBPLqaAKMbsfIMgVsVaG29fILKDv3fV+1AMF?= =?iso-8859-1?Q?kO3YWECrk+XVvrtv/C9GmOIfMYc4hfVXV97RYxP56zpFgMJ0qMuGQfCd2L?= =?iso-8859-1?Q?Gfs5o5VkM4NdlCxSnAlX2QA1jzghhcsojnO/I2Jeml6rO1S8fbJ+0PcJ2P?= =?iso-8859-1?Q?5U5B7abLohJS2UpBu5UZYvIeIgf8U8fQqXakYv7Knv8SC3lb8oEnzRbkHc?= =?iso-8859-1?Q?TnQoVJnBD5hZTDQwvjHWGt1UahcikzG1nway8UolvVQiD7nIDp5r74D56B?= =?iso-8859-1?Q?b35LBlH1HG7sEjZolo/M4ekP7VbmmrekUZ6brKn0mpd4psRA/XzCV1DbN8?= =?iso-8859-1?Q?Lccx9EbpfhiKcu9ALpDW7I5FBQIgKpqCa15p9x9wfZ/KX2fXLZR+A3PJfe?= =?iso-8859-1?Q?d8+RnhQiisaYM8Rpux6bv/bB0Jy5hX9e9/H5qoCGSgUdLL+tYzIacv90dh?= =?iso-8859-1?Q?0zIhjaqwsH33/CauxBlaLvY0/TkPB9v9lwZVgmZU2M5FW5XA0ilu5Pz1Qs?= =?iso-8859-1?Q?y4TwFu2hLMGHY/ydIhnM3ye2D6y93yIRTJnfIh+bCmV8lCyu/rnA/9UegY?= =?iso-8859-1?Q?ah1abo14s5cGzcDOALTIJBEJsZg9LRSF329G6aF1BIZ/qanYzzsSuhXcA4?= =?iso-8859-1?Q?1PnbwsGnAyzJJfmpIwaAq40oCv+BmeoOOXZ6+88xcIDbRzQ9SLvEuSUbCM?= =?iso-8859-1?Q?mJ/khwV3v3fLmHrAFtulmUKLt4tymyrY3CEQtjK6IAIJn3zNrxLQlEergb?= =?iso-8859-1?Q?1yzfkH2dpn8Ncskt45xON6A+HNC/TzWJPJGLVpVLLGGVXjhRc2Mt/PA/iZ?= =?iso-8859-1?Q?+6I+Ty9nufZJ78LWrYufGEbkEUp/diaOE1FtDKI/GWpvVVIv2xXWsprWyc?= =?iso-8859-1?Q?AoT2toCnNLGIit6uFrm4lgKVbIyEDI2WmRIEWAv67XN6mAe4j7YM90vR04?= =?iso-8859-1?Q?AOPkBAlH2+D4SIInRZzohLiH4EjeT//uhZAq5hr6u35VBsYf8YDeKPNCUg?= =?iso-8859-1?Q?hAFEpG0IJtONLsfSE0D+hOpiEBAGUvgoMlSuImwIyUKxjUQyKbqh/xx3bp?= =?iso-8859-1?Q?MY9/JoeaGq+pdyTo5ADA/oG8eIESo+7cPPWdWKBFcXXsgS3rHoJ1fYPVaF?= =?iso-8859-1?Q?/hS5/er+4ytTdhUEgnQHW/huGMWaE41M1XKDFMCV3G0QDjHuw1BmHMFVIK?= =?iso-8859-1?Q?9F5HR+4NUh2YFsI6Mys9KLX9jNzFEgVy6gvUYiR0D/IWCv?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3647.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41dd3f06-d7f9-47e2-2416-08da3cc5f0c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 14:10:07.1447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TcIsJXOhw16Vhqyz32++444kuISkmbZCxinIzyoDUxjlePagqN/HWyyoA2LtrgHDmBCrWCS9eZ11WuszngIMCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1404 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, May 23, 2022 6:59 PM > To: Spike Du ; Morten Br=F8rup > > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; dev@dpdk.org; > Raslan Darawsheh > Subject: Re: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermar= k >=20 > External email: Use caution opening links or attachments >=20 >=20 > 23/05/2022 08:07, Morten Br=F8rup: > > > + uint8_t lwm; > > > > Why percentage, why not 1/128th, or 1/16th? 2^N seems more logical, and > I wonder if such high granularity is really necessary. Just a thought, it= 's not > important. >=20 > I think percentage is the easiest to understand and to share with other t= eams > in design documents. >=20 > > If you stick with percentage, it only needs 7 bits, and you can make th= e > remaining one bit reserved. Agree, will change to use 7 bits. > > > > Also, please add here that 0 means disable. Sure. >=20 > Good idea. >=20