From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63811A04FD; Mon, 23 May 2022 04:18:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49FD34014F; Mon, 23 May 2022 04:18:15 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2063.outbound.protection.outlook.com [40.107.236.63]) by mails.dpdk.org (Postfix) with ESMTP id D096040040 for ; Mon, 23 May 2022 04:18:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gUmPO3gK4ORpAp1dN32jmW1sXbR9QUW8TaC3SzGWAvhurdZC2ittL99lNxXHd/vzfSZGRnYqAKXDRgwAiw7WOxSYZpiWOvWmKN5hWia2VV298FBtkKj4GflM10TrGNkkFlxYRkYavycu1tsvgF/mJ6vYzteYsS2tcVHSHrEPMsdRX84XsEvaVPvvCfMcYC+B1ImR9zUEl2yWdCm+e1/QvgSCOfmpOxO/4vX7fi2vJC7/6ujLqyjECREbCRI0cvqWaBi56PkS342Onk93jTUD83CLN5LtFS8OSer+DNFHvLFwewCu3AFjjW5Q0ZQtz0A6cPDdLk/UtH4LBYrD+9RvaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YiJytG6z9H6vwDN7bjxhaLOkYxAJijGKIXvCYRSNMAw=; b=AV+ebckoKZUKBYICpX2xqqA9VXFcQwjI9vyz2I+RUzk+E+kD99U70OUxb2+XPBKXj4eyRd9UCWqXJNDqb7dKNbmZtOIS1nPPNVSq9tD76lVdOFRqb8Qkd6kxU6To/pKPkK3iJFQhM3J03DE6K/Jq1Jw0g2uRIlgrf4zPraAvSgbYmlmszFbueO6dnoAvjSfp+GVdTLCo40UKkAfDW4MZQjTtHlwUBqaB0KzN8rrmuU+EpF2i3/DITbMboqr9uleuaeUOdoByY0Z6Iz1Z2Pkf/hwqBKRNElvVZzurVDihecuK/Si6bTVsk3+cTb4MVT8PPYT2KoyafvKvOx8wYpr42Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YiJytG6z9H6vwDN7bjxhaLOkYxAJijGKIXvCYRSNMAw=; b=dksxXVxKztN+tTWT3JZsF7W7IFkuDEuy7LaOXjj5con1cEA/IjxFlFmfu2aQaRhOPJAduYqK05sWMEsJB8zZ3jO4y0SfHOpo9WhqCewPNbkqGwShng0dxD6TGnlP5dafhv3m3rVbTh9rOioRF7EXDOxaVpt10lKcOkMu1MPGaBpeNQE8OhpuajTEtzqLCgo8Sxd80FBKiCuMuFPQZxEw6Es4eTcf4hFkooiDNJtxRyEUfioXl3j8r34PgAs627IkF3qYKth4nIJX+MgXf2ESJl7m+0YFaHDyqms7nDXOZCDgCW6yYwQVmgIK6YKsor3Nfw7UR+6NagiRmGfnrj6EWw== Received: from MN2PR12MB3647.namprd12.prod.outlook.com (2603:10b6:208:c4::17) by MWHPR1201MB2557.namprd12.prod.outlook.com (2603:10b6:300:e4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Mon, 23 May 2022 02:18:06 +0000 Received: from MN2PR12MB3647.namprd12.prod.outlook.com ([fe80::f831:cec1:9c49:5988]) by MN2PR12MB3647.namprd12.prod.outlook.com ([fe80::f831:cec1:9c49:5988%6]) with mapi id 15.20.5273.022; Mon, 23 May 2022 02:18:06 +0000 From: Spike Du To: Stephen Hemminger CC: Matan Azrad , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "dev@dpdk.org" , Raslan Darawsheh Subject: RE: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark Thread-Topic: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark Thread-Index: AQHYbfAYAz+l86Nfv02itzUhoBl7mq0ruddg Date: Mon, 23 May 2022 02:18:05 +0000 Message-ID: References: <20220506035645.4101714-1-spiked@nvidia.com> <20220522055900.417282-1-spiked@nvidia.com> <20220522055900.417282-4-spiked@nvidia.com> <20220522082458.621e878d@hermes.local> In-Reply-To: <20220522082458.621e878d@hermes.local> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e39c71ec-bc19-4f29-9bb6-08da3c62790f x-ms-traffictypediagnostic: MWHPR1201MB2557:EE_ x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WXWz2dUHKHEGJjBpkORVQPc8hOcEVUcd/8JHHpUXwT6iL7qLsceqLfRj79lFw5ZWDFlAhFBq5HTvZpN11+zL0x4iW8u4d/dSVKP1AMXVsHkqKaPx/cIoeDgy/w3eRpv30jmJ+kgANRPAa4QlCNDTzkFJoy/XnkFga2Bopyukp8O/LqAHIR5SyRwtCOZnz5LI82NmbYnU5fJz6HKdva36hrYrJ/S0uQ+dFx73y1XlXSb93eDusXXoXPgFtZZ0XchCY2vkOz9WCl+Alrr8qQpvfS5BXU6o3BWk8nUghQ4QDBwlOxEWxJ3h5zRVLxe7cRDRCHaWJztwb3hR74f+sghM4PNABrcnVhBvk1ZJI8qPGxREXbC5o4McXZRrUyrZ+DX5dhPq9Khktm+3SFeBA6CC5un8sPggX8g6nBxc+QPYHPTGJcVoW18jNv59X2/TAJghRlG4zbKyzHiepaiGlMuyCP0NtQ30aRCN7TlanFhRUerfaphMmgW0TfMriC4HH3+lRwlhOYwob5gPoDmE5UMKKprXUSGEF1T9OApjR/Zviq7diBcs9+HoBf/lN2krIa5egPeQgwW88EFGK0lNoq+ZJ35K821ZBRI5FxqmXjjFFIxgwiPaSDDZ9y07fC2NTReUSsyNOpK1gK468oUBUAzE2fxdo28WlvRItjZZXAylJA2BGOUtCQB8u1ObgpTdkIjng/e25GS++KJJ9UryQTb6HA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3647.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(53546011)(316002)(6506007)(86362001)(5660300002)(64756008)(26005)(9686003)(38100700002)(38070700005)(2906002)(71200400001)(7696005)(8676002)(4326008)(6916009)(54906003)(33656002)(66446008)(66556008)(66476007)(76116006)(8936002)(186003)(508600001)(52536014)(107886003)(83380400001)(122000001)(55016003)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WB1ZmIjgtdyjHpQTcPOwM/wCYd6vScMw4gZfqgiFhZg4vGt5nGQvfLmg56BB?= =?us-ascii?Q?6w2dpMIqE/qgSLaP7lS9AmFkeWTGweLKqbTmNp0m5S4h9UWjoG8L8RMw1c/v?= =?us-ascii?Q?KD0EMBEhZZrvbfdv7yu205C7TjW162wAzcsAHSHHzM11NFJAbDcolf4Xds2O?= =?us-ascii?Q?bdYkxxM8SFH636cgOzA3NCp45zz9H42/YN4t/Le1d1nUR5oXVU487fjJjxwX?= =?us-ascii?Q?/pkqA/PTcMwb5PWBX5tYzMkdzaUcej+QeiU1AadkcgC89ao+W5adLlKv5pYS?= =?us-ascii?Q?z7mqg40AaUACMRrkvdIoySNA6jd/fSjxmnoBrKmGf8+0DzYJonK3/9f53aIW?= =?us-ascii?Q?GXG71F9PEzOgb/kqgNT+Fg3+IrOMcYMzOfM/K0A1RgOsrXCeQOIPtC+AjSCE?= =?us-ascii?Q?mhgkGxKdwwe5/2jqkhqHOuDSSYN3MI1K37MeK1B4VXOPGQtOM3+lrUh/3voW?= =?us-ascii?Q?IDxZWTFw8YKo3K3j1CyS1knLfWSgjXRYDHhN6oZKwOotgwwDJgr1YWQzUVvb?= =?us-ascii?Q?ySS3HYHDSly74GUwTJqV9AzLUtGY66aCHSMAGT8Rl0gazhW7VIbdlVfMvw2/?= =?us-ascii?Q?dH8uBsLlsfNXA14mR1zM7z0K3bNn15J4Ro0ioVyBuikG/Zn/RIh15C4HzvYr?= =?us-ascii?Q?WFhayBsPo8hosxbquNlrtNoNwp8JAO9iJtnMUS1dSsTk2ddAaUxVUl3tp+Pp?= =?us-ascii?Q?9bQgb7c5K+dOl5m97NDSbddzSWlyt6EPNd/j/QFIY81PikHjiDeT/ylBwknt?= =?us-ascii?Q?4sIBuN0O22BzjgCHPYoBcei2ny0q8kDOzmr9CHin3rC7vXYSrI5+U+AzZgO+?= =?us-ascii?Q?08ZpxCE6lyBFeCaws3Tbaz9/+SkYJbqnqAMdvG6JC5KJcI4a9dsdl2H1zns2?= =?us-ascii?Q?AKy+Osw69IxEChGx/hg98sRCO2ouMqNoJrVj2vkSRbig+e5areBCu2j2nUv/?= =?us-ascii?Q?VvG4LYLBma24bzhw+7McysOKtZGddwm8z7KJQOF6Fd1xQ6uyEXxRkiAXLMiW?= =?us-ascii?Q?t4OJe6zNdNAU0NMsmkJ1cEB8YZg1MwzJqs85DvpF05chSPH7y+QZeXZNhaa6?= =?us-ascii?Q?+2XI36WnyN1Wt5Tc/rHZ5rTE3/f+qlzAFH3eMrzZgOAM2dgYTGzG+lag7ucl?= =?us-ascii?Q?ptwPbKz0cJrzvrG2jcdhJEWeD5wLK8ymeuc+pQRMfGQbbaY+4pA2x4lbpF8d?= =?us-ascii?Q?uugmdUp7lmV7uvIyCc5BBPkfH61KBv/7YtmQL1fciRgYg6wizLSkka+x9qIh?= =?us-ascii?Q?pwvEHfPnrI0VHyxIR4M8u5V926wUbLYfvabGKJrPvSr4bXiFwE4SGt43M+jJ?= =?us-ascii?Q?fGDyj4TW869AOiXoDfsitWdWJMAVVaBJv2yPamzrSKDUCFk2kpw9uMLCc8V4?= =?us-ascii?Q?3KUlJtA/m36V3QieIi4ZINqGD1Gh3Ng1cEDjyjOU62C/qRmHEylWkJIWMxPp?= =?us-ascii?Q?eY/R984wEvBmApyjK+jAzyzdndr2C2kohDxfGOJ8vbK7dj/OlLGq2H12hQo/?= =?us-ascii?Q?LQuRV9t8rC8S4HGB2Ev7HA232pUJcwIvkcEDMubTATdy3bvbzQ1GlSV5GWDI?= =?us-ascii?Q?OKvY9AFOgbTqBkdOf+o7zCvJQuU3KCqut1RaHl2d2RjKjdhUrQ7O7CEuy+bM?= =?us-ascii?Q?zIUQz04CvYJcAFLxygwmblnzhRlzlCuTcOOVQonGGdd1/ucocbcp0OJk72K1?= =?us-ascii?Q?pNcDr0cWcL24tegqxONuX//ugT0JJvl9LVmFUDWR2oEgfGS2?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3647.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e39c71ec-bc19-4f29-9bb6-08da3c62790f X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 02:18:06.1249 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s/c1+zUIrovzGNfl7GvSWDzZekibSzBJEyIf0LPJ/QEruG0P9qP/8L6FWIS38+nFAWz5t8C2E82TIAOOAVu5dA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB2557 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Stephen Hemminger > Sent: Sunday, May 22, 2022 11:25 PM > To: Spike Du > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; dev@dpdk.org; > Raslan Darawsheh > Subject: Re: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermar= k >=20 > External email: Use caution opening links or attachments >=20 >=20 > On Sun, 22 May 2022 08:58:56 +0300 > Spike Du wrote: >=20 > > LWM(limit watermark) describes the fullness of a Rx queue. If the Rx > > queue fullness is above LWM, the device will trigger the event > > RTE_ETH_EVENT_RX_LWM. > > LWM is defined as a percentage of Rx queue size with valid value of > > [0,99]. > > Setting LWM to 0 means disable it, which is the default. > > When translate the percentage to queue descriptor number, the numbe > > should be bigger than 0 and less than queue size. > > Add LWM's configuration and query driver callbacks in eth_dev_ops. > > > > Signed-off-by: Spike Du >=20 > One other objection, please don't invent yet another event channel for th= is. > It should be part of existing Rx interrupt logic. I think this is misunderstanding, the "event channel" is a specific concept= in MLX5 PMD. For the DPDK common code like testpmd and event register/callback, I'm usin= g standard dpdk interfaces.=20