From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EBE9A04C7; Tue, 15 Sep 2020 10:00:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19F6C1BE8E; Tue, 15 Sep 2020 10:00:00 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id B4E25160 for ; Tue, 15 Sep 2020 09:59:58 +0200 (CEST) Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 15 Sep 2020 15:59:57 +0800 Received: from HKMAIL101.nvidia.com ([10.18.16.10]) by hkpgpgate101.nvidia.com (PGP Universal service); Tue, 15 Sep 2020 00:59:57 -0700 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Tue, 15 Sep 2020 00:59:57 -0700 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 15 Sep 2020 07:59:56 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.57) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 15 Sep 2020 07:59:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=btqCZ90SZHP8GAxjnCsmgfaf7tPRvOE6ZG8Td8l/5fxfUwbiJ8djKAU+2p9a8o/DQ4LpP5tMuAYAJQrcdQn6xhyWTYz9kXZwlujbNsk/V1EtbA2GZFk3NmobirX1JmS9sW99FsI9IxHACljxZNpD1VLrZfiue/fHOlB912yMLy6/Jku6nrLZUtsouVeoAt0gQH3ckqE+j7ZDnWjYhTh/Q4TcfJOH4KjKKag5YtNKj0cM06Ctd2Sjmv4Vq4PSFjm/MaDkrCWDg/L+L6v3dMNY9OpS1qtQWmengqMo8ZiIOiEdeWiLIbqTNZCCWeTxf7vCObat5buUtksUI28c4jVhtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8HozMpXBwoCzWtxgYR1Rr+LvLJluNiWHymJIORev6Mo=; b=mNaMjuq2yw4rkqCw2KJrTYXkl7i3wVNR89aSJqLfqMmXkbRc418f8j+nzeBJW2qSAxYHxtFtRDNe+pdL3mkU6t8VIlg5dyHTn14xwDhxhcVHuAnMhphL9a2DCpieBsauPfpFN7+gwKCjOe1otob8jHmrZbBP5iqWbo/xQcGhXClsRqbygF76QavlbVwgiKAHVhPBsrROH2+qTul56YxbeWVvJxohj03VnUurbtcSRB9IJ9PdwRQTqDEOjVOBQAq4NKWTBUv2flle0sr2cQ3OQwetI5frVtU4dyCjWEenwFuK7krVjjyqX5FXZu2FPS1iQaVni93aZ97+agb/VEsjCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB4286.namprd12.prod.outlook.com (2603:10b6:208:199::22) by BL0PR12MB4692.namprd12.prod.outlook.com (2603:10b6:208:82::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.17; Tue, 15 Sep 2020 07:59:54 +0000 Received: from MN2PR12MB4286.namprd12.prod.outlook.com ([fe80::61fd:a36e:cf4f:2d3f]) by MN2PR12MB4286.namprd12.prod.outlook.com ([fe80::61fd:a36e:cf4f:2d3f%9]) with mapi id 15.20.3370.019; Tue, 15 Sep 2020 07:59:54 +0000 From: Ori Kam To: Shiri Kuzin , "dev@dpdk.org" CC: Slava Ovsiienko , NBU-Contact-Adrien Mazarguil , Raslan Darawsheh Thread-Topic: [dpdk-dev] [RFC] ethdev: introduce GENEVE header extension item Thread-Index: AdZztd1BqhGC1RoKTme0ULehzxUbiwXfl/qQ Date: Tue, 15 Sep 2020 07:59:54 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39ee658a-a451-4b41-6216-08d8594d54ca x-ms-traffictypediagnostic: BL0PR12MB4692: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wLm3eCJA3XBQgT2r5n7qU8NMgIoGV0fKsZo8UGqZkHwBy5kUhbE3irYGOpFRM886iGNo0OAqWgvMehx9klIA7587kZjgl3c1EJaB3TzflwkkqWMakB4+P/8GeNHm+DH/bqDZXQ7WbZ050JcIBqeoEGWCQcZNS57UZiMkp9tA78xiimfTJ5gWERizvca6oE92AWhJ00uJOYcv+R2gUkpymV9QpoQtfKYV5Z8Pf1fv2SlGx+wtYjK37V7Nx/2RMz3IYXsOXBKFjbevTuctSnXuoFUpaVvY+xDeaSGToSR4fd7nIyujQvfXRJgfBYJS61Qr+KODqveFJuGblWuhGg7Q0Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4286.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(39860400002)(376002)(366004)(396003)(54906003)(8676002)(107886003)(478600001)(4326008)(66476007)(66446008)(6506007)(186003)(64756008)(76116006)(5660300002)(71200400001)(86362001)(66946007)(26005)(66556008)(33656002)(7696005)(316002)(52536014)(110136005)(83380400001)(55016002)(2906002)(9686003)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: sdZqkG1i8LZbEFUDkQ96s1vELuKvKeQN0WhpE17vnUBcO4oTXA5iWNcADRALEPPA96cXtkJBc5pxkpqfydh3Gp0qblDdzgVFhB1RXjAGP6d2p4PpI8LUNL8vfk/EdbXv6GP7SsPeEkx1Az0rraMElqqcuKJtxHEbbefhv3D7MMZhroux1bAjxyWah75cqff+t1NpQGK2MzODkpYX4bx8G1uf23P0H6acIyB1C1u8KrdM1X0yyjn8dM4Q3QV9tixJ7Hf7denGhnztAPMPnbpXyVAdyRGqDa/evztWl3VERwrb1HR8JsV1gGmNeDCEyszwEsnPteSpD2/o2x/F0JqDLC7EbTDQU+WnTGSWKdU6AEyh4/jV+aZkcYibKdfg6vLBo56OShyapgWbkRsOdV2oKwvbWR52k3VAE7bdADTOFnTZEyi1IYGwGMtSWKAvI6E578PIBGyGp1WvaAARj00XSETa3b+jfgi3jSYB4QBm+PWi3F3UXmofDVR8TWE6wPkbZSgDnlKSoNuVEbzki1JQ+J0zdK8weQYe1WR/5sb/hEAnC4GpUsJMDNu8YJusZvMX/eHFuxinpoNGyOyNyquNbheGFj3VvJ7rMumLZ6MPYiYwrczNflqC+N3RSMDtj0dgq/vQTm7cuh1VLsiuH1RCrQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4286.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39ee658a-a451-4b41-6216-08d8594d54ca X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Sep 2020 07:59:54.1126 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 59MAFckPnUYKzO80lw7j6HIz2c7Tn50TeBkHDKILUA67sUxv/RduQkfGJ1hOwAVk1DKClccHgFcb9IEStCS8EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4692 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600156797; bh=8HozMpXBwoCzWtxgYR1Rr+LvLJluNiWHymJIORev6Mo=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=H3dj7lhWwXA4KK+v/yF+pifOIAzI0klOKec15ZBe2I2C9krJkA+21DhPCwTrqnzE1 IfxHLbhwr9I8zsFA0BLR9343cK03uGGk7+5sL52gGBxOgjbz0iAYDcBhWA1wldymUy yfdndicnrofAN4pfQoSWRpxtECfTYLrCkykH+l/F1IT9PXI15kLUaw4f4enXeipBEz WUeP8z3h1cbJgll2Kiyz92QEfFEMQ2ZNqLhcby1j1fKiXpD2aTFX27mO0jYb98D60c omfLXwhC4iBJXyNeyjvfvO0PXFqQmlZEtE7PjtkEhu1vDEtgog50idZE2Pkf2vqWzK DGIMMDaCAnCig== Subject: Re: [dpdk-dev] [RFC] ethdev: introduce GENEVE header extension item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi=20 PSB, > -----Original Message----- > From: dev On Behalf Of Shiri Kuzin >=20 > The Geneve tunneling protocol is designed to allow > the user to specify some data context on the packet. > The header extension options is the mean intended > to present the user data. These ones are implemented > in TLV (Type-Length-Value) fashion, in order to > support these Geneve protocol feature we will > introduce the new item "rte_flow_item_geneve_option" >=20 > The support for new item will be added to testpmd > and include values and masks for the fields: > - class > - type > - data length > - data itself >=20 > The usage example: >=20 > "flow create 0 ingress pattern ipv4 / udp / > geneve / geneve_opt class is 102 type is 80 > type mask ff data is 10002 data mask is > 7fffffff / end actions drop / end " >=20 Can we have in the same flow number of such items? > New item will be added to testpmd to support > raw encap/decap action. >=20 > Signed-off-by: Shiri Kuzin > --- > lib/librte_ethdev/rte_flow.h | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) >=20 > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index da8bfa5..d04ee7c 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -347,6 +347,13 @@ enum rte_flow_item_type { > RTE_FLOW_ITEM_TYPE_GENEVE, >=20 > /** > + * Matches a GENEVE Variable Length Option. > + * > + * See struct rte_flow_item_geneve_option. > + */ > + RTE_FLOW_ITEM_TYPE_GENEVE_OPTION, > + > + /** > * Matches a VXLAN-GPE header. > * > * See struct rte_flow_item_vxlan_gpe. > @@ -1097,6 +1104,24 @@ struct rte_flow_item_geneve { > #endif >=20 > /** > + * RTE_FLOW_ITEM_TYPE_GENEVE_OPTION. > + * > + * Matches a GENEVE Variable Length Option > + */ > +struct rte_flow_item_geneve_option { > + rte_be16_t option_class; > + uint8_t option_type; > +#if RTE_BYTE_ORDER =3D=3D RTE_LITTLE_ENDIAN > + uint8_t length:5; > + uint8_t rsvd0:3; > +#else > + uint8_t rsvd0:3; > + uint8_t length:5; > +#endif > + uint8_t data[]; I think it will be better to use pointer and not empty array. Other option is to always take the max possible data size 32. > +}; > + > +/** > * RTE_FLOW_ITEM_TYPE_VXLAN_GPE (draft-ietf-nvo3-vxlan-gpe-05). > * > * Matches a VXLAN-GPE header. > -- > 1.8.3.1 Best, Ori