From: Ori Kam <orika@nvidia.com> To: Bing Zhao <bingz@nvidia.com>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>, "bernard.iremonger@intel.com" <bernard.iremonger@intel.com>, "beilei.xing@intel.com" <beilei.xing@intel.com>, "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH 2/4] ethdev: add new attributes to hairpin config Date: Sun, 4 Oct 2020 09:22:05 +0000 Message-ID: <MN2PR12MB428611074A676DB2C57C1B84D60F0@MN2PR12MB4286.namprd12.prod.outlook.com> (raw) In-Reply-To: <1601511962-21532-3-git-send-email-bingz@nvidia.com> Hi Bing, PSB, Best, Ori > -----Original Message----- > From: Bing Zhao <bingz@nvidia.com> > Sent: Thursday, October 1, 2020 3:26 AM > Subject: [PATCH 2/4] ethdev: add new attributes to hairpin config > > To support two ports hairpin mode and keep the backward compatibility > for the application, two new attribute members of hairpin queue > config structure are added. > > `tx_explicit` means if the application itself will insert the TX part > flow rules. If not set, PMD will insert the rules implicitly. > `manual_bind` means if the hairpin TX queue and peer RX queue will be > bound automatically during device start stage. > > Different TX and RX queue pairs could have different values, but it > is highly recommend that all paired queues between one egress and its > peer ingress ports have the same values, in order not to bring any > chaos to the system. The actual support of these attribute parameters > will be checked and decided by the PMD driver. > > In a single port hairpin, if both are zero without any setting, the > behavior will remain the same as before. It means no bind API needs > to be called and no TX flow rules need to be inserted manually by > the application. > > Signed-off-by: Bing Zhao <bingz@nvidia.com> > --- > lib/librte_ethdev/rte_ethdev.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index c3fb684..0cabff0 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1027,6 +1027,21 @@ struct rte_eth_hairpin_cap { > > #define RTE_ETH_MAX_HAIRPIN_PEERS 32 > > +/* > + * Hairpin queue attribute parameters. > + * Each TX queue and peer RX queue should have the same value. > + * Default value 0 is for backward-compatibility, the same behaviors should > + * remain if the value is not set (0). > + */ > +/**< Hairpin queues will be bound automatically */ > +#define RTE_ETH_HAIRPIN_BIND_AUTO (0) > +/**< Hairpin queues will be bound manually with bind API */ > +#define RTE_ETH_HAIRPIN_BIND_MANUAL (1) > +/**< Hairpin TX part flow rule will be inserted implicitly by PMD */ > +#define RTE_ETH_HAIRPIN_TXRULE_IMPLICIT (0) > +/**< Hairpin TX part flow rule will be inserted explicitly by APP */ > +#define RTE_ETH_HAIRPIN_TXRULE_EXPLICIT (1) > + Why do you need those defines if you are using bit fields? > /** > * @warning > * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > @@ -1046,6 +1061,9 @@ struct rte_eth_hairpin_peer { > */ > struct rte_eth_hairpin_conf { > uint16_t peer_count; /**< The number of peers. */ > + uint32_t reserved : 30; /**< Reserved bits. */ > + uint32_t tx_explicit : 1; /**< Explicit TX flow rule mode. */ > + uint32_t manual_bind : 1; /**< Manually bind hairpin queues. */ Why not place the new bits at the end? Also why do you place the reserved first? > struct rte_eth_hairpin_peer peers[RTE_ETH_MAX_HAIRPIN_PEERS]; > }; > > -- > 2.5.5
next prev parent reply other threads:[~2020-10-04 9:24 UTC|newest] Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-11 4:51 [dpdk-dev] [RFC] introduce support for hairpin between two ports Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 0/4] " Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 1/4] ethdev: add support for flow item transmit queue Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 2/4] testpmd: add item transmit queue in flow CLI Bing Zhao 2020-09-13 15:48 ` [dpdk-dev] [RFC PATCH v2 3/4] ethdev: add hairpin bind APIs Bing Zhao 2020-09-13 15:49 ` [dpdk-dev] [RFC PATCH v2 4/4] ethdev: add new attributes to hairpin queues config Bing Zhao 2020-10-01 0:25 ` [dpdk-dev] [PATCH 0/4] introduce support for hairpin between two ports Bing Zhao 2020-10-01 0:25 ` [dpdk-dev] [PATCH 1/4] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-04 9:20 ` Ori Kam 2020-10-07 11:21 ` Bing Zhao 2020-10-07 11:42 ` Ori Kam 2020-10-01 0:26 ` [dpdk-dev] [PATCH 2/4] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-04 9:22 ` Ori Kam [this message] 2020-10-07 11:32 ` Bing Zhao 2020-10-01 0:26 ` [dpdk-dev] [PATCH 3/4] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-04 9:34 ` Ori Kam 2020-10-07 11:34 ` Bing Zhao 2020-10-01 0:26 ` [dpdk-dev] [PATCH 4/4] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-04 9:39 ` Ori Kam 2020-10-07 11:36 ` Bing Zhao 2020-10-04 9:45 ` [dpdk-dev] [PATCH 0/4] introduce support for hairpin between two ports Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 0/6] " Bing Zhao 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-08 9:07 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 2/6] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-08 9:23 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 3/6] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-08 9:40 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 4/6] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-08 9:44 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 5/6] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-08 9:45 ` Ori Kam 2020-10-08 8:51 ` [dpdk-dev] [PATCH v2 6/6] doc: update for two ports hairpin mode Bing Zhao 2020-10-08 9:47 ` Ori Kam 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 0/6] introduce support for hairpin between two ports Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-14 14:35 ` Thomas Monjalon 2020-10-15 2:56 ` Bing Zhao 2020-10-15 7:31 ` Thomas Monjalon 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 2/6] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-12 21:37 ` Thomas Monjalon 2020-10-13 12:29 ` Bing Zhao 2020-10-13 12:41 ` Thomas Monjalon 2020-10-13 13:21 ` Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 3/6] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-08 12:31 ` Ori Kam 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 4/6] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 5/6] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-08 12:05 ` [dpdk-dev] [PATCH v3 6/6] doc: update for two ports hairpin mode Bing Zhao 2020-10-12 21:30 ` Thomas Monjalon 2020-10-13 1:13 ` Bing Zhao 2020-10-13 6:37 ` Thomas Monjalon 2020-10-13 6:40 ` Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 0/5] introduce support for hairpin between two ports Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-14 14:43 ` Thomas Monjalon 2020-10-15 2:59 ` Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 2/5] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-14 15:02 ` Thomas Monjalon 2020-10-15 4:03 ` Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-13 16:19 ` [dpdk-dev] [PATCH v4 5/5] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 0/5] introduce support for hairpin between two ports Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-15 10:34 ` Thomas Monjalon 2020-10-15 11:39 ` Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 2/5] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-15 10:46 ` Thomas Monjalon 2020-10-15 13:45 ` Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-15 5:35 ` [dpdk-dev] [PATCH v5 5/5] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 0/5] introduce support for hairpin between two ports Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 1/5] ethdev: add hairpin bind and unbind APIs Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 2/5] ethdev: add new attributes to hairpin config Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 3/5] ethdev: add API to get hairpin peer ports list Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 4/5] ethdev: add APIs for hairpin queue operation Bing Zhao 2020-10-15 13:08 ` [dpdk-dev] [PATCH v6 5/5] app/testpmd: change hairpin queues setup Bing Zhao 2020-10-15 23:03 ` [dpdk-dev] [PATCH v6 0/5] introduce support for hairpin between two ports Ferruh Yigit 2020-10-16 1:34 ` Bing Zhao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MN2PR12MB428611074A676DB2C57C1B84D60F0@MN2PR12MB4286.namprd12.prod.outlook.com \ --to=orika@nvidia.com \ --cc=arybchenko@solarflare.com \ --cc=beilei.xing@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=bingz@nvidia.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=mdr@ashroe.eu \ --cc=nhorman@tuxdriver.com \ --cc=thomas@monjalon.net \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git