From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 752E7A04B7; Sun, 4 Oct 2020 15:50:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 541BD1BB5C; Sun, 4 Oct 2020 15:50:09 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 696A71BBD6 for ; Sun, 4 Oct 2020 15:50:06 +0200 (CEST) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 04 Oct 2020 21:50:05 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 4 Oct 2020 13:50:01 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sun, 4 Oct 2020 13:50:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J+JasCJ9lDNW+FeQS1oYkOhUx2t+uvun1Jlb+PO38cqWKJqpNwU6NAFqfT9Kh2JleVCb1NM5Ar16PGVHZwYlnY63alGUE4qCPBMDxRGa5HZqktVFUcSWnddGe5ylmYtRy1aXzSVuI5th86m+EnTGr9tSYaAUQ7VZytU0JkkrXt6EphfmHikng0rykzPwy/nRcRHaTDjwtthEcBmpGqNdeQs8jowG2p71V06y3/ycpxPjs76MwLVDSQehfA5+2ifGLqtnkfJSWXcK+jVSv7YuElUfvr4C3qvNlW3WsrU+LXWVh2yxokS8L2RLMPXQIn6/FnWuM5zyDnDOE9ljJB3uzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sbMQ+a9NjF7z7D/Pmjwzoysf2enJoCp98CrzDWlVrG4=; b=GJt24ZMS/qUB+I5356mu291dR8PzWCkXyTMryTiFOigbyGrowAr0cCLDrZOk4CnAJHT+RNm3TEzCU5qtzghMLJYzpxslResf1iwDFcydlCjmjHe6TdHVWJMyqCsXHVVM4y5eBBdQmGv6yma/to/Of0uS7UPm+cW7X5Oa+u+YFmKZZ3EzAlBKS9KV6w0oTC6KeShsFvoZFuco9N1MPp9U+VmSfnn+71nN7+9UurhM1QGgeLeTgR6sksFEWupsZ3C+KsmGSGtdKPmJlRRs78hcD0p+Ac6F4QVxvqfBzY4oPgFg4/FT8xKC6RIR9ssoSIsys1abOfRcqvVwHvmQQXqTMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB4286.namprd12.prod.outlook.com (2603:10b6:208:199::22) by BL0PR12MB4964.namprd12.prod.outlook.com (2603:10b6:208:1c7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Sun, 4 Oct 2020 13:49:59 +0000 Received: from MN2PR12MB4286.namprd12.prod.outlook.com ([fe80::61fd:a36e:cf4f:2d3f]) by MN2PR12MB4286.namprd12.prod.outlook.com ([fe80::61fd:a36e:cf4f:2d3f%8]) with mapi id 15.20.3433.042; Sun, 4 Oct 2020 13:49:59 +0000 From: Ori Kam To: Dekel Peled , NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "konstantin.ananyev@intel.com" , "olivier.matz@6wind.com" , "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , "bernard.iremonger@intel.com" , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 06/11] net/mlx5: remove handling of ICMP fragmented packets Thread-Index: AQHWmDgnHtRpO0ifNUCw9Jrm8fu3tKmHefSg Date: Sun, 4 Oct 2020 13:49:59 +0000 Message-ID: References: <66fcec003fc002f8d4d8c83021de8f27a94ad083.1601586564.git.dekelp@nvidia.com> In-Reply-To: <66fcec003fc002f8d4d8c83021de8f27a94ad083.1601586564.git.dekelp@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 86d0947a-e4b6-438e-9de6-08d8686c62dd x-ms-traffictypediagnostic: BL0PR12MB4964: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:454; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ULlD0cUpM016CnJm8QCA5cKk8zij1mF1oM7JkEOjljZwxg5CksbOd6VuZcYrhRacTDIjjJjwfHeTKi2tYM6RG0y/1QqfVy/sGVFV5MOL4DtKyNuWY9YmgTc9UYazev5kh/Yb8ySbOh+J4zAvA1vuXlTfJFfT6eSiCKmbQfw4UV+E6pUOINQccEFzVTUMjfBWaHczNLj+ue8hOYVdLsU8/IxOCLPR/hebz31nwsSapkKO3bcTcdYTgY6Imp9sHKzRTHsVYjtJXE+xxRkLLwRW/Gtl4VpY0rPV55NDgHZtlykpebj5lcYhjcdUQXHUtXlm/y58EdhIRFLpKn6NqvMMzLkrdd6d7ZO4N1yzNXcllShXb0ZrqzKkIRs5dO9G+v4F x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4286.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(8936002)(83380400001)(4326008)(478600001)(7696005)(33656002)(76116006)(66556008)(52536014)(86362001)(66946007)(66446008)(64756008)(66476007)(71200400001)(110136005)(2906002)(26005)(5660300002)(316002)(9686003)(186003)(55016002)(6636002)(6506007)(53546011)(8676002)(921003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: pextqQOkxpn50EHqz5AGMbecPH/wlwUzuPy4D2iwpNeYogQ4IhUV8eoGkTQoJLYOn2v6o1BOZomtF3Y0Tet0niko7OheSQeoQ3yqLibkzOnPXgcNHMdpQN8GLxnF/gqGm2RIxGvmYQKsLjD+hR7eC51ndRlI111GpWu/WfeqRCmDs0J3LrFcxiPcjxqh8uRxx7qTeky01tGgde/YLKZkQGzQwCWs2U/MyjzUdaEQSwncKdw1fCHwXSnMAZiy6+b7Wjklgsy+njjJ0oPmc/pJMVV4F9xL4WQJ4RuzIWulmllgW2KBBLxwM8nn9Rby+8wGEEZC14hdX9Qo25frBffzzc+kLcuMY9dLC31s7s2Rs6M6jC7RYf3JPnurOjOstx6VkomaUBE5XKA/ssu37YIQfjmFIXUX2dY1MGR1O6CzrKz93XUe30BRzHgswlmtanSQbQejLgmb3aHX/drJOv/L7rQJQDpsIy75iWi27UYoR5FRFvNvGsEbswD9Hty+KxTBR+hRYL/npTIbLGTIJ7+9PCwxzzufuwUZrZoM5BUCo+2QcXYZEG9Q5mx23875dQVGdWG9cojApfYgltcNcS8Kt9ZZ7BUnWNiDA2Vh74+RkqXJdH0qntrN+1XdXZ3kvknZcTyONGrnhCfWG4B3/yMT4g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4286.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86d0947a-e4b6-438e-9de6-08d8686c62dd X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2020 13:49:59.6048 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yK3uyeAuSHAiG7gWwfAetLPMB6sy6CpMGNOinne191X4upfGjgX3dlEBJuIAseCYP/J7sQEkA3BEopbY3bZS6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4964 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601819405; bh=sbMQ+a9NjF7z7D/Pmjwzoysf2enJoCp98CrzDWlVrG4=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=GmPqNDY+Bzv0qQzWldfLw8ZmoHSirkXcWr6zjLLTfkuTRzao+pWcrNiZC5Incwwno rVpwEam1eqkA45ibbfwKmrirJhiNV4mj45qXMZhPcZZaDRfuqzt11p5Ox65fB3vkLN oMkW52EalYRRTnlG+meVaLm6LSc9i3r2trfL0g/V3x+4GoPfK7VCBGSVouRh1M0Xwz 9KFLXSGO92gQ5ZpRHKwmdVAs2nHkVSXgtp3ckHOCMxDBTCdfqsN243ByWANbQ4TeKf 83xxikt2Uvsrha+8EJrdNWrjc2UqFgP2GPiku2yzsEaOrNDQiCIPpeHTP5UW2+++H9 R4t1BoTPeQHxg== Subject: Re: [dpdk-dev] [PATCH v2 06/11] net/mlx5: remove handling of ICMP fragmented packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Dekel Peled > Sent: Friday, October 2, 2020 12:15 AM > Subject: [PATCH v2 06/11] net/mlx5: remove handling of ICMP fragmented > packets >=20 > Commit [1] forced setting of match on 'frag' bit mask 1 and value 0. > Previous patch in this series added support of match on fragmented and > non-fragmented packets on L3 items, so this setting is now redundant. >=20 > This patch removes the changes done in [1]. >=20 > [1] commit 85407db9f60d ("net/mlx5: fix matching for ICMP fragments") >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow_dv.c | 12 ------------ > 1 file changed, 12 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 79fdf34..0a0a5a4 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -7345,12 +7345,6 @@ struct field_modify_info modify_tcp[] =3D { > return; > if (!icmp6_m) > icmp6_m =3D &rte_flow_item_icmp6_mask; > - /* > - * Force flow only to match the non-fragmented IPv6 ICMPv6 packets. > - * If only the protocol is specified, no need to match the frag. > - */ > - MLX5_SET(fte_match_set_lyr_2_4, headers_m, frag, 1); > - MLX5_SET(fte_match_set_lyr_2_4, headers_v, frag, 0); > MLX5_SET(fte_match_set_misc3, misc3_m, icmpv6_type, icmp6_m- > >type); > MLX5_SET(fte_match_set_misc3, misc3_v, icmpv6_type, > icmp6_v->type & icmp6_m->type); > @@ -7398,12 +7392,6 @@ struct field_modify_info modify_tcp[] =3D { > return; > if (!icmp_m) > icmp_m =3D &rte_flow_item_icmp_mask; > - /* > - * Force flow only to match the non-fragmented IPv4 ICMP packets. > - * If only the protocol is specified, no need to match the frag. > - */ > - MLX5_SET(fte_match_set_lyr_2_4, headers_m, frag, 1); > - MLX5_SET(fte_match_set_lyr_2_4, headers_v, frag, 0); > MLX5_SET(fte_match_set_misc3, misc3_m, icmp_type, > icmp_m->hdr.icmp_type); > MLX5_SET(fte_match_set_misc3, misc3_v, icmp_type, > -- > 1.8.3.1 Acked-by: Ori Kam Thanks, Ori