From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E2A1A04DC; Mon, 19 Oct 2020 17:03:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20D51E2FC; Mon, 19 Oct 2020 17:03:37 +0200 (CEST) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 9E6B6E2F9 for ; Mon, 19 Oct 2020 17:03:35 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 19 Oct 2020 08:03:21 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 19 Oct 2020 15:03:28 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 19 Oct 2020 15:03:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kltILRYEPg+JWhrh26tUgwg+jZ+uzFMhUhju3CX0UIS3t2p0qOLedwonHI0SMN5ZCCTI11mRRrSFYyFnMRghv4gyWlPw1klf15NGfxk5jq5DF088qv9qJdRZhWL8E8uzGGN72NVlIunI7+AOO6OH131jI9bVEi3WtEjDVWPGnQuLy50xCdlKp1hphME4nHmJw3f6GUFULb7V+wzA+66NMSKaWyVE++cBKBcvKtXKcTIjUpJPeIbcFSZnin+IRt66otXCfcF50Hp1OKBGQ1ef+jAL8dVK/wERZnd9VrKnTubTFldSJ+TI/OBOwIdyKUAQe4U59mZ0pSWJ1KPa3WmLYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NErtHV3wzjVDdC72GOlaMo3d5AYAh8nA1UGwNyasMyY=; b=QyIFHNQ9TS5TjxS0lEAhQ0EQYvuqGADmjuADfuwvBnT6211G4suuojhU/fgUu6XNDch2f5awXV8RfnpKm7u0z/vUSCCXgYiNtTN8IYku2OMHaWZ/m/eZeGDMIJVS9FIjEKJFDcm88DViKW2IW2ZUJGOAMIrxrflE3mQPFuzZ1FO/3MBPGoINhyo/UIiyuBelOq+MIObSoa42K3YhhGZVt7DqipBHD+SHqbbvuN+pwtfjH/2GTbCgH8nxa/FBxADWfsubTFz5aeo4kgRo8J5NQfhx5rWyL89vO5xhoP3SpY5bBU3gTPAFXNhkMkssvDImZGrRnvcO00g5Db/t9djZlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB4286.namprd12.prod.outlook.com (2603:10b6:208:199::22) by MN2PR12MB4045.namprd12.prod.outlook.com (2603:10b6:208:1d6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Mon, 19 Oct 2020 15:03:26 +0000 Received: from MN2PR12MB4286.namprd12.prod.outlook.com ([fe80::28b4:b63a:c74c:be99]) by MN2PR12MB4286.namprd12.prod.outlook.com ([fe80::28b4:b63a:c74c:be99%5]) with mapi id 15.20.3477.028; Mon, 19 Oct 2020 15:03:26 +0000 From: Ori Kam To: "guyk@marvell.com" , "orika@mellanox.com" CC: NBU-Contact-Thomas Monjalon , "smadarf@marvell.com" , "dev@dpdk.org" Thread-Topic: [PATCH v1] app/regex: change default qp configuration flags Thread-Index: AQHWpfovNFtlNny3IUiiSktClAs7fKmfBPeA Date: Mon, 19 Oct 2020 15:03:26 +0000 Message-ID: References: <20201019092630.20460-1-guyk@marvell.com> <20201019092630.20460-2-guyk@marvell.com> In-Reply-To: <20201019092630.20460-2-guyk@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [2.55.145.134] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dd26bc28-2902-4107-36cf-08d8744021ca x-ms-traffictypediagnostic: MN2PR12MB4045: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:1775; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BgSI40BBvdjhyQamzD46S1yQZ647HwMbNIKdx6e64Qj7s0I5HgnEPBwqunoHtvwemKw1x/wNIwul0NxeV96Z/+Slb8fTmFZYGS6NxzOR7HnvesrhjVY0IVV6raXqoGo+o88o2/TqQVYd/UfS1bLE+Z+CXOa0OdqGjBKbRfoHMcCqdvvmkp5nMdckFccfOMSphobcZ5sVFVuooLz64/1zw+YWiWZktMAQGfXE+OQ0MFss0a4al+/Hxkr8Iuso/hHN69MsYWDEoLQlCdnfDX/OvfsWlOb7/5YRO4C+aMD8Pr4zDpUxJ43eSxpus9WcG6RiUtEPmM562wp5S2OHp6VP4Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4286.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(2906002)(52536014)(66476007)(66556008)(55016002)(76116006)(64756008)(66946007)(71200400001)(54906003)(110136005)(4326008)(66446008)(86362001)(5660300002)(33656002)(186003)(9686003)(478600001)(83380400001)(26005)(6506007)(8676002)(53546011)(8936002)(7696005)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 8O3HiDTmnJ5eRkDgq8/K6KDn44QhUGqz2N9NlfIh6dFJp6uqulfLUH0yYYfSRlzB4DzbepQH8nfSHVW1aV99afdkCJziDUbojDdg0WyFQQ8RAoOI0XeJLriuo1tdO+EFIa6shf65f9E5QI0FnYCXwsTrhHkoO/Ok4wH+UnyCpCScqpkJmHVS6BUGXh7h65EewAVDxw9W/aLcwtOsxHtNQtExwEUIPK9GsFlXG+/VRXPmd9dwUV+vnX3E/ZruQ/H6JOLY9XCbK2IVkdgUmTUPBxgwj797rc33dhGDK0vXr0KtgX77ike4r8PFWkqVOdl6tyB0ek6OxEqWTUsdzpbgXgmsfJ50a5XqaAYlbe6OeiwY/VdLBKVzh9EiynwCHRdPf4xu0iwS1l1KPhcjbck9ThyjqCJzHK8aB27QqG1ynlRvgCrbHpwnT1HuYh8v6A1YMlemiXinIiKbp2F49+hu37ycR0h1cflXIZXU5vOkwrcoOk9WUc5pC9TZHnTb6Ve7PWkKyGU0Gvu4BDyIwmSQtg88PVI1iRD8SIwnBgXUJ4+NgQ+PFxVi6g9l7PhU/48Hnsu0BLeShK8IwPiukn60ioyCS05MUIcTfJ8ZWm7ds+JgTXB1zG43tgUqFunvuOWH3NONfjLuWN0BR7MOtFSLZg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4286.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd26bc28-2902-4107-36cf-08d8744021ca X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2020 15:03:26.5051 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RYX0tK+aMFHicbCeoWcX81xloAVSCiavoS6VlKCQmibabVHa0j1LVpnAvSExniMwO//nJXPnBGz3DML+XrT7Qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4045 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603119801; bh=NErtHV3wzjVDdC72GOlaMo3d5AYAh8nA1UGwNyasMyY=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-exchange-transport-forked: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=fNA/1qoi+9S4gh3bm8BBZKUmRi/DZVmJX5j8rOyhLD7inT+Dn9LlxNPeU1UxuEZcp 7pgZnBy7S2BomjqGs5ZVyvNMnfM64A9PpOJjS6r1D4RQ0SskwDSH8LnKcPd7CBqg0p TnzOlvfyInwMX/ghSDhL/hozM35sZaegnagp79ivoJzMtWFJpNxJ1wr9HqKMvT8lV1 4guJbtx9aUVMEYr43se4koXbDEDmNH8v1jKJQDfljIMQRizSYXZ6ci1fM3n24X3dU5 Q8KZMfJr6u9IyjhkAm3rw1m++Nnc24Y8Ntk6NJiNKDtl+7Jl3stCog+4PAKVuCHCM8 zTlIAgR1b6jyg== Subject: Re: [dpdk-dev] [PATCH v1] app/regex: change default qp configuration flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Guy, > -----Original Message----- > From: guyk@marvell.com > Sent: Monday, October 19, 2020 12:27 PM > Subject: [PATCH v1] app/regex: change default qp configuration flags >=20 > From: Guy Kaneti >=20 > By default qp configuration flags was set with > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F. > Changed flags default to 0. In order to set OOS flag use > new argument --cfg_oos to config queue pair out of order scan. >=20 > Signed-off-by: Guy Kaneti > --- > app/test-regex/main.c | 24 +++++++++++++++++------- > 1 file changed, 17 insertions(+), 7 deletions(-) >=20 > diff --git a/app/test-regex/main.c b/app/test-regex/main.c > index 0d35f4583..9b19031ea 100644 > --- a/app/test-regex/main.c > +++ b/app/test-regex/main.c > @@ -33,6 +33,7 @@ enum app_args { > ARG_NUM_OF_JOBS, > ARG_PERF_MODE, > ARG_NUM_OF_ITERATIONS, > + ARG_CFG_OOS, > }; >=20 > static void > @@ -43,13 +44,15 @@ usage(const char *prog_name) > " --data NAME: data file to use\n" > " --nb_jobs: number of jobs to use\n" > " --perf N: only outputs the performance data\n" > - " --nb_iter N: number of iteration to run\n", > + " --nb_iter N: number of iteration to run\n" > + " --cfg_oos: configure regexdev queue flag out of order > scan\n", > prog_name); > } >=20 > static void > args_parse(int argc, char **argv, char *rules_file, char *data_file, > - uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations) > + uint32_t *nb_jobs, bool *perf_mode, uint32_t *nb_iterations, > + uint32_t *qp_conf_flags) > { > char **argvopt; > int opt; > @@ -66,7 +69,9 @@ args_parse(int argc, char **argv, char *rules_file, cha= r > *data_file, > /* Perf test only */ > { "perf", 0, 0, ARG_PERF_MODE}, > /* Number of iterations to run with perf test */ > - { "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS} > + { "nb_iter", 1, 0, ARG_NUM_OF_ITERATIONS}, > + /* configure out of order scan */ > + { "cfg_oos", 0, 0, ARG_CFG_OOS} > }; >=20 > argvopt =3D argv; > @@ -98,6 +103,9 @@ args_parse(int argc, char **argv, char *rules_file, ch= ar > *data_file, > case ARG_NUM_OF_ITERATIONS: > *nb_iterations =3D atoi(optarg); > break; > + case ARG_CFG_OOS: > + *qp_conf_flags =3D > RTE_REGEX_QUEUE_PAIR_CFG_OOS_F; > + break; > case ARG_HELP: > usage("RegEx test app"); > break; > @@ -158,7 +166,8 @@ read_file(char *file, char **buf) >=20 > static int > init_port(struct rte_mempool **mbuf_mp, uint32_t nb_jobs, > - uint16_t *nb_max_payload, char *rules_file, uint8_t > *nb_max_matches) > + uint16_t *nb_max_payload, char *rules_file, uint8_t > *nb_max_matches, > + uint32_t qp_conf_flags) > { > uint16_t id; > uint16_t num_devs; > @@ -171,7 +180,7 @@ init_port(struct rte_mempool **mbuf_mp, uint32_t > nb_jobs, > }; > struct rte_regexdev_qp_conf qp_conf =3D { > .nb_desc =3D 1024, > - .qp_conf_flags =3D RTE_REGEX_QUEUE_PAIR_CFG_OOS_F, > + .qp_conf_flags =3D qp_conf_flags, > }; > int res =3D 0; >=20 > @@ -407,6 +416,7 @@ main(int argc, char **argv) > bool perf_mode =3D 0; > uint32_t nb_iterations =3D 0; > uint8_t nb_max_matches =3D 0; > + uint32_t qp_conf_flags =3D 0; > int ret; >=20 > ret =3D rte_eal_init(argc, argv); > @@ -416,10 +426,10 @@ main(int argc, char **argv) > argv +=3D ret; > if (argc > 1) > args_parse(argc, argv, rules_file, data_file, &nb_jobs, > - &perf_mode, &nb_iterations); > + &perf_mode, &nb_iterations, &qp_conf_flags); >=20 > ret =3D init_port(&mbuf_mp, nb_jobs, &nb_max_payload, rules_file, > - &nb_max_matches); > + &nb_max_matches, qp_conf_flags); > if (ret < 0) > rte_exit(EXIT_FAILURE, "init port failed\n"); > ret =3D run_regex(mbuf_mp, nb_jobs, nb_max_payload, perf_mode, > -- > 2.28.0 General comment I think we should add=20 capability to the rte_regexdev to check if the PMD support=20 OOF. and have the default based on this capability. Best, Ori