From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CD35CA04B7;
	Wed, 14 Oct 2020 14:07:17 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id AC84E1DBF7;
	Wed, 14 Oct 2020 14:07:16 +0200 (CEST)
Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com
 [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id 91C5C1D692
 for <dev@dpdk.org>; Wed, 14 Oct 2020 14:07:14 +0200 (CEST)
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by
 hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
 id <B5f86e9c50002>; Wed, 14 Oct 2020 05:06:29 -0700
Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 14 Oct
 2020 12:07:09 +0000
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by
 HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server
 (TLS) id
 15.0.1473.3 via Frontend Transport; Wed, 14 Oct 2020 12:07:09 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=TMoTHi2SjPoCO2UJ1rQ++yL3tFB+MNj1Vq4LM+4BJv7D0pIyXgNAgSQQ7UzXkih+GId6knChezdSCz34wbwipzcIfxy5K38dtYFM+iqAXxrTJzVBPhUTOM2cZDhCorBjucZSvCTttF/1688PH2Zl++UcLL2kH/yVZezNrupeq96v5C8lZqrkTooKnpO6Xam9Ay8pyAKdLLoSyjFJr6fShdU5EYXXJY85Yh32FKpVf4jIFjymlp5/NWYDCT+leWtnCG8dWCr+56kyBaSsufLhfqmvUDp0y9Mytf6J2J9Xl3zzn9F9B+BH/WurGVARcb9HtK0/yPUZ2SEVrxZ2TNvwwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=zKFo+v7jKvdUIgzNYWmEZ9JVmYexlapIYwN8AxhzFQ4=;
 b=Xw+3P1NJmBUuvBTYvCw0V0+HY0CYnDVc5oLyt+7Ep3Gbv+qv7KLiAvs//P4cIzIu8f92YjeElM9obVcDqEznaGxnaAA0ij01VPygsxLHrxUE66Iv/hKXdtjmaD7LaYmhRNoIABSEN/Vke6TG+38hidit1mJr5iVnR5TAJvhxAEzfNdRAanof7TJf8g2mSYErVns/KjrlKzn0rY1uk/CJGhIiGHKbIBn3Tw7FWQ33g89K4nkw0CW6R4lO7VnmRVGPW3byEwmeW8PfjpZq1PKWPXdwLsDrXWQACGjgiLpBI+ZUYKrVER3CUJ/uiDbjdzxCnXOTjKofn7twdZAE2cm9mA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
 dkim=pass header.d=nvidia.com; arc=none
Received: from MN2PR12MB4286.namprd12.prod.outlook.com (2603:10b6:208:199::22)
 by BL0PR12MB4995.namprd12.prod.outlook.com (2603:10b6:208:1c7::23)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Wed, 14 Oct
 2020 12:07:07 +0000
Received: from MN2PR12MB4286.namprd12.prod.outlook.com
 ([fe80::61fd:a36e:cf4f:2d3f]) by MN2PR12MB4286.namprd12.prod.outlook.com
 ([fe80::61fd:a36e:cf4f:2d3f%9]) with mapi id 15.20.3455.030; Wed, 14 Oct 2020
 12:07:07 +0000
From: Ori Kam <orika@nvidia.com>
To: SimonX Lu <simonx.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "jia.guo@intel.com" <jia.guo@intel.com>, "haiyue.wang@intel.com"
 <haiyue.wang@intel.com>, "qiming.yang@intel.com" <qiming.yang@intel.com>,
 "beilei.xing@intel.com" <beilei.xing@intel.com>
Thread-Topic: [PATCH v1 1/8] ethdev: support the mirror action for flow
Thread-Index: AQHWogYTHtdWVv9fUEGh8gwxFYHwqKmW/nzA
Date: Wed, 14 Oct 2020 12:07:07 +0000
Message-ID: <MN2PR12MB42868FE01EA489190625447ED6050@MN2PR12MB4286.namprd12.prod.outlook.com>
References: <20201014084131.72035-1-simonx.lu@intel.com>
 <20201014084131.72035-2-simonx.lu@intel.com>
In-Reply-To: <20201014084131.72035-2-simonx.lu@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com;
x-originating-ip: [147.236.152.129]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 52373c23-f7c5-4d67-06b5-08d87039ac03
x-ms-traffictypediagnostic: BL0PR12MB4995:
x-microsoft-antispam-prvs: <BL0PR12MB499549E36416665003E3EFC4D6050@BL0PR12MB4995.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5516;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: hDg7cCXTlclpZhy36vYJrOv0+syunMSs/Wl9x0btl6yB15yRVSPpCLnhJ3iuLKtIr8I0ae90RXpm2hZdL31SUt/JsBtDRj9c3hYelPGZIc6wT/d0cL3UgNcGQXFPd3+P1K75dK5dpuoDTWT3g6XVKttFcayc2oATnAYBK1KsYsDfh6nKVzTjilMyQZvJHXRCll0u7fIZVy7zz96tlsOZy1cPAMgo/FVIrgmsxT/MAM9F2sEd+zcD9dV9n4+ErbtGo/+QQZYmYkjYmbdq9FKgW6BTQKJvF6GCiRi0BnAIhVY3XDi8hBFnwtYiCxlesvb484XytRe9xVHxP9N/m8PHO0+XKe0kKqug1rm5YPOpvKh9Gem0IKGsw7lkULIdSk89/qUY7QdWSPLcRt03ioFynA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:MN2PR12MB4286.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(83380400001)(71200400001)(4326008)(86362001)(186003)(8936002)(83080400001)(55016002)(2906002)(8676002)(66476007)(9686003)(33656002)(4744005)(64756008)(66446008)(66946007)(66556008)(7696005)(110136005)(76116006)(52536014)(54906003)(5660300002)(478600001)(316002)(6506007)(26005)(53546011)(966005);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata: ZYBdeQjfZ0++kXIH9HXrenitZzKebXOPgt+Xena1pG9uDBEM6GL6OGKrxs0QftRScKhEno5KbfzBTYznXcaTg9MC0lR85XIvWYOrKRH04t+FkWMMl2P8R1Y3xFpDBxZGa/zRTHq4Kk7V5nCHAAOg8EwwcgVrGym6Ab5u9B6VSrpeBLDFQaeRMS5fxIuYyR9yCZrm0FJgCnojwGgs2/bnuVC1+tPRXJx9/QJh8Wr7IIAoMG2ayl72SS8VBmwa6D8wXn+JdC1qM/FmDF6taRqdooap0KXAO5X7zS07NNOjkDYoXIedQmXAhyn4Jo+0kD1X0CprW0BSwxVfmlN0ZHJclyr7uhXvA/k2M5ZFrQEylzh74UiELri0GVAorsiEBfimcYdSTp2FOX9tElltN0CTVatViVznqKM7lISXlp31dLCsUXLz81p8O+zvrBvFAndC9UtEFaDPEUj3Apr7o0Xc5hP4WqXVVsd8Uzn5cjrFuYCLPzgGU3kEVnnxoS1bzpFpx7vLMq4kt5GSaXoQsgG/0sjRJj64TEqc3gRPCFsVcM9neYMC7RxqRfINM5mR3SsTSMED4x95fdRkOQ73uj0DHNbLiD+4qRNKAOyFEcWogv+nfHoY26mSzyNCxwS4LwPVoco6iV697zGT83PhOsJRWA==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4286.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 52373c23-f7c5-4d67-06b5-08d87039ac03
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2020 12:07:07.3186 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JKi2EfyjlWg0YgoSDYomhG86CfippSDs8oBX2jBRovh2uGw08xK1Y2zgSVopobbct3464vZBCbOjSLrW3RGgJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4995
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
 t=1602677189; bh=zKFo+v7jKvdUIgzNYWmEZ9JVmYexlapIYwN8AxhzFQ4=;
 h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:
 CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:
 In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach:
 X-MS-TNEF-Correlator:authentication-results:x-originating-ip:
 x-ms-publictraffictype:x-ms-office365-filtering-correlation-id:
 x-ms-traffictypediagnostic:x-microsoft-antispam-prvs:
 x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck:
 x-microsoft-antispam:x-microsoft-antispam-message-info:
 x-forefront-antispam-report:x-ms-exchange-antispam-messagedata:
 x-ms-exchange-transport-forked:Content-Type:
 Content-Transfer-Encoding:MIME-Version:
 X-MS-Exchange-CrossTenant-AuthAs:
 X-MS-Exchange-CrossTenant-AuthSource:
 X-MS-Exchange-CrossTenant-Network-Message-Id:
 X-MS-Exchange-CrossTenant-originalarrivaltime:
 X-MS-Exchange-CrossTenant-fromentityheader:
 X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
 X-MS-Exchange-CrossTenant-userprincipalname:
 X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
 b=QDVNc/dUOm15xdzYzj04qxR84LJAyVaKK1r+INtiDCm0aYWbt4Q/H0uFrB926GBlV
 My76a53Tc7HzuPmZP3IAR1tdRmW52aMCkEvbAC1vtcuClPOCK6FS7JgNoZNbpHYVws
 J5eOsnC2S5ai7T3OgZ0sDkwrlPNbjgyoiPa8gzZqbLMymZ4zJkttiTXcZeRD8goS79
 m+SYq7C9WjnDDQuWhctyijYJU1/6JboVdFMlMY77dsh4vesmMj7Jvvgql3GPo72M6O
 Bznx6+JEuG3TwBzZFrqIXbvMD6WAnLqGVVP35fuCZ8Eia2wZeE91strdMo5amH2Tsd
 N4ohd35MHFPKw==
Subject: Re: [dpdk-dev] [PATCH v1 1/8] ethdev: support the mirror action for
	flow
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Simon,
BSP,

> -----Original Message-----
> From: SimonX Lu <simonx.lu@intel.com>
> Sent: Wednesday, October 14, 2020 11:41 AM
> To: dev@dpdk.org
> Cc: jia.guo@intel.com; haiyue.wang@intel.com; qiming.yang@intel.com;
> beilei.xing@intel.com; Ori Kam <orika@nvidia.com>; Simon Lu
> <simonx.lu@intel.com>
> Subject: [PATCH v1 1/8] ethdev: support the mirror action for flow
>=20
> From: Simon Lu <simonx.lu@intel.com>
>=20
> Added the mirror type within rte_filter_type, and defined corresponding
> action & item to support mirror in rte_flow.
>=20
> Signed-off-by: Simon Lu <simonx.lu@intel.com>
> ---
>  lib/librte_ethdev/rte_eth_ctrl.h | 1 +
>  lib/librte_ethdev/rte_flow.c     | 1 +
>  lib/librte_ethdev/rte_flow.h     | 7 +++++++
>  3 files changed, 9 insertions(+)
>

Why did you create new action?
There was a new action "sampling" submitted in this release.
When set to 1 it means mirror since all packets will get duplicated
Please review https://patches.dpdk.org/cover/78893/
Thanks,
Ori=20
=20