From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29548A04B7; Mon, 21 Sep 2020 09:29:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB60D1D910; Mon, 21 Sep 2020 09:29:23 +0200 (CEST) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 450981D90D for ; Mon, 21 Sep 2020 09:29:22 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 21 Sep 2020 00:29:08 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 21 Sep 2020 07:29:14 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 21 Sep 2020 07:29:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ITi/rRLz2Os6iA02LWYAxNG8pkFqNSWmOln5rKxsTcgwcUxY9kKAVAq4sXlpoLIS7qW1vVagW2xLvYDME8AkeQ+nhnlXE/XNnRIhsoF8ydojN5mi9lPe+nFNMmhSm+t7zmcQr5dHxWX9Tnkv/+vEbzsGDI9jMETX/4OMIB1ZAoEMDrG3TejkxfaT6WXyGTmkWC9JkfwHJx6xQzHxec35JV01xNrqLZw3Y1Gtm2tidOxuWovbwzp0RkabIYPwRi+ZFncdgU44q6hoMMOwdlJVltLQVPwspz8O38jNRW7rfqHqhCSHSprXWdRx/ZLzl7OROpPqui1YGbyflgAqXVSZsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5H4IeWWqrODg92AobVtmWKVSLRxl3DCAvmRvaZCBNbw=; b=HiTh3QLHEWLdKW9VSBSEMHCBLGCdPW75ZBTD2GnME1wmGGu0wyh4Kxqc1Z7o0URFg1Zw9ko7xctwpC7KEXJlcQpd3bpVKltj9U1EPu++N/S6Pj6jDJIn1WiWuMXXRwP6qZzrkzXrUn3OOnfSk5hmc1uP+0eULHbzzRVjSfPHPAlMPLEmA+zLwrs9re+dgDxxOv1u3ncVbBlpECl+yIQwVpYlQL2+UomXLUKCkRURwpjknZCCIJ7AcvIY2NkPDvzG3FBAe2LTs1NwydRK3R5Uqvpoclyr0cVWiLeyZJziUyLacxW9aY2GWS1owmunu2KWbgsze5WVo7JIxhxTSbVccA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MN2PR12MB4286.namprd12.prod.outlook.com (2603:10b6:208:199::22) by MN2PR12MB4437.namprd12.prod.outlook.com (2603:10b6:208:26f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.17; Mon, 21 Sep 2020 07:29:12 +0000 Received: from MN2PR12MB4286.namprd12.prod.outlook.com ([fe80::61fd:a36e:cf4f:2d3f]) by MN2PR12MB4286.namprd12.prod.outlook.com ([fe80::61fd:a36e:cf4f:2d3f%9]) with mapi id 15.20.3391.026; Mon, 21 Sep 2020 07:29:12 +0000 From: Ori Kam To: NBU-Contact-Thomas Monjalon , Nipun Gupta , Stephen Hemminger , "orika@mellanox.com" CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "hemant.agrawal@nxp.com" , Rohit Raj , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] ethdev: add rx offload to drop error packets Thread-Index: AQHWf2y4WUGri5wS1kyzb+M/veVa7KlScZCAgAD+BICAH2H1cA== Date: Mon, 21 Sep 2020 07:29:12 +0000 Message-ID: References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20200831100019.11e5c916@hermes.lan> <1900043.OHW9WeN1RR@thomas> In-Reply-To: <1900043.OHW9WeN1RR@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b96e2083-4cb7-47f9-f1e1-08d85e000996 x-ms-traffictypediagnostic: MN2PR12MB4437: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0HFgUk/f6EBxF6U1OOp6kxpp9uqvp089FkEBHLW10zUbYSD+A/1+t9KNld2dwgykB5PKX7N7Un9yoWSSeVrtHDxz2H/a1rgf4Fe3Imesl5UkajResVtVBdDzjTQnR7MhvulHQKfIKWQGF5J9Eh2MnCvIppPKDCtn2uEr2bhUockIW7KM98hCYhheaDq5p5XVPtR+jHemqlWbmZv1bEnPgLHXB8aN6M2+7vfEEUz9CoPMSiWUuEayldpVf0AOFixjcqvNOkCGYG/lA6+XMVh2Q5vPBVdTZtSIaukiufSq3Nsu7Yx5VNBtM6BHdeWIIL4X0IjhQ6YN8q36uK1t3kWzORotomplrcGt5ZCQ+N+BTMDJzwci/lQPMYT9xtfTtZba x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4286.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(110136005)(8676002)(6506007)(71200400001)(478600001)(26005)(54906003)(316002)(33656002)(186003)(83380400001)(66446008)(76116006)(66556008)(8936002)(66946007)(4326008)(5660300002)(4744005)(66476007)(86362001)(55016002)(52536014)(64756008)(2906002)(9686003)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Xm/RnmJpHCnrx8377wA8EreUfG8kV0X6Fs2GLbVVZFajKqaDfdi2OH/NHdb1b1J3JAXATpIf0UF7LxVPKf1M1cSrCKEq2Z+ZwVNK8SfEIiVihWMj1aYbUv5wyZ5twM3/kqIkNkCcRy785rSeIpc2HHb22frWmlcXUTE5hopiT4vxrBKpYzpbBGxekOdzfj8PpbuTYtib8gnjDuumjzzA5VPdMh6+HpkZdeUnjYVmIrQwzMCEB5SPc4TDnjOwshOeNCOpVE1sg3AHS+7wEFzqmSyt3CBllXWeEHnKAid5KkwEEzS36N0wbKnG1+wK6zQ/YR/JyMnCVhC+2oKxfTz3nmuHiKbspGCG4bfBUlfBLtVl9PwwMAMxKxFRv91f7DeauZKVEdYzrVV727Pdy1z/oCpOfrnelkuHhsx/M+m6QTqPZb5/GIJMLohnSFxt0RK4yoXVluP4lDBgbns50CzjnipzdiZeXIz8cK1SyAqN5AJWEv5rZ4MTmL7o3NyyZC7QJoojj91rQiq773IZkFp9LvcH1bWkMnQT1DiG2+JQ7lxar/TBrztRcFyE62Co4iOyVnBvl+V6BcGnaxHet31AQ4P8smiEtO9X/YH/D/iBsmf6FRrCox4zV4ew4gQi/7BGfp4y21XZvGExnAF24HIwRg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4286.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b96e2083-4cb7-47f9-f1e1-08d85e000996 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 07:29:12.5668 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +HXClh3+x2fojuTkgSVj5BMMoWxrUBlHvDPTVmtQYfpbRk5bcE5PtZGYSDbFfkbiVf+P2MA0KSTpoq5bSpArEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4437 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1600673348; bh=5H4IeWWqrODg92AobVtmWKVSLRxl3DCAvmRvaZCBNbw=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-exchange-transport-forked: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=NdAiUPrHwCC1hhMcy+NGOVgnnTsJPIuzNkatcvLHo7J4jHLc+StNin32bwgNPV72F eKIK4RXjYdTJNmeyuDFEzc6nY7qyG7UtYY6+o2GVBuGdkXPPkRblvH8tO/Ds4Y31dM tFe7Q6fhtbZ4bDZ+bZY1MnbL9WKIUUQEijxmnZzUe5GRyBdxduSlbJnDCOAlFRUDhv HQmQhpeP1GoomMvqq2oWkftYltOkhhYL+O5Ybif6Y9w4/3iIPImvtoBwnwUNXkhSBp zPdk+4wWoHZyigKPy7hdqRBO4ZESR1/n/k9VCBfS+cBO3q8Zk7/tkdaV73kONrAatK gVGMGUzxnzrSg== Subject: Re: [dpdk-dev] [PATCH] ethdev: add rx offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > Subject: Re: [dpdk-dev] [PATCH] ethdev: add rx offload to drop error pack= ets >=20 > 31/08/2020 19:00, Stephen Hemminger: > > On Mon, 31 Aug 2020 13:23:33 +0530 > > Nipun Gupta wrote: > > > > > This change adds a RX offload capability where hardware can drop the > > > packets in case there is an error in the packet such as L3 checksum > > > error or L4 checksum. > > > > > > Signed-off-by: Nipun Gupta > > > Signed-off-by: Rohit Raj > > > --- > > > +#define DEV_RX_OFFLOAD_ERR_PKT_DROP 0x00100000 >=20 > Please add RTE_ prefix, even if older macros don't have it. > We could (in a separate effort) alias old ones with RTE_ prefixed names. >=20 > > Could/should this be an rte_flow action as well? >=20 > I feel rte_flow API is not appropriate here. > Ori, any opinion? >=20 I also don't think this is relevant action in case of rte_flow, If we want to support such a thing in rte_flow we should=20 add item that matches on error and then use the drop action. Best, Ori